[PATCH v3 0/3] arch/powerpc: Resolve backlight include dependencies

2024-03-06 Thread Thomas Zimmermann
After cleaning up in commit 11b4eedfc87d ("fbdev: Do not include in header"), building with CONFIG_PMAC_BACKLIGHT=y returns errors about missing declarations. Patches 1 and 2 resolve the errors. Patch 1 has been reviewed at [1]. Patch 3 removes another dependency between backlight and fbdev

[PATCH v3 2/3] macintosh/via-pmu-backlight: Include

2024-03-06 Thread Thomas Zimmermann
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from . Add it to via-pmu-backlight.c to get the necessary symbols. Reported-by: Naresh Kamboju Closes:

[PATCH v3 1/3] fbdev/chipsfb: Include

2024-03-06 Thread Thomas Zimmermann
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from . Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/ Signed-off-by: Thomas Zimmermann

[PATCH v3 3/3] arch/powerpc: Remove from backlight code

2024-03-06 Thread Thomas Zimmermann
Replace with a forward declaration in to resolve an unnecessary dependency. Remove pmac_backlight_curve_lookup() and struct fb_info from source and header files. The function and the framebuffer struct are unused. No functional changes. v3: * Add Fixes tag (Christophe) * fix

[PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Douglas Anderson
This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. Apparently there was a previous discussion about emulation of formats and it was decided XRGB was the only format to support for legacy userspace [1]. Remove ARGB. Userspace needs to be fixed to accept XRGB. [1]

[PATCH] staging: fbtft: Fix space before parenthesis as per checkpatch.pl

2024-03-06 Thread me
From: Uri Arev Errors reported by checkpatch.pl: ERROR: space prohibited before that close parenthesis ')' +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) ERROR: space prohibited before that close parenthesis ')' +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) CHECK:

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Thomas Zimmermann
Am 06.03.24 um 15:37 schrieb Douglas Anderson: This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. Apparently there was a previous discussion about emulation of formats and it was decided XRGB was the only format to support for legacy userspace [1]. Remove ARGB. Userspace

Re: [RFC PATCH net-next v6 09/15] memory-provider: dmabuf devmem memory provider

2024-03-06 Thread Pavel Begunkov
On 3/6/24 02:42, Mina Almasry wrote: On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote: On 2024-03-04 18:01, Mina Almasry wrote: + if (pool->p.queue) + binding = READ_ONCE(pool->p.queue->binding); + + if (binding) { + pool->mp_ops = _devmem_ops; +

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2024-03-06 Thread Luca Ceresoli
> > > > sn65dsi83_atomic_disable is not called in my case for some > > > > > > > reason. > > > > > > > > > > > > So you remove the module and atomic_disable is not called, after > > > > > > having called atom

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 22:58 schrieb Dmitry Osipenko: On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking in DRM's console emulation. Similar

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Rob Clark
On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann wrote: > > Hi, > > sorry that I did not see the patch before. > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > Even though the UDL driver converts to RGB565 internally (see > > pixel32_to_be16() in udl_transfer.c), it advertises XRGB for

[PATCH v2 1/2] MAINTAINERS: Update drm-misc.git URL

2024-03-06 Thread Maxime Ripard
Now that the drm-misc tree has moved to Gitlab, adjust the MAINTAINERS git trees to reflect the location change. Signed-off-by: Maxime Ripard --- MAINTAINERS | 172 ++-- 1 file changed, 86 insertions(+), 86 deletions(-) diff --git a/MAINTAINERS

[PATCH v2 2/2] MAINTAINERS: Update drm-misc web page

2024-03-06 Thread Maxime Ripard
This URL gets redirected to the Intel landing page now. Let's switch the webpage to freedesktop. Signed-off-by: Maxime Ripard --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d4e33b3a3bc0..cdd3ddd6efb5 100644 --- a/MAINTAINERS

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > > On 3/6/2024 6:12 PM, Christian König wrote: > > Am 06.03.24 um 11:40 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 3:37 PM, Christian König wrote: > >>> Am 06.03.24 um 10:04 schrieb Sunil Khatri: > When an page fault interrupt is

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-06 Thread Pavel Begunkov
On 3/5/24 22:36, Mina Almasry wrote: On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote: On 2024-03-04 18:01, Mina Almasry wrote: +struct memory_provider_ops { + int (*init)(struct page_pool *pool); + void (*destroy)(struct page_pool *pool); + struct page *(*alloc_pages)(struct

Re: [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-03-06 Thread Steven Price
On 06/03/2024 01:56, Adrián Larumbe wrote: > Debugfs isn't always available in production builds that try to squeeze > every single byte out of the kernel image, but we still need a way to > toggle the timestamp and cycle counter registers so that jobs can be > profiled for fdinfo's drm engine and

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-06 Thread Shuah Khan
Hi Stephen, On 3/1/24 15:30, Shuah Khan wrote: Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37

[PATCH v3 1/6] drm/mst: read sideband messaging cap

2024-03-06 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 0/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
v3 of https://patchwork.freedesktop.org/series/129468/ Jani Nikula (6): drm/mst: read sideband messaging cap drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: abstract choosing the MST mode to use drm/i915/mst: use the MST mode detected previously drm/i915/mst: add

[PATCH v3 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-03-06 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

[PATCH v3 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-03-06 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 4/6] drm/i915/mst: use the MST mode detected previously

2024-03-06 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. v2: Rebase on drm_dp_mst_detect() returning the mode, not bool Cc: Arun R

[PATCH v3 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-03-06 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[PATCH v3 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 6:38 AM Douglas Anderson wrote: > > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB was the only format to support for legacy > userspace [1]. Remove

Re: [PATCH v7 2/6] drm/i915: Unregister in-kernel clients

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 17:25 schrieb Jani Nikula: On Tue, 05 Mar 2024, Rodrigo Vivi wrote: On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote: Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915

Re: [PATCH v15 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-03-06 Thread Maxime Ripard
Hi, On Wed, Mar 06, 2024 at 11:16:21AM +0100, Alexander Stein wrote: > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device *mhdp) > +{ > + u8 status; > + int ret; > + > + mutex_lock(>mbox_mutex); > + > + ret = cdns_mhdp_mailbox_send(>base, MB_MODULE_ID_GENERAL, > +

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are

[PATCH] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path"

2024-03-06 Thread Luca Ceresoli
-- base-commit: a71e4adac20bfe852d269addfef340923ce23a4c change-id: 20240306-ti-sn65dsi83-regulator-imbalance-10e217fd302c Best regards, -- Luca Ceresoli

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote: >> Hmm. As Hsin-Yi pointed out to me offline. Somehow we'll need to get >> the actual panel ID out. Right now in panel-edp.c we have: >> >> dev_warn(dev, >> "Unknown panel %s %#06x, using

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an page fault

Re: [PATCH v3 5/5] arm64: dts: allwinner: a64: Run GPU at 432 MHz

2024-03-06 Thread Erico Nunes
On Mon, Mar 4, 2024 at 6:01 PM Frank Oltmanns wrote: > > The Allwinner A64's GPU has currently three operating points. However, > the BSP runs the GPU fixed at 432 MHz. In addition, at least one of the > devices using that SoC - the pinephone - shows unstabilities (see link) > that can be

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > On 3/6/2024 8:34 PM, Christian König wrote: > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > >>> > >>> On 3/6/2024 6:12 PM, Christian König wrote: > Am 06.03.24 um 11:40

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Thomas Zimmermann
Hi Am 06.03.24 um 16:05 schrieb Doug Anderson: Hi, On Wed, Mar 6, 2024 at 4:07 AM Thomas Zimmermann wrote: Hi, sorry that I did not see the patch before. Am 27.02.24 um 23:19 schrieb Douglas Anderson: Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information

Re: [PATCH 1/3] drm/arm/komeda: Fix komeda probe failing if there are no links in the secondary pipeline

2024-03-06 Thread Liviu Dudau
Hi Faiz, On Mon, Feb 19, 2024 at 03:39:13PM +0530, Faiz Abbas wrote: > Since commit f7936d6beda9 ("drm/arm/komeda: Remove component framework and > add a simple encoder"), the devm_drm_of_get_bridge() call happens > regardless of whether any remote nodes are available on the pipeline. Fix > this

Re: [PATCH v3] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-03-06 Thread Dharma.B
On 05/03/24 3:31 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Mar 04, 2024 at 08:00:03PM +0530, Dharma Balasubiramani wrote: >> Convert the atmel,lcdc bindings to DT schema. >> Changes during conversion: add

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Javier Martinez Canillas
Douglas Anderson writes: Hello Doug, > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB was the only format to support for legacy > userspace [1]. Remove ARGB. Userspace

[rerere PATCH v2] nightly.conf: Update the drm-misc repo

2024-03-06 Thread Maxime Ripard
drm-misc has moved to gitlab now, so let's update the repo location. Signed-off-by: Maxime Ripard --- nightly.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/nightly.conf b/nightly.conf index b851af21929a..ab58579c8006 100644 --- a/nightly.conf +++ b/nightly.conf @@ -40,10 +40,15

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Thomas Zimmermann
Hi, sorry that I did not see the patch before. Am 27.02.24 um 23:19 schrieb Douglas Anderson: Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in udl_transfer.c), it advertises XRGB for compatibility. Let's add ARGB to that list. We had a heated

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > When extending support for a driver-specific KMS property to additional > drivers, we should apply all the requirements for new properties and > make sure the semantics are the same and documented. > > Signed-off-by: Sebastian

Re: [PATCH v15 2/8] phy: Add HDMI configuration options

2024-03-06 Thread Maxime Ripard
Hi Alexander, On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > From: Sandor Yu > > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. > > The parameters added here are based on HDMI PHY > implementation

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Ville Syrjälä
On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote: > On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann wrote: > > > > Hi, > > > > sorry that I did not see the patch before. > > > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > > Even though the UDL driver converts to RGB565 internally

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Rob Clark
On Wed, Mar 6, 2024 at 7:06 AM Ville Syrjälä wrote: > > On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote: > > On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann > > wrote: > > > > > > Hi, > > > > > > sorry that I did not see the patch before. > > > > > > Am 27.02.24 um 23:19 schrieb

Re: [PATCH v3] drm/bridge: anx7625: Update audio status while detecting

2024-03-06 Thread Jani Nikula
is used to apply the patches, it can automagically pick up the trailers from replies to the patch with the Fixes: trailer. > - Link to v2: > https://lore.kernel.org/r/20240306-anx7625-v2-1-7138e00b2...@chromium.org > > Changes in v2: > - Add a space after the colons in the subjec

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-06 Thread Yunsheng Lin
On 2024/3/6 5:17, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 4:55 AM Yunsheng Lin wrote: >> >> On 2024/3/5 10:01, Mina Almasry wrote: >> >> ... >> >>> >>> The netdev_dmabuf_binding struct is refcounted, and releases its >>> resources only when all the refs are released. >>> >>> Signed-off-by:

Re: [RFC PATCH net-next v6 00/15] Device Memory TCP

2024-03-06 Thread Yunsheng Lin
On 2024/3/6 3:38, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote: >> >> On 2024/3/5 10:01, Mina Almasry wrote: >> >> ... >> >>> >>> Perf - page-pool benchmark: >>> --- >>> >>> bench_page_pool_simple.ko tests with and without these changes: >>>

Re: [PULL] drm-misc-fixes

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 01:54:30PM +, Matthew Auld wrote: > On 29/02/2024 13:37, Maxime Ripard wrote: > > Hi, > > > > Here's this week drm-misc fixes PR. > > > > There's two commits for files unders drivers/soc/qcom that don't have a > > maintainer Acked-by. Bjorn's Acked-by was

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 4:07 AM Thomas Zimmermann wrote: > > Hi, > > sorry that I did not see the patch before. > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > Even though the UDL driver converts to RGB565 internally (see > > pixel32_to_be16() in udl_transfer.c), it advertises XRGB

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 17:06 schrieb Khatri, Sunil: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:59 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > On Tue, 5 Mar 2024 14:51:49 +0100 > Sebastian Wick wrote: > > > The initial idea of the Colorspace prop was that this maps 1:1 to > > InfoFrames/SDP but KMS does not give user space enough information nor > > control over the

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-06 Thread Mina Almasry
On Wed, Mar 6, 2024 at 6:30 AM Pavel Begunkov wrote: > > On 3/5/24 22:36, Mina Almasry wrote: > > On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote: > >> > >> On 2024-03-04 18:01, Mina Almasry wrote: > >>> +struct memory_provider_ops { > >>> + int (*init)(struct page_pool *pool); > >>> +

Re: [PATCH v2 3/9] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-03-06 Thread Louis Chauvet
r non-1x1 blocks until you > have code handling at least one such format. > > All of the YUV formats that patch 6 adds support for use 1x1 blocks all > all their planes. Yes, none of the supported format have block_h != block_w != 1, so there is no need to drm_format_info_block*() helpers. I wrote the code for DRM_FORMAT_R*. They are packed, with block_w != 1. I will add this patch in the next revision. I also wrote the IGT test for DRM_FORMAT_R1 [1]. Everything will be in the v5 (I will send it when you have the time to review the v4). For information, I also have a series ready for adding more RGB variants (I introduced a macro to make it easier and avoid copy/pasting the same loop). I don't send them yet, because I realy want this series merged first. I also have the work for the writeback "line-by-line" algorithm ready (I just need to rebase it, but it will be fast). [1]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd...@bootlin.com Kind regards, Louis Chauvet [...] -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 5/9] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-06 Thread Louis Chauvet
Le 05/03/24 - 12:10, Pekka Paalanen a écrit : > On Mon, 4 Mar 2024 16:28:33 +0100 > Louis Chauvet wrote: > > > Le 29/02/24 - 12:21, Pekka Paalanen a écrit : > > > On Tue, 27 Feb 2024 16:02:09 +0100 > > > Louis Chauvet wrote: > > > > > > > [...] > > > > > > > > > > -static void

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Xaver Hugl
Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : > So the idea being if the compositor isn't using it we let > power-profiles-daemon (or any other software) take control via sysfs and > if the compositor does want to control it then it then it writes a DRM > cap and we destroy the

Re: [PATCH] Removed redundant @ symbol to fix kernel-doc warnings in -next repo

2024-03-06 Thread Alex Deucher
Fixed up patch title prefix and applied. Thanks! Alex On Tue, Mar 5, 2024 at 10:48 PM R SUNDAR wrote: > > For linux-next repository. > > ./drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured > comments found > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:132: warning:

[PATCH 00/22] drm: fix headers, add header test facility

2024-03-06 Thread Jani Nikula
First, fix a bunch of issues in drm headers, uncovered with the last patch. A few kernel-doc warnings are just brushed under the carpet for now, with a FIXME comment. Otherwise, pretty straightforward stuff. Second, add a header test facility to catch issues at build time when

[PATCH 01/22] drm/crtc: make drm_crtc_internal.h self-contained

2024-03-06 Thread Jani Nikula
Forward declare struct drm_printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index a514d5207e41..72c26f996b3b 100644 ---

[PATCH 02/22] drm: add missing header guards to drm_internal.h

2024-03-06 Thread Jani Nikula
Including the file twice leads to errors. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index 8e4faf0a28e6..d69744c9ac15 100644 ---

[PATCH 05/22] drm: bridge: samsung-dsim: make samsung-dsim.h self-contained

2024-03-06 Thread Jani Nikula
Include and forward declare struct platform device. Signed-off-by: Jani Nikula --- include/drm/bridge/samsung-dsim.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index e0c105051246..9764d6eb5beb

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:19 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:

Re: [RFC PATCH net-next v6 09/15] memory-provider: dmabuf devmem memory provider

2024-03-06 Thread Mina Almasry
On Wed, Mar 6, 2024 at 6:59 AM Pavel Begunkov wrote: > > On 3/6/24 02:42, Mina Almasry wrote: > > On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote: > >> > >> On 2024-03-04 18:01, Mina Almasry wrote: > >>> + if (pool->p.queue) > >>> + binding = READ_ONCE(pool->p.queue->binding); >

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Xaver Hugl
Like already mentioned in the power profiles daemon repository, I don't think this makes sense. This is a display setting, which compositors have interest in controlling, for example to: - disable it in a bright environment, because afaiu it reduces the maximum screen brightness - disable it

Re: [RFC PATCH 0/5] Add support for suppressing warning backtraces

2024-03-06 Thread Daniel Díaz
Hello! On Tue, 5 Mar 2024 at 12:40, Guenter Roeck wrote: > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. > > Such

Re: [PATCH v4 4/5] drm/panel-edp: Match edp_panels with panel identity

2024-03-06 Thread Hsin-Yi Wang
On Wed, Mar 6, 2024 at 1:23 AM Jani Nikula wrote: > > On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. When matching generic edp > > panels, we should first match with both

[PATCH 5/5] drm/i915: Remove special handling for !RCS_MASK()

2024-03-06 Thread Lucas De Marchi
With both XEHPSDV and PVC removed (as platforms, most of their code remain used by others), there's no need to handle !RCS_MASK() as other platforms don't ever have fused-off render. Remove those code paths and the special WA flag when initializing GuC. Signed-off-by: Lucas De Marchi ---

[PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-06 Thread Lucas De Marchi
PCI IDs for XEHPSDV were never added and platform always marked with force_probe. Drop what's not used and rename some places to either be xehp or dg2, depending on the platform/IP checks. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- Potential problem

[PATCH 3/5] drm/i915: Update IP_VER(12, 50)

2024-03-06 Thread Lucas De Marchi
With no platform declaring graphics/media IP_VER(12, 50), replace the checks throughout the code with IP_VER(12, 55) so the code makes sense by itself with no additional explanation of previous baggage. The info override for the various _info is then changed so the version definition is clearer

[PATCH 0/5] drm/i915: cleanup dead code

2024-03-06 Thread Lucas De Marchi
Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by subsequent ones, so it's not a huge amount of code being removed.

[PATCH 1/5] drm/i915: Drop WA 16015675438

2024-03-06 Thread Lucas De Marchi
With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done because now the driver always set a fixed partition of EUs during initialization via the ccs_mode configuration. The flag to GuC is

[PATCH 4/5] drm/i915: Drop dead code for pvc

2024-03-06 Thread Lucas De Marchi
PCI IDs for PVC were never added and platform always marked with force_probe. Drop what's not used and rename some places as needed. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-

Re: [PATCH] drm/msm/dp: fix typo in dp_display_handle_port_status_changed()

2024-03-06 Thread Dmitry Baryshkov
On Wed, 6 Mar 2024 at 21:35, Abhinav Kumar wrote: > > Fix the typo in the name of dp_display_handle_port_status_changed(). > > Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd") > Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov -- With best wishes

[PATCH 18/22] drm/ttm: fix ttm_bo.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Some renames, some formatting fixes, add some as FIXME. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_bo.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h index 0223a41a64b2..8b1eb6828f0a 100644 ---

[PATCH 19/22] drm/ttm: make ttm_caching.h self-contained

2024-03-06 Thread Jani Nikula
Include for pgprot_t. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_caching.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h index 235a743d90e1..a18f43e93aba 100644 --- a/include/drm/ttm/ttm_caching.h +++

[PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-06 Thread Jani Nikula
Ensure drm headers build, are self-contained, have header guards, and have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. The mechanism follows similar patters used in i915, xe, and usr/include. To cover include/drm, we need to recurse there using the top level Kbuild and the new

[PATCH 21/22] drm/ttm: fix ttm_kmap_iter.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_kmap_iter.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_kmap_iter.h b/include/drm/ttm/ttm_kmap_iter.h

[PATCH 20/22] drm/ttm: fix ttm_execbuf_util.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Fix some formatting errors and excess documentation. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_execbuf_util.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/drm/ttm/ttm_execbuf_util.h b/include/drm/ttm/ttm_execbuf_util.h index

[RFC PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-06 Thread Abhinav Kumar
There are cases where the userspace might still send another frame after the HPD disconnect causing a modeset cycle after a disconnect. This messes the internal state machine of MSM DP driver and can lead to a crash as there can be an imbalance between bridge_disable() and bridge_enable(). This

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > > > > On 3/6/2024 8:34 PM, Christian König wrote: > > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > >>> > > >>> On

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:07 PM, Christian König wrote: > > Am 06.03.24 um 16:13 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 8:34 PM, Christian König wrote: > >>> Am 06.03.24 um 15:29 schrieb Alex Deucher: > On Wed, Mar 6, 2024 at 8:04 AM

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 03:14:15PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > > When extending support for a driver-specific KMS property to additional > > drivers, we should apply all the requirements for new properties and > > make

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
As discussion we decided that we dont need the client id, srcid, pasid etc in page fault information dump. So this patch isnt needed anymore. So dropping this patch and will add the new information in the devcoredump for pagefault which is all available in existing structures. As discussed,

[linux-next:master] BUILD REGRESSION 61996c073c9b070922ad3a36c981ca6ddbea19a5

2024-03-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 61996c073c9b070922ad3a36c981ca6ddbea19a5 Add linux-next specific files for 20240306 Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c:168

[PATCH] drm/msm/dp: fix typo in dp_display_handle_port_status_changed()

2024-03-06 Thread Abhinav Kumar
Fix the typo in the name of dp_display_handle_port_status_changed(). Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd") Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Mario Limonciello
On 3/6/2024 12:59, Harry Wentland wrote: On 2024-03-06 13:02, Mario Limonciello wrote: On 3/6/2024 12:00, Xaver Hugl wrote: Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : So the idea being if the compositor isn't using it we let power-profiles-daemon (or any other software)

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:42 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:59 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:45 PM, Alex Deucher wrote: > >>> On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > On 3/6/2024 9:07 PM,

Re: [RFC PATCH 0/5] Add support for suppressing warning backtraces

2024-03-06 Thread Guenter Roeck
Hi Daniel, On 3/6/24 10:24, Daniel Díaz wrote: [ ... ] Thank you SO very much for this work! This is very much appreciated! Thanks a lot for the feedback. We run into these warnings at LKFT all the time, and making sure that the noise doesn't drown the relevant signal is very important.

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Harry Wentland
On 2024-03-06 13:02, Mario Limonciello wrote: > On 3/6/2024 12:00, Xaver Hugl wrote: >> Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello >> : >>> So the idea being if the compositor isn't using it we let >>> power-profiles-daemon (or any other software) take control via sysfs and >>>

Re: [RFC PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-06 Thread Dmitry Baryshkov
On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar wrote: > > There are cases where the userspace might still send another > frame after the HPD disconnect causing a modeset cycle after > a disconnect. This messes the internal state machine of MSM DP driver > and can lead to a crash as there can be an

Re: [RFC PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-06 Thread Abhinav Kumar
On 3/6/2024 11:52 AM, Dmitry Baryshkov wrote: On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar wrote: There are cases where the userspace might still send another frame after the HPD disconnect causing a modeset cycle after a disconnect. This messes the internal state machine of MSM DP driver

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6,

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:45 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:07 PM, Christian König wrote: > >>> Am 06.03.24 um 16:13 schrieb Khatri, Sunil: > On 3/6/2024 8:34 PM,

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Matthew Auld
On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages

  1   2   3   >