Re: [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

2021-07-25 Thread Inki Dae
Sorry for late and thanks for fixing it. Thanks, Inki Dae 2021년 6월 16일 수요일, Wei Yongjun 님이 작성: > Add the missing unlock before return from function g2d_runqueue_worker() > in the error handling case. > > Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()"

Re: [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly

2021-04-19 Thread Inki Dae
ne automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here. > > Signed-off-by: Daniel Vetter Acked-by: Inki Dae Thanks, Inki Dae > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park

Re: [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-08-12 Thread Inki Dae
SoC specific things should be considered, I think MIPI DSI Driver - interrupt handler and probing order things are really specific to device driver - should be separated but we could share the control part of the device. I was busy with other projects so didn't care of Linux DRM world so

Re: [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-08-17 Thread Inki Dae
Hi Laurent, 21. 8. 13. 오후 9:16에 Laurent Pinchart 이(가) 쓴 글: > Hi Inki, > > On Fri, Aug 13, 2021 at 03:50:56PM +0900, Inki Dae wrote: >> 21. 7. 26. 오전 2:25에 Sam Ravnborg 이(가) 쓴 글: >>> On Sun, Jul 04, 2021 at 02:32:19PM +0530, Jagan Teki wrote: >>>> Exynos DSI dr

[GIT PULL] exynos-drm-next

2021-08-21 Thread Inki Dae
Hi Dave, Just two fixups - fixing one build warning and missing unlock, and one cleanup - replaceing atomic_t with refcount_t. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 397ab98e2d69cede8a28eab77a171983d14e: Merge tag

Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes

2021-03-14 Thread Inki Dae
Hi Tian Tao, 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글: > remove the legacy GPIO headers but what it really > uses is since only gpio_desc structs are ever > referenced. This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion? Th

Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes

2021-03-15 Thread Inki Dae
21. 3. 15. 오후 3:45에 tiantao (H) 이(가) 쓴 글: > > 在 2021/3/15 14:35, Inki Dae 写道: >> Hi Tian Tao, >> >> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글: >>> remove the legacy GPIO headers but what it really >>> uses is since only gpio_desc structs are ever >&g

[GIT PULL] exynos-drm-fixes

2021-03-29 Thread Inki Dae
Hi Dave, Just one cleanup to drop unused header inclusion. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 09d78dde88ef95a27b54a6e450ee700ccabdf39d: Merge tag 'drm-msm-fixes-2021-02-25' of https://gitlab.freedesktop.o

[GIT PULL] exynos-drm-next

2021-03-30 Thread Inki Dae
me know if there is any problem. Thanks, Inki Dae [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git/commit/?id=cbe16f35bee6880becca6f20d2ebf6b457148552 The following changes since commit 99e5730dd2b11fedc890bbc9c803f69aad24e3ca: Merge tag 'irq-no-autoen-2021

[GIT PULL] exynos-drm-fixes

2021-05-19 Thread Inki Dae
Hi Dave, Just one fixup to kerneldoc and two cleanups to drop redundant error messages. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc: Linux 5.13-rc2 (2021-05-16 15:27:44 -0700) are

[GIT PULL] exynos-drm-fixes

2020-11-23 Thread Inki Dae
Hi Dave, Just one bug fix to a build error due to common framework dependency. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 6600f9d52213b5c3455481b5c9e61cf5e305c0e6: Merge tag 'drm-intel-fixes-2020-11-19

[GIT PULL] exynos-drm-next

2020-11-30 Thread Inki Dae
Hi Dave, Just a new mode support for HDMI and two clenups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 22f8c80566c4a29a0d8b5ebf24aa1fd1679b39e5: Merge tag 'drm-misc-next-2020-11-18' of ssh://git.freedesktop.org/g

Re: [PATCH v2 03/16] drm/exynos: use exynos_dsi as drvdata

2020-11-08 Thread Inki Dae
> Reviewed-by: Sam Ravnborg > > Likewise, the exynos people are expected to pick this up. Cleanup patch so picked it up. Thanks, Inki Dae > > Sam > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 02/16] drm/exynos: remove in_bridge_node from exynos_dsi

2020-11-08 Thread Inki Dae
ned-off-by: Michael Tretter > Reviewed-by: Sam Ravnborg > > Note: I expect exynos people to pick it up. Cleanup patch so picked it up. Thanks, Inki Dae > > Sam > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.o

Re: [PATCH v2 04/16] drm/exynos: extract helper functions for probe

2020-11-08 Thread Inki Dae
that this patch series will be fixed and reviewed more. Thanks, Inki Dae > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-08 Thread Inki Dae
PI-DSI driver to bridge type of driver? Seems not sensible. The reason would be just to share MIPI-DSI phy driver for Exynos with i.MX8M Mini? Thanks, Inki Dae > to 13) and finally expose the API, split the code and move the platform > independent driver to the bridges (patches 14 - 1

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-10 Thread Inki Dae
20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글: > On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: >> 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글: >>> This is v2 of the series to convert the Exynos MIPI DSI driver into a drm >>> bridge and make it usable with

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-10 Thread Inki Dae
20. 11. 11. 오후 12:04에 Inki Dae 이(가) 쓴 글: > > > 20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글: >> On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: >>> 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글: >>>> This is v2 of the series to convert the Exynos MIPI D

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-13 Thread Inki Dae
20. 11. 11. 오후 7:18에 Michael Tretter 이(가) 쓴 글: > On Wed, 11 Nov 2020 12:11:15 +0900, Inki Dae wrote: >> 20. 11. 11. 오후 12:04에 Inki Dae 이(가) 쓴 글: >>> 20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글: >>>> On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: >>>

Re: [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests

2020-11-22 Thread Inki Dae
nos_mixer.o: in > function `mixer_bind': > exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent' > > Reported-by: kernel test robot > Signed-off-by: Krzysztof Kozlowski Picked it up. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/Kconfig

Re: [GIT PULL] exynos-drm-fixes

2022-02-22 Thread Inki Dae
Hi Dave, Seems you missed. Is there any issue? Thanks, Inki Dae 22. 2. 10. 20:07에 Inki Dae 이(가) 쓴 글: > Hi Dave and Daniel, > >Just two fixup series - one is to fix irq chaining issue and other is >regressions to TE-gpio handling. > > Please let me know if th

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-23 Thread Inki Dae
documented register only. Sorry for late and thanks, Inki Dae 22. 1. 30. 07:01에 Martin Jücker 이(가) 쓴 글: > In the downstream kernels for exynos4 and exynos5 devices, there is an > undocumented register that controls the order of the RGB output. It can > be set to either normal order or reve

[GIT PULL] exynos-drm-fixes for rc6

2022-02-24 Thread Inki Dae
Hi Dave and Daniel, Just fixups series. Ps. my previous git-pull request[1] isn't merged so I'm sending it again after rebasing on top of drm-fixes. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://www.spinics.net/lists/dri-devel/msg3

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-24 Thread Inki Dae
Hi Martin, 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Thu, Feb 24, 2022 at 10:41:04AM +0900, Inki Dae wrote: >> Hi Martin. >> >> I found that exynos4 and 5 data sheet include documented same register. >> RGB_ORDER_E field of VIDCONx regist

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-28 Thread Inki Dae
Hi Martin, 22. 2. 25. 18:33에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: >> Hi Martin, >> >> 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: >>> Hello Inki, >>> >>> On Thu, Feb 24, 20

Re: [PATCH v3 RESEND 21/24] drm/exynos/decon5433: add local path support

2022-03-01 Thread Inki Dae
s DT schema checks. Let me know if other approach > (revert of DTS change) should be taken. > Sorry for late response. As of now, "dsd" is a dead property not used anywhere. This patch series makes real user not to work correctly due to ABI change. How about reverting it until this patch series is merged after fixing the real user problem? Thanks, Inki Dae > Best regards, > Krzysztof >

[GIT PULL] exynos-drm-next for v5.18

2022-03-04 Thread Inki Dae
Hi Dave and Daniel, Just adding BGR pixel format support per a plane. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fedc89821990013608bc210c9aef5bb33a1345a7: drm/exynos: Search for TE-gpio in DSI panel's node (2022-03-04

Re: [PATCH] drm/exynos: Make use of the helper function devm_platform_ioremap_resource()

2021-09-15 Thread Inki Dae
21. 8. 31. 오후 4:49에 Cai Huoqing 이(가) 쓴 글: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > Picked it up. Thanks, Inki Dae > Signed-off-by: Cai Huoqing > --- > d

Re: [PATCH v2 06/13] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-26 Thread Inki Dae
rom EDID. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/gpu/drm/drm_edid.c?h=v5.14.14#n4725 Signed-off-by: Inki Dae Thanks, Inki Dae > DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", > (hd

Re: [PATCH v2 06/13] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-26 Thread Inki Dae
21. 10. 27. 오전 7:28에 Inki Dae 이(가) 쓴 글: > Hi, > > 21. 10. 17. 오전 3:42에 Claudio Suarez 이(가) 쓴 글: >> Once EDID is parsed, the monitor HDMI support information is available >> through drm_display_info.is_hdmi. Retriving the same information with >> drm_detect_hdmi_

[GIT PULL] exynos-drm-fixes

2021-09-28 Thread Inki Dae
Hi Dave, Just one clean up to use helper function. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: git

Re: [PATCH] Revert "drm: exynos: dsi: Convert to bridge driver"

2022-01-18 Thread Inki Dae
Hi, 22. 1. 17. 오후 6:55에 Robert Foss 이(가) 쓴 글: > Hi Inki, > > On Fri, 14 Jan 2022 at 02:18, Inki Dae wrote: >> >> Hi Robert, >> >> 22. 1. 12. 오후 7:05에 Robert Foss 이(가) 쓴 글: >>> Thank you again for catching this and submitting a revert. >>> >

Re: [PATCH] drm/exynos: Don't fail if no TE-gpio is defined for DSI driver

2022-01-23 Thread Inki Dae
Hi Marek, Thanks for fixing it. Inki Dae. 22. 1. 21. 19:00에 Marek Szyprowski 이(가) 쓴 글: > TE-gpio is optional and if it is not found then gpiod_get_optional() > returns NULL. In such case the code will continue and try to convert NULL > gpiod to irq what in turn fails. The failur

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

2022-01-27 Thread Inki Dae
Hi, 22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글: > Hi Marek, > > On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: >> TE-gpio, if defined, is placed in the panel's node, not the parent DSI >> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and >> pass proper devic

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-08 Thread Inki Dae
Hi, Really sorry for late. I saw this patch in my mailbox just before. Seems I missed it due to a typo, exynox. I will review and apply this patch ASAP. Thanks, Inki Dae 21. 11. 8. 오후 7:28에 Thomas Zimmermann 이(가) 쓴 글: > Moving the driver-specific mmap code into a GEM object function all

Re: [PATCH] drm/exynos: Replace legacy gpio interface for gpiod interface

2021-11-09 Thread Inki Dae
Hi, 21. 11. 2. 오전 11:20에 Maíra Canal 이(가) 쓴 글: > Considering the current transition of the GPIO subsystem, remove all > dependencies of the legacy GPIO interface (linux/gpio.h and linux > /of_gpio.h) and replace it with the descriptor-based GPIO approach. > Applied. Thanks, Inki D

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-09 Thread Inki Dae
lgtm, but would still be good if exynos maintainers would > ack/review/test it. But if you don't get anything within 2 weeks here's Sorry for late. Confirmed working well on Odroid board, and had a review. Applied. https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/

[PATCH] drm/exynos: drop the use of label from exynos_dsi_register_te_irq

2021-11-30 Thread Inki Dae
el test robot [1] https://www.spinics.net/lists/dri-devel/msg323803.html Reported-by: kernel test robot Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/dr

[GIT PULL] exynos-drm-next

2021-12-21 Thread Inki Dae
Hi Dave and Daniel, Just four cleanups such as replacing the use of legacy interface, implementing generic gem mmap, fixing a build warning and dropping unnecessary code. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: [PATCH] Revert "drm: exynos: dsi: Convert to bridge driver"

2022-01-13 Thread Inki Dae
ge conflict may happen on drm-next because drm-misc-next has this patch set exynos-drm-next tree doesn't include. Leaving this patch history in drm-misc-next is correct? Thanks, Inki Dae

Re: [PATCH 2/5] drm/exynos: mixer: Use platform_get_irq() to get the interrupt

2022-01-14 Thread Inki Dae
roblem :), in exynos_drm_platform_probe function component_master_add_with_match() in component_master_add_with_match function try_to_bring_up_master() Thanks, Inki Dae > > Cheers, > Prabhakar > --- > drivers/gpu/drm/exynos/exynos_mi

Re: [PATCH 0/5] drm/exynos: Use platform_get_irq*() variants to fetch IRQ's

2022-01-14 Thread Inki Dae
agreed based on > the discussion [0]. > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/ > patch/20211209001056.29774-1-prabhakar.mahadev-lad...@bp.renesas.com/ > Applied. Thanks, Inki Dae > Cheers, > Prabhakar > > Lad Prabhakar (5): > drm/exynos/exyn

[GIT PULL] exynos-drm-next

2016-04-30 Thread Inki Dae
trigger mode so this patch makes trigger mode - HW or SW trigger - to be set according to SoC version properly. - And some cleanups and regression fixups. Please, kindly let me know if there is any problem. Thanks, Inki Dae The following changes since

[PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear

2016-08-09 Thread Inki Dae
Picked it up. :) Thanks, Inki Dae 2016-08-09 8:48 GMT+09:00 Shuah Khan : > Fix unsupported GEM memory type error message to include the memory type > information. > > Signed-off-by: Shuah Khan > --- > Changes since v1: > -- Comment changed to read clearly > &

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-11 Thread Inki Dae
imedia device and other DMA devices. Even though IOMMU support is disabled, other framework based DMA drivers can use IOMMU - i.e., GPU driver - and they can use non-contiguous GEM buffer through UMM. (DMABUF) So GEM allocation type is not dependent on IOMMU. Thanks, Inki Dae > allocate non-c

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-16 Thread Inki Dae
Hi Shuah, 2016년 08월 13일 02:52에 Shuah Khan 이(가) 쓴 글: > On 08/12/2016 11:28 AM, Shuah Khan wrote: >> On 08/10/2016 05:05 PM, Shuah Khan wrote: >>> On 08/10/2016 04:59 PM, Inki Dae wrote: >>>> Hi Shuah, >>>> >>>> 2016년 08월

Re: [PATCH 04/13] drm/exynos: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls

2019-05-27 Thread Inki Dae
Hi Emil, 19. 5. 27. 오후 5:17에 Emil Velikov 이(가) 쓴 글: > From: Emil Velikov > > The authentication can be circumvented, by design, by using the render > node. > >>From the driver POV there is no distinction between primary and render > nodes, thus we can drop the token.

[PATCH 0/2] drm/exynos: clean up logs

2019-04-14 Thread Inki Dae
Just clean up logs from exynos drm driver. Inki Dae (2): drm/fimd: use DRM_ERROR instead of DRM_INFO in error case drm/exynos: remove unnecessary messages drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 8 +++- 2 files changed, 3

[PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-14 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 2/2] drm/exynos: remove unnecessary messages

2019-04-14 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 -- 2 files changed, 4

Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-14 Thread Inki Dae
Hi Sam, 19. 4. 15. 오후 12:17에 Sam Ravnborg 이(가) 쓴 글: > Hi Inki > > On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote: >> This patch makes error messages to be printed out using DRM_ERROR >> instead of DRM_INFO. >> >> Signed-off-by: Inki Dae

[PATCH 6/7] drm/vidi: replace platform_device pointer with device one

2019-04-15 Thread Inki Dae
Add device pointer to vidi_context and remove platform_device pointer. It doesn't need for vidi_context to contain platform_device object. Instead, this patch makes this driver more simply by replacing platform_device pointer with device one. Signed-off-by: Inki Dae --- drivers/gpu/drm/e

[PATCH 7/7] drm/ipp: clean up debug messages

2019-04-15 Thread Inki Dae
. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 5 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 5 ++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 46 ++--- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 9 +++--- drivers/gpu/drm

[PATCH 4/7] drm/exynos: use DRM_DEV_ERROR to print out error message

2019-04-15 Thread Inki Dae
This patch just cleans up the use of error log macro, which changes the log macro to DRM_DEV_ERROR. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 14 +--- drivers/gpu/drm/exynos/exynos_dp.c| 9

[PATCH 1/7] drm/exynos: g2d: remove style error

2019-04-15 Thread Inki Dae
From: Seung-Woo Kim Remove checkpatch error, "foo* bar" should be "foo *bar". Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 0/7 v2] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
driver by adding device pointer to vidi_context. . Clean up ipp driver by using device pointer instead of drm_device one, which makes ipp driver to print out the debug messages with correct device name. Inki Dae (6): drm/fimd: use DRM_ERROR instead of DRM_INFO in error case drm/exynos: remove

[PATCH 2/7] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-15 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 5/7] drm/exynos: use DRM_DEV_DEBUG* instead of DRM_DEBUG macro

2019-04-15 Thread Inki Dae
Use DRM_DEV_DEBUG* instead of DRM_DEBUG macro to print out debug messages. This patch just cleans up the use of debug log macro, which changes the log macro to DRM_DEV_DEBUG*. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos

[PATCH 3/7] drm/exynos: remove unnecessary messages

2019-04-15 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 -- drivers/gpu/drm/exynos

Re: [PATCH 1/7] drm/exynos: g2d: remove style error

2019-04-15 Thread Inki Dae
Oops. There was my mistake. This patch is already merged to exynos-drm-fixes. Please ignore this one. Thanks, Inki Dae 19. 4. 15. 오후 5:54에 Inki Dae 이(가) 쓴 글: > From: Seung-Woo Kim > > Remove checkpatch error, "foo* bar" should be "foo *bar". > > Signed-off

Re: [PATCH 0/7 v2] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
Hi Sam, 19. 4. 15. 오후 6:13에 Sam Ravnborg 이(가) 쓴 글: > Hi Inki > > >> Inki Dae (6): >> drm/fimd: use DRM_ERROR instead of DRM_INFO in error case >> drm/exynos: remove unnecessary messages >> drm/exynos: use DRM_DEV_ERROR to print out error message &

[PATCH 1/6] drm/exynos: fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-15 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 0/6 v3] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
up debug/error messages of all Exynos DRM KMS and DMA drivers. . Clean up vidi driver by adding device pointer to vidi_context. . Clean up ipp driver by using device pointer instead of drm_device one, which makes ipp driver to print out the debug messages with correct device name. Inki Dae (6

[PATCH 2/6] drm/exynos: remove unnecessary messages

2019-04-15 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 -- drivers/gpu/drm/exynos

[PATCH 5/6] drm/exynos: vidi: replace platform_device pointer with device one

2019-04-15 Thread Inki Dae
Add device pointer to vidi_context and remove platform_device pointer. It doesn't need for vidi_context to contain platform_device object. Instead, this patch makes this driver more simply by replacing platform_device pointer with device one. Signed-off-by: Inki Dae --- drivers/gpu/drm/e

[PATCH 3/6] drm/exynos: use DRM_DEV_ERROR to print out error message

2019-04-15 Thread Inki Dae
This patch just cleans up the use of error log macro, which changes the log macro to DRM_DEV_ERROR. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 14 +--- drivers/gpu/drm/exynos/exynos_dp.c| 9

[PATCH 4/6] drm/exynos: use DRM_DEV_DEBUG* instead of DRM_DEBUG macro

2019-04-15 Thread Inki Dae
Use DRM_DEV_DEBUG* instead of DRM_DEBUG macro to print out debug messages. This patch just cleans up the use of debug log macro, which changes the log macro to DRM_DEV_DEBUG*. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos

[PATCH 6/6] drm/exynos: ipp: clean up debug messages

2019-04-15 Thread Inki Dae
. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 5 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 5 ++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 46 ++--- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 9 +++--- drivers/gpu/drm

[GIT PULL] exynos-drm-next

2019-04-22 Thread Inki Dae
Hi Dave, Just log cleanup patches of Exynos KMS and DMA drivers including one trivial style fixup. Please kinkdly let me know if there is any problem. Thanks, Inki Dae The following changes since commit dbb92471674a48892f5e50779425e03388073ab9: Revert "drm: allow render ca

Re: [GIT PULL] exynos-drm-next

2019-04-23 Thread Inki Dae
lease fix and resent the pull > Sorry for this. I missed to remove them with some cleanup. Will resend the pull. Thanks, Inki Dae > Dave. > > On Mon, 22 Apr 2019 at 19:50, Inki Dae wrote: >> >> Hi Dave, >> >>Just log cleanup patches of Exynos KMS and DMA

[GIT PULL RESEND] exynos-drm-next

2019-04-23 Thread Inki Dae
of drm-next again. Thanks, Inki Dae The following changes since commit 70b5f09e4389c789263c6d79c539b8378e3af3bc: Merge tag 'drm-msm-next-2019-04-21' of https://gitlab.freedesktop.org/drm/msm into drm-next (2019-04-24 11:56:32 +1000) are available in the git repository

[GIT PULL] exynos-drm-next

2019-02-07 Thread Inki Dae
Hi Dave, Just adding s5pv210 SoC support of rotator module and changing email address of scaler module author. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2cc3b81dfa7f7de0d647e7f1473de811eef8b0de: Merge tag 'drm-intel

Re: [PATCH 1/3] drm/exynos: rotator: Add support for s5pv210

2019-01-08 Thread Inki Dae
Applied. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 23 + > 1 file changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index a820a68429b9..a822

Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels

2019-01-17 Thread Inki Dae
see why above two types are needed. Is there any case that the range checking behavior should be different according to the color space? And even if there is that case, I think you have to put DRM_COLOR_RANG_MAX under DRM_COLOR_FULL_RANGE. Thanks, Inki Dae > }; >

Re: [PATCH v1 1/1] drm/exynos: drop drmP.h usage

2019-06-21 Thread Inki Dae
filp->driver_priv; -- snip -- ---- Thanks, Inki Dae > > Signed-off-by: Sam Ravnborg > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Kukjin K

Re: [PATCH v2 1/1] drm/exynos: drop drmP.h usage

2019-06-21 Thread Inki Dae
HI, 2019년 6월 8일 (토) 오후 5:35, Sam Ravnborg 님이 작성: > > Drop use of the deprecated drmP.h file. > Replace with forwards / externals as appropriate. > > While touching the list of include files divide > them up in blocks and sort them. > > Signed-off-by: Sam Ravnborg > Cc

Re: [PATCH v4 1/2] drm/exynos: drop drmP.h usage

2019-06-24 Thread Inki Dae
Hi Sam, 2019년 6월 22일 (토) 오후 8:56, Sam Ravnborg 님이 작성: > > Drop use of the deprecated drmP.h file. > Replace with forwards / externals as appropriate. > > While touching the list of include files divide > them up in blocks and sort them. > > v3: > - fix build errors in

Re: [PATCH v4 1/2] drm/exynos: drop drmP.h usage

2019-06-24 Thread Inki Dae
Ah, there was a trivial merge conflict so I merged it manually. Thanks, Inki Dae 2019년 6월 24일 (월) 오후 10:32, Inki Dae 님이 작성: > > Hi Sam, > > 2019년 6월 22일 (토) 오후 8:56, Sam Ravnborg 님이 작성: > > > > Drop use of the deprecated drmP.h file. > > Replace with forwa

Re: [PATCH v4 2/2] drm/exynos: trigger build of all modules

2019-06-24 Thread Inki Dae
(&pdev->dev); > > This is due to the definition of iounmap() in sh, > and nothing that exynos driver can fix. > > Include fix of exynos build for alpha. > > Signed-off-by: Sam Ravnborg > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Ky

Re: [PATCH v4 2/2] drm/exynos: trigger build of all modules

2019-06-24 Thread Inki Dae
but I always make sure to test things using alpha so 0-day do not yell at me. I couldn't see any warning message while building your patch after dropping above change. Could you check it again on top of below git repo.? git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git

Re: [PATCH v4 2/2] drm/exynos: trigger build of all modules

2019-06-25 Thread Inki Dae
n of function ‘vunmap’; did you mean ‘iounmap’? > [-Werror=implicit-function-declaration] > vunmap(exynos_gem->kvaddr); > ^~ > iounmap > cc1: some warnings being treated as errors > > > This is with a freshly pulled tree from drm-exynos.git exynos-drm-next > >

[GIT PULL] exynos-drm-next

2019-06-27 Thread Inki Dae
Hi Dave, Just two cleanups - one is to drop drmP.h header, and other is to add COMPILE_TEST flag for increasing build test coverage. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 14808a12bdbdc21143eba70ea07830197b3a04ff

Re: [PATCH] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-18 Thread Inki Dae
ne kernel - linux-5.1.0-rc1 - and even on Tizen kernel (tizen-next branch) but screen remained blank after running modetest app. Without this patch, modetest app worked well on both kernels. Thanks, Inki Dae > > -- > Either I've been missing something or nothing has been going on. (K. E.

Re: [PATCH 2/6] drm/exynos: dsi: Use drm_bridge_detach

2019-03-18 Thread Inki Dae
-off-by: Jagan Teki Acked-by: Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index a

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
you or someone else who has Exynos4xxx based board check it on Odroid-u3 board? I have no board. :( Thanks, Inki Dae > > Regards > Andrzej > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 110 +++--- > 1 file changed, 66 insertions(+), 44 deletions(-) > &

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
Hi Marek, 19. 3. 21. 오후 5:32에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2019-03-21 09:20, Inki Dae wrote: >> 19. 3. 19. 오후 10:05에 Andrzej Hajda 이(가) 쓴 글: >>> MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 >>> to update

[GIT PULL] exynos-drm-fixes

2019-03-21 Thread Inki Dae
Hi Dave, Just one fixup to resolve page fault issue at Mixer device. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the git

Re: [PATCH v2 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-24 Thread Inki Dae
Hi Andrzej, Merge conflict. Could you rebase this patch series on top of exynos-drm-next? Thanks, Inki Dae 19. 3. 20. 오후 10:06에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > GSCALERs in Exynos SoCs support conversion between wide range of image > formats, > plus scaling and rot

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
rm-next. > > Please be aware that DTS patches has been already applied to samsung-soc tree, > I left them here to simplify testing on exynos-drm-next, which is not in sync > with > samsung-soc, for this reason I have moved them on the beginning of the > patchset. Got it. I can

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
19. 3. 26. 오후 10:51에 Andrzej Hajda 이(가) 쓴 글: > On 26.03.2019 09:45, Inki Dae wrote: >> Hi Andrzej, >> >> 19. 3. 25. 오후 4:13에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> GSCALERs in Exynos SoCs support conversion between wide range of image >&g

Re: [PATCH 08/21] drm/exynos: Use drm_fb_helper_fill_info

2019-03-27 Thread Inki Dae
19. 3. 26. 오후 10:19에 Daniel Vetter 이(가) 쓴 글: > This will give the exynos fbdev a name! > > v2: Rebase > > Signed-off-by: Daniel Vetter Acked-by: Inki Dae Thanks, Inki Dae > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > C

[GIT PULL] exynos-drm-fixes

2019-08-02 Thread Inki Dae
Hi Dave, Just two fixups which fixes undefined reference error with NOMMU configuration and potential infinite issue of scaler module, and two trivial cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: Exynos vblank timeout issue

2022-06-03 Thread Inki Dae
ignal works or not in exynos_dsi_te_irq_handler function of exynos_drm_dsi.c Thanks, Inki Dae 2022년 5월 27일 (금) 오전 8:34, Martin Jücker 님이 작성: > > Hello again, > > I tried to dig around a bit to unearth some more information. What I'm > seeing is that it works just fine in the begi

[GIT PULL] exynos-drm-fixes

2022-06-14 Thread Inki Dae
Hi Dave and Daniel, Just two regression fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3: Linux 5.19-rc2 (2022-06-12 16:11:37 -0700) are available in the Git repository at: git

Re: Exynos vblank timeout issue

2022-06-21 Thread Inki Dae
Hi Martin, 2022년 6월 4일 (토) 오후 8:05, Martin Jücker 님이 작성: > > On Sat, Jun 04, 2022 at 01:05:39PM +0900, Inki Dae wrote: > > Hi Martin, > > > > Hi Inki, > > > What kind of panel does Galaxy Note 10.1 use? I guess it uses I80 > > panel which needs CPU-tr

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-02 Thread Inki Dae
Hi Martin. Thanks for your contribution, Inki Dae 22. 1. 30. 07:01에 Martin Jücker 이(가) 쓴 글: > In the downstream kernels for exynos4 and exynos5 devices, there is an > undocumented register that controls the order of the RGB output. It can > be set to either normal order or revers

[GIT PULL] exynos-drm-fixes

2022-02-10 Thread Inki Dae
Hi Dave and Daniel, Just two fixup series - one is to fix irq chaining issue and other is regressions to TE-gpio handling. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566: Linux 5.17-rc3 (2022-02

Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe

2022-04-20 Thread Inki Dae
Hi, 22. 4. 12. 13:19에 Dan Carpenter 이(가) 쓴 글: > On Tue, Apr 12, 2022 at 10:01:20AM +0900, Inki Dae wrote: >> Hi Dan Carpenter. >> >> Same patch[1] was posted so I will pick it up. >> >> [1] >> https://protect2.fireeye.com/v1/url?k=94e9d569-f562c05f-94e85

Re: [PATCH] drm/exynos: fix repeated words in comments

2022-08-24 Thread Inki Dae
rect. > "next next" is correct. :) As you said, "next next" could be reworded more clearly. As of now, the original sentence could make it confusing. Thanks, Inki Dae > Robin. > > > Signed-off-by: Jilin Yuan > > --- > > drivers/gpu/drm/e

Re: [PATCH] drm/exynos: mic: Rework initialization

2022-05-15 Thread Inki Dae
misc-next together with the > rest of Exynos DSI to drm bridge rework patches. The commit-id, dd8b6803bc49, has already been merged to drm-next. Seems no need to go drm-misc-next. So I will merge it as a regression fix after the review, which will be merged to 5.19-rc series. Please let me kn

  1   2   3   4   5   6   7   8   9   10   >