Re: [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 5:10 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called

Re: [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 4:42 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called

Re: [PATCH v6 3/7] drm/i915: Add checks specific to async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:51 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:47PM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject

Re: [PATCH v6 2/7] drm/i915: Add support for async flips in I915

2020-09-02 Thread Karthik B S
On 9/1/2020 4:45 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:46PM +0530, Karthik B S wrote: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane

Re: [PATCH v6 5/7] drm/i915: Add dedicated plane hook for async flip case

2020-09-02 Thread Karthik B S
On 9/1/2020 4:57 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:49PM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. Signed-off

Re: [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:53 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:48PM +0530, Karthik B S wrote: Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get

[PATCH v7 3/7] drm/i915: Add checks specific to async flips

2020-09-04 Thread Karthik B S
-Do not allow async flip with linear buffer on older hw as it has issues with this. (Ville) -Remove break after intel_atomic_check_async. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 143 +++ 1 file chan

[PATCH v7 5/7] drm/i915: Add dedicated plane hook for async flip case

2020-09-04 Thread Karthik B S
and call it from intel_update_plane. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- .../gpu/drm/i915/display/intel_atomic_plane.c | 7 ++ .../drm/i915/display/intel_display_types.h| 3 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 24

[PATCH v7 7/7] drm/i915: Enable async flips in i915

2020-09-04 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni

[PATCH v7 6/7] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-04 Thread Karthik B S
Add the details of the implementation of asynchronous flips for i915. v7: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- Documentation/gpu/i915.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index

[PATCH v7 0/7] Asynchronous flip implementation for i915

2020-09-04 Thread Karthik B S
-with: <20200904102215.4440-1-karthik@intel.com> Karthik B S (7): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async flips in I915 drm/i915: Add checks specific to async flips drm/i915: Do not call drm_crtc_arm_vblank_event in async flips drm/i915: Add dedicated

[PATCH v7 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-04 Thread Karthik B S
'g4x_get_flip_counter' static.(Reported-by: kernel test robot ) -Fix the typo in commit message. v6: -Revert back to old time stamping code. -Remove the break while calling skl_enable_flip_done. (Paulo) v7: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers

[PATCH v7 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-04 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -No need of irq disable if we are not doing vblank evade. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v7 2/7] drm/i915: Add support for async flips in I915

2020-09-04 Thread Karthik B S
) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files

[PATCH v8 0/8] Asynchronous flip implementation for i915

2020-09-14 Thread Karthik B S
platforms with double buffered async address update enable bit. Test-with: <20200908061001.20302-1-karthik@intel.com> Karthik B S (8): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async flips in I915 drm/i915: Add checks specific to async

[PATCH v8 1/8] drm/i915: Add enable/disable flip done and flip done handler

2020-09-14 Thread Karthik B S
'g4x_get_flip_counter' static.(Reported-by: kernel test robot ) -Fix the typo in commit message. v6: -Revert back to old time stamping code. -Remove the break while calling skl_enable_flip_done. (Paulo) v7: -Rebased. v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita

[PATCH v8 7/8] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-14 Thread Karthik B S
Add the details of the implementation of asynchronous flips for i915. v7: -Rebased. v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- Documentation/gpu/i915.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu

[PATCH v8 6/8] drm/i915: WA for platforms with double buffered adress update enable bit

2020-09-14 Thread Karthik B S
In Gen 9 and Gen 10 platforms, async address update enable bit is double buffered. Due to this, during the transition from async flip to sync flip we have to wait until this bit is updated before continuing with the normal commit for sync flip. Signed-off-by: Karthik B S Signed-off-by: Vandita

[PATCH v8 8/8] drm/i915: Enable async flips in i915

2020-09-14 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the series (Paulo) v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -Rebased. v8: -Rebased. Signed-off-by: Karthik B S Signed-off

[PATCH v8 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-14 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -No need of irq disable if we are not doing vblank evade. (Ville) v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++ 1 file changed, 6

[PATCH v8 2/8] drm/i915: Add support for async flips in I915

2020-09-14 Thread Karthik B S
) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h

[PATCH v8 3/8] drm/i915: Add checks specific to async flips

2020-09-14 Thread Karthik B S
-Do not allow async flip with linear buffer on older hw as it has issues with this. (Ville) -Remove break after intel_atomic_check_async. (Ville) v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c |

[PATCH v8 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-14 Thread Karthik B S
and call it from intel_update_plane. (Ville) v8: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- .../gpu/drm/i915/display/intel_atomic_plane.c | 7 ++ .../drm/i915/display/intel_display_types.h| 3 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 24

Re: [PATCH v10 0/8] Asynchronous flip implementation for i915

2020-09-29 Thread Karthik B S
On 9/28/2020 5:48 PM, Ville Syrjälä wrote: On Mon, Sep 21, 2020 at 04:32:02PM +0530, Karthik B S wrote: Without async flip support in the kernel, fullscreen apps where game resolution is equal to the screen resolution, must perform an extra blit per frame prior to flipping. Asynchronous page

[PATCH v10 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-18 Thread Karthik B S
legacy cursor updates. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- .../gpu/drm/i915/display/intel_atomic_plane.c | 6 - .../drm/i915/display/intel_display_types.h| 3 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 24 +++ 3 files changed

Re: [PATCH v8 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-16 Thread Karthik B S
On 9/15/2020 7:40 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:30AM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. v7: -Plane ctl

Re: [PATCH v8 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-16 Thread Karthik B S
On 9/16/2020 6:30 PM, Karthik B S wrote: On 9/15/2020 8:11 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:30AM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during

[PATCH v9 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-16 Thread Karthik B S
and call it from intel_update_plane. (Ville) v8: -Rebased. v9: -Use if-else instead of return in intel_update_plane(). (Ville) -Rename 'program_async_surface_address' to 'async_flip'. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- .../gpu/drm/i915/display

[PATCH v9 0/8] Asynchronous flip implementation for i915

2020-09-16 Thread Karthik B S
platforms with double buffered async address update enable bit. v9: -Changes as per feedback received on previous version. Test-with: <20200916135044.6903-1-karthik@intel.com> Karthik B S (8): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async

[PATCH v9 6/8] drm/i915: WA for platforms with double buffered address update enable bit

2020-09-16 Thread Karthik B S
) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 0f0bcbb00c7f

[PATCH v9 1/8] drm/i915: Add enable/disable flip done and flip done handler

2020-09-16 Thread Karthik B S
) -Use intel_crtc instead of drm_crtc. (Ville) -Do not mix the flip done and vblank hooks. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 8 +++ drivers/gpu/drm/i915/i915_irq.c

[PATCH v9 3/8] drm/i915: Add checks specific to async flips

2020-09-16 Thread Karthik B S
lle) -Remove irrelevant FB size check. (Ville) -Add missing stride check. (Ville) -Use drm_rect_equals() instead of individual checks. (Ville) -Call intel_atomic_check_async before state dump. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i

[PATCH v9 2/8] drm/i915: Add support for async flips in I915

2020-09-16 Thread Karthik B S
) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) v8: -Rebased. v9: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 3

[PATCH v9 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-16 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -No need of irq disable if we are not doing vblank evade. (Ville) v8: -Rebased. v9: -Move the return in intel_pipe_update_end before tracepoint. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed

Re: [PATCH v8 1/8] drm/i915: Add enable/disable flip done and flip done handler

2020-09-16 Thread Karthik B S
On 9/15/2020 7:17 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:26AM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called

Re: [PATCH v8 6/8] drm/i915: WA for platforms with double buffered adress update enable bit

2020-09-16 Thread Karthik B S
On 9/15/2020 7:49 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:31AM +0530, Karthik B S wrote: In Gen 9 and Gen 10 platforms, async address update enable bit is double buffered. Due to this, during the transition from async flip to sync flip we have to wait until this bit is updated

Re: [PATCH v8 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-16 Thread Karthik B S
On 9/15/2020 7:37 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:29AM +0530, Karthik B S wrote: Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get

Re: [PATCH v8 2/8] drm/i915: Add support for async flips in I915

2020-09-16 Thread Karthik B S
On 9/15/2020 7:18 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:27AM +0530, Karthik B S wrote: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane

Re: [PATCH v8 3/8] drm/i915: Add checks specific to async flips

2020-09-16 Thread Karthik B S
On 9/15/2020 7:33 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:28AM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified

[PATCH v9 8/8] drm/i915: Enable async flips in i915

2020-09-16 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the series (Paulo) v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -Rebased. v8: -Rebased. v9: -Rebased. Signed-off-by: Karthik B S

[PATCH v9 7/8] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-16 Thread Karthik B S
Add the details of the implementation of asynchronous flips for i915. v7: -Rebased. v8: -Rebased. v9: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- Documentation/gpu/i915.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/i915.rst b

Re: [PATCH v8 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-16 Thread Karthik B S
On 9/15/2020 8:11 PM, Ville Syrjälä wrote: On Mon, Sep 14, 2020 at 11:26:30AM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. v7: -Plane ctl

[PATCH v10 3/8] drm/i915: Add checks specific to async flips

2020-09-18 Thread Karthik B S
lle) -Remove irrelevant FB size check. (Ville) -Add missing stride check. (Ville) -Use drm_rect_equals() instead of individual checks. (Ville) -Call intel_atomic_check_async before state dump. (Ville) v10: -Fix the checkpatch errors seen on CI. Signed-off-by: Karthik B S Signed-

Re: [PATCH v10 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-21 Thread Karthik B S
On 9/18/2020 5:23 PM, Ville Syrjälä wrote: On Fri, Sep 18, 2020 at 12:30:45PM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. v7: -Plane ctl

Re: [PATCH v9 6/8] drm/i915: WA for platforms with double buffered address update enable bit

2020-09-21 Thread Karthik B S
On 9/18/2020 5:24 PM, Ville Syrjälä wrote: On Wed, Sep 16, 2020 at 08:38:22PM +0530, Karthik B S wrote: In Gen 9 and Gen 10 platforms, async address update enable bit is double buffered. Due to this, during the transition from async flip to sync flip we have to wait until this bit is updated

Re: [PATCH v10 3/8] drm/i915: Add checks specific to async flips

2020-09-21 Thread Karthik B S
On 9/18/2020 5:21 PM, Ville Syrjälä wrote: On Fri, Sep 18, 2020 at 02:32:34PM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified

Re: [PATCH v9 7/8] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-21 Thread Karthik B S
On 9/18/2020 5:28 PM, Ville Syrjälä wrote: On Wed, Sep 16, 2020 at 08:38:23PM +0530, Karthik B S wrote: Add the details of the implementation of asynchronous flips for i915. v7: -Rebased. v8: -Rebased. v9: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni

Re: [PATCH v9 8/8] drm/i915: Enable async flips in i915

2020-09-21 Thread Karthik B S
On 9/18/2020 5:33 PM, Ville Syrjälä wrote: On Wed, Sep 16, 2020 at 08:38:24PM +0530, Karthik B S wrote: Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the series (Paulo) v4: -Rebased

[PATCH v10 1/8] drm/i915: Add enable/disable flip done and flip done handler

2020-09-21 Thread Karthik B S
) -Use intel_crtc instead of drm_crtc. (Ville) -Do not mix the flip done and vblank hooks. (Ville) v10: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 8 +++ drivers/gpu/drm/i915

[PATCH v10 0/8] Asynchronous flip implementation for i915

2020-09-21 Thread Karthik B S
platforms with double buffered async address update enable bit. v9: -Changes as per feedback received on previous version. v10: -Changes as per feedback received on previous version. Karthik B S (8): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async

[PATCH v10 2/8] drm/i915: Add support for async flips in I915

2020-09-21 Thread Karthik B S
) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) v8: -Rebased. v9: -Rebased. v10: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display

[PATCH v11 3/8] drm/i915: Add checks specific to async flips

2020-09-21 Thread Karthik B S
tes. (Ville) -Use 'switch' instead of 'if' for modifier check. (Ville) -Move documentation changes to a single patch. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 121 +++ 1 f

[PATCH v10 6/8] drm/i915: WA for platforms with double buffered address update enable bit

2020-09-21 Thread Karthik B S
) v10: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915

[PATCH v10 8/8] drm/i915: Enable async flips in i915

2020-09-21 Thread Karthik B S
-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index c0e0c8992982

[PATCH v10 7/8] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-21 Thread Karthik B S
Add the details of the implementation of asynchronous flips for i915. v7: -Rebased. v8: -Rebased. v9: -Rebased. v10: Move all documentation changes to this patch. (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- Documentation/gpu/i915.rst

[PATCH v11 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-21 Thread Karthik B S
legacy cursor updates. (Ville) v11: -Rename skl_program_async_surface_address(). (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni Reviewed-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_atomic_plane.c | 6 - .../drm/i915/display/intel_display_types.h| 3

[PATCH v10 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-21 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. v6: -Rebased. v7: -No need of irq disable if we are not doing vblank evade. (Ville) v8: -Rebased. v9: -Move the return in intel_pipe_update_end before tracepoint. (Ville) v10: Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni

Re: [PATCH v5 0/5] Asynchronous flip implementation for i915

2020-08-04 Thread Karthik B S
On 8/4/2020 11:19 AM, Kulkarni, Vandita wrote: -Original Message- From: Michel Dänzer Sent: Wednesday, July 29, 2020 1:04 PM To: Kulkarni, Vandita ; Zanoni, Paulo R ; Vetter, Daniel ; B S, Karthik ; intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ;

[PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-08-07 Thread Karthik B S
'g4x_get_flip_counter' static.(Reported-by: kernel test robot ) -Fix the typo in commit message. v6: -Revert back to old time stamping code. -Remove the break while calling skl_enable_flip_done. (Paulo) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915

[PATCH v6 7/7] drm/i915: Enable async flips in i915

2020-08-07 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. v5: -Rebased. v6: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers

[PATCH v6 6/7] Documentation/gpu: Add asynchronous flip documentation for i915

2020-08-07 Thread Karthik B S
Add the details of the implementation of asynchronous flips for i915. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- Documentation/gpu/i915.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 33cc6ddf8f64

[PATCH v6 3/7] drm/i915: Add checks specific to async flips

2020-08-07 Thread Karthik B S
eck for n_planes in intel_atomic_check_async -Added documentation for async flips. (Paulo) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 113 +++ 1 file changed, 113 insertions(+) diff --git a/drivers/gpu/drm/i

[PATCH v6 5/7] drm/i915: Add dedicated plane hook for async flip case

2020-08-07 Thread Karthik B S
This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 25

[PATCH v6 2/7] drm/i915: Add support for async flips in I915

2020-08-07 Thread Karthik B S
) -Remove the early return in skl_plane_ctl. (Paulo) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH v6 0/7] Asynchronous flip implementation for i915

2020-08-07 Thread Karthik B S
are not allowed. v5: -Fixed the Checkpatch and sparse warnings. v6: -Reverted back to the old timestamping code as per the feedback received. -Added documentation. Test-with: <20200806132935.23293-1-karthik@intel.com> Karthik B S (7): drm/i915: Add enable/disable flip done an

[PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-08-07 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. v6: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-08-05 Thread Karthik B S
On 7/28/2020 3:04 AM, Daniel Vetter wrote: On Mon, Jul 27, 2020 at 2:27 PM Michel Dänzer wrote: On 2020-07-25 1:26 a.m., Paulo Zanoni wrote: Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-08-05 Thread Karthik B S
On 7/25/2020 4:56 AM, Paulo Zanoni wrote: Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-08-05 Thread Karthik B S
On 7/27/2020 5:57 PM, Michel Dänzer wrote: On 2020-07-25 1:26 a.m., Paulo Zanoni wrote: Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 1fa67700d8f4..95953b393941 100644 --- a/drivers/gpu/drm/i915

[PATCH v4 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-13 Thread Karthik B S
handler (Paulo) -Make the pending vblank event NULL in the begining of flip_done_handler to remove sporadic WARN_ON that is seen. v4: -Calculate timestamps using flip done time stamp and current timestamp for async flips (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita

[PATCH v4 3/5] drm/i915: Add checks specific to async flips

2020-07-13 Thread Karthik B S
crtc_state->enable_fbc check. (Ville) -Set the I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP flag for async flip case as scanline counter is not reliable here. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c |

[PATCH v4 0/5] Asynchronous flip implementation for i915

2020-07-13 Thread Karthik B S
are not allowed. Karthik B S (5): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async flips in I915 drm/i915: Add checks specific to async flips drm/i915: Do not call drm_crtc_arm_vblank_event in async flips drm/i915: Enable async flips in i915

[PATCH v4 5/5] drm/i915: Enable async flips in i915

2020-07-13 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display

[PATCH v4 2/5] drm/i915: Add support for async flips in I915

2020-07-13 Thread Karthik B S
Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers

[PATCH v4 4/5] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-07-13 Thread Karthik B S
once every few flips. v4: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 3:28 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 8:15 PM, Kazlauskas, Nicholas wrote: On 2020-06-17 5:58 a.m., Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-24 Thread Karthik B S
On 6/17/2020 9:00 PM, Ville Syrjälä wrote: On Wed, Jun 17, 2020 at 11:58:10AM +0200, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler

Re: [PATCH v5 2/5] drm/i915: Add support for async flips in I915

2020-07-28 Thread Karthik B S
On 7/25/2020 4:56 AM, Paulo Zanoni wrote: Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook

[PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-20 Thread Karthik B S
'g4x_get_flip_counter' static.(Reported-by: kernel test robot ) -Fix the typo in commit message. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 10 +++ drivers/gpu/drm/i915/i915_irq.c | 83

[PATCH v5 2/5] drm/i915: Add support for async flips in I915

2020-07-20 Thread Karthik B S
Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) v5: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni

[PATCH v5 4/5] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-07-20 Thread Karthik B S
once every few flips. v4: -Rebased. v5: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_sprite.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm

[PATCH v5 5/5] drm/i915: Enable async flips in i915

2020-07-20 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. v5: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915

[PATCH v5 3/5] drm/i915: Add checks specific to async flips

2020-07-20 Thread Karthik B S
crtc_state->enable_fbc check. (Ville) -Set the I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP flag for async flip case as scanline counter is not reliable here. v5: -Fix typo and other check patch errors seen in CI in 'intel_atomic_check_async' function. Signed-off-by: Karthik B S Sig

[PATCH v5 0/5] Asynchronous flip implementation for i915

2020-07-20 Thread Karthik B S
are not allowed. v5: -Fixed the Checkpatch and sparse warnings. Karthik B S (5): drm/i915: Add enable/disable flip done and flip done handler drm/i915: Add support for async flips in I915 drm/i915: Add checks specific to async flips drm/i915: Do not call drm_crtc_arm_vblank_event in async

Re: [Intel-gfx] [PATCH v6 00/18] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-26 Thread Karthik B S
-karthik@intel.com As HDCP over MST set up is not present on CI, tested this series locally with v4 of the IGT series. https://patchwork.freedesktop.org/series/82987/ Tested-by: Karthik B S Anshuman Gupta (18): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hdcp: Get conn

Re: [Intel-gfx] [PATCH v5 00/17] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-24 Thread Karthik B S
on CI, I've tested this series on local set up with the above IGT series. Tested-by: Karthik B S [PATCH v5 11/17] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len has an Ack from Tomas to merge it via drm-intel. [PATCH v5 12/17] drm/hdcp: Max MST content streams has an Ack from drm-misc

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake

2023-10-11 Thread Karthik B S
is booting seamlessly into Ubuntu UI and played around with a few display settings as well.(Single display, clone and extended modes). Also tried hot-unplug and plug for the HDMI and is working as expected. Basic video playback was also verified on both eDP and HDMI. Tested-by: Karthik B S