Re: [PATCH] drm/amd/display: Fix off by one in hdmi_14_process_transaction()

2021-03-02 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] Thanks Reviewed-by: Bhawanpreet Lakha From: Dan Carpenter Sent: March 2, 2021 6:15 AM To: Wentland, Harry ; Lakha, Bhawanpreet Cc: Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; David

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-12 Thread Lakha, Bhawanpreet
the patch layout that was sent before. Thanks, Bhawan From: Bhawanpreet Lakha Sent: October 12, 2021 5:58 PM To: Zuo, Jerry ; dri-devel@lists.freedesktop.org ; ly...@redhat.com Cc: Wentland, Harry ; Lin, Wayne ; Kazlauskas, Nicholas ; Lakha, Bhawanpreet

Re: [PATCH -next] drm/amd/display: tweak the kerneldoc for active_vblank_irq_count

2021-01-11 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] Thanks, Reviewed-by: Bhawanpreet Lakha From: Lukas Bulwahn Sent: January 11, 2021 3:46 AM To: Lakha, Bhawanpreet ; Kazlauskas, Nicholas ; Deucher, Alexander ; Koenig, Christian ; amd

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Lakha, Bhawanpreet
iel Vetter wrote: >> On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: >>> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet >>> wrote: >>>> I misunderstood and was talking about the ksv validation specifically >>>> (usage of drm_hdcp_check_ksvs_r

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-10-09 Thread Lakha, Bhawanpreet
Hi, The reason we don't use drm_hdcp is because our policy is to do hdcp verification using PSP/HW (onboard secure processor). Bhawan On 2019-10-09 12:32 p.m., Daniel Vetter wrote: > On Thu, Oct 03, 2019 at 11:08:03PM +0100, Colin Ian King wrote: >> Hi, >> >> Static analysis with Coverity has d

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-10-09 Thread Lakha, Bhawanpreet
I misunderstood and was talking about the ksv validation specifically (usage of drm_hdcp_check_ksvs_revoked()). For the defines I will create patches to use drm_hdcp where it is usable. Bhawan On 2019-10-09 2:43 p.m., Daniel Vetter wrote: > On Wed, Oct 9, 2019 at 8:23 PM Lakha, Bhawanpr

Re: [PATCH] drm/amdgpu/display: hook renoir dc to pplib funcs

2019-10-15 Thread Lakha, Bhawanpreet
Reviewed-by: Bhawanpreet Lakha On 2019-10-15 11:04 a.m., Hersen Wu wrote: > enable dc get dmp clock table and set dcn watermarks > via pplib. > > Signed-off-by: Hersen Wu > --- > .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 93 +++ > drivers/gpu/drm/amd/display/dc/dm_pp_smu

Re: [PATCH] drm/amdgpu/display: fix build error casused by CONFIG_DRM_AMD_DC_DCN2_1

2019-10-15 Thread Lakha, Bhawanpreet
Reviewed-by: Bhawanpreet Lakha On 2019-10-15 12:51 p.m., Hersen Wu wrote: > when CONFIG_DRM_AMD_DC_DCN2_1 is not enable in .config, > there is build error. struct dpm_clocks shoud not be > guarded. > > Signed-off-by: Hersen Wu > --- > drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 3 --- > 1 fi

HDCP Content Type Interface

2019-09-09 Thread Lakha, Bhawanpreet
Hi all, This is regarding the recent hdcp content type patch that was merged into drm-misc. (https://patchwork.freedesktop.org/patch/320958/?series=57233&rev=11) There are displays on the market that advertise HDCP 2.2 support and will pass authentication and encryption but will then show a cor

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] pos->port->connector? This is checking the crtc not the connector. The crtc can be null if its disabled. Since it is happening after a unplug->hotplug, I guess we are missing something in the disable sequence and the old connector is still i

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Lakha, Bhawanpreet
nd anything that I can use to remove the port from the list. So, a potential solution to this would be to add a check for vpci = 0 and skip that port. Thoughts/Suggestions? Bhawan From: amd-gfx on behalf of Lakha, Bhawanpreet Sent: August 14, 2020 2:52 PM T

Re: [PATCH] drm/amdgpu: Fixes uninitialized variable usage in amdgpu_dm_setup_replay

2023-10-27 Thread Lakha, Bhawanpreet
, Christian ; Pan, Xinhui ; dan...@ffwll.ch ; Lakha, Bhawanpreet ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; linux-kernel-ment...@lists.linuxfoundation.org Subject: [PATCH] drm/amdgpu: Fixes uninitialized variable usage in

Re: [PATCH] drm/amdgpu: Fixes uninitialized variable usage in amdgpu_dm_setup_replay

2023-10-27 Thread Lakha, Bhawanpreet
(Leo) ; Lakha, Bhawanpreet ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian ; linux-kernel-ment...@lists.linuxfoundation.org Subject: Re: [PATCH] drm/amdgpu: Fixes