https://bugs.freedesktop.org/show_bug.cgi?id=110897
GitLab Migration User changed:
What|Removed |Added
Resolution|--- |MOVED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #71 from Richard Thier ---
Made a similar writeup on this topic too:
http://ballmerpeak.web.elte.hu/devblog/debugging-hyperz-and-fixing-a-radeon-drm-linux-kernel-module.html
Also tried to document all relevant information if it
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Richard Thier changed:
What|Removed |Added
Attachment #144572|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #69 from Marek Olšák ---
Can you send it to amd-...@lists.freedesktop.org adding the "drm/radeon: "
commit prefix and your Signed-off-by?
Thanks.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Richard Thier changed:
What|Removed |Added
Attachment #144559|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #67 from Marek Olšák ---
Keep the rs400_mc_wait_for_idle call.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Michel Dänzer changed:
What|Removed |Added
CC|mic...@daenzer.net |
--- Comment #66 from Michel Dänzer
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #65 from Richard Thier ---
Okay. Then variant 1 is the way to go I think.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #64 from Marek Olšák ---
rs400, which includes rc400, is not r400. It's r300.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #63 from cosiek...@o2.pl ---
(In reply to Richard Thier from comment #58)
> Also there was one time where things were working for me before changes but
> I do not know what the pipe value was back then. So yes, there is SOME
> chance
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #62 from Richard Thier ---
Tested both versions and both work for me. Performance gain when using HyperZ
is around 5-10% for me (that is sometimes just 2-4 FPS, sometimes more).
gb_pipes are reported as 1 now as it should be.
--
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #61 from Richard Thier ---
Created attachment 144560
--> https://bugs.freedesktop.org/attachment.cgi?id=144560=edit
Fix variant 2 (special case pipe number for 0x5a62)
Added the second fix variation I've imagined. I am still
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #60 from Richard Thier ---
Created attachment 144559
--> https://bugs.freedesktop.org/attachment.cgi?id=144559=edit
Fix variant 1 (delegate to r300 init)
Added a possible drm patch for kernel source tree. This version is the one
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #59 from Richard Thier ---
> the glitches are the same (I know about some already),
> everything works that worked before...
I was kinda hoping maybe some glitches I know can go away if the init code does
the r300_init but that is
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #58 from Richard Thier ---
I still have some dmesg logs around from my other debugging session and in
every one of those I get 3 pipes despite different kernel versions from 4.4 to
latest 5.x
Also looking at git blame I can see
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #57 from cosiek...@o2.pl ---
4.14.124: 1 quad pipes, 1 z pipes initialized.
4.19.49: 1 quad pipes, 1 z pipes initialized.
4.20.17: 1 quad pipes, 1 z pipes initialized.
5.0.21: 1 quad pipes, 1 z pipes initialized.
5.1.8: 1 quad pipes,
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #56 from Richard Thier ---
(In reply to cosiekvfj from comment #54)
> Created attachment 144558 [details]
> dmesg log
>
> [ 14.303343] [drm] radeon: 1 quad pipes, 1 z pipes initialized.
This is really interesting! It tells us
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #55 from Richard Thier ---
(In reply to Dieter Nützel from comment #53)
> If you do NOT 'make mrproper' and change only radeon/amdgpu stuff it should
> only take some minutes (seconds) on your system/CPU.
I was dumb-enough that
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #54 from cosiek...@o2.pl ---
Created attachment 144558
--> https://bugs.freedesktop.org/attachment.cgi?id=144558=edit
dmesg log
[ 14.303343] [drm] radeon: 1 quad pipes, 1 z pipes initialized.
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #53 from Dieter Nützel ---
(In reply to Richard Thier from comment #52)
> (In reply to Marek Olšák from comment #45)
> > The problem might be in the kernel. See function rs400_gpu_init. I think it
> > should call r300_gpu_init
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #52 from Richard Thier ---
(In reply to Marek Olšák from comment #45)
> The problem might be in the kernel. See function rs400_gpu_init. I think it
> should call r300_gpu_init instead of r420_pipes_init.
Aaaah Am I this
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #51 from Richard Thier ---
(In reply to cosiekvfj from comment #17)
>*-display
> description: VGA compatible controller
> product: RC410M [Mobility Radeon Xpress 200M]
>
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #50 from Richard Thier ---
"
Also there is this "RS400" asic listed in the above switch case and it is still
an other candidate maybe but surely not the rs400_asic.
"
I mean my card should be surely not rs420_asic. The rs_400 I
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #49 from Richard Thier ---
Hmmm. There are a lot of FIXMEs in the kernel at this part saying things are
not pretty sure. I think I am running into an other code path I should be
taking, but if this was always like this then maybe
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #48 from Richard Thier ---
Btw I saw that mesa codes handle my RC410 as one having RV350 (is_rv350 is
true), but unlike R400 family chip. I have no idea if that is right, but if the
kernel part do differently than the userland part
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #47 from Richard Thier ---
Created attachment 144552
--> https://bugs.freedesktop.org/attachment.cgi?id=144552=edit
grepping around init functions in kernel / drm
Hmmm... I see that this got printed out in dmesg:
[ 17.669902]
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #46 from Richard Thier ---
(In reply to Marek Olšák from comment #45)
> The problem might be in the kernel. See function rs400_gpu_init. I think it
> should call r300_gpu_init instead of r420_pipes_init.
I will put some logging
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #45 from Marek Olšák ---
The problem might be in the kernel. See function rs400_gpu_init. I think it
should call r300_gpu_init instead of r420_pipes_init.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #44 from Marek Olšák ---
RC410 most likely has only 1 pipe. 3 pipes would be for a discrete GPU that
isn't small.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #43 from Marek Olšák ---
You can try to compare your num_gb_pipes with somebody else who has the same
GPU.
--
You are receiving this mail because:
You are the assignee for the bug.___
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #42 from Richard Thier ---
(In reply to Marek Olšák from comment #40)
> I'm afraid nobody remembers anymore how HyperZ works on r300. I can answer
> basic questions if you have any.
Hi!
Currently I have added this to
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #41 from Dieter Nützel ---
(In reply to Marek Olšák from comment #40)
> I'm afraid nobody remembers anymore how HyperZ works on r300. I can answer
> basic questions if you have any.
Hello Marek!
Thanks for your offer, I know you
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #40 from Marek Olšák ---
I'm afraid nobody remembers anymore how HyperZ works on r300. I can answer
basic questions if you have any.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #39 from Dieter Nützel ---
Oh and have a look, here:
Feature Matrix for Free Radeon Drivers
https://www.x.org/wiki/RadeonFeature/
r300 have some points open...;-)
https://www.x.org/wiki/RadeonFeature/#note_14
--
You are
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Dieter Nützel changed:
What|Removed |Added
CC||mar...@gmail.com,
|
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #37 from Richard Thier ---
(In reply to Dieter Nützel from comment #35)
> Hello Richard,
>
> very NICE progress!
>
> Maybe you can run 'glmark2' with/without HyperZ.
Good idea.
Can you test if HyperZ works for you without any
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #36 from Richard Thier ---
Okay it seems pipes=1 is working on my machine.
diff --git a/src/gallium/drivers/r300/r300_texture_desc.c
b/src/gallium/drivers/r300/r300_texture_desc.c
index 77d272bfb6b..029b28570d7 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #35 from Dieter Nützel ---
Hello Richard,
very NICE progress!
Maybe you can run 'glmark2' with/without HyperZ.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #34 from Richard Thier ---
Created attachment 144549
--> https://bugs.freedesktop.org/attachment.cgi?id=144549=edit
Proof screenshot that it works now
Added screenshot of HyperZ "just working" with the quickfix for me. I think it
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #33 from Richard Thier ---
Created attachment 144548
--> https://bugs.freedesktop.org/attachment.cgi?id=144548=edit
Working hack / quickfix
Pretty interesting but I just tried to change the "most logical" part of
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #32 from Richard Thier ---
If my card has no "hiz_ram" what that means? Can anyone explain if I am right?
This is what I suspect so far:
- Zcompression I get still, because the card has zmask_ram
- No hierarchical Z (hiz) at all
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #31 from Richard Thier ---
Created attachment 144545
--> https://bugs.freedesktop.org/attachment.cgi?id=144545=edit
Really no cmask ram it seems
I have faked to have hiz ram and cmask ram just to see what happens.
When I am
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #30 from Richard Thier ---
It seems it can be normal, but then my understanding of hyperZ was a bit off
then.
I will try adding hiz ram for it just to see what happens :-)
--
You are receiving this mail because:
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #29 from Richard Thier ---
Okay this is weird for me:
/* src/gallium/drivers/r300/r300_texture_desc.c */
399 /* Get the HIZ buffer size in dwords. */
400 hiz_numdw = (stride * height) / (8*8 * pipes);
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #28 from Richard Thier ---
I still see the glitches with the following changes:
@@ -364,11 +369,21 @@ static void r300_clear(struct pipe_context* pipe,
/* Clear. */
if (buffers) {
/* Clear using the blitter. */
+
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Richard Thier changed:
What|Removed |Added
Priority|low |medium
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #27 from Richard Thier ---
This is also always happening:
434 /* Enable fastfill and/or hiz.
435 *
436 * If we cleared zmask/hiz, it's in use now. The Hyper-Z state update
437 * looks if zmask/hiz is in
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #26 from Richard Thier ---
Okay it is still bad now despite I have compiled with "-O0" flags actually...
To be honest I have no idea actually why it started working last time.
Also now that I step with the debugger I see that a lot
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Richard Thier changed:
What|Removed |Added
Severity|minor |normal
Priority|lowest
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #25 from Richard Thier ---
Pfff it is bad once again now and I have no idea why... maybe a real heisenbug
because of some state :-(
Also turning off the machine or rebooting does not seem to help despite I went
back to the "-O2"
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #24 from Richard Thier ---
Hmmm...
With -O3 I see the same kind of issue. It seems it is there when highest
optimization is on maybe?
I will build -O2 once again without a restart just to see.
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Richard Thier changed:
What|Removed |Added
Severity|normal |minor
Priority|medium
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #23 from Richard Thier ---
Or can it be that literally I had a short term hardware error in my card
because of running in this hot summer for very long periods. I could be ram
corruption too that just got solved now for some reason.
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #22 from Richard Thier ---
Created attachment 144532
--> https://bugs.freedesktop.org/attachment.cgi?id=144532=edit
should not affect anything patch
Interestingly now I am running with this patch, but I never saw this code path
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #21 from cosiek...@o2.pl ---
No wait. That reminds me of this weird behavior I had in
https://bugs.freedesktop.org/show_bug.cgi?id=101382
17.1.2-1 crash(different)
17.1.1-1 crash(different)
17.1.0-1 crash(different)
17.0.5-1 working
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #20 from cosiek...@o2.pl ---
>I have less and less of an idea when this thing happens.
My first thought was maybe compositor or 64 vs 32 bit os. I'm using xfwm with
compositing turned off. I also changed the CPU in this laptop ;)
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #19 from Richard Thier ---
Btw the code paths for my logs are always the same - both when wrong and
good I have no idea...
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #18 from Richard Thier ---
Weird. That is exactly the same card as mine... I have less and less of an idea
when this thing happens. I will try building with various optimization fals but
it might be also that the card can get stick
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #17 from cosiek...@o2.pl ---
*-display
description: VGA compatible controller
product: RC410M [Mobility Radeon Xpress 200M]
vendor: Advanced Micro Devices, Inc. [AMD/ATI]
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #16 from Richard Thier ---
Btw I now have no problems at all... This is weird... all I did was to remove
my printfs so that code is actually stock mesa and I both see the speed gain
and there is no problems whatsoever...
But I
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #15 from Richard Thier ---
(In reply to cosiekvfj from comment #14)
> Created attachment 144524 [details]
> bigger glxgears window
>
> >Is HyperZ just good without any changes to stock mesa?
> yes, mesa is from manjaro repo, and I
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #14 from cosiek...@o2.pl ---
Created attachment 144524
--> https://bugs.freedesktop.org/attachment.cgi?id=144524=edit
bigger glxgears window
>Is HyperZ just good without any changes to stock mesa?
yes, mesa is from manjaro repo,
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #13 from cosiek...@o2.pl ---
01:05.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
RC410M [Mobility Radeon Xpress 200M] (prog-if 00 [VGA controller])
Subsystem: Packard Bell B.V. RC410M [Mobility Radeon
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #12 from Richard Thier ---
Hi Cosiek!
What card is that (lspci output maybe)? Is HyperZ just good without any changes
to stock mesa? Your card seems to be also reported as RC410 like mine, but you
have much-much more FPS for some
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #11 from cosiek...@o2.pl ---
Created attachment 144523
--> https://bugs.freedesktop.org/attachment.cgi?id=144523=edit
good HyperZ glxgears
Extended renderer info (GLX_MESA_query_renderer):
Vendor: X.Org R300 Project (0x1002)
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #10 from cosiek...@o2.pl ---
>Was it looking similar? Was it solved for your case?
I didn't report that bug. Someone just wrote in that thread that HyperZ was not
enabled due to lack of testing, so I ran some piglid tests. :)
I
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #9 from Richard Thier ---
So these does not seem to happen at any time:
/* Emit clear packets. */
r300_emit_gpu_flush(r300, r300->gpu_flush.size, r300->gpu_flush.state);
r300->gpu_flush.dirty = FALSE;
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #8 from Richard Thier ---
I think I see a bug happening here and we are not emitting the relevant things.
A bit tired now for the night...
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #7 from Richard Thier ---
Created attachment 144515
--> https://bugs.freedesktop.org/attachment.cgi?id=144515=edit
Log output for "added logging" patch
As you can see the "KUL-D" and the "KULAKVA-n" log messages never gets
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #6 from Richard Thier ---
Created attachment 144514
--> https://bugs.freedesktop.org/attachment.cgi?id=144514=edit
Added logging - magically works but slow from logging!
This is what I am running with now. There are no other
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #5 from Richard Thier ---
Hi!
Was it looking similar? Was it solved for your case?
Btw I just started to have insights on what the hardware does, but might need
to work a bit in the wine field because of the good weather so if I
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #4 from cosiek...@o2.pl ---
Hello you all! Couple of years ago I did tests HyperZ
https://bugs.freedesktop.org/show_bug.cgi?id=37724
Maybe you will find this link useful!
--
You are receiving this mail because:
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #3 from Richard Thier ---
H... I must have made a measurement error as looking at the code the small
patch of mine cannot be slower than before it when not using HYPERZ...
--
You are receiving this mail because:
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #2 from Richard Thier ---
Created attachment 144512
--> https://bugs.freedesktop.org/attachment.cgi?id=144512=edit
Error gone patch - but it is slow
If I understand it well, HyperZ can be owned by only one process / owner and
the
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #1 from Richard Thier ---
Created attachment 144510
--> https://bugs.freedesktop.org/attachment.cgi?id=144510=edit
Second screenshot (visible tile boundary - zbuffer is completely wasted below)
Added second screenshot. You can
https://bugs.freedesktop.org/show_bug.cgi?id=110897
Bug ID: 110897
Summary: HyperZ is broken for r300 (bad z for some micro and
macrotiles?)
Product: Mesa
Version: git
Hardware: Other
OS: other
76 matches
Mail list logo
