Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-13 Thread Marc Zyngier
Hi Heiko, On 10/02/18 16:23, Heiko Stuebner wrote: > Hi Marc, > > Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier: >> The rockchip DRM driver is quite careful to disable interrupts >> when taking a lock that is also taken in interrupt context, >> which is a good thing. >> >> What

[PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-11 Thread Marc Zyngier
The rockchip DRM driver is quite careful to disable interrupts when taking a lock that is also taken in interrupt context, which is a good thing. What is a bit over the top is to use spin_lock_irqsave when already in interrupt context, as you cannot take another interrupt again, and disabling

Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-10 Thread Heiko Stuebner
Hi Marc, Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier: > The rockchip DRM driver is quite careful to disable interrupts > when taking a lock that is also taken in interrupt context, > which is a good thing. > > What is a bit over the top is to use spin_lock_irqsave when >