Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-28 Thread Andrzej Hajda
On 27.08.2018 19:59, Russell King - ARM Linux wrote: > Hi Andrzej, > > On Mon, Aug 27, 2018 at 06:15:59PM +0200, Andrzej Hajda wrote: >> On 30.07.2018 18:42, Russell King wrote: >>> static void tda998x_destroy(struct tda998x_priv *priv) >>> { >>> + drm_bridge_remove(>bridge); >>> + >>> /*

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-27 Thread Russell King - ARM Linux
Hi Andrzej, On Mon, Aug 27, 2018 at 06:15:59PM +0200, Andrzej Hajda wrote: > On 30.07.2018 18:42, Russell King wrote: > > static void tda998x_destroy(struct tda998x_priv *priv) > > { > > + drm_bridge_remove(>bridge); > > + > > /* disable all IRQs and free the IRQ handler */ > >

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-27 Thread Andrzej Hajda
On 30.07.2018 18:42, Russell King wrote: > Convert tda998x to a bridge driver with built-in encoder support for > compatibility with existing component drivers. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 154 > +++--- > 1 file

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-14 Thread Russell King - ARM Linux
On Tue, Aug 14, 2018 at 12:42:42PM +0200, Daniel Vetter wrote: > Given your past track record of handling other contributors I think it's > entirely understandably that people do not choose to collaborate with you > voluntarily. Fixing that is entirely up to you though. I do not work piecemeal.

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-14 Thread Daniel Vetter
On Tue, Aug 14, 2018 at 12:48 PM, Russell King - ARM Linux wrote: > On Tue, Aug 14, 2018 at 12:42:42PM +0200, Daniel Vetter wrote: >> Given your past track record of handling other contributors I think it's >> entirely understandably that people do not choose to collaborate with you >>

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-14 Thread Daniel Vetter
On Fri, Aug 10, 2018 at 06:16:30PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 10, 2018 at 01:02:29PM -0400, Sean Paul wrote: > > On Fri, Aug 10, 2018 at 05:50:37PM +0100, Russell King - ARM Linux wrote: > > > Almost none of my DRM specific patches on dri-devel this time around > > >

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-11 Thread Russell King - ARM Linux
On Fri, Aug 10, 2018 at 12:11:05PM -0400, Sean Paul wrote: > On Wed, Aug 08, 2018 at 11:15:47PM +0100, Russell King - ARM Linux wrote: > > In any case, bridges are buggy with unbinding/rebinding as I've pointed > > out several times in the past, but TDA998x used with Armada and TI LCDC > > as it

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-11 Thread Russell King - ARM Linux
On Fri, Aug 10, 2018 at 01:02:29PM -0400, Sean Paul wrote: > On Fri, Aug 10, 2018 at 05:50:37PM +0100, Russell King - ARM Linux wrote: > > Almost none of my DRM specific patches on dri-devel this time around > > received any feedback what so ever, even after myself and David chasing > > them up.

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-11 Thread Russell King - ARM Linux
On Wed, Aug 08, 2018 at 03:09:30PM -0400, Sean Paul wrote: > > -static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs > > = { > > - .dpms = tda998x_encoder_dpms, > > - .prepare = tda998x_encoder_prepare, > > - .commit = tda998x_encoder_commit, > > - .mode_set =

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-10 Thread Sean Paul
On Fri, Aug 10, 2018 at 05:50:37PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 10, 2018 at 12:11:05PM -0400, Sean Paul wrote: > > On Wed, Aug 08, 2018 at 11:15:47PM +0100, Russell King - ARM Linux wrote: > > > In any case, bridges are buggy with unbinding/rebinding as I've pointed > > >

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-10 Thread Sean Paul
On Wed, Aug 08, 2018 at 11:15:47PM +0100, Russell King - ARM Linux wrote: > On Wed, Aug 08, 2018 at 03:09:30PM -0400, Sean Paul wrote: > > > -static const struct drm_encoder_helper_funcs > > > tda998x_encoder_helper_funcs = { > > > - .dpms = tda998x_encoder_dpms, > > > - .prepare =

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-08 Thread Sean Paul
On Mon, Jul 30, 2018 at 05:42:21PM +0100, Russell King wrote: > Convert tda998x to a bridge driver with built-in encoder support for > compatibility with existing component drivers. > > Signed-off-by: Russell King Hi Russell, Thanks for doing the bridge conversion, it certainly seems a better

Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-08-02 Thread Peter Rosin
Hi! This patch needs a refresh since commit cde4c44d8769 ("drm: drop _mode_ from drm_mode_connector_attach_encoder") interferes with hunk#4 On 2018-07-30 18:42, Russell King wrote: > Convert tda998x to a bridge driver with built-in encoder support for > compatibility with existing component

[PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver

2018-07-31 Thread Russell King
Convert tda998x to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 154 +++--- 1 file changed, 79 insertions(+), 75 deletions(-) diff --git