[RFCv4 10/14] drm: convert crtc to properties/state

2014-03-04 Thread Sean Paul
On Tue, Mar 4, 2014 at 5:04 PM, Rob Clark wrote: > On Tue, Mar 4, 2014 at 4:29 PM, Sean Paul wrote: >> On Mon, Nov 25, 2013 at 9:47 AM, Rob Clark wrote: >>> Break the mutable state of a crtc out into a separate structure >>> and use atomic properties mechanism to set crtc attributes. This >>>

[RFCv4 10/14] drm: convert crtc to properties/state

2014-03-04 Thread Rob Clark
On Tue, Mar 4, 2014 at 4:29 PM, Sean Paul wrote: > On Mon, Nov 25, 2013 at 9:47 AM, Rob Clark wrote: >> Break the mutable state of a crtc out into a separate structure >> and use atomic properties mechanism to set crtc attributes. This >> makes it easier to have some helpers for

[RFCv4 10/14] drm: convert crtc to properties/state

2014-03-04 Thread Sean Paul
On Mon, Nov 25, 2013 at 9:47 AM, Rob Clark wrote: > Break the mutable state of a crtc out into a separate structure > and use atomic properties mechanism to set crtc attributes. This > makes it easier to have some helpers for crtc->set_property() > and for checking for invalid params. The idea

[RFCv4 10/14] drm: convert crtc to properties/state

2013-12-11 Thread Rob Clark
On Wed, Dec 11, 2013 at 4:48 PM, Matt Roper wrote: > On Mon, Nov 25, 2013 at 09:47:34AM -0500, Rob Clark wrote: > ... >> +static struct drm_crtc_state * >> +drm_atomic_helper_get_crtc_state(struct drm_crtc *crtc, void *state) >> +{ >> + struct drm_atomic_helper_state *a = state; >> +

[RFCv4 10/14] drm: convert crtc to properties/state

2013-12-11 Thread Matt Roper
On Mon, Nov 25, 2013 at 09:47:34AM -0500, Rob Clark wrote: ... > +static struct drm_crtc_state * > +drm_atomic_helper_get_crtc_state(struct drm_crtc *crtc, void *state) > +{ > + struct drm_atomic_helper_state *a = state; > + struct drm_crtc_state *cstate; > + int ret; > + > + ret =

[RFCv4 10/14] drm: convert crtc to properties/state

2013-11-25 Thread Rob Clark
Break the mutable state of a crtc out into a separate structure and use atomic properties mechanism to set crtc attributes. This makes it easier to have some helpers for crtc->set_property() and for checking for invalid params. The idea is that individual drivers can wrap the state struct in