Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Joe Perches
On Thu, 2018-12-06 at 15:41 +0100, Michel Dänzer wrote: > On 2018-12-06 1:23 p.m., Joe Perches wrote: > > On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote: > > > In contrast to the 2b case, the pr_debug output isn't visible by default > > > with 1b, so the latter doesn't fit "always produce

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Michel Dänzer
On 2018-12-06 5:10 p.m., Daniel Thompson wrote: > On Thu, Dec 06, 2018 at 03:41:16PM +0100, Michel Dänzer wrote: >> On 2018-12-06 1:23 p.m., Joe Perches wrote: >>> On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote: In contrast to the 2b case, the pr_debug output isn't visible by default

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Daniel Thompson
On Thu, Dec 06, 2018 at 03:41:16PM +0100, Michel Dänzer wrote: > On 2018-12-06 1:23 p.m., Joe Perches wrote: > > On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote: > >> In contrast to the 2b case, the pr_debug output isn't visible by default > >> with 1b, so the latter doesn't fit "always

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Michel Dänzer
On 2018-12-06 1:23 p.m., Joe Perches wrote: > On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote: >> In contrast to the 2b case, the pr_debug output isn't visible by default >> with 1b, so the latter doesn't fit "always produce output" either. > > I think you are mistaken here. Still puzzled

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Joe Perches
On Thu, 2018-12-06 at 12:52 +0100, Michel Dänzer wrote: > In contrast to the 2b case, the pr_debug output isn't visible by default > with 1b, so the latter doesn't fit "always produce output" either. I think you are mistaken here. Adding #define DEBUG as Chris did enables pr_debug output and is

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Michel Dänzer
On 2018-12-06 12:41 p.m., Joe Perches wrote: > On Thu, 2018-12-06 at 10:23 +0100, Michel Dänzer wrote: >> On 2018-12-06 3:51 a.m., Joe Perches wrote: >>> On Thu, 2018-12-06 at 10:40 +0800, Zhang, Jerry(Junwei) wrote: On 12/6/18 12:56 AM, Michel Dänzer wrote: > From: Michel Dänzer >

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Joe Perches
On Thu, 2018-12-06 at 10:23 +0100, Michel Dänzer wrote: > On 2018-12-06 3:51 a.m., Joe Perches wrote: > > On Thu, 2018-12-06 at 10:40 +0800, Zhang, Jerry(Junwei) wrote: > > > On 12/6/18 12:56 AM, Michel Dänzer wrote: > > > > From: Michel Dänzer > > > > > > > > The following cases are possible

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Chris Wilson
Quoting Michel Dänzer (2018-12-06 09:21:40) > On 2018-12-06 10:12 a.m., Chris Wilson wrote: > > Quoting Zhang, Jerry(Junwei) (2018-12-06 02:40:42) > >> On 12/6/18 12:56 AM, Michel Dänzer wrote: > >>> From: Michel Dänzer > >>> > >>> The following cases are possible for pr_debug(): > >>> > >>> 1.

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Michel Dänzer
On 2018-12-06 3:51 a.m., Joe Perches wrote: > On Thu, 2018-12-06 at 10:40 +0800, Zhang, Jerry(Junwei) wrote: >> On 12/6/18 12:56 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> The following cases are possible for pr_debug(): >>> >>> 1. CONFIG_DYNAMIC_DEBUG disabled >>> a) DEBUG not

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Michel Dänzer
On 2018-12-06 10:12 a.m., Chris Wilson wrote: > Quoting Zhang, Jerry(Junwei) (2018-12-06 02:40:42) >> On 12/6/18 12:56 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> The following cases are possible for pr_debug(): >>> >>> 1. CONFIG_DYNAMIC_DEBUG disabled >>> a) DEBUG not defined:

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Chris Wilson
Quoting Zhang, Jerry(Junwei) (2018-12-06 02:40:42) > On 12/6/18 12:56 AM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > The following cases are possible for pr_debug(): > > > > 1. CONFIG_DYNAMIC_DEBUG disabled > > a) DEBUG not defined: pr_debug() translates to no_printk(...), i.e. > >

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-05 Thread Joe Perches
On Thu, 2018-12-06 at 10:40 +0800, Zhang, Jerry(Junwei) wrote: > On 12/6/18 12:56 AM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > The following cases are possible for pr_debug(): > > > > 1. CONFIG_DYNAMIC_DEBUG disabled > > a) DEBUG not defined: pr_debug() translates to

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-05 Thread Zhang, Jerry(Junwei)
On 12/6/18 12:56 AM, Michel Dänzer wrote: From: Michel Dänzer The following cases are possible for pr_debug(): 1. CONFIG_DYNAMIC_DEBUG disabled a) DEBUG not defined: pr_debug() translates to no_printk(...), i.e. it never generates any output. b) DEBUG defined: pr_debug()