Re: [RFC][PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-29 Thread Arnd Bergmann
On Wed, Nov 29, 2017 at 6:05 AM, Archit Taneja wrote: > On 11/29/2017 03:02 AM, John Stultz wrote: >> On Sun, Nov 26, 2017 at 4:56 AM, Archit Taneja >> wrote: >>> Apart from this, we should also move adv7511_cec_init() up in the probe >>> so that

Re: [RFC][PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-28 Thread Archit Taneja
On 11/29/2017 03:02 AM, John Stultz wrote: On Sun, Nov 26, 2017 at 4:56 AM, Archit Taneja wrote: On 11/17/2017 04:29 AM, John Stultz wrote: diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index

Re: [RFC][PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-28 Thread John Stultz
On Sun, Nov 26, 2017 at 4:56 AM, Archit Taneja wrote: > > On 11/17/2017 04:29 AM, John Stultz wrote: >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> index 0e14f15..939c3b9 100644 >> ---

Re: [RFC][PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-26 Thread Archit Taneja
Hi, On 11/17/2017 04:29 AM, John Stultz wrote: From: Arnd Bergmann An otherwise correct cleanup patch from Dan Carpenter turned a broken failure handling from a feature patch by Hans Verkuil into a kernel Oops, so bisection points to commit 7af35b0addbc ("drm/kirin: Checking

Re: [RFC] [PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-20 Thread John Stultz
On Fri, Nov 17, 2017 at 12:43 AM, Hans Verkuil wrote: > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index 3a33075dbb22..56a6a1fa 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++

Re: [RFC] [PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-20 Thread Hans Verkuil
On 11/20/2017 04:05 PM, Hans Verkuil wrote: > On 11/17/2017 09:43 AM, Hans Verkuil wrote: >> If the device tree for a board did not specify a cec clock, then >> adv7511_cec_init would return an error, which would cause adv7511_probe() >> to fail and thus there is no HDMI output. >> >> There is no

Re: [RFC] [PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-20 Thread Hans Verkuil
On 11/17/2017 09:43 AM, Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is no need to have adv7511_probe() fail if the CEC