[Bug 10892] New: Mesa build failure: drm_i915_flip conflict between intel_buffers.c and DRM

2007-05-09 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=10892 Summary: Mesa build failure: drm_i915_flip conflict between intel_buffers.c and DRM Product: Mesa Version: CVS Platform: x86 (IA32) OS/Version: All Status: NEW

Re: R300 cleanup questions

2007-05-09 Thread Jerome Glisse
On 5/8/07, Christoph Brill [EMAIL PROTECTED] wrote: I reviewed the cleanup done by Olliver McFadden and had the following questions: -int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) +static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int prim) Is it

Re: drm-ttm-cleanup-branch

2007-05-09 Thread Thomas Hellström
Dave Airlie wrote: I'll try it out as soon as there is time. I've just tested glxgears and a few mesa tests on it and it seems to be working fine We should probably think about pulling this over into the DRM sooner rather than later, there are also some changes to the DDX i830_driver.c

Re: drm-ttm-cleanup-branch

2007-05-09 Thread Thomas Hellström
...And the patch. Thomas Hellström wrote: Dave Airlie wrote: I'll try it out as soon as there is time. I've just tested glxgears and a few mesa tests on it and it seems to be working fine We should probably think about pulling this over into the DRM sooner rather than later, there are

Re: drm-ttm-cleanup-branch

2007-05-09 Thread Dave Airlie
On 5/9/07, Thomas Hellström [EMAIL PROTECTED] wrote: Dave Airlie wrote: I'll try it out as soon as there is time. I've just tested glxgears and a few mesa tests on it and it seems to be working fine We should probably think about pulling this over into the DRM sooner rather than

Re: [PATCH] make radeons fire fewer vblank interrupts

2007-05-09 Thread Michel Dänzer
On Fri, 2007-05-04 at 14:47 -0700, Jesse Barnes wrote: In playing around yesterday, we found that some drivers will unnecessarily enable interrupts for vblank events. Since these tend to happen frequently (60+ Hz), they'll cause your CPU to wake up a lot, which will waste power if they're

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Jerome Glisse wrote: On 5/8/07, Christoph Brill [EMAIL PROTECTED] wrote: I reviewed the cleanup done by Olliver McFadden and had the following questions: -int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) +static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Hi, I added the not implemented yet comment back, although there are other places that use 65535 so it could be some kind of hardware limit... The only reason that I went with camel case r300FooBar names is because that's what 90% of the driver uses; it's easier to change a few r300_foo_bar to

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
I also think we might need to add _dri_warning/_dri_error because the _mesa versions output Mesa warning: %s which implies to the user this is a Mesa problem, not a DRI driver problem. I could add r300Warning and r300Error, but probably all DRI drivers need warning and error functions... So maybe

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A */ #ifdef RADEON_VTXFMT_A #define HW_VBOS #endif So the VTXFMT

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Here is the patch. On 5/9/07, Oliver McFadden [EMAIL PROTECTED] wrote: I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A

Re: R300 cleanup questions

2007-05-09 Thread Keith Whitwell
Oliver McFadden wrote: I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A */ #ifdef RADEON_VTXFMT_A #define HW_VBOS

Re: [PATCH] make radeons fire fewer vblank interrupts

2007-05-09 Thread Eric Anholt
On Wed, 2007-05-09 at 12:33 +0200, Michel Dänzer wrote: On Fri, 2007-05-04 at 14:47 -0700, Jesse Barnes wrote: In playing around yesterday, we found that some drivers will unnecessarily enable interrupts for vblank events. Since these tend to happen frequently (60+ Hz), they'll cause

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Oliver McFadden wrote: I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A */ #ifdef RADEON_VTXFMT_A #define HW_VBOS

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Oliver McFadden wrote: I also think we might need to add _dri_warning/_dri_error because the _mesa versions output Mesa warning: %s which implies to the user this is a Mesa problem, not a DRI driver problem. I could add r300Warning and r300Error, but probably all DRI drivers need warning

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Well both Keith and Jerome are okay with me removing the VTXFMT code, so I'll go ahead and do that. I don't think there is any serious risk as I'm only removing code that is already disabled. :) Brian, let me know if you want to make a branch so I know when I can push. On 5/9/07, Brian Paul

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
If it's just dead code removal, go ahead. -Brian Oliver McFadden wrote: Well both Keith and Jerome are okay with me removing the VTXFMT code, so I'll go ahead and do that. I don't think there is any serious risk as I'm only removing code that is already disabled. :) Brian, let me know if

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Done. On 5/9/07, Brian Paul [EMAIL PROTECTED] wrote: If it's just dead code removal, go ahead. -Brian Oliver McFadden wrote: Well both Keith and Jerome are okay with me removing the VTXFMT code, so I'll go ahead and do that. I don't think there is any serious risk as I'm only

[Bug 10892] Mesa build failure: drm_i915_flip conflict between intel_buffers.c and DRM

2007-05-09 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=10892 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[R300] minor cleanups

2007-05-09 Thread Christoph Brill
Hi list, I've been browsing through the code to get more in touch with it. On my way I added few doxygen comments and removed the use of a unnecessary function. The removal was agreed by Jerome Glisse. Please check and push these. Thanks in advance, Christoph Brill

[Bug 10892] Mesa build failure: drm_i915_flip conflict between intel_buffers.c and DRM

2007-05-09 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=10892 --- Comment #2 from [EMAIL PROTECTED] 2007-05-09 12:07 PST --- Thanks, Michel. Your reply resolved my problem. I'd just like to confirm the behavior of the DRM and Mesa makefiles now. For DRM, $ ./autogen.sh --prefix=/usr