Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-16 Thread Jesse Barnes
On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: > On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote: > > Recall our last discussion where I outlined the cases we'd have to deal > > with in the modeset ioctl if we didn't use get/put to just keep > >

Re: [PATCH] i915: add page flipping ioctl

2009-02-16 Thread Jesse Barnes
On Sunday, February 15, 2009 4:02 pm Chris Wilson wrote: > On Thu, 2009-02-12 at 16:52 -0800, Jesse Barnes wrote: > > This adds a new ioctl for queueing a page flip with GEM objects. There's > > a completion per private object, that we use at execbuf time to wait for > &g

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: > On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: > > On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: > > > On Fri, 2009-02-13 at 10:27 -0800, Jesse Barnes wrote: > > > > Recall our last d

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:27 am Jesse Barnes wrote: > On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: > > On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: > > > On Sunday, February 15, 2009 11:33 pm Michel Dänzer wrote: > > > > On Fri, 2009-02-1

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 9:43 am Michel Dänzer wrote: > On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: > > On Tuesday, February 17, 2009 9:04 am Michel Dänzer wrote: > > > On Mon, 2009-02-16 at 10:42 -0800, Jesse Barnes wrote: > > > > On Sunday, Feb

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 10:49 am Michel Dänzer wrote: > On Tue, 2009-02-17 at 10:34 -0800, Jesse Barnes wrote: > > On Tuesday, February 17, 2009 9:43 am Michel Dänzer wrote: > > > On Tue, 2009-02-17 at 09:27 -0800, Jesse Barnes wrote: > > > > On Tuesday, Fe

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
value. Apps get to > ignore the man behind the curtain and listen to the real Oz. In that case we should just do it in userspace, Mesa can figure out a value totally independent of the kernel based on refresh rate... Somehow I suspect apps might expect something different though. -- Jesse Barn

Re: [PATCH] drm: make drm_wait_vblank return immediately for very old sequence values

2009-02-17 Thread Jesse Barnes
On Tuesday, February 17, 2009 5:26 pm Ian Romanick wrote: > Jesse Barnes wrote: > > On Tuesday, February 17, 2009 4:10 pm Ian Romanick wrote: > >> Stepping back, there are two separate axes (Are vblanks happening? Is > >> anyone listening?) that give four separate ca

Re: [PATCH] i915: add page flipping ioctl

2009-02-19 Thread Jesse Barnes
dev, crtc); > + > + dev->vblank_inmodeset[crtc] = 0; > } > } > EXPORT_SYMBOL(drm_vblank_post_modeset); Looks fine to me; checking for errors when calling functions is probably a good idea! Thanks, -- Jesse Barnes, Intel Open Source Technology Center --

Re: [PATCH] i915: add page flipping ioctl

2009-02-19 Thread Jesse Barnes
some issues with the X side, but it seems like it's approaching readiness. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC t

Re: [PATCH] i915: add page flipping ioctl

2009-02-19 Thread Jesse Barnes
On Thursday 19 February 2009 16:43:54 Jesse Barnes wrote: > On Thursday 19 February 2009 11:37:01 Chris Wilson wrote: > > With a few additional suggestions by Jesse, I've managed to get > > tear-free compositing working on i915. Here's the diff on top of the > > o

Re: [Intel-gfx] [PATCH] i915: add page flipping ioctl

2009-02-20 Thread Jesse Barnes
ithmetic to > deal with the seqno wrapping around. Given its not obvious at first glance > you might like to add a comment that to explain? It's a somewhat common idiom in the kernel, but yeah a comment wouldn't hurt. -- Jesse

[PATCH] i915: handle bogus VBT panel timing

2009-02-23 Thread Jesse Barnes
We've seen cases in the wild where the VBT sync data is wrong, so add some code to fix it up in that case, taking care to make sure that the total is greater than the sync end. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_bios.c |6 ++ 1 files changed, 6 insertions(

[PATCH] i915: remove PLL debugging messages

2009-02-23 Thread Jesse Barnes
These are normal; we walk through different values looking for the right one, so why flood the screen with messages? Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH] drm: fix parsing of EDID pixel timing

2009-02-23 Thread Jesse Barnes
Had two problems: the bit fields were ordered incorrectly and we were shifing by the wrong amount, leading to very large vsync ranges. Also-authored-by: Linus Torvalds Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_edid.c |4 ++-- include/drm/drm_edid.h |4 ++-- 2 files

[PATCH] i915: suspend/resume interrupt state

2009-02-23 Thread Jesse Barnes
In the KMS case, enter/leavevt won't fix up the interrupt handler for us, so we need to do it at suspend/resume time. Make sure we don't fail the resume if the chip is hung either. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_drv.c | 10 +++--- 1 files changed, 7

Collection of KMS fixes

2009-02-23 Thread Jesse Barnes
Here's a collection of KMS fixes I've put together over the past few days. -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the

[PATCH] i915: suspend/resume interrupt state

2009-02-23 Thread Jesse Barnes
Oops. In the KMS case, enter/leavevt won't fix up the interrupt handler for us, so we need to do it at suspend/resume time. Make sure we don't fail the resume if the chip is hung either. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/

[PATCH] drm: disable encoders before re-routing them

2009-02-23 Thread Jesse Barnes
>From 00501470f64e9bff025e068101286bd101d8214a Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Mon, 23 Feb 2009 16:09:34 -0800 Subject: [PATCH] drm: disable encoders before re-routing them MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In some ca

Re: [PATCH] drm: don't decrement vblank wait refcount if we never took a ref

2009-02-23 Thread Jesse Barnes
Dave, please pick this one up (just grab it from the parent message). Thanks, Jesse On Thursday 19 February 2009 06:55:28 Chris Wilson wrote: > On Mon, 2009-02-16 at 10:55 -0800, Jesse Barnes wrote: > > On Sunday, February 15, 2009 4:02 pm Chris Wilson wrote: > > > On my i9

Re: [REGRESSION] i915 VT switch with AIGLX causes X lock up

2009-02-24 Thread Jesse Barnes
nel.org/show_bug.cgi?id=12264 but I > > can't reopen that bug and this bug might turn out to be different. Might > > also be related to > > http://marc.info/?l=linux-kernel&m=123499984611624&w=2 . > > Still here in 2.6.29-rc6. Can

Re: [PATCH] drm: edid revision 0 is valid

2009-02-24 Thread Jesse Barnes
Heh, yeah this makes the code correct *and* match the message. Thanks. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francis

Re: [Intel-gfx] [PATCH] i915: add page flipping ioctl

2009-02-25 Thread Jesse Barnes
; hurt their performance because struct_mutex is hold. Yeah, that's a good point. I'll see if we can drop it here and restart the execbuffer if that happens. Thanks for checking it out; new patch on its way soon. -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH] i915: add page flipping ioctl

2009-02-25 Thread Jesse Barnes
should be an offset into the object, in case you want to flip between addresses within a large object? -- Jesse Barnes, Intel Open Source Technology Center -- Open Source Business Conference (OSBC), March 24-25, 2009,

Page flipping update

2009-02-25 Thread Jesse Barnes
Here's the kernel, libdrm, mesa and xserver patches I"m working with atm. These ones are untested (need to update the xf86-video-intel bits first, which is why they're not included here), but I wanted people to take a look and make sure things are looking ok. -- Jesse Bar

[PATCH] i915: page flipping support

2009-02-25 Thread Jesse Barnes
This one still doesn't include a KMS version, but the rest of it should be nearly ready. I've taken Chris & Nanhai's feedback from the last round and incorporated it, so we'll no longer block with the struct_mutex held at execbuffer time if a flip is pending, and the ring command submission has be

[PATCH] libdrm: support page flipping on i915

2009-02-25 Thread Jesse Barnes
diff --git a/shared-core/i915_drm.h b/shared-core/i915_drm.h index 5456e91..a36bcf6 100644 --- a/shared-core/i915_drm.h +++ b/shared-core/i915_drm.h @@ -205,6 +205,7 @@ typedef struct drm_i915_sarea { #define DRM_I915_GEM_GET_TILING0x22 #define DRM_I915_GEM_GET_APERTURE 0x23 #define DRM_

[PATCH] mesa/intel: support for DRI2 swapbuffers

2009-02-25 Thread Jesse Barnes
The DRI2 protocol and support bits for Mesa are pretty straightfoward. But I still need to port this forward to the new flush hook code, since at swapbuffers we need to make sure everything is flushed. diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 2

[PATCH] xserver: support DRI2 swapbuffers

2009-02-25 Thread Jesse Barnes
Just realized I still need to check whether the driver supports swapbuffers, if not we should fall back to copyarea. Other than that it's pretty simple. diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 4e76c71..42a596e 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -131,10 +131,27 @@ __glXDRId

[PATCH] dri2proto: support buffer swaps

2009-02-25 Thread Jesse Barnes
Protocol documentation and support for the new buffer swap request. diff --git a/dri2proto.h b/dri2proto.h index dc3f2d1..6f5ddf0 100644 --- a/dri2proto.h +++ b/dri2proto.h @@ -35,7 +35,7 @@ #define DRI2_NAME "DRI2" #define DRI2_MAJOR 1 -#define DRI2_MI

Another page flipping update

2009-02-26 Thread Jesse Barnes
e the code in i830_dri.c better. -- Jesse Barnes, Intel Open Source Technology Center -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sou

[PATCH] i915: support page flipping

2009-02-26 Thread Jesse Barnes
. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 2d797ff..0d6a6d3 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -829,6 +829,175 @@ static int i915_set_status_page(struct drm_device *dev, void

[PATCH] mesa/intel: add DRI2 swapbuffers interface

2009-02-26 Thread Jesse Barnes
Add support to Mesa and the intel driver for the new DRI2 swapbuffers interface. Uses the new flush hook to make sure any outstanding rendering is complete before sending the swapbuffers request. Signed-off-by: Jesse Barnes diff --git a/include/GL/internal/dri_interface.h b/include/GL

[PATCH] xserver: support DRI2 swapbuffers

2009-02-26 Thread Jesse Barnes
Add support for the new DRI2 swapbuffers request by supporting the protocol and adding a new driver hook to perform the swap. If it fails we'll fall back to blitting. Signed-off-by: Jesse Barnes diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 4e76c71..b76a786 100644 --- a/glx/glxdri2.c

[PATCH] xf86-video-intel: support swapbuffers using page flipping

2009-02-26 Thread Jesse Barnes
Support the new swapbuffers request using the new page flipping ioctl if possible. This patch still needs some work; there's a bug in the no-flip case that causes us to lose track of pixmaps, and the pipe is still hardcoded to 1, but that should be easy to fix. The code is pretty ugly too; it see

Re: Another page flipping update

2009-02-26 Thread Jesse Barnes
will tear by default. Jesse On Thursday, February 26, 2009 1:30:43 pm Zhao, Chunfeng wrote: > Hi Jesse, > For the page flipping to work, is there any need to change the old > application to make it work? > > Thanks! > > Calvin > > -----Original Message- > F

Re: [Intel-gfx] [PATCH] i915: support page flipping

2009-02-26 Thread Jesse Barnes
On Thursday, February 26, 2009 1:56:52 pm Chris Wilson wrote: > On Thu, 2009-02-26 at 13:28 -0800, Jesse Barnes wrote: > > Add a new page flip ioctl to the i915 driver. The new ioctl takes the > > new drm_i915_gem_page_flip arg, which contains a buffer object target for > >

Re: [PATCH] xserver: support DRI2 swapbuffers

2009-02-26 Thread Jesse Barnes
Found a bug in the AIGLX code; can't free the new buffers since we need them. -- Jesse Barnes, Intel Open Source Technology Center diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 4e76c71..28bd3c4 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -131,10 +131,23 @@ __glXDRIdrawableCopySubB

Re: [PATCH] xf86-video-intel: support swapbuffers using page flipping

2009-02-26 Thread Jesse Barnes
On Thursday, February 26, 2009 1:36:26 pm Jesse Barnes wrote: > Support the new swapbuffers request using the new page flipping ioctl > if possible. > > This patch still needs some work; there's a bug in the no-flip case that > causes us to lose track of pixmaps, and the pipe i

Re: [PATCH] xserver: support DRI2 swapbuffers

2009-02-27 Thread Jesse Barnes
On Thursday, February 26, 2009 4:35:34 pm Jesse Barnes wrote: > Found a bug in the AIGLX code; can't free the new buffers since we need > them. And another bug in the indirect case: if swapbuffers fails we should fall back to a copyregion. This should fix the old compiz case. -- J

Re: [PATCH] mesa/intel: add DRI2 swapbuffers interface

2009-02-27 Thread Jesse Barnes
On Thursday, February 26, 2009 1:31:03 pm Jesse Barnes wrote: > Add support to Mesa and the intel driver for the new DRI2 swapbuffers > interface. Uses the new flush hook to make sure any outstanding rendering > is complete before sending the swapbuffers request. Need to update the FBco

Re: [PATCH] make KMS resource mappings exclusive

2009-03-12 Thread Jesse Barnes
On Monday, March 9, 2009 3:29:40 am Simon Farnsworth wrote: > Eric Anholt wrote: > > On Mon, 2009-01-19 at 13:00 -0800, Jesse Barnes wrote: > >> This should help avoid problems with unsupported userspace programs or > >> configurations running on top of a KMS e

Re: [Patch 1/5]: DRM/I915: Add the crt save/restore function for VT switch

2009-03-12 Thread Jesse Barnes
handle global GPU state (and possibly save/restore a GPU context), but beyond that we just set a mode, which should take care of the rest. That means we can get rid of all the output specific save/restore routines as a bonus. -- Jesse Barnes, Intel Open Source Technology Center --

Re: [Intel-gfx] [PATCH] i915: support page flipping

2009-03-13 Thread Jesse Barnes
On Friday, March 13, 2009 2:08:50 pm Chris Wilson wrote: > On Thu, 2009-02-26 at 14:35 -0800, Jesse Barnes wrote: > > On Thursday, February 26, 2009 1:56:52 pm Chris Wilson wrote: > > > On Thu, 2009-02-26 at 13:28 -0800, Jesse Barnes wrote: > > > > Add a new page

Re: [Intel-gfx] [PATCH] make KMS resource mappings exclusive

2009-03-16 Thread Jesse Barnes
On Thursday, March 12, 2009 10:42:22 am Jesse Barnes wrote: > On Monday, March 9, 2009 3:29:40 am Simon Farnsworth wrote: > > Eric Anholt wrote: > > > On Mon, 2009-01-19 at 13:00 -0800, Jesse Barnes wrote: > > >> This should help avoid problems with uns

Re: udpated KMS speed improvement patch

2009-03-19 Thread Jesse Barnes
m/drm_crtc_helper.c > @@ -29,6 +29,8 @@ > * Jesse Barnes > */ > > +#include > + > #include "drmP.h" > #include "drm_crtc.h" > #include "drm_crtc_helper.h" > @@ -137,6 +139,26 @@ int drm_helper_probe_connector_modes(struct &g

Re: [PATCH] KMS: register the LVDS before the CRT

2009-03-26 Thread Jesse Barnes
should decide that. > > Couldn't there be some sort of primary field on the dev struct that > get turned on? And that could be selected by a command line option > like "i915.primary=hdmi0" and the default being lvds, if it is > present. Giving

Re: [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path.

2009-03-26 Thread Jesse Barnes
less under pressure), then we'll be limited to 128k/8 page pointers on 64 bit, or 64M per pwrite... Is that ok? Or do we need to handle multiple passes here? Looks good othe

Re: [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free.

2009-03-26 Thread Jesse Barnes
also, did you measure it? Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- -- ___ Dri-devel mailing list Dri-devel@lists.sourcef

Re: [PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path.

2009-03-26 Thread Jesse Barnes
x27;s so similar but can't share more code... Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- -- ___ Dri-devel mailing list Dri-devel@li

Re: [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-26 Thread Jesse Barnes
On Wed, 25 Mar 2009 14:45:08 -0700 Eric Anholt wrote: > Signed-off-by: Eric Anholt Same comments as 3/6... Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Cen

Re: [PATCH 5/6] drm/i915: Fix lock order reversal with cliprects and cmdbuf in non-DRI2 paths.

2009-03-26 Thread Jesse Barnes
too much here as long as it's been tested. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- -- ___ Dri-devel mailing list Dri-dev

Re: [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path.

2009-03-27 Thread Jesse Barnes
On Fri, 27 Mar 2009 09:56:03 -0700 Eric Anholt wrote: > On Thu, 2009-03-26 at 17:43 -0700, Jesse Barnes wrote: > > On Wed, 25 Mar 2009 14:45:05 -0700 > > Eric Anholt wrote: > > > > > Since the pagefault path determines that the lock order we use > > >

[PATCH] libdrm: speed up connector & mode fetching

2009-03-27 Thread Jesse Barnes
t have to make the second call, which saves a lot of time. Any comments or problems with the patch? Thanks, -- Jesse Barnes, Intel Open Source Technology Center diff --git a/libdrm/xf86drmMode.c b/libdrm/xf86drmMode.c index 872604f..e2aba81 100644 --- a/libdrm/xf86drmMode.c +++ b/libdrm/xf86drmMod

[PATCH] drm: remove unused "can_grow" parameter from drm_crtc_helper_initial_config

2009-03-27 Thread Jesse Barnes
Cleanup some leftovers from the X port. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc_helper.c |3 +-- include/drm/drm_crtc_helper.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm

Re: [PATCH] libdrm: speed up connector & mode fetching

2009-03-27 Thread Jesse Barnes
On Fri, 27 Mar 2009 22:53:00 +0100 Jakob Bornecrantz wrote: > On Fri, Mar 27, 2009 at 8:58 PM, Jesse Barnes > wrote: > > This patch speeds up drmModeGetConnector by pre-allocating mode & > > property info space before calling into the kernel.  In many cases > >

Re: [PATCH] KMS: Do the actual mode setting from asynchronous context

2009-03-27 Thread Jesse Barnes
ardware > probing and poking happens. I'm curious if the patch I recently posted to add the idea of a primary head to the driver have a similar effect? It avoids probing secondary connectors if the primary one is found, so it should provide the same speedup as this one. --

Re: [PATCH] KMS: clean up udelay usage

2009-03-27 Thread Jesse Barnes
{ > /* Wait for 20ms, i.e. one cycle at 50hz. */ > - udelay(2); > + mdelay(20); > } > > static int Yeah, looks fine. Hopefully Eric can pick it u

Re: [PATCH] KMS: do a faster EDID

2009-03-27 Thread Jesse Barnes
t, then fall back to robust ones if that fails) and get a double benefit. Have you looked at that at all? Either way, this one looks ok, so I'm ok with it as long as Dave is. Acked-by: Jesse

Re: [PATCH] KMS: cache the EDID information of the LVDS

2009-03-27 Thread Jesse Barnes
it to the intel_output struct I'd rather see it stored with the rest of the LVDS stuff in i915_private (though that stuff should be pulled out into an output private at some point). We could also just open code the intel_ddc_get_modes stuff in intel_lvds_init, getting the EDID just once, storin

Re: [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path.

2009-03-27 Thread Jesse Barnes
On Sat, 28 Mar 2009 01:54:32 +0100 Peter Zijlstra wrote: > On Thu, 2009-03-26 at 17:43 -0700, Jesse Barnes wrote: > > On Wed, 25 Mar 2009 14:45:05 -0700 > > Eric Anholt wrote: > > > > > Since the pagefault path determines that the lock order we use > > >

Re: enabling kms for i915 disables brightness control and xrandr

2009-03-30 Thread Jesse Barnes
On Mon, 30 Mar 2009 15:37:19 +0200 Soeren Sonnenburg wrote: > On Sun, 2009-03-29 at 15:22 +0200, Soeren Sonnenburg wrote: > > On Sun, 2009-03-29 at 14:07 +0100, Sitsofe Wheeler wrote: > > > (CC'ing dri-devel, Eric Anholt and Jesse Barnes) > > > > > >

Re: enabling kms for i915 disables brightness control and xrandr

2009-03-30 Thread Jesse Barnes
On Tue, 31 Mar 2009 00:57:50 +0200 Soeren Sonnenburg wrote: > On Mon, 2009-03-30 at 14:34 -0700, Jesse Barnes wrote: > > On Mon, 30 Mar 2009 15:37:19 +0200 > > Soeren Sonnenburg wrote: > > > > > On Sun, 2009-03-29 at 15:22 +0200, Soeren Sonnenburg wrote: >

Re: [PATCH] libdrm: speed up connector & mode fetching

2009-03-31 Thread Jesse Barnes
On Tue, 31 Mar 2009 12:39:17 -0700 Eric Anholt wrote: > On Fri, 2009-03-27 at 15:48 -0700, Jesse Barnes wrote: > > On Fri, 27 Mar 2009 22:53:00 +0100 > > Jakob Bornecrantz wrote: > > > > > On Fri, Mar 27, 2009 at 8:58 PM, Jesse Barnes > > &g

Re: [Patch 3/3_v2]: [DRM/I915] : Sync the default modes for LVDS output device

2009-04-01 Thread Jesse Barnes
t any mode to be sent down at mode set time, but that would probably mean changes to the way we handle modes in the DRM core. Alternately, we could export the flag and let use

[PATCH] drm: fix EDID compatibility check

2009-04-02 Thread Jesse Barnes
>From 3e4b036692ea35cef3356db4ee6b7349a92abf28 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Thu, 2 Apr 2009 14:56:24 -0700 Subject: [PATCH] drm: fix EDID backward compat check EDIDs should be backward compatible, so don't bail if we see a version of 3 (which is out there now) and

[PATCH] drm: remove unused "can_grow" parameter from drm_crtc_helper_initial_config

2009-04-02 Thread Jesse Barnes
Cleanup some leftovers from the X port. Dave you may want to just let Eric take this since the next patch depends on this one. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc_helper.c |3 +-- include/drm/drm_crtc_helper.h |2 +- 2 files changed, 2 insertions(+), 3

Re: [PATCH] drm: remove unused "can_grow" parameter from drm_crtc_helper_initial_config

2009-04-02 Thread Jesse Barnes
ds a > change in the i915 driver include it in this patch and I'll take care > of it. if I apply this now i915 won't build unless I fix it up. Oh duh I didn't mean to break bisect... This one could be rolled into the i915 patch or I could respin both. Any preference? -- Je

Re: [PATCH] drm: remove unused "can_grow" parameter from drm_crtc_helper_initial_config

2009-04-02 Thread Jesse Barnes
ds a > change in the i915 driver include it in this patch and I'll take care > of it. if I apply this now i915 won't build unless I fix it up. Here's a fixed version. >From 886474be2ef11a5b522df4c0bbb06551a04ee8c4 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Fri, 27 Ma

Re: [RFC] [intel-gfx] :The backlight issue when KMS is used

2009-04-03 Thread Jesse Barnes
On Fri, 3 Apr 2009 17:29:06 +0100 Matthew Garrett wrote: > On Fri, Apr 03, 2009 at 09:24:08AM -0700, Jesse Barnes wrote: > > I'd rather not have a native kernel backlight property (i.e. a > > property on the LVDS output) exposed at all. I chatted with > > Matthew

Re: workaround for bogus EDID data

2009-04-03 Thread Jesse Barnes
hat Linus fixed. Yes we should make a common routine, and just make the various mode_fixup hooks call it. -- Jesse Barnes, Intel Open Source Technology Center -- -- ___ Dri-devel

Re: [RFC] [intel-gfx] :The backlight issue when KMS is used

2009-04-03 Thread Jesse Barnes
t have to hack the backlight class code a little to prevent multiple registrations for the same device, but that shouldn't be too hard. Then whichever driver loads first (i915 or acpi video) would create a backlight interface if it could, and the userspace driver could use it; no need for new pr

Re: [PATCH] drm/i915: Allow tiling of objects with bit 17 swizzling by the CPU.

2009-04-03 Thread Jesse Barnes
ad of a byte. > If you choose to go that route there are a bunch of bitmap handling routines in . -- Jesse Barnes, Intel Open Source Technology Center -- -- ___ Dri-d

Re: [PATCH] i915: indicate framebuffer restore key in SysRq help message

2009-04-06 Thread Jesse Barnes
= "Restore framebuffer console", > }; > > int intelfb_probe(struct drm_device *dev) Looks good to me. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- -- __

Re: [PATCH] drm: ignore LVDS on intel graphics systems that lie about having it

2009-04-06 Thread Jesse Barnes
nting for VBIOS versioning and structure size changes) we shouldn't need this patch. If we can't get that done in time for 2.6.30 though I'm all for including this. Zhenyu

Re: [PATCH] drm: ignore LVDS on intel graphics systems that lie about having it

2009-04-06 Thread Jesse Barnes
On Mon, 6 Apr 2009 13:29:53 -0400 Jarod Wilson wrote: > On Monday 06 April 2009 12:52:16 Jesse Barnes wrote: > > On Mon, 6 Apr 2009 10:11:25 -0400 > > Jarod Wilson wrote: > > > > > There are a number of small form factor desktop systems with Intel > > >

[PATCH] drm: get connector status fix

2009-04-07 Thread Jesse Barnes
drm_mode_getconnector currently has full probe semantics, make it return a current status at all times so that config changes are properly picked up. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 94a7688..403e00d 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b

Re: [RFC] [intel-gfx] :The backlight issue when KMS is used

2009-04-07 Thread Jesse Barnes
this, as does displayport I think). But we'd definitely want to preserve the current ACPI interaction, so we'd have to make the i915 and other DRM drivers clients of the ACPI or platform backlight drivers (at least interna

[ANNOUNCE] libdrm 2.4.9

2009-04-10 Thread Jesse Barnes
nks, Jesse Jesse Barnes (3): Revert "libdrm: speed up connector & mode fetching" Bump version to 2.4.8 Bump version to 2.4.9 git tag: libdrm-2.4.9 http://dri.freedesktop.org/libdrm/libdrm-2.4.9.tar.bz2 MD5: a7eacf9d4532391c7a53709da8f34495 l

Re: [Intel-gfx] [PATCH] mesa/intel: add DRI2 swapbuffers interface

2009-04-13 Thread Jesse Barnes
On Fri, 27 Feb 2009 15:34:26 -0500 Kristian Høgsberg wrote: > On Fri, Feb 27, 2009 at 2:22 PM, Jesse Barnes > wrote: > > On Thursday, February 26, 2009 1:31:03 pm Jesse Barnes wrote: > >> Add support to Mesa and the intel driver for the new DRI2 > >> swapbuffers

Re: Broken vblanks on Intel

2009-04-14 Thread Jesse Barnes
d this stuff we were assuming that interrupts & vblanks would be enabled at load time and stay on forever. But now we have vblank init at load time, but interrupts going on & off at VT switch and startup time... it really messes up the logic. -- Jesse Barnes, Intel Open Source Technology

[RFC] DRI2 swapbuffers

2009-04-14 Thread Jesse Barnes
completion list, should be easy to fix though That's all I'm aware of however. It works really nicely in the simple case now, and I've changed the ioctl to be KMS-only. It now just takes a CRTC id and an FB id, and does all the lookup & pin handling in the kernel. -- Jesse Ba

[PATCH] dri2proto: add swapbuffers

2009-04-14 Thread Jesse Barnes
This part is pretty simple. I think I've left it flexible enough to accommodate triple buffering (or n-buffering) but would appreciate feedback there. diff --git a/dri2proto.h b/dri2proto.h index dc3f2d1..6f5ddf0 100644 --- a/dri2proto.h +++ b/dri2proto.h @@ -35,7 +35,7 @@ #define DRI2_NAME

[PATCH] libdrm/intel: add page flip ioctl support

2009-04-14 Thread Jesse Barnes
Eric suggested moving the ioctl handling into libdrm, which makes sense. The API prototype could probably be more consistent with the xf86drmMode stuff, I'm happy to hear suggestions on that. diff --git a/libdrm/intel/intel_bufmgr.c b/libdrm/intel/intel_bufmgr.c index 25a6828..3b99b45 100644 ---

[PATCH] i915: add page flipping support

2009-04-14 Thread Jesse Barnes
Add a new page flipping ioctl to the i915 driver, using KMS functionality. Internally, the new flip ioctl will use the mode_set_base function, which will simply update the front buffer pointer, taking care to pin the new buffer and unpin the old one. This means userspace needs to create an FB id

[PATCH] mesa: add DRI2 swap buffers support

2009-04-14 Thread Jesse Barnes
Add support to Mesa for handling the new DRI2 swapbuffers request, along with support in the Intel drivers for the new setBuffers callback, which is responsible for updating the renderbuffers appropriately following a swapbuffers call. diff --git a/include/GL/internal/dri_interface.h b/include/GL

[PATCH] xserver: add DRI2 swapbuffers support

2009-04-14 Thread Jesse Barnes
Add support to the X server for the new DRI2 swapbuffers request. This requires a new driver callback, SwapBuffers, which takes care of performing the swap and allocating new buffers if necessary. diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 4544a2c..af6755b 100644 --- a/glx/glxdri2.c +++ b/g

Re: [PATCH] i915: add page flipping support

2009-04-14 Thread Jesse Barnes
Arg, and w/o word wrapping this time. diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index c23b3a9..5273ce0 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -871,6 +871,127 @@ static int i915_set_status_page(struct drm_device *de

Re: [Bug 13103] New: i915 closing laptop lid kills LVDS until reboot

2009-04-16 Thread Jesse Barnes
ore and after the lid close should help narrow this down quickly, so please include those too. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Stay on top of everything new and different, both inside and arou

Re: [Intel-gfx] Screen Corruption On Intel GM45

2009-04-16 Thread Jesse Barnes
ig the 2D driver will try to use a tiled buffer but the kernel won't set it up properly and you'll just get corruption. -- Jesse Barnes, Intel Open Source Technology Center -- Stay on top of everything new

Re: [Intel-gfx] [PATCH] i915: add page flipping support

2009-04-21 Thread Jesse Barnes
On Tue, 21 Apr 2009 19:48:39 -0700 Eric Anholt wrote: > On Tue, 2009-04-14 at 15:22 -0700, Jesse Barnes wrote: > > Add a new page flipping ioctl to the i915 driver, using KMS > > functionality. > > > > Internally, the new flip ioctl will use the mode_set_base func

Re: [PATCH] drm/i915: increase i2c timeout to 2 jiffies.

2009-04-22 Thread Jesse Barnes
&chan->adapter, chan); Ah yeah, that probably explains some misdetection I've seen too, looks good. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- Stay on top of everything n

Re: [Bug #12765] i915 VT switch with AIGLX causes X lock up

2009-04-27 Thread Jesse Barnes
eople (at least not that I've heard); I certainly have a hard time reproducing it. -- Jesse Barnes, Intel Open Source Technology Center diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 69aa0ab..c41cba4 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_ir

Re: [Intel-gfx] [RFC] DRI2 swapbuffers (yes yet again)

2009-04-29 Thread Jesse Barnes
On Wed, 29 Apr 2009 15:09:33 -0700 Jesse Barnes wrote: > I'm still working through mutlihead issues on the kernel side; the > flip waits should wait for *both* vblank events before completing the > flip. But other than that, I'm pretty happy with things. This increment

Re: [Intel-gfx] [RFC] DRI2 swapbuffers (yes yet again)

2009-04-30 Thread Jesse Barnes
On Thu, 30 Apr 2009 08:08:36 +0200 Michel Dänzer wrote: > On Wed, 2009-04-29 at 18:02 -0700, Jesse Barnes wrote: > > On Wed, 29 Apr 2009 15:09:33 -0700 > > Jesse Barnes wrote: > > > I'm still working through mutlihead issues on the kernel side; the > > > fl

Re: [Intel-gfx] [RFC] DRI2 swapbuffers (yes yet again)

2009-04-30 Thread Jesse Barnes
On Thu, 30 Apr 2009 11:36:55 +0300 Ville Syrjälä wrote: > On Wed, Apr 29, 2009 at 06:02:59PM -0700, Jesse Barnes wrote: > > On Wed, 29 Apr 2009 15:09:33 -0700 > > Jesse Barnes wrote: > > > I'm still working through mutlihead issues on the kernel side; the > >

Re: [Intel-gfx] [RFC] DRI2 swapbuffers (yes yet again)

2009-04-30 Thread Jesse Barnes
On Thu, 30 Apr 2009 17:48:08 +0200 Michel Dänzer wrote: > On Thu, 2009-04-30 at 08:39 -0700, Jesse Barnes wrote: > > On Thu, 30 Apr 2009 08:08:36 +0200 > > Michel Dänzer wrote: > > > > > On Wed, 2009-04-29 at 18:02 -0700, Jesse Barnes wrote: > > &g

Re: [PATCH] drm/i915: save/restore fence registers across suspend/resume

2009-04-30 Thread Jesse Barnes
simplest way to fix the issue, so Acked-by: Jesse Barnes Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Register Now & Save for Velocity, the Web Performance & Operations Conference from O'

Re: [Intel-gfx] [RFC] DRI2 swapbuffers (yes yet again)

2009-04-30 Thread Jesse Barnes
If you > combine that with supporting interval (should be useful when queueuing > up several frames using 3:2 pulldown sequence) then there seems to be > a need for something more than just a single number. Ok. I'd better add wha

Re: [PATCH] KMS: cache the EDID information of the LVDS

2009-04-30 Thread Jesse Barnes
On Wed, 01 Apr 2009 12:29:04 -0700 Eric Anholt wrote: > On Fri, 2009-03-27 at 22:01 -0700, Arjan van de Ven wrote: > > On Fri, 27 Mar 2009 16:08:18 -0700 > > Jesse Barnes wrote: > > > > > > > > return ret; > > > > > > I defi

  1   2   3   4   5   6   7   8   >