This patch introduces a bug.
On Sat, Mar 01, 2014 at 06:59:20PM -0800, Surendra Patil wrote:
Replaced all the spin lock/unlock wrappers from oz_polling_lock_bh()
and oz_polllin_unlock_bh() with spin_lock_bh(g_polling_lock) and
spin_unlock_bh(g_polling_lock).Completely erased the wrappers
Patch introduces bugs. Please redo and be more careful next time.
On Sat, Mar 01, 2014 at 10:22:47PM -0700, Axel Rasmussen wrote:
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
@@ -935,7 +946,8 @@ static short alloc_rx_desc_ring(struct net_device *dev,
u16 bufsize, int count)
On Sat, Mar 01, 2014 at 10:22:53PM -0700, Axel Rasmussen wrote:
The function rtl8180_wmm_param_update contained two blocks of code which
were nearly identical. This patch combines those two blocks into a
single function, to reduce code duplication, and do fix some
checkpatch.pl warnings about
On Sun, Mar 02, 2014 at 08:52:19PM -0600, Chase Southwood wrote:
This patch introduces a few simple outl and inl helper functions to allow
several lines which violate the character limit to be shortened
appropriately. It also changes a few macro values which represented
offset values from a
On Sun, Mar 02, 2014 at 08:52:33PM -0600, Chase Southwood wrote:
Use the newly created helper functions to improve code readability and shorten
several lines to under the character limit.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
On 03/01/2014 04:57 AM, Mark Hounschell wrote:
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
---
On 2014-03-01 05:48, Chase Southwood wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-28 07:35, Chase Southwood wrote:
And finally, are timeouts here even necessary or helpful, or are there
any better ways to do it?
In the case of s626_send_dac(),
On Mon, Mar 03, 2014 at 08:30:28AM -0500, Mark Hounschell wrote:
On 03/01/2014 04:57 AM, Mark Hounschell wrote:
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes externs should be avoided in .c files
in dgap.c as reported
On 2014-03-02 04:13, Chase Southwood wrote:
On Friday, February 28, 2014 11:49 PM, Chase Southwood
chase.southw...@yahoo.com wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-28 07:35, Chase Southwood wrote:
[snip]
In the case of
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff
On Sat, Mar 1, 2014 at 5:37 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Mar 01, 2014 at 03:37:17PM +0530, Monam Agarwal wrote:
Hello all,
I have a confusion regarding functions in aes_ccmp.c. It seems none of
these functions are currently being used. So Is fine if we can remove
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate
On Mon, Mar 03, 2014 at 10:07:02AM -0500, Mark Hounschell wrote:
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi
On 2014-02-28 23:24, H Hartley Sweeten wrote:
The interrupt is only generated by the hardware at the completion of
an A/D conversion. Because of this the sanity check to make sure that
the A/D conversion is complete and data is available is probably
unnecessary but it doesn't hurt anything.
The
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git
On 03/03/2014 10:11 AM, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2
On 2014-02-28 23:24, H Hartley Sweeten wrote:
The interrupt is only generated by the hardware at the completion of
an A/D conversion. Because of this the sanity check to make sure that
the A/D conversion is complete and data is available is probably
unnecessary but it doesn't hurt anything.
The
On 2014-02-28 23:24, H Hartley Sweeten wrote:
The A/D FIFO uses two registers to get each analog data sample.
PCL818_FI_DATALO is the LSB of the data and PCL818_FI_DATAHI is
the MSB of the data. The current define for PCL818_FI_DATAHI is
incorrect and results in the LSB getting read twice.
On 2014-03-03 16:00, Ian Abbott wrote:
On 2014-02-28 23:24, H Hartley Sweeten wrote:
The A/D FIFO uses two registers to get each analog data sample.
PCL818_FI_DATALO is the LSB of the data and PCL818_FI_DATAHI is
the MSB of the data. The current define for PCL818_FI_DATAHI is
incorrect and
On 2014-02-28 23:24, H Hartley Sweeten wrote:
To clarify the code, introduce a helper function to read the analog
input data sample from the FIFO and optionally return the channel
that the sample was for. The channel is used to check for dropped
samples.
Signed-off-by: H Hartley Sweeten
Use PCI_VENDOR_ID_INTEL instead of creating its own vendor ID #define.
Signed-off-by: Jon Mason jdma...@kudzu.us
Cc: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/staging/media/dt3155v4l/dt3155v4l.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
This series includes a base set of drivers for the Unisys s-Par system.
This set of drivers is enough to get a virtual guest up and running on s-Par
hardware. The remaining drivers needed to have a fully functional system
will be submitted after review of this initial set.
s-Par is firmware
The visorchannelstub module provides support routines for storing and
retrieving data from a channel.
Signed-off-by: Ken Cox j...@redhat.com
Cc: Ben Romer sparmaintai...@unisys.com
Index: upstream-staging/drivers/staging/unisys/Kconfig
Documentation for the set of s-Par drivers
Signed-off-by: Ken Cox j...@redhat.com
Cc: Ben Romer sparmaintai...@unisys.com
Index: linux-2.6.staging/drivers/staging/unisys/Documentation/proc-entries.txt
===
--- /dev/null
+++
On 2014-02-28 23:23, H Hartley Sweeten wrote:
This series continues the cleanup of the pcl812/816/818 drivers.
H Hartley Sweeten (66):
I've looked through them all now. I have noted likely problems with
patches 13 and 19, although the code in patch 13 doesn't seem to be
reachable.
--
-=(
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Remove check for kfree of brd-channels as kfree is safe.
Also there is no need to set it to NULL after freeing it.
Remove a useless cast for a kzalloc return value.
Remove double negative test in a white space fix line.
On Mon, Mar 03, 2014 at 11:01:14AM -0600, Ken Cox wrote:
This series includes a base set of drivers for the Unisys s-Par system.
This set of drivers is enough to get a virtual guest up and running on s-Par
hardware. The remaining drivers needed to have a fully functional system
will be
On Mon, Mar 03, 2014 at 11:30:19AM -0600, Ken Cox wrote:
+/* periodic_work.h
+ *
+ * Copyright © 2010 - 2013 UNISYS CORPORATION
+ * All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as
On Saturday, March 01, 2014 3:28 AM, Chase Southwood wrote:
Subject: [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_*
helper functions in hwdrv_apci1564.c
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
What software do we need to test this? Is there a quick start guide?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 03/03/2014 01:12 PM, Greg KH wrote:
On Mon, Mar 03, 2014 at 11:01:14AM -0600, Ken Cox wrote:
This series includes a base set of drivers for the Unisys s-Par system.
This set of drivers is enough to get a virtual guest up and running on s-Par
hardware. The remaining drivers needed to have a
On 03/03/2014 01:22 PM, Dan Carpenter wrote:
What software do we need to test this? Is there a quick start guide?
Unisys hardware/firmware is required.
___
devel mailing list
de...@linuxdriverproject.org
On Mon, Mar 03, 2014 at 01:24:05PM -0600, Ken Cox wrote:
On 03/03/2014 01:12 PM, Greg KH wrote:
Why do you want these in the drivers/staging/ part of the kernel? I
have my guesses, but you need to tell me why :)
Frankly, I wasn't sure of the most appropriate place since this is a
Hi Greg,
The copyright text is old boilerplate that we'd been carrying. We'll
change it so that it's correctly GPL 2 only, and we'll fix all of the
EXPORT_SYMBOL()s also.
The majority of our proc entries are switches for debugging or purely
informational, so these could be moved to /sys with
On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote:
On 2014-02-28 23:23, H Hartley Sweeten wrote:
This series continues the cleanup of the pcl812/816/818 drivers.
H Hartley Sweeten (66):
I've looked through them all now. I have noted likely problems with
patches 13 and 19, although the
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 100 +++-
1
This patch series fixes some discrepancies noted in a
previous patch series.
Removes the rest of the debug/tracing code
Removes a nasty macro
Add curly braces back in for a multi-line indent block
Fixes some pr_warns with newline chars in the strings
Yes, these pr_warns will eventually
This patch fixes some pr_warns that have newline
chars in the string because they mess up the
output.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 14 +-
1 file changed, 9 insertions(+), 5
This patch removes more, if not all, of the debug/tracing code
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 27 ---
drivers/staging/dgap/dgap.h | 5 -
2 files changed, 32
Multi-line indent blocks get curly braces for readability.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c
On Mon, Mar 03, 2014 at 04:36:23PM -0500, Mark Hounschell wrote:
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
On 03/03/2014 04:50 PM, Dan Carpenter wrote:
On Mon, Mar 03, 2014 at 04:36:23PM -0500, Mark Hounschell wrote:
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
On Mon, Mar 03, 2014 at 02:05:07PM -0600, Romer, Benjamin M wrote:
Hi Greg,
The copyright text is old boilerplate that we'd been carrying.
Be careful about old boilerplate, that can get you in trouble :)
We'll
change it so that it's correctly GPL 2 only, and we'll fix all of the
It moves the state setting for query into rndis_filter_receive_response().
All callbacks including query-complete and status-callback are synchronized
by channel-inbound_lock. This prevents pentential race between them.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. Adding an usbip uapi header file will
define the kernel - userspace interface for this device status. This
new uapi file is added under usbip/uapi to keep the staging tree code
self-contained.
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. Adding an usbip uapi header file will
define the kernel - userspace interface for this device status. This
new uapi file is added under usbip/uapi to keep the staging tree code
self-contained.
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. A new uapi usbip.h now defines the
usbip device status for kernel and userspace to use. Change usbip
kernel space to include uapi usbip.h for usbip device status.
Signed-off-by: Shuah Khan
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. A new uapi usbip.h now defines the
usbip device status for kernel and userspace to use. Change usbip
userspace to include uapi usbip.h for usbip device status.
Signed-off-by: Shuah Khan
The comedi core expects the (*insn_write) functions to write insn-n
values. Fix this function to work like the core expects.
The counters are actually 25-bit (24-bits + 1 sign bit). The comedi core
validates that all the data is in range before calling the (*insn_write),
fix the subdevice maxdata
For aesthetics, rename this function so ist has namespace associated
with the driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ke_counter.c | 6 +++---
1
This series is a full cleanup of the comedi ke_counter driver. It
also adds support for the 3 digital output pins on the board.
H Hartley Sweeten (9):
staging: comedi: ke_counter: remove CNT_CARD_DEVICE_ID
staging: comedi: ke_counter: define the register map
staging: comedi: ke_counter:
The comedi core expects the (*insn_read) functions to read insn-n
values. Fix this function to work like the core expects.
The counters are actually 25-bit (24-bits + 1 sign bit). Instead of munging
the data when the sign bit is set just return the full 25-bit value.
Signed-off-by: H Hartley
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ke_counter.c | 54 ++---
1 file
Define the register map for the board and remove the magic values.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ke_counter.c | 43 +++--
This define is only used in the pci_device_id table and does not add
any significant clarity to the code. Remove the define and just open
code the value.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
For aesthetics, add some whitespace to the subdevice init.
This driver does not support async commands so remove the dev-read_subdev
initialization.
Remove the commented out SDF_COMMON from the subdevice subev_flags.
Add the subdevice range_table initialization.
For aesthetics, rename the
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
I think line
clean up checkpatch.pl warnings in linux.c:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 524
1 files changed, 262 insertions(+), 262
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 1478
1 files changed, 743 insertions(+), 735 deletions(-)
diff --git
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 48 +--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index
On 03/04/2014 07:54 AM, Haiyang Zhang wrote:
It moves the state setting for query into rndis_filter_receive_response().
All callbacks including query-complete and status-callback are synchronized
by channel-inbound_lock. This prevents pentential race between them.
This still looks racy to me.
On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Please run your patches through checkpatch.
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
@@ -431,13 +432,15 @@ create_chan(struct
On Monday, March 3, 2014 8:13 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-02 04:13, Chase Southwood wrote:
On Friday, February 28, 2014 11:49 PM, Chase Southwood
chase.southw...@yahoo.com wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk
wrote:
On 2014-02-28
Thanks for review.
How about fix it as your comment within another patch?
I sent many smaller patches for fixing coding style and other things.
And I think this patch has just fixed about long line length, so I
want to let it leave this change and
I will send a patch after fixing as your
This patch applies following code style changes to the whole driver.
- Removing braces from single statements following a 'if' statement.
- Removing unnessasary spaces and braces from files.
- Re-order statements crossing 80 columns limitation.
- Fixed one quoted string split across lines.
DaeSeok Youn daeseok.y...@gmail.com writes:
- * match with board's first found interface, otherwise this
is first
- * found
+ * match with board's first found interface, otherwise this is
+ * fisrt found
^
I wonder
This set of patches fixes a substantial number of checkpatch.pl errors and
warnings, and additionally it refactors some sections of code where lines were
far too long due to organizational problems.
This second version of the patch set addresses some embarrassingly obvious
issues in the
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 132 +
1 file changed, 69 insertions(+), 63
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
The function rtl8180_wmm_param_update contained two blocks of code which
were nearly identical. This patch combines those two blocks into a
single function, to reduce code duplication, and do fix some
checkpatch.pl warnings about excessively long lines due to the large
number of indents that were
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 49
* Replaced all the spin lock/unlock wrappers from oz_polling_lock_bh()
and oz_polllin_unlock_bh() with spin_lock_bh(g_polling_lock) and
spin_unlock_bh(g_polling_lock).Completely erased the wrappers defination
and declaration.
* declared g_polling_lock as global variable in header file and added
81 matches
Mail list logo
