On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote:
>
> This patch fixes the following checkpatch.pl issues caused by the new
> function: ether_addr_copy
>
> Signed-off-by: Joel Pelaez Jorge
> ---
> drivers/staging/slicoss/slicoss.c | 20 ++--
> 1 file changed, 10 i
This patch fixes the following checkpatch.pl issues caused by the new
function: ether_addr_copy
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/slicoss/slicoss.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
On Tue, 2014-03-18 at 12:38 +0900, Jingoo Han wrote:
> In addition to this, there are the same cases like this,
> in this file as below. Please search other same cases.
> For instance, 'grep' will be a good way to find it.
[]
> static void slic_adapter_set_hwaddr(struct adapter *adapter)
> {
>
On Tuesday, March 18, 2014 12:18 PM, Joel Pelaez Jorge wrote:
>
> This patch fixes the following checkpatch.pl issues caused by the new
> function: ether_addr_copy
>
> Signed-off-by: Joel Pelaez Jorge
> ---
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
>
the same for function dgap_do_bios_load
patch generated against: next-20140317
Signed-off-by: Masood Mehmood
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index bfafe7e..b
This patch fixes the following checkpatch.pl issues caused by the new
function: ether_addr_copy
Signed-off-by: Joel Pelaez Jorge
---
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 12aafe3..4ff39aa 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/d
From: Micky Ching
Using non-DMA dump-regs, which would be more exactly for DMA transfer failed.
More careful handle when cmd/data timeout, add stop(CMD12) cmd before go to
finish request when multi-rw timeout.
Remove some static checher warings.
on commit:
drivers/mmc/host/rtsx_pci_sdmmc.c:194
From: Micky Ching
Add new command type(R1 without CRC) handle, without this patch mmc card
initialize will be failed.
Using a more careful handle in request timeout, and debug info is printed
using non DMA mode. Smatch warning was removed.
Micky Ching (2):
mmc: rtsx: add R1-no-CRC mmc command
From: Micky Ching
commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a
produced a cmd.flags unhandled in realtek pci host driver.
This will make MMC card failed initialize, this patch is
used to handle the new cmd.flags condition and MMC card can be used.
Signed-off-by: Micky Ching
---
drivers/mmc
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
v2: fix a typo in subject
this patch is rebased in
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
> vmalloc/kmalloc directly.
Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being
used, but cc: the driver maintainers just to be sure.
> (UISMALLOC
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc directly.
(UISMALLOC() macro is also removed.)
And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which
is just tracing buffer status(Malloc_FailuresAlloc, Malloc_BytesInUse
...) for info_proc_read_
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but ar
pcmd->parmbuf->pbuf has been allocated if command is
GEN_CMD_CODE(_Set_Drv_Extra),
and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by
rtw_dequeue_cmd.
The memory leak happened on this branch "if( _FAIL == rtw_cmd_filter(pcmdpriv,
pcmd) )"
which goto post_process directly against
Hi all,
Given that 3.14 will be out in a few days, it's time to close my trees
for new patches until 3.15-rc1 is out.
Please feel free to send me patches for these trees, but note that I'll
be ignoring them until 3.15-rc1 is out, at which point in time I'll
start reviewing them again and applying
On Mon, 17 Mar 2014, Greg KH wrote:
On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote:
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppress
Ok. I will rebase this patch in staging-next branch and send it again.
Thanks.
Daeseok Youn.
2014-03-18 6:23 GMT+09:00 Greg KH :
> On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote:
>>
>> The mkret() change a value of error from positive to
>> negative. This patch is modified to return
On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote:
> Firstly, some background is needed to confirm the validity of
> this patch as error fixing. It seems the developer when writing
> this driver from scratch, used what are known to me as error
> suppressors in the form of extra tmp brac
On Mon, Mar 17, 2014 at 10:12:01PM +, Hartley Sweeten wrote:
> On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> > On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
> >> From: H Hartley Sweeten
> >>
> >> The DAC02 board, which is the only board supported by this driver, now
On Monday, March 17, 2014 2:14 PM, Greg KH wrote:
> On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
>> From: H Hartley Sweeten
>>
>> The DAC02 board, which is the only board supported by this driver, now
>> has its own comedi driver (dac02).
>>
>> Remove this obsolete driver.
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but a
On Mon, 17 Mar 2014, Greg KH wrote:
On Thu, Mar 13, 2014 at 08:58:09PM -0400, Gary Rookard wrote:
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
should be immediately below its function warning fix.
Signed-off-by: Gary Alan Rookard
---
Correct patch, first two breaks buil
On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote:
> These are the minimum changes required to get the code to build
> statically in the kernel. It's necessary to do this first so that we
> can empirically determine that future cleanup patches aren't changing
> the generated object code
Clean up multiple sparse warnings mostly due to different address spaces
when accessing I/O memory.
Also, remove SignalRemoveAll(), SignalQueueHasOneElement(),
SignalQueueIsFull(), because they were never called.
Signed-off-by: Ken Cox
diff --git a/drivers/staging/unisys/include/commontype
On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote:
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/unisys/uislib/uislib.c |5 +
> drivers/staging/unisys/uislib/uisutils.c |2 +-
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/
On Mon, Mar 10, 2014 at 11:37:44AM -0400, Wang, Xiaoming wrote:
> pcmd->parmbuf->pbuf has been allocated if command is
> GEN_CMD_CODE(_Set_Drv_Extra),
> and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by
> rtw_dequeue_cmd.
> The memory leak happened on this branch "if( _FAIL ==
>
On Wed, Mar 12, 2014 at 08:55:44PM -0700, Masood Mehmood wrote:
> sparse reported dgap_do_fep_load is redeclared with different type. while
> fixing, I noticed __user attribute is used incorrectly in declaration.
> There is no need to define __user for firware->data.
>
> Replaced the __user with '
On Wed, Mar 12, 2014 at 12:50:56PM -0400, Mark Hounschell wrote:
> This patch adds a pr_info per board that indicates
> board number, type, etc..
>
> Signed-off-by: Mark Hounschell
> ---
> drivers/staging/dgap/dgap.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/d
On Sun, Mar 09, 2014 at 12:57:35AM -0800, Masood Mehmood wrote:
> sparse reported dgap_do_fep_load is redeclared with different type. while
> fixing, I noticed __user attribute is used incorrectly in declaration.
> There is no need to define __user for firware->data.
>
> Replaced the __user with '
On Thu, Mar 13, 2014 at 08:58:09PM -0400, Gary Rookard wrote:
> I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
> should be immediately below its function warning fix.
>
> Signed-off-by: Gary Alan Rookard
>
> ---
> Correct patch, first two breaks build.
Patch 3/3? Where are th
On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote:
>
> The mkret() change a value of error from positive to
> negative. This patch is modified to return negative value
> when it failed. It doesn't need to call with function
> for changing from positive to negative.
>
> Signed-off-by: D
On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote:
> From: H Hartley Sweeten
>
> The DAC02 board, which is the only board supported by this driver, now
> has its own comedi driver (dac02).
>
> Remove this obsolete driver.
>
> Signed-off-by: H Hartley Sweeten
> Reviewed-by: Ian
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 03:59:53PM -0400, Gary Rookard wrote:
I removed some useless extra parenthesis.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
On Sun, Mar 09, 2014 at 09:24:40AM -0700, Conrad Meyer wrote:
> Also kill some useless comments while I was there, e.g.:
> if (foo) {
> ...
> } /* if (foo) */
>
> With vim:
> :%s/}\t\t*\/\*\s\s*\(if\|else\|for\|while\|switch\).*$/}/
Neither of these patches apply to my tree, can you re
> -Original Message-
> From: Ben Hutchings [mailto:b...@decadent.org.uk]
> Sent: Monday, March 17, 2014 4:28 PM
> To: Haiyang Zhang
> Cc: da...@davemloft.net; net...@vger.kernel.org; KY Srinivasan;
> o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;
> driverdev-devel@linu
On Tue, Mar 11, 2014 at 07:58:17AM -0700, Conrad Meyer wrote:
> Replace hw_dev with class_dev in new dev_warn()s.
>
>
> Signed-off-by: Conrad Meyer
> Reviewed-by: Ian Abbott
> ---
> .../comedi/drivers/addi-data/hwdrv_apci1500.c | 104
> ++---
> 1 file changed, 52 insertio
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Monday, March 17, 2014 4:20 PM
> To: Haiyang Zhang
> Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
> jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org
> S
On Sat, 2014-03-15 at 10:18 -0700, Haiyang Zhang wrote:
[...]
> #define RING_SIZE_MIN 64
> -static int ring_size = 128;
> +int ring_size = 128;
> module_param(ring_size, int, S_IRUGO);
> MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)");
You have to add some driver-specific prefix to
From: Haiyang Zhang
Date: Sat, 15 Mar 2014 10:18:07 -0700
> - if (netif_queue_stopped(ndev) && !net_device->start_remove &&
> - (hv_ringbuf_avail_percent(&device->channel->outbound)
> - > RING_AVAIL_PERCENT_HIWATER ||
> - num
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote:
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID;
from out of a switch/case statement. And also, removed useless duplicate
UINT uiSearchRuleIndex = 0; and a variant UINT uiSe
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 03:31:18PM -0400, Gary Rookard wrote:
I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case
assuming that is the actual desired effect needed by the case label.
Signed-off-by: Gary Alan Rookard
---
On branch s
On Sun, Mar 16, 2014 at 03:59:53PM -0400, Gary Rookard wrote:
> I removed some useless extra parenthesis.
>
> Signed-off-by: Gary Alan Rookard
>
> ---
> On branch staging-next
> drivers/staging/bcm/CmHost.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/st
On Sun, Mar 16, 2014 at 03:31:18PM -0400, Gary Rookard wrote:
> I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case
> assuming that is the actual desired effect needed by the case label.
>
> Signed-off-by: Gary Alan Rookard
>
> ---
> On branch staging-next
> drivers/stagi
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote:
> I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID;
> from out of a switch/case statement. And also, removed useless duplicate
> UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;.
>
> Signed-off-by
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but a
On 13/03/14 01:21, Jérôme Pinot wrote:
This fixes the following issues detected by checkpatch.pl:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)
#220: FILE: drivers/staging/ozwpan/ozcdev.c:220:
+ memcpy(g_cdev.active_addr, addr, ETH
On 13/03/14 01:20, Jérôme Pinot wrote:
This fixes the following issues detected by checkpatch.pl:
WARNING: __constant_cpu_to_le16 should be cpu_to_le16
#1991: FILE: drivers/staging/ozwpan/ozhcd.c:1991:
+ __constant_cpu_to_le16(0x0001);
WARNING: __constant_cpu_to_le3
On 13/03/14 01:17, Jérôme Pinot wrote:
This fixes the following spacing issues detected by checkpatch.pl:
WARNING: line over 80 characters
#357: FILE: drivers/staging/ozwpan/ozhcd.c:357:
+static struct oz_urb_link *oz_uncancel_urb(struct oz_hcd *ozhcd, struct urb
*urb)
ERROR: trailing
Hi,
Laurent Pinchart wrote:
> Hello,
>
> On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> > On 03/13/2014 06:17 PM, Denis Carikli wrote:
> > > We need a way to pass signal polarity informations
> > > between DRM panels, and the display drivers.
> > >
> > > To do that, a pol_flags field wa
Hi Lothar,
On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
> Laurent Pinchart wrote:
> > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> > > On 03/13/2014 06:17 PM, Denis Carikli wrote:
> > > > We need a way to pass signal polarity informations
> > > > between DRM panels, and the di
Clean up code to get rid of sparse warnings.
Also fixed variable length arrays declared on the stack by removing
visor_hexDumpToBuffer() and using hex_dump_to_buffer() instead.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/include/timskmodutils.h | 22 --
.../unisys/visorchannel/vis
On Mon, 17 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 10:16:09PM -0400, Gary Rookard wrote:
On Sun, 16 Mar 2014, Gary Rookard wrote:
On Sun, 16 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
I unline split some quoted strings.
Hi,
On 2014-03-14 19:24, H Hartley Sweeten wrote:
This driver is _really_ broken.
It initializes an analog input subdevice that only has a (*cancel)
function. It also does a request_irq() to hookup an interrupt handler
using it->options[0] as the IRQ. This option is actually the base
address of the
Hello,
On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> On 03/13/2014 06:17 PM, Denis Carikli wrote:
> > We need a way to pass signal polarity informations
> > between DRM panels, and the display drivers.
> >
> > To do that, a pol_flags field was added to drm_display_mode.
> >
> > Signed-
On 03/16/2014 05:13 PM, Mark Einon wrote:
On 13/03/14 20:39, Ken Cox wrote:
Clean up code to get rid of sparse warnings.
Also fixed variable length arrays declared on the stack.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/visorutil/procobjecttree.c | 2 +-
drivers/staging/unisys/vis
Hi Denis,
Thanks for the patch.
On 03/13/2014 06:17 PM, Denis Carikli wrote:
> We need a way to pass signal polarity informations
> between DRM panels, and the display drivers.
>
> To do that, a pol_flags field was added to drm_display_mode.
>
> Signed-off-by: Denis Carikli
> ---
> ChangeLog
On 03/07/2014 05:46 PM, Dan Carpenter wrote:
I still prefer my patch. Unless I'm missing something? Could you
review it and I will submit it as a patch tomorrow.
regards,
dan carpenter
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index d00283a226a2..783cd75a2d96 1006
On Mon, 2014-03-17 at 08:18 +1300, Daniel Ngu wrote:
> Missing space after return type
Not really.
> diff --git a/drivers/staging/gdm724x/gdm_lte.h
> b/drivers/staging/gdm724x/gdm_lte.h
[]
> @@ -56,7 +56,7 @@ struct phy_dev {
> int (*cb)(void *cb_data, void *data, int len,
On Sun, Mar 16, 2014 at 10:16:09PM -0400, Gary Rookard wrote:
>
>
> On Sun, 16 Mar 2014, Gary Rookard wrote:
>
> >
> >
> >On Sun, 16 Mar 2014, Mark Einon wrote:
> >
> >>On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
> >>>I unline split some quoted strings.
> >>
> >>Hi,
> >>
> >>Wh
59 matches
Mail list logo
