Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Dan Carpenter
On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote: Fixed the ERROR thrown off by checkpatch.pl. Put the error message here, or say what it was. Signed-off-by: Chaitanya Hazarey c...@24.io Could you change your email client so it has your last in the From: header? This patch doesn't

Re: [PATCH] staging: octeon-usb: prevent memory corruption

2014-05-23 Thread Sergey Popov
28.04.2014 20:14, Sergey Popov пишет: 24.03.2014 01:18, Aaro Koskinen пишет: Hi, On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5 sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB)

Re: [PATCH] staging: rtl8723au: Use kmemdup() instead of memcpy() to duplicate memory

2014-05-23 Thread Jes Sorensen
Benoit Taine benoit.ta...@lip6.fr writes: This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci, and tested by compilation. Signed-off-by: Benoit Taine benoit.ta...@lip6.fr --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +--

[PATCH] staging: dgap: Remove more extra white space and tabs

2014-05-23 Thread Mark Hounschell
Removes more extra white space and tabs Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/dgap/dgap.c | 178 +--- 1 file changed, 86 insertions(+), 92 deletions(-) diff --git

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Chaitanya Hazarey
Hey Dan, Sorry my bad, will resubmit the patch in a proper manner with the required corrections. Thanks for looking into this. Thanks, Chaitanya On Fri, May 23, 2014 at 12:10 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote: Fixed

[PATCH] staging: dgap: Replace double negative conditionals

2014-05-23 Thread Mark Hounschell
This patch replaces double negativeconditionals Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Hans Verkuil
On 05/23/2014 06:59 PM, Chaitanya Hazarey wrote: Hey Dan, Sorry my bad, will resubmit the patch in a proper manner with the required corrections. Don't bother. This patch: http://comments.gmane.org/gmane.linux.drivers.driver-project.devel/48570 has just been merged and that has the same

[PATCH] staging: dgap: Simplify get_altpin and get_useintr functions

2014-05-23 Thread Mark Hounschell
Simplify dgap_config_get_useintr and dgap_config_get_altpin changing the case statement to an if statement. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.c | 10

[PATCH] staging: dgap: Change GFP_ATOMICs to GFP_KERNEL

2014-05-23 Thread Mark Hounschell
We don't need to use GFP_ATOMIC at driver load time so use GFP_KERNEL instead. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.c | 8 1 file changed, 4

Re: [PATCH] staging: slicoss: fix use-after-free in slic_entry_probe

2014-05-23 Thread Greg KH
On Thu, May 22, 2014 at 09:25:40PM -0700, David Matlack wrote: Fix a use-after-free bug that can cause a kernel oops. If slic_card_init fails then slic_entry_probe() (the pci probe() function for this device) will return error without cleaning up memory (including the registered netdev

Re: [PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-23 Thread Greg KH
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function

Re: [PATCH 4/6] Staging: unisys: Remove unused macros from visorchannel/visorchannel.h

2014-05-23 Thread Greg KH
On Thu, May 22, 2014 at 12:31:12PM -0500, Ken Cox wrote: VISORCHANNEL_CHANGE_SERVER_STATE and VISORCHANNEL_CHANGE_CLIENT_STATE are never used in any of the source so they have been removed. VISORCHANNEL_CHANGE_CLIENT_STATE would have caused a broken kernel build after commit a8d7f21d, but

Re: [PATCH 2/6] Staging: unisys: Fix sparse warnings in uislib

2014-05-23 Thread Greg KH
On Thu, May 22, 2014 at 12:31:10PM -0500, Ken Cox wrote: Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel() function so that it can operate on both memory space and IO space without getting sparse warnings. Signed-off-by: Ken Cox j...@redhat.com Don't add a new

Re: [PATCH 2/2] staging: slicoss: handle errors from slic_config_get

2014-05-23 Thread Greg KH
On Thu, May 22, 2014 at 09:38:45PM -0700, David Matlack wrote: slic_config_get() can fail. Change the return type from void to int and handle the error in slic_card_init(). So now, instead of silently failing (and then timing out waiting for the config data), the driver will fail loudly at

Re: [PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
++greg-kh and de...@driverdev.osuosl.org (my bad for missing you the first time around) On Thu, May 22 2014 at 06:09:11 PM, Colin Cross ccr...@android.com wrote: On Thu, May 22, 2014 at 5:51 PM, Mitchel Humpherys mitch...@codeaurora.org wrote: There are certain client bugs (double unmap, for

Re: [PATCH v7 4/4] memstick: Add realtek USB memstick host driver

2014-05-23 Thread Greg Kroah-Hartman
On Wed, Apr 30, 2014 at 03:56:20PM +0800, Roger wrote: On 04/28/2014 06:10 PM, Lee Jones wrote: From: Roger Tseng rogera...@realtek.com Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng

Re: [PATCH] staging/lustre: remove Peng Tao from Lustre contact list

2014-05-23 Thread Greg Kroah-Hartman
On Sun, May 04, 2014 at 03:45:50PM +0800, Peng Tao wrote: I am leaving emc for a new company where I cannot have much time working on Lustre. So remove myself from the contact list. I will still be around and continue to contribute as a hobbyist though. Thanks for all of your help on this

Re: [PATCH] staging: lustre: lnet: klnds: Remove prohibited space in socklnd.c

2014-05-23 Thread Greg KH
On Wed, May 21, 2014 at 11:23:33PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also, fix indenting due to changes. Signed-off-by: Masaru Nomura massa.nom...@gmail.com ---

Re: [PATCH v2] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

2014-05-23 Thread Greg KH
On Tue, May 20, 2014 at 12:03:23AM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. I undid modifications to memset(...) which I made in previous patches as it

Re: [PATCH] staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()

2014-05-23 Thread Greg KH
On Sun, May 04, 2014 at 02:26:09AM +0200, Christian Engelmayer wrote: This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left

Re: [PATCH v2] staging: rtl8821ae: mark pci_mem_start (and _end) as __iomem

2014-05-23 Thread Greg KH
On Sun, May 04, 2014 at 02:22:19PM +0200, Martin Kepplinger wrote: Shared addresses can be marked as such. Signed-off-by: Martin Kepplinger mart...@posteo.de --- I guess that's what you meant. Thanks for your feedback! Yes, that is correct, but someone beat you to this patch, sorry :(

Re: [PATCH net-next] Add hash value into RNDIS Per-packet info

2014-05-23 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 21 May 2014 12:55:39 -0700 It passes the hash value as the RNDIS Per-packet info to the Hyper-V host, so that the send completion notices can be spread across multiple channels. MS-TFS: 140273 Signed-off-by: Haiyang Zhang

Re: [PATCH] staging: wlags49_h2: fix sparse warning should it be static

2014-05-23 Thread Greg KH
On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote: Fixes the following warning: drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static? Signed-off-by: Luis Ortega luior...@gmail.com --- drivers/staging/wlags49_h2/sta_h2.c |

Greg caught up on staging patches

2014-05-23 Thread Greg KH
Hi all, Thanks to a trans-pacific flight, I think I'm now caught up on all drivers/staging/* patches that were sent to me before 10 hours ago. If you have sent something that I have not responded to, please consider it lost and please resend, after making sure it still applies on top of my

Re: [PATCH 3/8] drivers/staging: Remove useless return variables

2014-05-23 Thread Greg Kroah-Hartman
On Tue, May 20, 2014 at 12:33:43PM +0200, Peter Senna Tschudin wrote: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The

Re: [PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Greg Kroah-Hartman
On Fri, May 23, 2014 at 11:34:59AM -0700, Mitchel Humpherys wrote: ++greg-kh and de...@driverdev.osuosl.org (my bad for missing you the first time around) What can I do with this? Please send patches to me in a format that I can actually apply them in... thanks, greg k-h

RE: [PATCH net-next] Add hash value into RNDIS Per-packet info

2014-05-23 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, May 23, 2014 2:50 PM To: Haiyang Zhang Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org Subject:

[PATCH] Staging: xgifb: Fixed a code-style warning

2014-05-23 Thread Chaitanya Hazarey
Added a blank line after declarations to fix the following warning issued by checkpatch.pl: drivers/staging/xgifb/vb_init.c:800: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/xgifb/vb_setmode.c |1 + 1 file changed, 1

[PATCH] Staging: rtl8192u: Remove old WIRELESS_EXT support

2014-05-23 Thread Joel Pelaez Jorge
Remove support for building against ancient WIRELESS_EXT versions, only leaving support for the current version: 22 Signed-off-by: Joel Pelaez Jorge joelpel...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 - drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c |

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-23 Thread Nicolas Joseph
On 23/05/2014 14:42, Greg Kroah-Hartman wrote: All of the tabs were stripped out and replaced with spaces, making it impossible to apply this patch :( Can you please fix up your email client and resend? Sorry, I rebase and resend it. ___ devel

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-23 Thread Nicolas Joseph
WARNING: Missing a blank line after declarations Signed-off-by: Nicolas Joseph nicolas.jos...@homecomputing.fr --- drivers/staging/olpc_dcon/olpc_dcon.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c

[RESEND PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
There are certain client bugs (double unmap, for example) that can cause the handle-kmap_cnt (an unsigned int) to wrap around from zero. This causes problems when the handle is destroyed because we have: while (handle-kmap_cnt) ion_handle_kmap_put(handle); which takes a

Re: [PATCH] staging: slicoss: fix use-after-free in slic_entry_probe

2014-05-23 Thread David Matlack
On Fri, May 23, 2014 at 4:14 AM, Greg KH gre...@linuxfoundation.org wrote: I think I've already applied all of these, if not, please let me know. Also, you forgot to number these patches to let me know what order to apply them in :( thanks, greg k-h Thanks Greg. Sorry for the confusion. I

Re: [PATCH] staging: slicoss: remove private netdev list

2014-05-23 Thread David Matlack
Greg, this is one of the two patches that got dropped. It should apply cleanly in any order with respect to all my other patches. Thanks. ___ devel mailing list de...@linuxdriverproject.org

[PATCH 00/27] Cleanup for drivers/staging/bcm/CmHost.c

2014-05-23 Thread Matthias Beyer
Hi, I have some cleanup patches for the drivers/staging/bcm/CmHost.c file. I hope you like them. I compiled every single one of them, but I'm not able to test them as I do not have the appropriate hardware. If you want me to squash/split single patches, let me know. Regards, Matthias

[PATCH 01/27] Staging: bcm: Shortened code by using variable

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 4564c63..6793e25 100644 --- a/drivers/staging/bcm/CmHost.c

[PATCH 06/27] Staging: bcm: Shortened line

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 181c4e9..3f29dea 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 03/27] Staging: bcm: Shortened lines in get_dsx_sf_data_to_application()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 16262bb..3d8c049 100644 ---

[PATCH 02/27] Staging: bcm: Shortened lines in OverrideServiceFlowParams()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 6793e25..16262bb 100644 ---

[PATCH 05/27] Staging: bcm: Simplified by using variables

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 59a3eb9..181c4e9 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 09/27] Staging: bcm: Shortened lines in RestoreCmControlResponseMessage()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 102 +++ 1 file changed, 73 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 2743d16..3b65990 100644 ---

[PATCH 04/27] Staging: bcm: Outsourced restoring of endianess for ip adresses

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3d8c049..59a3eb9 100644 ---

[PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3f29dea..9fea9a8 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 24/27] Staging: bcm: Shortened lines in CopyIpAddrToClassifier()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 72 1 file changed, 52 insertions(+), 20 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 7fb8568..5bd6e1c 100644 ---

[PATCH 26/27] Staging: bcm: Shortened lines in SearchClsid()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 6dfa361..182efccd 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 08/27] Staging: bcm: Shortened lines in SetupTargetDsxBuffers()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9fea9a8..2743d16 100644 ---

[PATCH 25/27] Staging: bcm: Shortened lines in deleteSFBySfid()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 5bd6e1c..6dfa361 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 27/27] Staging: bcm: Shortened prototype for GetNextTargetBufferLocation()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 182efccd..fb1d932 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3b65990..f54b177 100644 ---

[PATCH 12/27] Staging: bcm: Shortened lines in RestoreSFParam()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index ea73c52..377e681 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 13/27] Staging: bcm: Replaced long member-accessing

2014-05-23 Thread Matthias Beyer
This patch replaces long object-member.member foo by variable useage. Increases the reading experience a lot by introducing only one variable (as it decreases the whoa-wall-of-text experience). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 107

[PATCH 15/27] Staging: bcm: Outsourced PHS rule applying

2014-05-23 Thread Matthias Beyer
This patch outsources the big PHS-rule-applying code chunk into a function. It also replaces member accessing by using variables. Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 170 +-- 1 file changed, 99

[PATCH 14/27] Staging: bcm: Shortened some lines in DumpCmControlPacker()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 106 +++ 1 file changed, 78 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 644087c..89030cc 100644 ---

[PATCH 16/27] Staging: bcm: Replaced struct member accessing with variable

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 96 ++-- 1 file changed, 49 insertions(+), 47 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 21074ae..d5e2ac2 100644 ---

[PATCH 11/27] Staging: bcm: Shortened lines in StoreSFParam()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index f54b177..ea73c52 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 18/27] Staging: bcm: Shortened line in DeleteAllClassifiersForSF()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index a13f2ad..aa121b7 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 19/27] Staging: bcm: Shortened lines in DeleteClassifierRuleFromSF()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index aa121b7..9186619 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 17/27] Staging: bcm: Shortened lines in CopyToAdapter()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 97 1 file changed, 70 insertions(+), 27 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index d5e2ac2..a13f2ad 100644 ---

[PATCH 20/27] Staging: bcm: Replaced member accessing with variable

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 77 +++- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9186619..20e4174 100644 ---

[PATCH 23/27] Staging: bcm: Replaced member accessing by variable

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index d5d5a9f..7fb8568 100644 ---

[PATCH 21/27] Staging: bcm: Shortened lines in CopyClassifierRuleToSF()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 128 ++- 1 file changed, 89 insertions(+), 39 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 20e4174..94f3f15 100644 ---

[PATCH 22/27] Staging: bcm: Shortened lines and replaced member accessing in CopyIpAddrToClassifier()

2014-05-23 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/CmHost.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 94f3f15..d5d5a9f 100644 --- a/drivers/staging/bcm/CmHost.c

[PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Added a blank line after declarations to fix the following warnings issued by checkpatch.pl: drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations

[PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations --- drivers/staging/silicom/bpctl_mod.c | 90 ++- 1 file changed, 88 insertions(+), 2 deletions(-) diff

Re: [PATCH] staging: slicoss: remove private netdev list

2014-05-23 Thread Greg KH
On Fri, May 23, 2014 at 01:11:01PM -0700, David Matlack wrote: Greg, this is one of the two patches that got dropped. It should apply cleanly in any order with respect to all my other patches. As my patch queue is now flushed out, what is this patch? :) Can you please just resend the two

Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

2014-05-23 Thread Greg KH
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations to fix the following warnings issued by checkpatch.pl: drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations

Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

2014-05-23 Thread Greg KH
On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations --- drivers/staging/silicom/bpctl_mod.c | 90

Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

2014-05-23 Thread Dan Carpenter
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations to fix the following warnings issued by checkpatch.pl: drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations

[PATCH] staging: lustre: Fixed warnings about using 0 as NULL ptr

2014-05-23 Thread Greg DeAngelis
Fixed a bunch of warnings pointed out by sparse about using 0 to represent a NULL pointer. Signed-off-by: Greg DeAngelis gdean...@gmail.com --- drivers/staging/lustre/lustre/mgc/lproc_mgc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH RESEND] staging: slicoss: remove private netdev list

2014-05-23 Thread David Matlack
Remove the private linked list of netdev structs. This list isn't being used anyway. This patch has no noticable effect. Signed-off-by: David Matlack matlackda...@gmail.com --- drivers/staging/slicoss/slic.h| 1 - drivers/staging/slicoss/slicoss.c | 4 2 files changed, 5 deletions(-)

[PATCH RESEND] staging: slicoss: clean up use of dev_err

2014-05-23 Thread David Matlack
First, don't print pci device information or driver prefixes, this is already printed by dev_err. Next, don't report error messages via dev_err when the failing function already reports all errors via dev_err. Signed-off-by: David Matlack matlackda...@gmail.com ---

[PATCH] staging: Convert __FUNCTION__ to __func__

2014-05-23 Thread Joe Perches
Use the normal mechanism for emitting a function name. Signed-off-by: Joe Perches j...@perches.com --- drivers/staging/bcm/Qos.c | 14 - drivers/staging/keucr/scsiglue.c | 2 +- drivers/staging/octeon-usb/octeon-hcd.c| 2 +-

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Thanks Greg K-H and Dan for the patience. Hope it works this time, I did apply it against staging and it was ok. Signed-off-by:

Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Hey Dan, Thanks for your patience, I have resubmitted via a new email. Hope that works. Thanks, Chaitanya On Fri, May 23, 2014 at 3:54 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations to

Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Forgot to add - what went wrong - I had deleted some whitespaces which made the git apply mad. Thanks, Chaitanya On Fri, May 23, 2014 at 10:32 PM, Chaitanya Hazarey c...@24.io wrote: Thanks Greg for looking into it, I have resubmitted using a new email, hope that works out. Thanks,

Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings

2014-05-23 Thread Chaitanya Hazarey
Thanks Greg for looking into it, I have resubmitted using a new email, hope that works out. Thanks, Chaitanya On Fri, May 23, 2014 at 3:26 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in