Hm... Now you've broken it into *too* many separate patches. Also the
subjects are the same. Also the subjects are too vague. Which coding
style issue is addressed?
It should be something like:
patch 1: comments
patch 2: add/remove spaces
patch 3: fix quoted text
patch 4: braces
patch 5: add
Hello, Arend.
On 01/09/14 16:08, Arend van Spriel wrote:
Maybe it would be better to use the DMA-API instead of the PCI wrappers.
I just found out that the PCI wrappers were indeed removed from the
DMA-API.txt documentation back in 2010, saying that driver writers are
always able to use the
fixed sparse warning : context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
spin_unlock_irqrestore is called at a later stage before returning
from the function if locked is 1.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:
Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Eli Billauer eli.billa...@gmail.com
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 57e8c3d..acf1a27 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
fixed sparse warning: incompatible types in comparison expression
(different address spaces)
wolw and reg both are being used only for the initialization of
the __iomem area.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/et131x/et131x.c | 4
Declare these functions as static:
llog_alloc_handle() is used in llog_open() only.
llog_free_handle() is used in llog_close() only.
Signed-off-by: Zheng Di zhengd...@gmail.com
---
drivers/staging/lustre/lustre/obdclass/llog.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Tue, Sep 02, 2014 at 07:22:12AM -0400, An Tuan Ha wrote:
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 05:05:32PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 04:39:47PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
spin_unlock_irqrestore is
On Tue, Sep 02, 2014 at 08:44:27PM +0530, Sudip Mukherjee wrote:
On Tue, Sep 02, 2014 at 05:05:32PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 04:39:47PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'do_locked_client_insert'
This patch fixes the following checkpatch.pl warning in lnet/lnet/lib-eq.c:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Mathieu OTHACEHE m.othac...@gmail.com
---
This patch is part of task 10 of the eudyptula challenge
On Tue, Sep 02, 2014 at 06:23:27PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 08:44:27PM +0530, Sudip Mukherjee wrote:
On Tue, Sep 02, 2014 at 05:05:32PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 04:39:47PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : context
The comedi skeleton driver is one of the few hybrid drivers with
both legacy and PCI attach mechanisms. Instead of splitting this
driver, just remove it. There are many other comedi drivers that
provide better examples.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
On Mon, Sep 01, 2014 at 11:52:35PM +0800, sunwxg wrote:
From: Sun Wang sun@gmail.com
Fix the style error checking by checkpatch.pl
ERROR: space required after that ','
Signed-off-by: Sun Wang sun@gmail.com
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
1 file
On Mon, Sep 01, 2014 at 10:24:40AM +0100, Ian Abbott wrote:
On 2014-09-01 10:23, Ian Abbott wrote:
On 2014-08-31 20:45, Chase Southwood wrote:
Sparse shows a couple of warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to
restricted __be32
Looking at the
On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote:
This commit adds the struct list_head to the struct dgnc_board so that
it is now possible to use it with the Linux list facility.
Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com
---
On Monday, September 01, 2014 4:04 AM, Ian Abbott wrote:
Continue to clean up the amplc_pci230 driver code and remove the legacy
attach mechanism, since it isn't very useful for this driver (see PATCH
05/28).
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
Each registered board is asigned a data structure to keep it's state.
So far this was implemented using the static array of fixed-size. This
commit changes the implementation by replacing the array with dynamic
solution based on the kernel list.
Because most of the setups will not use more than
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote:
Signed-off-by: Dipak Zope dipakzope.kernel@gmail.com
---
drivers/staging/android/uapi/binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/uapi/binder.h
On 09/02, Greg KH wrote:
On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote:
This commit adds the struct list_head to the struct dgnc_board so that
it is now possible to use it with the Linux list facility.
Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com
On Tue, Sep 02, 2014 at 07:55:49PM +0200, Konrad Zapalowicz wrote:
On 09/02, Greg KH wrote:
On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote:
This commit adds the struct list_head to the struct dgnc_board so that
it is now possible to use it with the Linux list facility.
From: Sudip Mukherjee su...@vectorindia.org
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v1 of the patch of the patch just
On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote:
From: Sudip Mukherjee su...@vectorindia.org
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
Signed-off-by:
Dear Sir/Madam,
Naturally, this letter will come to you as a surprise since we have not met,
permit me however. It is with deep
sense of honor and respect that I humbly make this appeal to you with the
understanding that any facts or
opinion expressed in this letter is given in confidence and
On Tue, Sep 02, 2014 at 11:24:02AM -0700, Greg Kroah-Hartman wrote:
On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote:
From: Sudip Mukherjee su...@vectorindia.org
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert'
Signed-off-by: Grzegorz Swirski grzeg...@swirski.name
---
drivers/staging/android/sync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index 0d37495..c5255dc 100644
--- a/drivers/staging/android/sync.c
+++
FROM: Husam Al Sayed.
EMAIL: husamalsayed...@hotmail.com
Hello,
I decided to write you this proposal in good faith, believing that you will
not betray me. I am Mr. Husam Al Sayed, a Bank officer here in U.A.E.
One Mr. Peter Adams, a citizen of your country and Crude Oil dealer made a
fixed
Fix checkpatch.pl space prohibited after that open parenthesis '(' errors
Signed-off-by: Greg Donald gdon...@gmail.com
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 18 +++-
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 4 +--
Fix commenting style from C99 comments to C89 comments
Signed-off-by: An Ha zero579...@gmail.com
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
Fix pointer placement coding style issue, where using foo * is
preferable over foo*.
Signed-off-by: An Ha zero579...@gmail.com
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix coding style issue which requires a blank line after declarations.
Signed-off-by: An Ha zero579...@gmail.com
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
Fix coding style issue which requires a space before the open
curly brace '{', after the open parenthesis '(', after a comma, and
after the equal sign '=' in an assignment.
Also, remove unnecessary whitespace after open parenthesis '(' and
before a quoted newline.
Signed-off-by: An Ha
Fix coding style issue where the if statement unnecessarily uses curly
braces for one line statements and where the else conditional statement
should follow the closing curly brace '}'. Also, the open curly brace
'{' should be on the same line as the if statement.
Signed-off-by: An Ha
Properly pack the data for file copy functionality. Patch based on
investigation done by Matej Muzila mmuz...@redhat.com
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reported-by: q...@redhat.com
Cc: sta...@vger.kernel.org
---
include/uapi/linux/hyperv.h |2 +-
1 files changed, 1
34 matches
Mail list logo