Include the new ../comedi_pci.h header instead of linux/pci.h and
../comedidev.h, which will now get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi_apci_16xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On Tue, Mar 10, 2015 at 10:46:55PM +0530, Sudip Mukherjee wrote:
we were getting build warnings about assignment of incompatible
pointer types. some of the function definitions were having wrong
return type or arguments.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
On Tue, Mar 10, 2015 at 10:46:51PM +0530, Sudip Mukherjee wrote:
Hi Greg,
all the build warnings have been taken care of in this series.
some of the patches will generate a few checkpatch warning and for some I
tried
to address few of the chcekpatch warnings while modifying them.
Don't mix
On Tue, Mar 10, 2015 at 09:11:00PM +0100, Greg Kroah-Hartman wrote:
On Tue, Mar 10, 2015 at 10:46:55PM +0530, Sudip Mukherjee wrote:
we were getting build warnings about assignment of incompatible
pointer types. some of the function definitions were having wrong
return type or arguments.
On Tue, Mar 10, 2015 at 10:08:48AM -0700, Mitchel Humpherys wrote:
Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect. Add the heap name and heap type to
the error message to make it more obvious.
Signed-off-by: Mitchel Humpherys
On Tuesday, March 10, 2015 9:10 AM, Ian Abbott wrote:
comedidev.h includes PCI-specific stuff that gets included by all
comedi drivers including non-PCI ones. Separate it out into its own
header comedi_pci.h. Make the new header include linux/pci.h and
comedidev.h so that comedi PCI drivers
On Tuesday, March 10, 2015 9:25 AM, Joe Perches wrote:
On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote:
comedidev.h includes PCI-specific stuff that gets included by all
comedi drivers including non-PCI ones. Separate it out into its own
header comedi_pci.h. Make the new header include
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, March 10, 2015 8:15 AM
To: KY Srinivasan
Cc: a...@canonical.com; de...@linuxdriverproject.org; o...@aepfle.de;
linux-ker...@vger.kernel.org
Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export
In sysfs methods struct device is guaranteed to not be NULL thus bd will
not be NULL in any way. Also, checking for bd-magic != DGNC_BOARD_MAGIC
and bd-state != BOARD_READY is redundant because we already don't
initialize broken boards since dgnc: Don't save boards in memory that
have failed to
Dgnc_state array of strings is never used anywhere and it seems pretty
useless anyway since the board state enum names speak for themselves.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 8
On Tue, Mar 10, 2015 at 11:35:25AM -0700, Joe Perches wrote:
On Tue, 2015-03-10 at 18:26 +, Hartley Sweeten wrote:
When comedi gets moved out of staging we will need to decide where the
headers go.
Any idea when that might happen?
when it is ready.
Remove FSF address because it's known in the past that it has changed.
Also, remove the pointless do not change the coding style comments
because it's one of the reasons why it's in staging and it's quite
contradictory to what it says in TODO. Also, they contain wrong e-mails
of people which are
On Mon, Mar 09, 2015 at 09:08:17PM +0100, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
The comedi_cmd struct has an hole after chanlist_len that could contain
uninitialized
memory, this struct is copied to userspace.
Is this a Smatch warning? If so then, I
On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
The bitmask should be used on msignals since the signals variable is not
used anywhere in the function.
You're probably right. I would really like to get Mark's Ack on this
though
On Mon, Mar 09, 2015 at 11:23:22PM -0300, mrugi...@gmail.com wrote:
From: Mario J. Rugiero mrugi...@gmail.com
Just fix your mail client so we don't need an extra From header.
No signed-off-by.
regards,
dan carpenter
___
devel mailing list
dgnc_NumBoards is the number of initialized elements in the
dgnc_Board[] array so the comparison should be = instead of so we
don't read invalid data. We can remove the special handling of the
empty array now that we've fixed this bug.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
Remove BOARD_FAILED and don't save dgnc_boards which failed to
initialize.
Assign the result of kzalloc() to brd in dgnc_found_board() and only put
it in the dgnc_Board[] if it successfully initializes. Also, remove
On Mon, Mar 09, 2015 at 08:57:08PM +, Lorenzo Stoakes wrote:
+#include asm/io.h
+
apart from what Dan Carpenter has said,
this is introducing one checkpatch warning, better to use #include linux/io.h
checkpatch is also giving warning about your patch subject
only one concern - if Greg
On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote:
Export the vmbus_sendpacket_pagebuffer_ctl() interface.
Why? Nothing in this patch needs it. Please include this in the patch
that needs the symbol, or at least give a hint as to what is going on.
As it is, this just looks like
On Tue, Mar 10, 2015 at 03:31:44AM +, KY Srinivasan wrote:
-Original Message-
From: KY Srinivasan
Sent: Friday, March 6, 2015 9:20 PM
To: KY Srinivasan; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
On Mon, Mar 09, 2015 at 08:57:08PM +, Lorenzo Stoakes wrote:
This patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
use hexadecimal constants (0x*) instead.
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
This is against v4.0-rc3. In next-20150310 there are two whitespace
differences.
---
drivers/staging/fbtft/fb_hx8340bn.c | 8
drivers/staging/fbtft/fb_hx8347d.c | 7 +++
drivers
Hi Joe,
On Tue, Mar 10, 2015 at 10:50 PM, Joe Perches j...@perches.com wrote:
On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote:
Gcc 4.3 doesn't understand binary constants (0b*):
trivia:
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c
b/drivers/staging/fbtft/fb_hx8340bn.c
[]
-Original Message-
From: Rafael J. Wysocki [mailto:rafael.j.wyso...@intel.com]
Sent: Thursday, March 5, 2015 3:04 PM
To: Jake Oshins
Cc: gre...@linuxfoundation.org; KY Srinivasan; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote:
Gcc 4.3 doesn't understand binary constants (0b*):
trivia:
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c
b/drivers/staging/fbtft/fb_hx8340bn.c
[]
@@ -156,10 +156,10 @@ static int set_var(struct fbtft_par *par)
static int
From: Nick Meier nme...@microsoft.com
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Intel:
[char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse:
From: Dan Carpenter dan.carpen...@oracle.com
The indenting makes it clear that there were curly braces intended here.
Fixes: 2dd37cb81580 ('Drivers: hv: vmbus: Handle both rescind and offer
messages in the same context')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: K. Y.
This patch is a continuation of the rescind handling cleanup work. We cannot
block in the global message handling work context especially if we are blocking
waiting for the host to wake us up. I would like to thank
Dexuan Cui de...@microsoft.com for observing this problem.
The current Linux-next
When a channel has been rescinded, the close operation is a noop.
Restructure the code so we deal with the rescind condition after
we properly cleanup the channel. I would like to thank
Dexuan Cui de...@microsoft.com for observing this problem.
The current code leaks memory when the channel is
Code reformatting based on checkpatch.pl:
- Replaced min() with min_t()
- Replaced printk() with netdev_*()
- Merged broken string
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_wx.c | 31 +--
1 file changed, 13
On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
- Replaced printk() with netdev_*()
trivia:
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
b/drivers/staging/rtl8192e/rtllib_wx.c
[]
@@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Increment the power_supply.use_cnt usage counter on:
- power_supply_get_by_phandle()
- power_supply_get_by_name()
and decrement it on power_supply_put() call.
This helps tracking of valid usage of power supply instance by
consumers. The usage counter itself also allows safe calling of
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
Acked-by: Robert Jarzmik
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
The return value of power_supply_register() call was not checked and
even on error probe() function returned 0. If registering failed then
during unbind the driver tried to unregister power supply which was not
actually registered.
This could lead to memory corruption because
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
- set_property - power_supply_set_property
- property_is_writeable -
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Reviewed-by: Sebastian Reichel s...@kernel.org
---
On 10 March 2015 at 07:42, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
only one concern - if Greg first applies the patches i sent yesterday then
this patch will not apply, and if this one is applied first then my series
will not apply ...
Indeed, I am more than happy to adapt the
Hi,
The patchset fixes invalid memory accesses in certain race scenarios by
moving ownership of struct power_supply to the core. All drivers are
modified.
TLDR for driver and subsystem maintainers
=
Two patches of patchset change power_supply_register()
Allow drivers to store private data inside power_supply structure for
later usage in power supply operations.
Usage of driver private data is necessary to access driver's state
container object from power supply calls (like get_property()) if struct
'power_supply' is a stored there as a pointer,
The commit c2be45f09bb0 (compal-laptop: Use
devm_hwmon_device_register_with_groups) wanted to change the
registering of hwmon device to resource-managed version. It mostly did
it except the main thing - it forgot to use devm-like function so the
hwmon device leaked after device removal or probe
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Pavel Machek pa...@ucw.cz
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Lee Jones lee.jo...@linaro.org
Reviewed-by: Bartlomiej
The power_supply_get_by_phandle() and power_supply_get_by_name() use
function class_find_device() for obtaining the reference to power
supply. Each use of class_find_device() increases the power supply's
device reference counter.
However the reference counter was not decreased by users of this
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property - power_supply_get_property
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by:
remove use of #pragma optimize which will usually be ignored by the
compiler.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v3: no change
v2: no change
drivers/staging/sm750fb/ddk750_swi2c.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
mention correct format specifier while printing.
fixes all the build warnings about incorrect argument type while
printing.
since this is a framebuffer device and it should follow what the
framebuffer layer is suggesting in struct fb_fix_screeninfo at
smem_start and mmio_start, so accordingly
check if it is already defined before defining SM750LE_REVISION_ID
again and at the same time mention correct data type.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v3: no change
v2: removed the redundant cast in sm750_hw.c
SM750LE_REVISION_ID is defined also in ddk750_chip.h.
kbuild test robot reported that for microblaze-allyesconfig
chan_to_field() and lynxfb_ops_set_par() were not defined. These two
functions were defined under CONFIG_PM, so for any archtecture if
CONFIG_PM is not defined we will have this error.
while moving the lynxfb_suspend() function some very
for powerpc-allyesconfig build failed with an error of g_option
undeclared. we will get this error on all architecture if MODULE is
not defined. fixed the declaration of g_option.
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v3: new
On 10 March 2015 at 07:00, Dan Carpenter dan.carpen...@oracle.com wrote:
No need for the volatile.
Will remove.
Really mmio750 should be a void __iomem *
it is declared as unsigned char __iomem * but it's not a char pointer
that's only to make the pointer math work. It would work just as
This patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment
(different address spaces)
In addition it eliminates an unnecessary volatile.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
On Tue, Mar 10, 2015 at 08:47:47AM +, Lorenzo Stoakes wrote:
On 10 March 2015 at 07:00, Dan Carpenter dan.carpen...@oracle.com wrote:
No need for the volatile.
Will remove.
Really mmio750 should be a void __iomem *
it is declared as unsigned char __iomem * but it's not a char
On 10 March 2015 at 08:59, Dan Carpenter dan.carpen...@oracle.com wrote:
The patch is:
[patch] cleanup the type of mmio750
silencing a Sparse warning is just a side benifit of using correct
data types. The one thing per patch rule also means that you should
fix a whole problem instead of
101 - 159 of 159 matches
Mail list logo
