Re: [PATCH v4 5/8] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

Hi Roy, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20161215] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stuart-Yoder/staging

RE: [PATCH 3/3] hv_netvsc: Implement VF matching based on serial numbers

> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Stephen Hemminger > Sent: Wednesday, December 14, 2016 3:52 PM > To: Greg KH > Cc: o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; >

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, December 15, 2016 6:32 AM > To: Olaf Hering > Cc: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org >

[PATCH v4 4/8] bus: fsl-mc: dpio: add global dpaa2 definitions

From: Roy Pledge Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- Notes: -v4 -adjust file location to be in drivers/staging

[PATCH v4 5/8] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

From: Roy Pledge Add QBman APIs for frame queue and buffer pool operations. Signed-off-by: Roy Pledge Signed-off-by: Haiying Wang Signed-off-by: Stuart Yoder --- Notes: -v4 -adjust file location

[PATCH v4 6/8] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

From: Roy Pledge The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notifications

[PATCH v4 3/8] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

From: Roy Pledge Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- Notes: -v4 -updated copyright -adjust file location to be

[PATCH v4 8/8] bus: fsl-mc: dpio: add maintainer for DPIO

From: Roy Pledge add Roy Pledge as maintainer of DPIO Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- Notes: -v4 -adjust file location to be in drivers/staging -v3 -no changes -v2

[PATCH v4 2/8] bus: fsl-mc: dpio: add APIs for DPIO objects

From: Ioana Radulescu Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder

[PATCH v4 0/8] staging: fsl-mc: add dpio driver

This patch series adds the driver for the DPIO object which is a step to addressing the final item in the staging TODO list-- adding a functional driver on top of the bus driver. The DPIO driver is a dependency for other functional drivers such as Ethernet. An overview of the DPIO object and

[PATCH v4 7/8] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

From: Roy Pledge The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by: Roy Pledge

RE: [PATCH v3 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

> > +struct dpaa2_io *dpaa2_io_create(const struct dpaa2_io_desc *desc) > > +{ > > + struct dpaa2_io *obj = kmalloc(sizeof(*obj), GFP_KERNEL); > > + > > + if (!obj) > > + return NULL; > > + > > + /* check if CPU is out of range (-1 means any cpu) */ > > + if (desc->cpu >=

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

On 15-12-2016 6:15, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile |

[PATCH 10/14 V2] rtlwifi: rtl8192cu: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 12/14 V2] rtlwifi: rtl8192c-common: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 08/14] rtlwifi: rtl8192se: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 01/14 V2] rtlwifi: Replace local debug macro RT_ASSERT

This macro can be replaced with WARN_ONCE. In addition to using a standard debugging macro for these critical errors, we also get a stack dump. In rtl8821ae/hw.c, a senseless comment was removed, and an incorrect indentation was fixed. This patch also fixes two places in each of rtl8192ee,

[PATCH 13/14 V2] rtlwifi: rtl8188ee: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 11/14 V2] rtlwifi: rtl8192ce: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 09/14 V2] rtlwifi: rtl8192de: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 07/14 V2] rtlwifi: rtl8723-common: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 04/14 V2] rtlwifi: rtl8723be: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 05/14 V2] rtlwifi: rtl8723ae: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 03/14 V2] rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG

This is a step toward eliminating the RT_TRACE macros. Those calls that have DBG_EMERG as the level are always logged, and they represent error conditions, thus they are replaced with pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 -

[PATCH 02/14 V2] rtlwifi: Remove RT_TRACE messages that use DBG_EMERG

These messages are always logged and represent error conditions, thus we can use pr_err(). Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 - eliminate some files that should not have been sent, and remove the module name from the format.

[PATCH 00/14 V2] rtlwifi: Start reworking of debug system

Following the discussion regarding the patch entitled "rtlwifi: Add BTC_TRACE_STRING to new btcoex", we are reworking the entire debug system. This set of patches does the following: 1. Replaces every invocation of RT_ASSERT with WARN_ON. With this change, triggering these conditions with now

RE: [PATCH 00/12] staging: comedi: add identifiers to function parameters

On Thursday, December 15, 2016 6:20 AM, Ian Abbott wrote: > Fix checkpatch.pl warnings of the form "function definition argument > 'foo' should also have an identifier name" in various comedi header > files. > > I omitted comedi_pci.h because Piotr Gregor already submitted a patch > for that one.

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On Thursday, December 15, 2016 4:45 AM, Ian Abbott wrote: > On 14/12/16 13:42, Piotr Gregor wrote: >> Add names of parameters to function prototypes in comedi PCI. >> Checkpatch reports now no errors. >> >> Signed-off-by: Piotr Gregor > > Looks good, thanks! > >

RE: [PATCH v3 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions

> -Original Message- > From: Laurentiu Tudor > Sent: Friday, December 02, 2016 6:19 AM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Leo Li > ;

RE: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

> -Original Message- > From: Laurentiu Tudor > Sent: Friday, December 02, 2016 6:12 AM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Leo Li > ;

RE: [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

> > +#define DPIO_CMD(id) ((id << DPIO_CMD_ID_OFFSET) | > > DPIO_CMD_BASE_VERSION) > > Paranthesis around 'id'? In all cases these are opcode values and will never be an expression. If we really need to future proof these definitions, we should do it for all objects not just DPIO. I'd

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote: > On 14/12/16 16:14, Hartley Sweeten wrote: >> On December 14, 2016 6:42 AM, Piotr Gregor wrote: >>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >>> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); >> >> For

Re: [PATCH] staging : osc : Remove braces from single-line body

On Thu, Dec 15, 2016 at 08:09:16PM +0530, Tabrez Khan wrote: > On Thu, Dec 15, 2016 at 7:08 AM, Greg KH wrote: > > On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote: > >> Remove unnecessary braces {} for single if statement block. > >> This warning is found

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Thu, Dec 15, Vitaly Kuznetsov wrote: > -> K. Y., but these words were written before I implemented > vmbus_wait_for_unload(), to me they just explain how we read messages. Another question for KY: In my testing, while busy-looping in vmbus_wait_for_unload, I see a few "message_type==1,

Re: [PATCH] staging : osc : Remove braces from single-line body

On Thu, Dec 15, 2016 at 7:08 AM, Greg KH wrote: > On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote: >> Remove unnecessary braces {} for single if statement block. >> This warning is found using checkpatch.pl. >> >> Signed-off-by: Tabrez khan

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Olaf Hering writes: > On Thu, Dec 15, Vitaly Kuznetsov wrote: > >> vmbus_wait_for_unload() may be receiving a message (not necessarily the >> CHANNELMSG_UNLOAD_RESPONSE, we may see some other message) on the same >> CPU it runs and in this case wrmsrl() makes sense. In other

[PATCH 1/2] media: s5p-cec: Remove unneeded linux/miscdevice.h include

s5p-cec: does not use any miscdevice so this patch remove this unnecessary inclusion. Signed-off-by: Corentin Labbe --- drivers/staging/media/s5p-cec/exynos_hdmi_cec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cec.h

[PATCH 2/2] media: s5p-cec: Remove references to non-existent PLAT_S5P symbol

Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") removed the Kconfig symbol PLAT_S5P. This patch remove the last occurrence of this symbol. Signed-off-by: Corentin Labbe --- drivers/staging/media/s5p-cec/Kconfig | 2 +- 1 file changed, 1

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Thu, Dec 15, Vitaly Kuznetsov wrote: > vmbus_wait_for_unload() may be receiving a message (not necessarily the > CHANNELMSG_UNLOAD_RESPONSE, we may see some other message) on the same > CPU it runs and in this case wrmsrl() makes sense. In other cases it > does nothing (neither good nor bad).

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Olaf Hering writes: > On Thu, Dec 15, Vitaly Kuznetsov wrote: > >> We actually need to read the reply and empty the message slot to make >> unload happen. And reading on a different CPU may not work, see: >> >>

[PATCH 10/12] staging: comedi: comedi_pcmcia.[ch]: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_pcmcia.c | 3 ++- drivers/staging/comedi/comedi_pcmcia.h | 22 -- 2 files changed,

[PATCH 09/12] staging: comedi: comedi_internal.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_internal.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH 08/12] staging: comedi: comedi_compat32.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_compat32.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 11/12] staging: comedi: comedi_usb.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_usb.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[PATCH 07/12] staging: comedi: ni_tio_internal.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_tio_internal.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 12/12] staging: comedi: comedidev.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedidev.h | 47 -- 1 file changed, 25 insertions(+), 22 deletions(-)

[PATCH 01/12] staging: comedi: addi_watchdog.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_watchdog.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 03/12] staging: comedi: comedi_isadma.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_isadma.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 00/12] staging: comedi: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name" in various comedi header files. I omitted comedi_pci.h because Piotr Gregor already submitted a patch for that one. 01) staging: comedi: addi_watchdog.h: add identifiers to function

[PATCH 06/12] staging: comedi: ni_tio.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_tio.h | 42 + 1 file changed, 22 insertions(+), 20 deletions(-)

[PATCH 02/12] staging: comedi: comedi_8254.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_8254.h | 30 +++- 1 file changed, 16 insertions(+), 14 deletions(-)

[PATCH 05/12] staging: comedi: ni_labpc.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_labpc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/12] staging: comedi: mite.h: add identifiers to function parameters

Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/mite.h | 37 ++- 1 file changed, 19 insertions(+), 18 deletions(-)

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Thu, Dec 15, Vitaly Kuznetsov wrote: > We actually need to read the reply and empty the message slot to make > unload happen. And reading on a different CPU may not work, see: > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2016-December/097330.html Does the following

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

On Thu, Dec 15, 2016 at 07:15:30AM +0200, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile

Re: [PATCH] drivers: staging: comedi: fix function prototypes

On 14/12/16 16:14, Hartley Sweeten wrote: On December 14, 2016 6:42 AM, Piotr Gregor wrote: Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors. Signed-off-by: Piotr Gregor --- drivers/staging/comedi/comedi_pci.h | 18

Re: [PATCH] drivers: staging: comedi: fix function prototypes

On 14/12/16 13:42, Piotr Gregor wrote: Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors. Signed-off-by: Piotr Gregor --- drivers/staging/comedi/comedi_pci.h | 18 ++ 1 file changed, 10 insertions(+), 8

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Olaf Hering writes: > On Thu, Dec 15, Olaf Hering wrote: > >> On Thu, Dec 15, Vitaly Kuznetsov wrote: >> >> > I see a number of minor but at least one major issue against such move: >> > At least for some Hyper-V versions (2012R2 for example) >> > CHANNELMSG_UNLOAD_RESPONSE is

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Olaf Hering writes: > On Thu, Dec 15, Vitaly Kuznetsov wrote: > >> I see a number of minor but at least one major issue against such move: >> At least for some Hyper-V versions (2012R2 for example) >> CHANNELMSG_UNLOAD_RESPONSE is delivered to the CPU which initially sent >>

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Thu, Dec 15, Olaf Hering wrote: > On Thu, Dec 15, Vitaly Kuznetsov wrote: > > > I see a number of minor but at least one major issue against such move: > > At least for some Hyper-V versions (2012R2 for example) > > CHANNELMSG_UNLOAD_RESPONSE is delivered to the CPU which initially sent > >

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Thu, Dec 15, Vitaly Kuznetsov wrote: > I see a number of minor but at least one major issue against such move: > At least for some Hyper-V versions (2012R2 for example) > CHANNELMSG_UNLOAD_RESPONSE is delivered to the CPU which initially sent > CHANNELMSG_REQUESTOFFERS and on kdump we may not

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Olaf Hering writes: > KY, > > if a hyperv VM crashes alot of work must be done to prepare the > environment for the kdump kernel. This approach is different compared to > all the other VM types, or baremetal. Since the just crashed kernel is > per definition unreliable all that

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

On 12/15/2016 06:15 AM, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- [...] > drivers/net/can/Makefile | 1 - For drivers/net/can/Makefile: Acked-by: Marc