Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

On Tue, Feb 28, 2017 at 09:52:44PM +0200, Alexander Kapshuk wrote: > Use a single fmt string with appropriate verbs as conversion specifiers, > followed by the original string literals and the integer argument > instead of using a backslash to escape a new line embedded inbetween > quoted string

Re: [PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context

On Tue, Feb 28, 2017 at 01:57:55PM +0530, Pranay Kr. Srivastava wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. > > Pass GFP_ flags as well to speakup_allocate depending > on the context it is called in. > >

Re: [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info

On Tue, Feb 28, 2017 at 01:57:53PM +0530, Pranay Kr. Srivastava wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > >

Re: [PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

On 02/27/2017 06:45 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:26PM -0800, Steve Longerbeam wrote: This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve

Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

On 02/27/2017 06:41 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:17PM -0800, Steve Longerbeam wrote: From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The

Re: [PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

Hi Rob, On 02/27/2017 06:38 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:03PM -0800, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 66

Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote: > Use a single fmt string with appropriate verbs as conversion specifiers, > followed by the original string literals and the integer argument > instead of using a backslash to escape a new line embedded inbetween > quoted string literals

Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

On Tue, Feb 28, 2017 at 10:34 PM, Joe Perches wrote: > On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote: >> Use a single fmt string with appropriate verbs as conversion specifiers, >> followed by the original string literals and the integer argument >> instead of using

[PATCH v2] staging: rtl8192e: remove unnecessary whitespace in rtl_wx.c

Remove unncessary whitespaces in rtl_wc.c. Problem found by checkpatch.pl. Signed-off-by: Sumantro Mukherjee --- Changes since v1: -Add reason of change -Add version number to patch -Add full legal name ---

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

On Tue, 2017-02-28 at 21:18 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 28. Februar 2017 um > > 19:49 geschrieben: > > > > > > Change the audio's dependency on BCM2835_VCHIQ to a select. > > > > Signed-off-by: Michael Zoran > > --- > >  

Re: [PATCH 2/2] staging: comedi: cb_pcidas64: refactor relocated code

On Tue, Feb 28, 2017 at 02:36:25PM +, Ian Abbott wrote: > On 27/02/17 21:08, Tobin C. Harding wrote: > >Code was moved to a separate function in a previous patch. Code > >structure wast maintained to ease review. Code may now be refactored > >to ease reading. > > > >Move multi-line dereference

Re: [PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

On Tue, Feb 28, 2017 at 11:43:16AM -0800, Michael Zoran wrote: > On Tue, 2017-02-28 at 20:19 +0100, Greg KH wrote: > > On Tue, Feb 28, 2017 at 10:49:35AM -0800, Michael Zoran wrote: > > > Create a new config for Broadcom VideoCore services. > > > > > > Signed-off-by: Michael Zoran

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

> Michael Zoran hat am 28. Februar 2017 um 19:49 > geschrieben: > > > Change the audio's dependency on BCM2835_VCHIQ to a select. > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++- > 1 file

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

Use a single fmt string with appropriate verbs as conversion specifiers, followed by the original string literals and the integer argument instead of using a backslash to escape a new line embedded inbetween quoted string literals passed as fmt arguments to dev_err() invoked in

[PATCH v3] staging: iio: adis16201: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: simran singhal --- v3: -Removing endif as it is not needed -Changing subject drivers/staging/iio/accel/adis16201.h | 144

Re: [PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

On Tue, 2017-02-28 at 20:19 +0100, Greg KH wrote: > On Tue, Feb 28, 2017 at 10:49:35AM -0800, Michael Zoran wrote: > > Create a new config for Broadcom VideoCore services. > > > > Signed-off-by: Michael Zoran > > --- > >  drivers/staging/vc04_services/Kconfig | 15

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote: > On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron wrote: >> On 28/02/17 19:17, Jonathan Cameron wrote: >>> On 28/02/17 18:51, simran singhal wrote: The contents of the header file are used only by this single source file.

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On Wed, Mar 1, 2017 at 1:04 AM, Lars-Peter Clausen wrote: > On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote: >> On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron wrote: >>> On 28/02/17 19:17, Jonathan Cameron wrote: On 28/02/17 18:51, simran singhal wrote:

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron wrote: > On 28/02/17 19:17, Jonathan Cameron wrote: >> On 28/02/17 18:51, simran singhal wrote: >>> The contents of the header file are used only by this single >>> source file. Move content into .c and remove .h. >>> >>>

Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters

On Tue, Feb 28, 2017 at 08:26:19PM +0100, Greg KH wrote: > On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > > This patch fixes warning of line over 80 characters, as issued by > > checkpatch.pl > > > > Signed-off-by: Chetan Sethi > > --- > > v2: > > - split

Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters

On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > This patch fixes warning of line over 80 characters, as issued by > checkpatch.pl > > Signed-off-by: Chetan Sethi > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch

Re: [PATCH V2 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

On Tue, Feb 28, 2017 at 06:12:35PM +1300, Derek Robson wrote: > Fixed style of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > Version #1 introduced lines over 80. > This version moves comments to be above the line of code. > > >

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On 28/02/17 19:17, Jonathan Cameron wrote: > On 28/02/17 18:51, simran singhal wrote: >> The contents of the header file are used only by this single >> source file. Move content into .c and remove .h. >> >> Signed-off-by: simran singhal > Applied to the togreg branch of

Re: [Outreachy kernel] Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Tue, 28 Feb 2017, Joe Perches wrote: > On Wed, 2017-03-01 at 00:41 +0530, SIMRAN SINGHAL wrote: > > On Tue, Feb 28, 2017 at 1:49 AM, SIMRAN SINGHAL > > wrote: > > > On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > > > > On Mon, 2017-02-27 at

Re: [PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

On Tue, Feb 28, 2017 at 10:49:35AM -0800, Michael Zoran wrote: > Create a new config for Broadcom VideoCore services. > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/Kconfig | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > >

Re: [Outreachy kernel] [PATCH 3/5] staging: rtl8712: Remove unnecessary else after return

On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 2:49 AM, Julia Lawall wrote: > > > > > > On Mon, 27 Feb 2017, simran singhal wrote: > > > >> This patch fixes the checkpatch warning that else is not generally > >> useful after a break or return. > >> >

Re: [Outreachy kernel] Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 1:49 AM, SIMRAN SINGHAL > wrote: > > On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > >> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: > >>> This patch fixes the

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Wed, 2017-03-01 at 00:41 +0530, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 1:49 AM, SIMRAN SINGHAL > wrote: > > On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > > > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: > > > > This

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On 28/02/17 18:51, simran singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: simran singhal Applied to the togreg branch of iio.git and pushed out as testing for the

Re: [Outreachy kernel] [PATCH 3/5] staging: rtl8712: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:49 AM, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, simran singhal wrote: > >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. >> >> This was done using Coccinelle: >> @@ >> expression e2; >>

Re: [Outreachy kernel] Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 2:13 AM, Joe Perches wrote: > > On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote: > >> On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: > >> > On Mon, 2017-02-27 at 23:44 +0530,

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 1:49 AM, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: >> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >>> This patch fixes the checkpatch warning that else is not generally >>> useful

Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Wed, Mar 1, 2017 at 12:30 AM, Julia Lawall wrote: > > > On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > >> On Tue, Feb 28, 2017 at 2:45 AM, Julia Lawall wrote: >> > >> > >> > On Mon, 27 Feb 2017, simran singhal wrote: >> > >> >> This patch fixes the

Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:13 AM, Joe Perches wrote: > On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote: >> On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: >> > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> > > This patch fixes the

Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 2:45 AM, Julia Lawall wrote: > > > > > > On Mon, 27 Feb 2017, simran singhal wrote: > > > >> This patch fixes the checkpatch warning that else is not generally > >> useful after a break or return. > >> >

Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:45 AM, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, simran singhal wrote: > >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. >> >> This was done using Coccinelle: >> @@ >> expression e2; >>

[PATCH v2] staging: iio: accel: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: simran singhal --- v2: -Removing ifndef and define drivers/staging/iio/accel/adis16201.h | 144 -

[PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

Create a new config for Broadcom VideoCore services. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/Kconfig

[PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

Change the audio's dependency on BCM2835_VCHIQ to a select. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig

[PATCH 3/3] staging: bcm2835-camera: select BCM2835_VCHIQ rather then depending on it.

Change the camera's dependency on BCM2835_VCHIQ to a select. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/Kconfig

[PATCH 0/3] staging: vc04-services: Create new toplevel config VIDEOCORE

The current toplevel menu item for vc04-services has this description: Kernel to VideoCore communication interface for the BCM2835 family of products. Defaults to Y when the Broadcom Videocore services are included in the build, N otherwise. 1. This isn't quite how things work today. Videocore

[PATCH] scsi: storvsc: Add support for FC rport.

Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver also attaches to the FC transport to allow host and port names to be published under /sys/class/fc_host/hostX. Current

Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote: > staging:rtl8192e: removed extra whitelines which were giving warnings > Signed-off-by: Sumantro We need a blank line before the signed-off-by line, as well as a "real/full" name being used (unless you use only

[PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c

staging:rtl8192e: removed extra whitelines which were giving warnings Signed-off-by: Sumantro --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

Re: [PATCH 2/2] staging: comedi: cb_pcidas64: refactor relocated code

On 27/02/17 21:08, Tobin C. Harding wrote: Code was moved to a separate function in a previous patch. Code structure wast maintained to ease review. Code may now be refactored to ease reading. Move multi-line dereference onto single line. Give function parameter more meaningful name. Fix minor

Re: [PATCH 1/2] staging: comedi: cb_pcidas64: refactor out function

On 27/02/17 21:08, Tobin C. Harding wrote: Function contains code at differing levels of abstraction. This is shown by the fact that conditional is loop-invariant. Code may be refactored out into a separate function. Refactor out loop body to separate function. Do not alter original code

Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

Vitaly Kuznetsov writes: > Dexuan Cui writes: > >>> From: devel [...] On Behalf Of Dexuan Cui >>> > > --- a/drivers/hv/hv_utils_transport.h >>> > > +++ b/drivers/hv/hv_utils_transport.h >>> > > @@ -32,6 +32,7 @@ struct hvutil_transport { >>> > > int

Re: [PATCH] staging/rtl8192e fixed checkpatch.pl warnings in rtl_wx.c

On Tuesday 28 February 2017 07:21 PM, Sumantro wrote: Fixed Warning rasied by checkpatch.pl Hi, Usually we prefer to have subject stating what change is done and commit log stating why that change is done instead of stating tool name. Though you can give credit to the tool in the commit log

[PATCH] staging/rtl8192e fixed checkpatch.pl warnings in rtl_wx.c

Fixed Warning rasied by checkpatch.pl Signed-off-by: Sumantro --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index

Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

Dexuan Cui writes: >> From: devel [...] On Behalf Of Dexuan Cui >> > > --- a/drivers/hv/hv_utils_transport.h >> > > +++ b/drivers/hv/hv_utils_transport.h >> > > @@ -32,6 +32,7 @@ struct hvutil_transport { >> > > int mode; /*

RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

> From: devel [...] On Behalf Of Dexuan Cui > > > --- a/drivers/hv/hv_utils_transport.h > > > +++ b/drivers/hv/hv_utils_transport.h > > > @@ -32,6 +32,7 @@ struct hvutil_transport { > > > int mode; /* hvutil_transport_mode */ > > > struct file_operations fops;

RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > void hv_fcopy_deinit(void) > > { > > + bool wait = hvt->dev_opened; > > + > > fcopy_transaction.state = HVUTIL_DEVICE_DYING; > > cancel_delayed_work_sync(_timeout_work); > > hvutil_transport_destroy(hvt); > > -

Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

Dexuan Cui writes: > If the daemon is NOT running at all, when we disable the util device from > Hyper-V Manager (or sometimes the host can rescind a util device and then > re-offer it), we'll hang in util_remove -> hv_kvp_deinit -> > wait_for_completion(_event), because

[PATCH 1/2] Staging: xgifb: vb_setmode.c: Fix checkpath warning

Fix the following checkpatch.pl warning: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/vb_setmode.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 2/2] Staging: xgifb: vb_setmode.c: Fix checkpath warnings

Fix the following checkpatch.pl warnings: 1: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+i].ModeID' 2: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai ---

Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

Hi Pranay, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.10 next-20170228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pranay-Kr-Srivastava/return-same

Re: [PATCH] staging: fixed style in greybus/tools/loopback_test.c

On Mon, Feb 27, 2017 at 12:52:17PM -0800, Jonathan Bowie wrote: > fixed a simple style issue in tools/loopback_test.c Please mention what kind of style issue you're addressing. Also make sure your patch summary (Subject) is on the format staging: greybus: loopback_test: add missing

[PATCH] staging: wilc1000: remove redundant result < 0 check

From: Colin Ian King The check for result < 0 is redundant because at that point result is always zero, hence we can remove this check and the netdev_err message. Detected by CoverityScan, CID#1357147 ("Logically Dead Code") Signed-off-by: Colin Ian King

[PATCH] staging: wilc1000: add check for kmalloc allocation failure.

From: Colin Ian King Add a sanity check that wid.val has been allocated, fixes a null pointer deference on stamac when calling ether_add_copy. Detected by CoverityScan, CID#1369537 ("Dereference null return value") Signed-off-by: Colin Ian King

[PATCH] staging: ks7010: Unnecessary parentheses removed and improved coding style.

Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved as it's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); memcpy(ap->bssid,

Re: [Outreachy kernel] Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

On Tue, 2017-02-28 at 12:24 +0100, Julia Lawall wrote: > It's drifting a little bit from the original issue, but the whole *i thing > is not very nice. The function is used in only one place, and the call > looks like this: > >temp = XGI_AjustCRT2Rate(ModeIdIndex,

Re: [Outreachy kernel] Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

On Tue, 28 Feb 2017, Joe Perches wrote: > On Tue, 2017-02-28 at 16:15 +0530, Arushi Singhal wrote: > > Error reported by checkpatch.pl as "avoid multiple line dereference". > > Addition of new variables to make the code more readable. > > You should probably split this into 2 patches, one for >

Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

On Tue, 2017-02-28 at 16:15 +0530, Arushi Singhal wrote: > Error reported by checkpatch.pl as "avoid multiple line dereference". > Addition of new variables to make the code more readable. You should probably split this into 2 patches, one for each file. What Julia said about finding a

[PATCH v7] staging: xgifb: correct the multiple line dereference

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v7 - Improve the coding style. - Introduced new variables.

Re: [PATCH] staging: fsl-mc: fix warning in DT ranges parser

Hi Arnd, On 02/27/2017 10:42 PM, Arnd Bergmann wrote: > The fsl-mc-bus driver in staging contains a copy of the standard > 'ranges' property parsing algorithm with a hack to treat a missing > property the same way as an empty one. This code produces false-positive > warnings for me in an

Re: [PATCH v6] staging: xgifb: correct the multiple line dereference

On Tue, Feb 28, 2017 at 01:59:53PM +0530, Arushi Singhal wrote: Please fix your email client to not send html mail, otherwise the mailing lists reject them, and your quoting is all messed up :( > On Tue, Feb 28, 2017 at 11:21 AM, Greg Kroah-Hartman < > gre...@linuxfoundation.org> wrote: > >

Re: [PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context

Pranay Kr. Srivastava, on mar. 28 févr. 2017 13:57:55 +0530, wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. > > Pass GFP_ flags as well to speakup_allocate depending > on the context it is called in. > >

Re: [PATCH SPEAKUP v2 2/3] remove unecessary initial allocation of vc

Pranay Kr. Srivastava, on mar. 28 févr. 2017 13:57:54 +0530, wrote: > This patch removes the unnecessary allocation of > current foreground vc during initialization. > > This initialization is already handled in the loop > that follows it for all available virtual consoles. > > Signed-off-by:

Re: [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info

Pranay Kr. Srivastava, on mar. 28 févr. 2017 13:57:53 +0530, wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > > Signed-off-by:

Re: [Outreachy kernel] Re: [PATCH v6] staging: xgifb: correct the multiple line dereference

On Tue, 28 Feb 2017, Arushi Singhal wrote: > > > On Tue, Feb 28, 2017 at 11:21 AM, Greg Kroah-Hartman > wrote: > On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote: > > Error reported by checkpatch.pl as "avoid multiple line dereference". >

[PATCH SPEAKUP v2 2/3] remove unecessary initial allocation of vc

This patch removes the unnecessary allocation of current foreground vc during initialization. This initialization is already handled in the loop that follows it for all available virtual consoles. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 11

[PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context

speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c |

[PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info

This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 27

[PATCH SPEAKUP v2 0/3] cleanup error and initilization

Changelog from v1: 1. fixed kbuild warning for i386 build as reported by kbuild robot 2. split initialization code in two patches. Pranay Kr. Srivastava (3): return same error value from spk_set_key_info remove unecessary initial allocation of vc use spkeaup_allocate as per