Re: ks7010 endianness question

On Wed, Apr 19, 2017 at 01:34:46PM +1000, Tobin C. Harding wrote: > Hi Wolfram, > > May I please ask you with an ks7010 driver endianness question? > > Comments on the hostif_hdr data structure (ks_hostif.h) state that the > target uses little endian byte order. > > /* > * HOST-MAC I/F data

Re: [PATCH v2 8/9] staging: fsl-dpaa2/eth: Add TODO file

On Wed, Apr 12, 2017 at 11:25 AM, Ioana Radulescu wrote: > Add a list of TODO items for the Ethernet driver > > Signed-off-by: Ioana Radulescu > --- > v2: Add note > > drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++ > 1 file

ks7010 endianness question

Hi Wolfram, May I please ask you with an ks7010 driver endianness question? Comments on the hostif_hdr data structure (ks_hostif.h) state that the target uses little endian byte order. /* * HOST-MAC I/F data structure * Byte alignmet Little Endian */ struct hostif_hdr { u16 size;

Re: [Intel-gfx] [PATCH] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

Hi Logan, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7 next-20170418] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Logan-Gunthorpe/dma-buf-Rename-dma-ops

Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues

On Apr 18, 2017, at 09:50, g...@kroah.com wrote: > > On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote: >> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to >> avoid precedence issues (typo) s/Parantheses/parenthesis/ s/Macro/macro/ The Subject line

Re: [Patch v3 2/2] lustre: CONSTANTS put on right side of comparison test

On Apr 15, 2017, at 07:50, Rishiraj Manwatkar wrote: > > Comparison should have the CONSTANT on the right side of the test I don't think this change really improves things. For standalone comparisons I agree that having the constant on the RHS is best, but here it is

[PATCH] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

Seeing the kunmap_atomic dma_buf_op shares the same name with a macro in higmem.h, the former can be aliased if any dma-buf user includes that header. I'm personally trying to include highmem.h inside scatterlist.h and this breaks the dma-buf code proper. Christoph Hellwig suggested [1] renaming

[PATCH 25/25] staging: unisys: visorhba: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

From: Sameer Wadgaonkar The root issue is that we are not allowed to have items on the stack being passed to "DMA" like operations. In this case we have a vmcall and an inline completion of scsi command. This patch fixes the issue by moving the variables on stack

[PATCH 23/25] staging: unisys: visorbus: remove POSTCODE from visorchipset_init

Remove POSTCODEs from visorchipset_init and replace them with dev_err when needed. Since there are no more POSTCODEs in the code, we can get rid of the data in the header file as well. Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 20/25] staging: unisys: visorbus: get rid of POSTCODES in my_device_changestate

Replace POSTCODEs with dev_err in the function my_device_changestate. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 22/25] staging: unisys: visorbus: remove postcodes in setup_crash_devices_work_queue

Replace postcodes with dev_err in the function setup_crash_device_work_queue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 33 --- 1 file changed, 14 insertions(+),

[PATCH 14/25] staging: unisys: visorbus: remove noisy postcode from visorchipset_exit

The postcodes in visorchipset_exit were not displaying errors, they can just be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 4 1 file changed, 4 deletions(-) diff

[PATCH 19/25] staging: unisys: visorbus: remove POSTCODE from my_device_create

Replace the POSTCODEs with dev_err in my_device_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +++ 1 file changed, 9 insertions(+), 15 deletions(-) diff

[PATCH 24/25] staging: unisys: visorbus: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

From: Sameer Wadgaonkar The root issue is that we are not allowed to have items on the stack being passed to "DMA" like operations. In this case we have vmcall operation that was using parameters from the stack. This patch fixes the issue by moving the variables on

[PATCH 18/25] staging: unisys: visorbus: remove POSTCODE from bus_configure

Remove the POSTCODE logging from bus_configure, replace it with an error message if we fail dumping the errno. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file

[PATCH 15/25] staging: unisys: visorbus: remove postcodes in visorbus_init

Remove the POSTCODES in visorbus_init. Since there are no more POSTCODES in visorbus_main.c we can remove the reference to the vmcallinterface header file. No need for vmcallinterface in visorbus_main.c Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 21/25] staging: unisys: visorbus: refactor setup_crash_devices_work_queue

The if statement was sending us down the happy path with the error path in the else. This can be simplified by having the if be the error and just falling through with the good path. Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 12/25] staging: unisys: visorbus: remove noisy postcodes

Get rid of postcodes from visorbus_main.c that are just informational. They were not logging errors, we don't need to replace them with anything. Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 16/25] staging: unisys: visorbus: get rid of POSTCODEs in save_crash_msg

Replace POSTCODES in save_crash_msg with dev_err handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-)

[PATCH 17/25] staging: unisys: visorbus: remove POSTCODEs from bus_create

Removed the POSTCODEs from the function bus_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH 13/25] staging: unisys: visorbus: remove noisy postcode in bus_destroy

Since kzalloc will display error the postcode becomes redundant, it can be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 09/25] staging: unisys: visorbus: remove POSTCODE from create_visor_device

Remove POSTCODES from create_visor_device, when we fail log an error with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 ++--- 1 file changed, 2 insertions(+), 7

[PATCH 11/25] staging: unisys: visorbus: remove POSTCODE in create_bus_instance

Remove postcodes from create_bus_instance. If there is an error log it with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH 10/25] staging: unisys: visorbus: remove POSTCODE from chispet_init

Get rid of the postcodes from the function chipset_init. They were being noisy, so don't replace them with errors. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1 file changed,

[PATCH 08/25] staging: unisys: visorbus: remove NORETRY

Allow retry when allocating memory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 03/25] staging; unisys: visorbus: replace uint32 with int

Shouldn't use uint32 in the kernel, it can be replaced with int here. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/25] staging: unisys: visorbus: handle visorchannel_write errors in code

Catch and report back errors when visorchannel_write fails. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchannel.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-)

[PATCH 05/25] staging: unisys: visorbus: update comment

Comment was outdated and did not reflect what was actually happening. Update the comment to reflect reality. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 15 --- 1 file

[PATCH 06/25] staging: unisys: visorbus: add timeout to controlvm_periodic_work

Limit the amount that gets pulled from the queue on each try so we don't get stuck in an infinite loop if something has gone wrong with the s-Par firmware. Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 00/25] staging: unisys: Remove POSTCODEs and allow boot with CONFIG_VMAP_STACK set to y

The following patch series removes the POSTCODE macros from the codebase, replacing them with dev_err where needed. It also fixes a problem with the drivers that were preventing them from working when CONFIG_VMAP_STACK was set to y. David Kershner (23): staging: unisys: visorbus: combine

[PATCH 04/25] staging: unisys: visorbus: fixed indentation

Moved the brace to the left to fix the indentation issue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/25] staging: unisys: visornic: remove keyword inline from function

Functions in c files don't need to be inlined, get rid of the keyword. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 01/25] staging: unisys: visorbus: combine response functions into a single one

There are several different controlvm response functions, consolidate them to one so we can simplify error handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 53

Re: [PATCH] staging: rtl8192u: fix incorrect assignments

On Tue, Apr 18, 2017 at 01:52:01PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 11, 2017 at 10:19:08AM +0200, Jakub Jedelsky wrote: > > Fixing warnings found by sparse on rtl8192u/ieee80211. > > > > drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: warning: > > incorrect type in

Re: [PATCH] staging: ks7010: Change capability field to __le16

On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote: > Change capability field to __le16 in struct ap_info_t, > struct link_ap_info_t, and struct local_ap_t. > This fixes a sparse warning. What warning is it fixing? And are you sure this is the correct fix? How did you test it?

[PATCHv4 11/12] staging: android: ion: Set query return value

This never got set in the ioctl. Properly set a return value of 0 on success. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index

[PATCHv4 08/12] staging: android: ion: Rework heap registration/enumeration

The current model of Ion heap registration is based on the outdated model of board files. The replacement for board files (devicetree) isn't a good replacement for what Ion wants to do. In actuality, Ion wants to show what memory is available in the system for something else to figure out what to

[PATCHv4 12/12] staging/android: Update Ion TODO list

Most of the items have been taken care of by a clean up series. Remove the completed items and add a few new ones. Signed-off-by: Laura Abbott --- drivers/staging/android/TODO | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git

[PATCHv4 09/12] staging: android: ion: Drop ion_map_kernel interface

Nobody uses this interface externally. Drop it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/android/ion/ion.c

[PATCHv4 10/12] staging: android: ion: Remove ion_handle and ion_client

ion_handle was introduced as an abstraction to represent a reference to a buffer via an ion_client. As frameworks outside of Ion evolved, the dmabuf emerged as the preferred standard for use in the kernel. This has made the ion_handle an unnecessary abstraction and prone to race conditions.

[PATCHv4 03/12] staging: android: ion: Use CMA APIs directly

When CMA was first introduced, its primary use was for DMA allocation and the only way to get CMA memory was to call dma_alloc_coherent. This put Ion in an awkward position since there was no device structure readily available and setting one up messed up the coherency model. These days, CMA can

[PATCHv4 05/12] staging: android: ion: Break the ABI in the name of forward progress

Several of the Ion ioctls were designed in such a way that they necessitate compat ioctls. We're breaking a bunch of other ABIs and cleaning stuff up anyway so let's follow the ioctl guidelines and clean things up while everyone is busy converting things over anyway. As part of this, also remove

[PATCHv4 06/12] staging: android: ion: Get rid of ion_phys_addr_t

Once upon a time, phys_addr_t was not everywhere in the kernel. These days it is used enough places that having a separate Ion type doesn't make sense. Remove the extra type and just use phys_addr_t directly. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.h

[PATCHv4 02/12] cma: Introduce cma_for_each_area

Frameworks (e.g. Ion) may want to iterate over each possible CMA area to allow for enumeration. Introduce a function to allow a callback. Signed-off-by: Laura Abbott --- include/linux/cma.h | 2 ++ mm/cma.c| 14 ++ 2 files changed, 16 insertions(+)

[PATCHv4 04/12] staging: android: ion: Stop butchering the DMA address

Now that we have proper caching, stop setting the DMA address manually. It should be set after properly calling dma_map. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git

[PATCHv4 07/12] staging: android: ion: Collapse internal header files

Ion current has ion_priv.h and ion.h as header files. ion.h was intended to be used for public APIs but Ion never ended up really having anything public. Combine the two headers so there is only one internal header. Signed-off-by: Laura Abbott --- v4: minor cleanup suggested

[PATCHv4 01/12] cma: Store a name in the cma structure

Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it useful to have an explicit name attached to each region. Store the name in each CMA structure. Signed-off-by: Laura Abbott --- arch/powerpc/kvm/book3s_hv_builtin.c | 3 ++- drivers/base/dma-contiguous.c

[PATCHv4 00/12] Ion cleanup in preparation for moving out of staging

Hi, This is v4 of the series to cleanup to Ion. Greg took some of the patches that weren't CMA related already. There was a minor bisectability problem with the CMA APIs so this is a new version to address that. I also addressed some minor comments on the patch to collapse header files. Thanks,

[PATCH] staging: ks7010: Change capability field to __le16

Change capability field to __le16 in struct ap_info_t, struct link_ap_info_t, and struct local_ap_t. This fixes a sparse warning. Signed-off-by: Johan Svensson --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- drivers/staging/ks7010/ks_wlan.h | 2 +- 2 files

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

On 18/04/17 09:50 AM, Konrad Rzeszutek Wilk wrote: > I am not sure if you know, but you can add on each patch the respective > maintainer via 'CC'. That way you can have certain maintainers CCed only > on the subsystems they cover. You put it after (or before) your SoB and > git send-email

Re: 答复: Using ion memory for direct-io

On 04/17/2017 07:05 PM, Zengtao (B) wrote: > Hi Laura: > >> -邮件原件- >> 发件人: Laura Abbott [mailto:labb...@redhat.com] >> 发送时间: 2017年4月18日 0:14 >> 收件人: Zengtao (B) ; sumit.sem...@linaro.org >> 抄送: gre...@linuxfoundation.org; a...@android.com; >>

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

On Tue, Apr 18, 2017 at 09:42:20AM -0600, Logan Gunthorpe wrote: > > > On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote: > > Interesting that you didn't CC any of the maintainers. Could you > > do that in the future please? > > Please read the cover letter. The distribution list for the

Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues

On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote: > Parantheses are added for Macro argument, to avoid precedence issues. > > Signed-off-by: Rishiraj Manwatkar > --- > v1 -> v2: Added mailing list in cc. > v2 -> v3: Changed From: to be same as

Re: [PATCH 05/22] drm/i915: Make use of the new sg_map helper function

On 18/04/17 12:44 AM, Daniel Vetter wrote: > On Thu, Apr 13, 2017 at 04:05:18PM -0600, Logan Gunthorpe wrote: >> This is a single straightforward conversion from kmap to sg_map. >> >> Signed-off-by: Logan Gunthorpe > > Acked-by: Daniel Vetter > >

Re: [PATCH 0/4] staging: add ccree crypto driver

On Tue, Apr 18, 2017 at 06:29:22PM +0300, Gilad Ben-Yossef wrote: > On Tue, Apr 18, 2017 at 6:13 PM, Mark Rutland wrote: > > On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: > >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > >>

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote: > Interesting that you didn't CC any of the maintainers. Could you > do that in the future please? Please read the cover letter. The distribution list for the patchset would have been way too large to cc every maintainer (even as limited as it

Re: [PATCH 0/4] staging: add ccree crypto driver

On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first

Re: [PATCH 0/4] staging: add ccree crypto driver

Hi Mark, On Tue, Apr 18, 2017 at 6:13 PM, Mark Rutland wrote: > Hi, > > On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware >> accelerators. It is supported by a long lived series of out of

Re: [PATCH 0/4] staging: add ccree crypto driver

Hi, On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the

RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

> On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena > wrote: > > > > > >> On Mon, 6 Mar 2017 15:38:29 -0600 > >> Bjorn Helgaas wrote: > >> > >> > [+cc Hyper-V folks, -cc others] > >> > > >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

On Tue, Apr 18, 2017 at 02:13:59PM +, David Laight wrote: > From: Logan Gunthorpe > > Sent: 13 April 2017 23:05 > > Straightforward conversion to the new helper, except due to > > the lack of error path, we have to warn if unmapable memory > > is ever present in the sgl. Interesting that you

RE: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

From: Logan Gunthorpe > Sent: 13 April 2017 23:05 > Straightforward conversion to the new helper, except due to > the lack of error path, we have to warn if unmapable memory > is ever present in the sgl. > > Signed-off-by: Logan Gunthorpe > --- >

[PATCH 0/4] staging: add ccree crypto driver

Arm TrustZone CryptoCell 700 is a family of cryptographic hardware accelerators. It is supported by a long lived series of out of tree drivers, which I am now in the process of unifying and upstreaming. This is the first drop, supporting the new CryptoCell 712 REE. The code still needs some

Re: [PATCHv3 13/22] staging: android: ion: Use CMA APIs directly

On Mon, Apr 03, 2017 at 11:57:55AM -0700, Laura Abbott wrote: > When CMA was first introduced, its primary use was for DMA allocation > and the only way to get CMA memory was to call dma_alloc_coherent. This > put Ion in an awkward position since there was no device structure > readily available

Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena wrote: > > >> On Mon, 6 Mar 2017 15:38:29 -0600 >> Bjorn Helgaas wrote: >> >> > [+cc Hyper-V folks, -cc others] >> > >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote: >> > >

Re: [PATCH] staging : rtl8188eu : remove void function return

On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote: > On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote: > > kernel coding style doesn't allow the return statement > > in void function. > > > > Signed-off-by: surenderpolsani > > I need a "real" name here,

Re: [greybus-dev][PATCH 2/3] staging: greybus: Add Greybus netlink driver

On Sun, Mar 26, 2017 at 06:58:24PM +0200, Alexandre Bailon wrote: > Currently, the only hd controller supported by Greybus is the es2 > controller which only support is mainly a bridge between USB and UniPro. > In order to use Greybus on devices that do not support UniPro, > add a the Greybus

Re: [greybus-dev][PATCH 2/3] staging: greybus: Add Greybus netlink driver

On Sun, Mar 26, 2017 at 06:58:24PM +0200, Alexandre Bailon wrote: > Currently, the only hd controller supported by Greybus is the es2 > controller which only support is mainly a bridge between USB and UniPro. > In order to use Greybus on devices that do not support UniPro, > add a the Greybus

Re: [PATCH] staging : rtl8188eu : remove void function return

On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: surenderpolsani I need a "real" name here, and in the from line please. Use what you use to sign

Re: [PATCH] staging: rtl8192u: fix incorrect assignments

On Tue, Apr 11, 2017 at 10:19:08AM +0200, Jakub Jedelsky wrote: > Fixing warnings found by sparse on rtl8192u/ieee80211. > > drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: warning: > incorrect type in assignment (different base types) >

Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

On Thu, Apr 13, 2017 at 08:14:23AM +0530, Aditya Shankar wrote: > On Tue, 11 Apr 2017 19:35:46 +0200 > Greg KH wrote: > > > On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote: > > > Change the config packet format used in handle_set_wfi_drv_handler() > > >

Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote: > Change the config packet format used in handle_set_wfi_drv_handler() > to align the host driver with the new format used in the wilc firmware. > > The change updates the format in which the host driver provides the > firmware with

Re: [PATCH 15/15] staging: ks7010: rename SDIO files

On Tue, Apr 18, 2017 at 10:35:43AM +1000, Tobin C. Harding wrote: > Driver SDIO code is currently in files name ks7010_sdio.[ch]. These > names are not uniform with the rest of the files in this driver. This > driver only covers a single chipset, the file prefix does not add any > extra

Re: [PATCH v3] [media] staging: css2400: fix checkpatch error

On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote: > isp_capture_defs.h: clean up ERROR: Macros with complex values should be > enclosed in parentheses > > Signed-off-by: Haim Daniel > --- > .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h

RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

> On Mon, 6 Mar 2017 15:38:29 -0600 > Bjorn Helgaas wrote: > > > [+cc Hyper-V folks, -cc others] > > > > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

On Tue, 2017-04-18 at 10:33 +0200, Greg KH wrote: > On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote: > > Removed the usb_device_reset(), replace with call to usb_reset_device() > > directly. Plus it removes the confusing function name and addressed > > the checkpatch warning as well

Re: [PATCH v2] staging: lustre: Fix sparse endianness warnings cast to restricted __le64 and __le32

On Apr 15, 2017, at 18:48, skanda.kash...@gmail.com wrote: > > From: Skanda Guruanand > > The struct lu_dirpage elements in lustre_idl.h file are modified to > __le64 and __le32 types since the elements are always converted from > litte endian to processor native

Re: [lustre-devel] [PATCH RESEND v2] Staging: lustre cleanup macros in libcfs_private.h

On Apr 13, 2017, at 03:24, Craig Inches wrote: > > This resolves a checkpatch warning that "Single statement macros should > not use a do {} while (0) loop" by removing the loop and adjusting line > length accordingly. > > Signed-off-by: Craig Inches

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote: [...] > >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv, > >> >format.height, > >> infmt->height / 4, MAX_H_SRC, > >>

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi! > That self-referencing mux-controls property looks a bit superfluous: > > mux: video-multiplexer { > mux-controls = <>; > }; > > Other than that, I'm completely fine with splitting the compatible into > something like video-mux-gpio and video-mux-mmio and reusing

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote: > Removed the usb_device_reset(), replace with call to usb_reset_device() > directly. Plus it removes the confusing function name and addressed > the checkpatch warning as well by swap string in the dev_warn() call with > __func__

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

Removed the usb_device_reset(), replace with call to usb_reset_device() directly. Plus it removes the confusing function name and addressed the checkpatch warning as well by swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

Hi, This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time! linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: usb_device_reset drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Pavel, On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote: > Hi! > > > > The MUX framework is already in linux-next. Could you use that instead of > > > adding new driver + bindings that are not compliant with the MUX > > > framework? > > > I don't think it'd be much of a change in terms

Re: [PATCH 05/22] drm/i915: Make use of the new sg_map helper function

On Thu, Apr 13, 2017 at 04:05:18PM -0600, Logan Gunthorpe wrote: > This is a single straightforward conversion from kmap to sg_map. > > Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter Probably makes sense to merge through some other tree,