Re: [PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

Hi Dan, Thanks for your detailed review comments. On Tue, 20 Mar 2018 22:46:32 +0300 Dan Carpenter wrote: > On Tue, Mar 20, 2018 at 10:25:34PM +0530, Ajay Singh wrote: > > Added changes to free the allocated memory in scan() for error condition. > > Also added 'NULL'

[PATCH v3 2/2] staging: media: davinci_vpfe: add kfree() on goto err statement

It needs to free of allocated params value in the goto error statement. Signed-off-by: Ji-Hun Kim --- Changes since v2: - add kfree(params) on the error case of the function - rename unclear goto statement name - declare the params value at start of the function, so

[PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

There is no failure checking on the param value which will be allocated memory by kmalloc. Add a null pointer checking statement. Then goto error: and return -ENOMEM error code when kmalloc is failed. Signed-off-by: Ji-Hun Kim --- Changes since v1: - Return with -ENOMEM

Re: [v2 PATCH 5/5] Staging:rtl8723bs clean spaces

On Tue, 2018-03-20 at 20:26 +, Paul McQuade wrote: > Used checkpatch.pl to clean up spaces around if and for statements > to make it easier to read Perhaps the commit message can be made clearer. I think this is technically correct, but it would be nicer to describe these changes as moving

Re: [PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

Stefan Wahren writes: > The TODO list missed some issues before we can move the driver out of staging. > > Signed-off-by: Stefan Wahren > --- > drivers/staging/vc04_services/interface/vchi/TODO | 27 > +++ > 1 file changed,

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

Hi Lorenzo, Transparent SRIOV is exposing the NIC directly to the kernel via para-virtual device, unlike creating a netdev and associating it with the bond driver. Further descriptions here,

Re: [PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers

On Tue, Mar 20 2018, hariprasath.ela...@gmail.com wrote: > From: HariPrasath Elango > > Remove the reduntant owner initialization from this platform driver as > the platform_driver_register() takes care of it. > > Signed-off-by: HariPrasath Elango

Re: [PATCH 0/7] staging: mt7621: Checkpatch cleanup

On Tue, Mar 20 2018, Christian Lütke-Stetzkamp wrote: > This patchset fiexes errors, warnings and checks found by checkpatch. > > Christian Lütke-Stetzkamp (7): > staging: mt7621-dma: Fix Pointer Location > staging: mt7621-dma: Fix Spacing > staging: mt7621-dma: Fix open brace position >

Re: [PATCH 4/7] staging: mt7621-dma: Remove assignment in if

On Tue, Mar 20 2018, Christian Lütke-Stetzkamp wrote: > Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if > > Signed-off-by: Christian Lütke-Stetzkamp > --- > drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[PATCH PATCH net 4/4] hv_netvsc: common detach logic

Make common function for detaching internals of device during changes to MTU and RSS. Make sure no more packets are transmitted and all packets have been received before doing device teardown. Change the wait logic to be common and use usleep_range(). Changes transmit enabling logic so that

[PATCH PATCH net 0/4] hv_netvsc: fix races during shutdown and changes

This set of patches fixes issues identified by Vitaly Kuznetsov and Mohammed Gamal related to state changes in Hyper-v network driver. A lot of the issues are because setting up the netvsc device requires a second step (in work queue) to get all the sub-channels running. Stephen Hemminger (4):

[PATCH PATCH net 1/4] hv_netvsc: disable NAPI before channel close

This makes sure that no CPU is still process packets when the channel is closed. Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal") Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 8 1 file changed, 4 insertions(+), 4

[PATCH PATCH net 3/4] hv_netvsc: change GPAD teardown order on older versions

On older versions of Windows, the host ignores messages after vmbus channel is closed. Workaround this by doing what Windows does and send the teardown before close on older versions of NVSP protocol. Reported-by: Mohammed Gamal Fixes: 0cf737808ae7 ("hv_netvsc:

[PATCH PATCH net 2/4] hv_netvsc: use RCU to fix concurrent rx and queue changes

The receive processing may continue to happen while the internal network device state is in RCU grace period. The internal RNDIS structure is associated with the internal netvsc_device structure; both have the same RCU lifetime. Defer freeing all associated parts until after grace period. Fixes:

[PATCH 7/7] staging: mt7621-dma: Fixing parenthesis alignment

Fixes checkpatch check: PARENTHESIS_ALIGNMENT Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/mtk-hsdma.c | 29 + drivers/staging/mt7621-dma/ralink-gdma.c | 55 2 files changed, 43 insertions(+), 41

[PATCH 5/7] staging: mt7621-dma: Fix ident by space

Fixes checkpatch error: CODE_IDENT Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c

[PATCH 6/7] staging: mt7621-dma: Removing unnecessary braces

Fixes checkpatch warning: BRACES Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/mtk-hsdma.c | 4 ++-- drivers/staging/mt7621-dma/ralink-gdma.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 4/7] staging: mt7621-dma: Remove assignment in if

Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c

[PATCH 1/7] staging: mt7621-dma: Fix Pointer Location

Fixes checkpatch error: POINTER_LOCATION Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- drivers/staging/mt7621-dma/ralink-gdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/7] staging: mt7621-dma: Fix open brace position

Fixes checkpatch error: OPEN_BRACE Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/ralink-gdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c

[PATCH 0/7] staging: mt7621: Checkpatch cleanup

This patchset fiexes errors, warnings and checks found by checkpatch. Christian Lütke-Stetzkamp (7): staging: mt7621-dma: Fix Pointer Location staging: mt7621-dma: Fix Spacing staging: mt7621-dma: Fix open brace position staging: mt7621-dma: Remove assignment in if staging: mt7621-dma:

[PATCH 2/7] staging: mt7621-dma: Fix Spacing

Fixes checkpatch error: SPACING Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index

[PATCH] staging: pi433: cleanup local variable

Rename temporary local variable and add required blank line. Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[v2 PATCH 1/5] Staging:rtl8723bs static variables are always 0

C standard guarantees that: global and static variables will be implicitly initialized to 0 or NULL if no explicit initializer is given. Signed-off-by: Paul McQuade --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[v2 PATCH 4/5] Staging:rtl8723bs:Add blank line after declaration

missing a blank line after declaration checkpatch warnings. Issue found by checkpatch.pl Signed-off-by: Paul McQuade --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c

[v2 PATCH 5/5] Staging:rtl8723bs clean spaces

Used checkpatch.pl to clean up spaces around if and for statements to make it easier to read Signed-off-by: Paul McQuade --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[v2 PATCH 2/5] Staging:rtl8723bs clean up spaces

Used checkpatch.pl to clean up spaces around for statements to make it easier to read Signed-off-by: Paul McQuade --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[v2 PATCH 3/5] Staging:rtl8723bs Remove unnecessary braces

Remove unnecessary parentheses highlighted by checkpatch.pl Signed-off-by: Paul McQuade --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c

[PATCH 1/2] staging: vc04_services: Remove import of bcm2835-camera from TODO

The bcm2835-camera driver has already been imported. So remove it from the TODO. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchi/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/TODO

[PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

The TODO list missed some issues before we can move the driver out of staging. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchi/TODO | 27 +++ 1 file changed, 27 insertions(+) diff --git

Re: [PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

On Tue, Mar 20, 2018 at 10:25:34PM +0530, Ajay Singh wrote: > Added changes to free the allocated memory in scan() for error condition. > Also added 'NULL' check validation before accessing allocated memory. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

On Tue, Mar 20, 2018 at 05:56:15PM +, Sridhar Pitchai wrote: > Hi Lorenzo, > Are we good with the explanation? Can I send the patch with the > updated commit comments? Almost. [...] > Since we have the transparent SRIOV mode now, the short VF device name > is no longer needed. Can

Re: [PATCH v2 06/21] fpga: Remove depends on HAS_DMA in case of platform dependency

On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven wrote: Hi Geert, > Hi Alan, > > On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote: >> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven >> wrote: >> This essentially removes this

Re: [PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

Hi Lorenzo, Are we good with the explanation? Can I send the patch with the updated commit comments? Thanks Sridhar On 3/15/18, 11:24 AM, "Sridhar Pitchai" wrote: Apologies for not aligning my reply, I just realized after looking into the mail archive

[PATCH 2/3] staging: ks7010: replace some custom defines with the ones in uapi/linux/if_ether.h

This commit reviews some custom defines changing them for the globals defined in if_ether header file. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/eap_packet.h | 8 +--- drivers/staging/ks7010/ks_hostif.c | 8 2 files changed, 5

[PATCH 3/3] staging: ks7010: review custom bit defines using macros from bitops header file

This commit reviews custom definitions using custom bit macros changing them for the ones defined in the bitops header file. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/eap_packet.h | 33 - 1 file changed, 16

[PATCH 1/3] staging: ks7010: remove not used function signature ks_wlan_read_config_file

This commit removes definition of function ks_wlan_read_config_file which is not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan_ioctl.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 0/3] staging: ks7010: Reviews some custom stuff in favour of kernel definitions

This patch series removes some custom definitions included in the driver replacing them with the ones used in the linux kernel global headers. Not used function signature is removed also. Sergio Paracuellos (3): staging: ks7010: remove not used function signature ks_wlan_read_config_file

[PATCH 11/11] staging: wilc1000: remove line over 80 char warning in few functions

Remove 'line over 80 characters' issues found by checkpatch.pl script for following functions. disconnect() del_pmksa() wilc_create_wiphy() del_pmksa() Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 1 file changed,

[PATCH 10/11] staging: wilc1000: remove unused 'struct add_key_params'

Cleanup patch to remove unused struct data structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 09/11] staging: wilc1000: remove line over 80 char in cfg_connect_result()

Fix 'line over 80 characters' issues reported by checkpatch.pl script in cfg_connect_result(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git

[PATCH 07/11] staging: wilc1000: rename hAgingTimer to avoid camelCase issue

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 08/11] staging: wilc1000: fix line over 80 char issue in clear_shadow_scan()

Remove 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 06/11] staging: wilc1000: refactor mgmt_tx to fix line over 80 chars

Refactor mgmt_tx() to fix line over 80 characters issue. Split the function to avoid the checkpatch.pl warning. Returning the same error code in case of memory allocation failure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 187

[PATCH 03/11] staging: wilc1000: remove line over 80 char warnings in set_wiphy_params()

Fix 'line over 80 character' issue reported by checkpatch.pl script in set_wiphy_params(). Directly used the 'wiphy' pointer received as function argument instead of using 'priv->dev->ieee80211_ptr->wiphy'. Signed-off-by: Ajay Singh ---

[PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Fix 'line over 80 characters' issue found by checkpatch.pl script. Refactor and split the function to avoid the checkpatch reported issues. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 145 -- 1 file changed, 82

[PATCH 05/11] staging: wilc1000: rename WILC_WFI_p2p_rx & s32Freq to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +- drivers/staging/wilc1000/wilc_wlan.h

[PATCH 02/11] staging: wilc1000: removed unused global variables for gtk and ptk information

Removed the unnecessary global variables used to store gtk and ptk information. Key data stored in the params was never access using these global variables. Global variables given below are removed g_add_gtk_key_params; g_key_gtk_params; g_add_ptk_key_params; g_key_ptk_params; g_key_wep_params;

[PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

Added changes to free the allocated memory in scan() for error condition. Also added 'NULL' check validation before accessing allocated memory. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 62 +-- 1 file

[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

This patch series contains fixes to avoid checkpatch issues and removed unused code. Few patch contains changes related to NULL check and freeing of dynamically allocated memory. Ajay Singh (11): staging: wilc1000: refactor scan() to free kmalloc memory on failure cases staging:

Re: [PATCH] staging: lustre: Fix unneeded byte-ordering cast

On 20 March 2018 at 01:06, NeilBrown wrote: > On Sat, Mar 17 2018, Justin Skists wrote: > >> Fix sparse warning: >> >> CHECK drivers/staging//lustre/lnet/lnet/acceptor.c >> drivers/staging//lustre/lnet/lnet/acceptor.c:243:30: warning: cast to >> restricted __le32 >> >>

[PATCH v4 1/2] staging: ks7010: replace KS_WLAN_DEBUG with DEBUG preprocessor directive

This commit replaces custom KS_WLAN_DEBUG which is not being used anymore in favour of DEBUG which is the one included when debugging is enabled. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/Makefile | 1 - drivers/staging/ks7010/ks7010_sdio.c

[PATCH v4 0/2] staging: ks7010: clean up some debug stuff

This patch was in a previous patch series and only this one wasn't applied. So include here v4 which reviews and clean up some write only fields used in debug mode. First patch of v3 wasn't be modified. Just another extra patch has been added removing write only fields only used in debug. v3:

[PATCH v4 2/2] staging: ks7010: remove max_event_count field which is only being used in debug

This patch removes max_event_count field of sme_info structure which is a write only variable just being used for debug purposes. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 7 --- drivers/staging/ks7010/ks_wlan.h | 4 2

Re: [PATCH v3] staging: ks7010: replace KS_WLAN_DEBUG with DEBUG preprocessor directive

On Tue, Mar 20, 2018 at 02:48:50PM +0100, Sergio Paracuellos wrote: > This commit replaces custom KS_WLAN_DEBUG which is not being used anymore > in favour of DEBUG which is the one included when debugging is enabled. > > Signed-off-by: Sergio Paracuellos > --- >

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 59 +++-- 1 file changed, 30

[PATCH v3] staging: ks7010: replace KS_WLAN_DEBUG with DEBUG preprocessor directive

This commit replaces custom KS_WLAN_DEBUG which is not being used anymore in favour of DEBUG which is the one included when debugging is enabled. Signed-off-by: Sergio Paracuellos --- This patch was in a previous patch series and only this one wasn't applied. So

[PATCHv3] staging: wilc1000: replace switch statement by simple if condition

From: HariPrasath Elango In this case,there is only a single switch case statement.So replacing by a simple if condition Signed-off-by: HariPrasath Elango --- changes since v3: *rebase on latest code *missed revision

Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote: > On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.ela...@gmail.com wrote: > > From: HariPrasath Elango > > > > In this case,there is only a single switch case statement.So replacing > > by a simple if

[PATCH v2] staging: fsl-dpaa2/eth: Defer probing if no MC portal available

MC portals may not be available at the initial probing attempt due to dependencies on other modules. Check the return value of the MC portal allocation function and defer probing in case it's not available yet. For all other error cases the behaviour stays the same. Signed-off-by: Ioana

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

On Tue, Mar 20, 2018 at 02:05:49PM +0530, Pratik Jain wrote: > Refactored the function `XGIfb_search_refresh_rate` by removing a level > of `if...else` block nesting. Removed unnecessary parantheses. > > Signed-off-by: Pratik Jain > --- >

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 61 +++-- 1 file changed, 32

Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.ela...@gmail.com wrote: > From: HariPrasath Elango > > In this case,there is only a single switch case statement.So replacing > by a simple if condition > > Signed-off-by: HariPrasath Elango

[PATCHv2] staging: wilc1000: replace switch statement by simple if condition

From: HariPrasath Elango In this case,there is only a single switch case statement.So replacing by a simple if condition Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +--- 1 file

Re: [PATCH 5/7] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 02:29:51PM +0300, Dan Carpenter wrote: > On Tue, Mar 20, 2018 at 11:42:27AM +0530, wrote: > > On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote: > > > On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com > > > wrote: > > > > From: HariPrasath

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

You got a valid point about `++i` and `i++`. But I still feel that it is less complicated than previous one. I am explicitly saying(in first loop) that we are skipping some values to get to a specific index. Apart from that, we can avoid unncessary wrapping and indentation. Logic becomes much more

Re: [PATCH 5/7] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 11:42:27AM +0530, wrote: > On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote: > > On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com > > wrote: > > > From: HariPrasath Elango > > > > > > In this case,there is only

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

I'm trying to review this, but I feel like this makes it slightly more complicated for no reason. Why break it up into two loops? > - i++; > + ++i; These are equivalent, so you should default to accepting the original author's style. Otherwise the next person to touch

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

> To play it safe, you want to postpone the subsystem patches until the core > part has landed upstream. I will rebase and resubmit after v4.17-rc1. Thanks for the heads up. I'll wait for the rebased patch then and apply it after rc1 for 4.17. signature.asc Description: PGP signature

Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

Hi Madalin-cristian, On Mon, Mar 19, 2018 at 6:27 AM, Madalin-cristian Bucur wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Geert Uytterhoeven >> Remove dependencies on HAS_DMA where a

Re: [PATCH v2 14/21] mtd: Remove depends on HAS_DMA in case of platform dependency

Hi Boris, On Sun, Mar 18, 2018 at 11:04 PM, Boris Brezillon wrote: > On Fri, 16 Mar 2018 14:51:47 +0100 > Geert Uytterhoeven wrote: > >> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >> symbol that implies HAS_DMA,

Re: [PATCH v2 06/21] fpga: Remove depends on HAS_DMA in case of platform dependency

Hi Alan, On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote: > On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven > wrote: > This essentially removes this commit > > commit 1c8cb409491403036919dd1c6b45013dc8835a44 > Author: Sudip Mukherjee

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

Hi Wolfram, On Fri, Mar 16, 2018 at 10:23 PM, Wolfram Sang wrote: >> To avoid allmodconfig/allyesconfig regressions on NO_DMA=y platforms, >> this (drivers) series should be applied after the previous (core) >> series (but not many people may notice/care ;-) > > I still don't

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 63 +++-- 1 file changed, 33

[PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers

From: HariPrasath Elango Remove the reduntant owner initialization from this platform driver as the platform_driver_register() takes care of it. Signed-off-by: HariPrasath Elango --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 1 - 1

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

On 03/20/2018 02:41 AM, Nicolas Dufresne wrote: > Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit : >> Hi Hans, >> >> Thanks for taking the time to take a look at this. >> >>> This should definitely use the V4L2 API. I guess it could be added >>> to staging/media with a big fat TODO

Re: [PATCH] staging: android: ashmem: Fix possible deadlock in ashmem_ioctl

On Mon, Mar 19, 2018 at 03:16:51PM -0700, Joel Fernandes (Google) wrote: > On Tue, Feb 27, 2018 at 10:59 PM, Yisheng Xie wrote: > > ashmem_mutex may create a chain of dependencies like: > > > > CPU0CPU1 > > mmap syscall

Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.

On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote: > There is no reason for comment describing the BSSID check for loop > to be spaced so far to the right. Move it above the for loop. [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -844,7

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

Hi Jonathan, I broke out the {Direction}_{Type}_{Index}_{Modifier}_{Info_Mask} into separate columns to make sure I understand your instructions. Good way to check the results. Probably easier to copy and paste this table into a spreadsheet. Let me know if there is anything I got wrong.

Re: [PATCH 5/7] staging: wilc1000: replace switch statement by simple if condition

On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote: > On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com wrote: > > From: HariPrasath Elango > > > > In this case,there is only a single switch case statement.So replacing > > by a simple if