Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread arvindY
On Friday 27 April 2018 06:32 PM, Alex Elder wrote: On 04/27/2018 07:50 AM, Arvind Yadav wrote: On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked

[PATCH] staging: luster: llite: fix a potential missing-check bug when copying lumv

2018-04-27 Thread Wenwen Wang
In ll_dir_ioctl(), the object lumv3 is firstly copied from the user space using Its address, i.e., lumv1 = If the lmm_magic field of lumv3 is LOV_USER_MAGIV_V3, lumv3 will be modified by the second copy from the user space. The second copy is necessary, because the two versions (i.e.,

[PATCHv3] staging: wlan-ng: prism2sta: fixed indent coding style issues.

2018-04-27 Thread Efstratios Gavas
Fixed format/style issues found with checkpatch. No code changes. Corrected alignment of variables after open parenthesis and line breaks. Checkpatch now returns clean except for line over 80 char warnings. Signed-off-by: Efstratios Gavas --- v2(unlabled): changed title info v3:

Re: [PATCH] ion: Consider ion pool pages as indirectly reclaimable

2018-04-27 Thread Laura Abbott
On 04/27/2018 02:29 AM, vji...@codeaurora.org wrote: On 2018-04-27 10:40, vji...@codeaurora.org wrote: On 2018-04-25 21:17, Laura Abbott wrote: On 04/24/2018 08:43 PM, vji...@codeaurora.org wrote: From: Vijayanand Jitta An issue is observed where mallocs are failing

Re: [PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

2018-04-27 Thread Rob Herring
On Mon, Apr 23, 2018 at 02:47:43PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7.txt| 158 ++ > 1 file changed, 158 insertions(+) >

Re: [PATCH v4 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-04-27 Thread Greg KH
On Tue, Mar 27, 2018 at 02:13:33PM -0400, Roy Pledge wrote: > Move the NXP DPIO (Datapath I/O Driver) out of the > drivers/staging directory and into the drivers/soc/fsl directory. > > The DPIO driver enables access to Queue and Buffer Manager (QBMAN) > hardware on NXP DPAA2 devices. This is a

Re: [v2, 1/3] staging: fsl-dpaa2/eth: Add support for hardware timestamping

2018-04-27 Thread Greg Kroah-Hartman
On Thu, Apr 26, 2018 at 06:23:47PM +0800, Yangbo Lu wrote: > From: Ioana Radulescu > > Hardware timestamping is supported both on Rx and Tx paths. > On Rx, timestamping is enabled for all frames. On Tx, we > only instruct the hardware to timestamp the frames marked >

Re: [PATCH v3 5/9] staging: iio: ad2s1200: Add documentation for device tree binding

2018-04-27 Thread Rob Herring
On Mon, Apr 23, 2018 at 12:03:47AM +0200, David Veenstra wrote: > Add documentation for the added device tree bindings. > > Signed-off-by: David Veenstra > --- > Changes in v3: > - Documentation is added to Documentation/devicetree/bindings/iio/resolver >

[GIT PULL] Staging driver fixes for 4.17-rc3 - take 2

2018-04-27 Thread Greg KH
Now with the correct message: -- The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/

Re: [GIT PULL] Staging driver fixes for 4.17-rc3

2018-04-27 Thread Greg KH
On Fri, Apr 27, 2018 at 04:39:54PM +0200, Greg KH wrote: > The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: > > Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) > > are available in the Git repository at: > >

[GIT PULL] Staging driver fixes for 4.17-rc3

2018-04-27 Thread Greg KH
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.17-rc3 for you to fetch changes up to

[PATCH] staging: fsl-mc/dpio: Fix the error handling in probe()

2018-04-27 Thread Dan Carpenter
First of all devm_memremap() function returns an error pointer, it doesn't return NULL. And second we need to set the error code on these paths. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-driver.c

[PATCH 10/10] staging: ks7010: remove non sense comments in ks_hostif.c source file

2018-04-27 Thread Sergio Paracuellos
Comments which say the same as the code are not useful at all so just remove them. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 09/10] staging: ks7010: avoid two long lines in hostif_sme_mode_setup

2018-04-27 Thread Sergio Paracuellos
This commit avoid two checkpatch script complains about two long lines. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH 08/10] staging: ks7010: move two preprocessor definitions to ks_wlan.h

2018-04-27 Thread Sergio Paracuellos
In ks_wlan_translate_scan function there are two preprocessor definitions: - RSN_INFO_ELEM_ID - GENERIC_INFO_ELEM_ID These can be moved to common ks_wlan.h because they can be used in get_current_ap function instead of use hardcoded values. GENERIC_INFO_ELEM_ID has been renamed to

[PATCH 06/10] staging: ks7010: add new helpers to achieve mib set request and simplify code

2018-04-27 Thread Sergio Paracuellos
New three functions have been created to centralice and simplify calls related with set MIB requests: - hostif_mib_set_request_int - hostif_mib_set_request_bool - hostif_mib_set_request_ostring Using these in different calls simplify functions related with this mainly when types are

[PATCH 00/10] staging: ks7010: next cleanups

2018-04-27 Thread Sergio Paracuellos
Cleanups continues with this patch series. Main changes are related with MIB where some preprocessor stuff has been change in favour of an enumeration and some helper functions to increase code readability has been included. Other changes are minor cleanups in different part of code. Sergio

[PATCH 05/10] staging: ks7010: change parameter types and reorder them in hostif_mib_set_request

2018-04-27 Thread Sergio Paracuellos
This commit changes parameter types to use enum mib_attribute, enum mib_data_type and size_t for size instead of unsigned short. It also reorder them in a more sense way. Code is updated in different calls to use new parameters order using 'size' auxiliar local variables in some of them to improve

[PATCH 04/10] staging: ks7010: change some casts from uint8_t to u8 in ks_hostif header

2018-04-27 Thread Sergio Paracuellos
This commit changes some type cast in rate related preprocessor definitions included in ks_hostif header file to use preferred u8 type. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.h | 24 1 file changed, 12

[PATCH 07/10] staging: ks7010: use ether_addr_copy in get_current_ap

2018-04-27 Thread Sergio Paracuellos
Instead of use memcpy to copy ethernet addresses use ether_addr_copy created for that. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH 01/10] staging: ks7010: clean SME_MIC_FAILURE_REQUEST case in hostif_sme_execute

2018-04-27 Thread Sergio Paracuellos
This commit cleans code for the event SME_MIC_FAILURE_REQUEST changing if logic to handle invalid value first and using a local variable. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 23 ++- 1 file changed, 10

[PATCH 02/10] staging: ks7010: convert MIB preprocessor defs into an enum

2018-04-27 Thread Sergio Paracuellos
This commit just change some preprocessor definitions related with MIB data types into an enumeration which is much cleaner for this here. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.h | 21 - 1 file changed, 16

[PATCH 03/10] staging: ks7010: conver MIB attributes preprocessor defs into an enum

2018-04-27 Thread Sergio Paracuellos
This commit just change some preprocessor definitions related with MIB attributes into an enumeration which is much cleaner for this here. Also add kerneldoc to avoid long comment lines. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.h | 130

Re: [PATCH 16/16] staging: ks7010: refactor ks_wlan_translate_scan function

2018-04-27 Thread Sergio Paracuellos
On Fri, Apr 27, 2018 at 02:00:29PM +0300, Dan Carpenter wrote: > This really should have been broken up into several patches. I've > reviewed the first 15 patches and they were straight forward. Then I > postponed because it was just so grizzly to figure out what was going > on... Thanks for

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Alex Elder
On 04/27/2018 07:50 AM, Arvind Yadav wrote: > > > On Friday 27 April 2018 05:47 PM, Alex Elder wrote: >> On 04/27/2018 05:52 AM, Arvind Yadav wrote: >>> Replace the manual validity checks for the GPIO with the >>> gpio_is_valid(). >> I haven't looked through the code paths very closely, but I >>

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Arvind Yadav
On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked through the code paths very closely, but I think that get_named_gpio() might return -EPROBE_DEFER, which

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Alex Elder
On 04/27/2018 05:52 AM, Arvind Yadav wrote: > Replace the manual validity checks for the GPIO with the > gpio_is_valid(). I haven't looked through the code paths very closely, but I think that get_named_gpio() might return -EPROBE_DEFER, which would be something we want to pass to the caller. So

Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread kbuild test robot
://github.com/0day-ci/linux/commits/kys-linuxonhyperv-com/X86-Hyper-V-APIC-enlightenments/20180427-114416 config: i386-randconfig-s1-04271426 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Re: [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the hypercall input page

2018-04-27 Thread kbuild test robot
://github.com/0day-ci/linux/commits/kys-linuxonhyperv-com/X86-Hyper-V-APIC-enlightenments/20180427-114416 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> arch/x86/hyperv

Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread kbuild test robot
://github.com/0day-ci/linux/commits/kys-linuxonhyperv-com/X86-Hyper-V-APIC-enlightenments/20180427-114416 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> arch/x86/hype

Re: [PATCH 16/16] staging: ks7010: refactor ks_wlan_translate_scan function

2018-04-27 Thread Dan Carpenter
This really should have been broken up into several patches. I've reviewed the first 15 patches and they were straight forward. Then I postponed because it was just so grizzly to figure out what was going on... On Wed, Apr 25, 2018 at 04:01:55PM +0200, Sergio Paracuellos wrote: > This commit

RE: [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the hypercall input page

2018-04-27 Thread Thomas Gleixner
On Fri, 27 Apr 2018, KY Srinivasan wrote: > > > > -Original Message- > > From: Thomas Gleixner > > Sent: Thursday, April 26, 2018 3:24 PM > > To: KY Srinivasan > > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > >

[PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Arvind Yadav
Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav --- drivers/staging/greybus/arche-platform.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c

Re: [PATCH] ion: Consider ion pool pages as indirectly reclaimable

2018-04-27 Thread vjitta
On 2018-04-27 10:40, vji...@codeaurora.org wrote: On 2018-04-25 21:17, Laura Abbott wrote: On 04/24/2018 08:43 PM, vji...@codeaurora.org wrote: From: Vijayanand Jitta An issue is observed where mallocs are failing due to overcommit failure. The failure happens when

Re: [PATCH] Staging: wlan-ng: prism2sta: fixed indent coding style issues.

2018-04-27 Thread Greg Kroah-Hartman
On Fri, Apr 27, 2018 at 05:45:07AM +, Efstratios Gavas wrote: > Fixed coding style issues. > Signed-off-by: Efstratios Gavas We need a blank line before the signed-off-by: line in order to properly work. Also, please be much more specific in your changelog text as to what you

RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter > Sent: Thursday, April 26, 2018 2:32 PM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; >

RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread KY Srinivasan
> -Original Message- > From: Michael Kelley (EOSG) > Sent: Thursday, April 26, 2018 3:55 PM > To: KY Srinivasan ; x...@kernel.org; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >

RE: [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the hypercall input page

2018-04-27 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 26, 2018 3:24 PM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; >

Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread kbuild test robot
://github.com/0day-ci/linux/commits/kys-linuxonhyperv-com/X86-Hyper-V-APIC-enlightenments/20180427-114416 config: i386-randconfig-b0-04270034 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new

RE: [PATCH 3/5] X86: Hyper-V: Enhanced IPI enlightenment

2018-04-27 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 26, 2018 3:17 PM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; >

RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

2018-04-27 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 26, 2018 3:09 PM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; >