[PATCH 5/6] media: staging: atomisp: Fix potential NULL pointer dereference

2018-05-22 Thread Pankaj Bharadiya
In sh_css_config_input_network(), "stream" is being dereferenced before it is null checked. Fix it by moving the "stream" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 2/6] media: staging: atomisp: Remove useless if statement

2018-05-22 Thread Pankaj Bharadiya
Local variable "requeue" is assigned only once to a constant "false" value so "if(requeue)" condition will never be true. Thus remove it. Signed-off-by: Pankaj Bharadiya --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 14 -- 1

[PATCH 3/6] media: staging: atomisp: Remove useless "ifndef ISP2401"

2018-05-22 Thread Pankaj Bharadiya
In atomisp_csi2_set_ffmt(), there is no reason to have "#ifndef ISP2401" condition since code is identical in ifndef and else sections. Hence remove redudent checks. Signed-off-by: Pankaj Bharadiya ---

[PATCH 4/6] media: staging: atomisp: Fix potential NULL pointer dereference

2018-05-22 Thread Pankaj Bharadiya
In ia_css_pipe_get_primary_binarydesc(), "pipe" is being dereferenced before it is null checked. Fix it by moving the "pipe" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 1/6] media: staging: atomisp: remove redundent check

2018-05-22 Thread Pankaj Bharadiya
Assignment asd = >asd[i] can never be null hence remove redundent check. Signed-off-by: Pankaj Bharadiya --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 6/6] media: staging: atomisp: Fix potential NULL pointer dereference

2018-05-22 Thread Pankaj Bharadiya
In verify_copy_out_frame_format(), "pipe" is being dereferenced before it is null checked. Fix it by moving the "pipe" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 0/6] Fix issues reported by static analysis tool.

2018-05-22 Thread Pankaj Bharadiya
This patch series fixes some of the issues reported by static analysis tool. Pankaj Bharadiya (6): media: staging: atomisp: remove redundent check media: staging: atomisp: Remove useless if statement media: staging: atomisp: Remove useless "ifndef ISP2401" media: staging: atomisp: Fix

Re: [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

2018-05-22 Thread Vaibhav Agarwal
On Tue, May 22, 2018 at 2:03 PM Colin King wrote: > From: Colin Ian King > Trivial fix to spelling mistake in dev_err error message > Signed-off-by: Colin Ian King > --- > drivers/staging/greybus/audio_topology.c

[PATCH] PCI: hv: Fix a __local_bh_enable_ip warning in hv_compose_msi_msg()

2018-05-22 Thread Dexuan Cui
Commit de0aa7b2f97d ("PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()") uses local_bh_disable()/enable(), because hv_pci_onchannelcallback() can also run in tasklet context as the channel event callback. With CONFIG_PROVE_LOCKING=y in the latest mainline, or old kernels that don't have commit

RE: [PATCH] tools: hv: lsvmbus: convert to Python3

2018-05-22 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Tuesday, May 22, 2018 01:45 > > Use '2to3' tool to make lsvmbus work with both Python2 and Python3. > > Signed-off-by: Vitaly Kuznetsov > --- > tools/hv/lsvmbus | 12 ++-- > 1 file changed, 6 insertions(+), 6

[PATCH net-next] hv_netvsc: Add handlers for ethtool get/set msg level

2018-05-22 Thread Haiyang Zhang
From: Haiyang Zhang The handlers for ethtool get/set msg level are missing from netvsc. This patch adds them. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH v2 11/11] docs: fix broken references with multiple hints

2018-05-22 Thread Rob Herring
On Wed, May 09, 2018 at 10:18:54AM -0300, Mauro Carvalho Chehab wrote: > The script: > ./scripts/documentation-file-ref-check --fix-rst > > Gives multiple hints for broken references on some files. > Manually use the one that applies for some files. > > Signed-off-by: Mauro Carvalho Chehab

[PATCH] staging: wilc1000: fix spelling mistake: "Preamle" -> "Preamble"

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in netdev_err error message Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: rtlwifi: fix spelling mistake: "Platfoem" -> "Platform"

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in ODM_RT_TRACE message text Signed-off-by: Colin Ian King --- drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Rob Herring
On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7-csi.txt| 44

[PATCH v6 13/13] media: staging/imx: add i.MX7 entries to TODO file

2018-05-22 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v6 12/13] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++

[PATCH v6 10/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-22 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v6 09/13] ARM: dts: imx7s: add multiplexer controls

2018-05-22 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel ---

[PATCH v6 11/13] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-22 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva

[PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7-csi.txt| 44 ++ .../bindings/media/imx7-mipi-csi2.txt | 82 +++

[PATCH v6 06/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-22 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1134 2 files changed, 1135

[PATCH v6 08/13] ARM: dts: imx7s: add mipi phy power domain

2018-05-22 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v6 05/13] clk: imx7d: reset parent for mipi csi root

2018-05-22 Thread Rui Miguel Silva
To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Acked-by: Shawn Guo Signed-off-by:

[PATCH v6 04/13] clk: imx7d: fix mipi dphy div parent

2018-05-22 Thread Rui Miguel Silva
Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase

[PATCH v6 00/13] media: staging/imx7: add i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

[PATCH v6 03/13] media: staging/imx7: add imx7 CSI subdev driver

2018-05-22 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 +

[PATCH v6 02/13] media: staging/imx: rearrange group id to take in account IPU

2018-05-22 Thread Rui Miguel Silva
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with

[PATCH v6 01/13] media: staging/imx: refactor imx media device probe

2018-05-22 Thread Rui Miguel Silva
Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile

Re: [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

2018-05-22 Thread Mark Greer
On Tue, May 22, 2018 at 09:33:42AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King > --- > drivers/staging/greybus/audio_topology.c | 2 +- > 1

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Sakari Ailus
On Tue, May 22, 2018 at 02:19:21PM +0100, Rui Miguel Silva wrote: > Hi Sakari, > On Fri 18 May 2018 at 22:13, Sakari Ailus wrote: > > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > > > > > +endpoint node > > > > > +- > > > > > + > > > > > +- data-lanes:

[PATCH] staging: lustre: libcfs: add parens around macros args

2018-05-22 Thread Ivan Bornyakov
One may call 'CFS_FAIL_TIMEOUT(id, secs + 5);' and get unexpected result after macro substitution, viz., 'secs + 5' will turn into 'secs + 5 * 1000' Signed-off-by: Ivan Bornyakov --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 6 +++--- 1 file changed, 3

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Hi Sakari, On Fri 18 May 2018 at 22:13, Sakari Ailus wrote: On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > > +endpoint node > > +- > > + > > +- data-lanes: (required) an array specifying active > > physical > > MIPI-CSI2 > > + data input lanes and

[PATCH] Tools: hv: vss: fix loop device detection

2018-05-22 Thread Vitaly Kuznetsov
Commit ea81fdf0981d ("Tools: hv: vss: Skip freezing filesystems backed by loop") added skip for filesystems backed by loop device. However, it seems the detection of such cases is incomplete. It was found that with 'devicemapper' storage driver docker creates the following chain: NAME

[PATCH] tools: hv: lsvmbus: convert to Python3

2018-05-22 Thread Vitaly Kuznetsov
Use '2to3' tool to make lsvmbus work with both Python2 and Python3. Signed-off-by: Vitaly Kuznetsov --- tools/hv/lsvmbus | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus index 353e56768df8..c184aac33d5c

Re: [greybus-dev] [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

2018-05-22 Thread Viresh Kumar
On 22-05-18, 09:33, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King > --- > drivers/staging/greybus/audio_topology.c | 2 +- > 1 file changed, 1

[PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_err error message Signed-off-by: Colin Ian King --- drivers/staging/greybus/audio_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: mt7621-mmc: fix spelling mistake: "Illgal" -> "Illegal"

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to another spelling mistake in N_MSG message text Signed-off-by: Colin Ian King --- drivers/staging/mt7621-mmc/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] tools: hv: update lsvmbus to be compatible with python3

2018-05-22 Thread Olaf Hering
Python3 changed the way how 'print' works. Adjust the code to a syntax that is understood by python2 and python3. Signed-off-by: Olaf Hering --- v2: correct author tools/hv/lsvmbus | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v1] tools: hv: update lsvmbus to be compatible with python3

2018-05-22 Thread Olaf Hering
From: Olaf Hering Python3 changed the way how 'print' works. Adjust the code to a syntax that is understood by python2 and python3. Signed-off-by: Olaf Hering --- tools/hv/lsvmbus | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 1/9] staging: rtl8723bs: Rename 'Hal8723BPwrSeq.{c, h}' to 'hal_pwr_seq.*'.

2018-05-22 Thread Quytelda Kahja
Camel-case naming is discouraged int the linux kernel coding style. Rename these files using snake case, and update the makefile to use the new names. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/Makefile | 2 +-

[PATCH 3/9] staging: rtl8723bs: Rename 'Hal8723BPhyCfg.h' using snake case.

2018-05-22 Thread Quytelda Kahja
Camel-case is discouraged in the linux kernel coding style. Rename this header file using snake case instead. Signed-off-by: Quytelda Kahja --- .../rtl8723bs/include/{Hal8723BPhyCfg.h => hal_phy_cfg.h} | 0 drivers/staging/rtl8723bs/include/rtl8723b_hal.h

[PATCH 6/9] staging: rtl8723bs: Fix camel-case in 'struct rt_firmware'.

2018-05-22 Thread Quytelda Kahja
Change the members of 'struct rt_firmware' to be snake case instead of camel-case, per the kernel coding style guide. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c| 16 drivers/staging/rtl8723bs/include/rtl8723b_hal.h

[PATCH 7/9] staging: rtl8723bs: Fix spelling/grammar errors in comment.

2018-05-22 Thread Quytelda Kahja
Fix the spelling/grammar errors in the comment block describing the 'Function' member of 'struct rt_firmware_hdr'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 9/9] staging: rtl8723bs: Fix grammar error in comment.

2018-05-22 Thread Quytelda Kahja
Fix a grammatical error in the comment describing 'struct rt_firmware_hdr'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/9] staging: rtl8723bs: Clean up whitespace in 'rtl8723_hal.h'.

2018-05-22 Thread Quytelda Kahja
Make alignment and whitespace more consistent within the file 'rtl8723_hal.h' and with the kernel coding style guidelines. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/include/rtl8723b_hal.h | 261 ++ 1 file changed, 144 insertions(+), 117

[PATCH 5/9] staging: rtl8723bs: Fix camel-case in IS_FW_HEADER_EXIST_8723B().

2018-05-22 Thread Quytelda Kahja
Change the parameter of the macro to the snake case 'fw_hdr' instead of '_pFwHdr'. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 8/9] staging: rtl8723bs: Fix camel-case in 'struct rt_firmware_hdr'.

2018-05-22 Thread Quytelda Kahja
Replace camel-case member names with snake-case names per the linux kernel coding style guidelines. Signed-off-by: Quytelda Kahja --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 14 .../staging/rtl8723bs/include/rtl8723b_hal.h | 32 +-- 2