Re: [PATCH v2 6/6] staging: lustre: mdc: use large xattr buffers for old servers

2018-05-31 Thread NeilBrown
On Thu, May 31 2018, Dilger, Andreas wrote: > On May 31, 2018, at 18:54, Greg Kroah-Hartman > wrote: >> >> On Tue, May 29, 2018 at 10:21:45AM -0400, James Simmons wrote: >>> From: "John L. Hammond" >>> >>> Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR >>> with

Re: [PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl.

2018-05-31 Thread Joe Perches
On Fri, 2018-06-01 at 00:25 +0530, Sankalp Negi wrote: > diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c > b/drivers/staging/mt7621-spi/spi-mt7621.c [] > @@ -164,9 +165,8 @@ static inline int mt7621_spi_wait_till_ready(struct > spi_device *spi) > u32 status; > >

[PATCH 3/3] Clear audio read buffer status after each read

2018-05-31 Thread rkir
From: Joshua Lang The buffer_status field is interrupt updated. After every read request, the buffer_status read field should be reset so that on the next loop iteration we don't read a stale value and read data before the device is ready. Signed-off-by: “Joshua Lang” ---

RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

2018-05-31 Thread Dexuan Cui
> From: Michael Kelley (EOSG) > Sent: Thursday, May 31, 2018 09:41 > > > > IMO we can disable the per-channel tasklet to exclude the race: > > This way, when we exit the loop, we're sure hv_pci_onchannelcallback() can > > not run anymore. What do you think of this? > > I've stared at this and the

Re: [PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl.

2018-05-31 Thread NeilBrown
On Fri, Jun 01 2018, Sankalp Negi wrote: > This patch fixes following checkpatch.pl issues: > > WARNING : line over 80 characters > ERROR : code indent should use tabs where possible > WARNING : no spaces at the start of a line > ERROR : switch and case should be at the same indent > ERROR

[PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl.

2018-05-31 Thread Sankalp Negi
This patch fixes following checkpatch.pl issues: WARNING : line over 80 characters ERROR : code indent should use tabs where possible WARNING : no spaces at the start of a line ERROR : switch and case should be at the same indent ERROR : space required before the open parenthesis WARNING :

RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-31 Thread Sunil Muthuswamy
Hey K. Y, Currently, while reporting the panic message, we don't have a check for the extra MSR capability. It key's off of the existing crash MSR bit. There are no operational issues with it. But, after some discussions with John, for consistency purposes, the suggestion was to check for the

Re: [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-31 Thread David Miller
From: Petr Machata Date: Wed, 30 May 2018 02:55:34 +0200 > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced

Re: [PATCH v2 6/6] staging: lustre: mdc: use large xattr buffers for old servers

2018-05-31 Thread Dilger, Andreas
On May 31, 2018, at 18:54, Greg Kroah-Hartman wrote: > > On Tue, May 29, 2018 at 10:21:45AM -0400, James Simmons wrote: >> From: "John L. Hammond" >> >> Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR >> with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for >>

Re: [PATCH] staging: mt7621-eth: fix line over 80 char in mtk_set_link_ksettings()

2018-05-31 Thread Greg KH
On Sun, May 27, 2018 at 02:59:08PM -0300, Jefferson Capovilla wrote: > Fix 'line over 80 characters' issue found by checkpatch.pl script in > mtk_set_link_ksettings(). > > Signed-off-by: Jefferson Capovilla > --- > drivers/staging/mt7621-eth/ethtool.c | 3 ++- > 1 file changed, 2 insertions(+),

Re: [PATCH] staging: mt7621-eth: Remove extra line in mtk_set_link_ksettings()

2018-05-31 Thread Greg KH
On Sun, May 27, 2018 at 03:05:49PM -0300, Jefferson Capovilla wrote: > Fix extra line before end of function. > > Signed-off-by: Jefferson Capovilla > --- > drivers/staging/mt7621-eth/ethtool.c | 1 - > 1 file changed, 1 deletion(-) This patch also does not apply :(

Re: [PATCH v2 6/6] staging: lustre: mdc: use large xattr buffers for old servers

2018-05-31 Thread Greg Kroah-Hartman
On Tue, May 29, 2018 at 10:21:45AM -0400, James Simmons wrote: > From: "John L. Hammond" > > Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR > with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for > clients connected to these older MDTs, try to avoid sending

RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

2018-05-31 Thread Michael Kelley (EOSG)
> From: Dexuan Cui > Sent: Tuesday, May 29, 2018 12:58 PM > Subject: RE: [PATCH] PCI: hv: Do not wait forever on a device that has > disappeared > > > From: Michael Kelley (EOSG) > > Sent: Monday, May 28, 2018 17:19 > > > > While this patch solves the immediate problem of getting hung waiting >

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-31 Thread Gabriel Fedel
Hello Dan Em 28-05-2018 10:25, Dan Carpenter escreveu: The original code is fine. Just ignore checkpatch.pl. You added some kmalloc()s without a freeing the memory afterward. It's all way more complicated than it looks... Thank you for review. You are right. I followed the checkpatch.pl, but

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-31 Thread Gabriel Fedel
Hello Samuel, Em 26-05-2018 16:17, Samuel Thibault escreveu: Hello, Gabriel Fedel, le sam. 26 mai 2018 16:03:35 -0300, a ecrit: Replace simple_strtoul() with kstrtoul(), because simple_strtoul() is obsolete. Well, rather than putting again a dozen lines of code, if simple_strtoul is really

Re: [PATCH 01/13] staging: greybus: camera: no need to check debugfs return values

2018-05-31 Thread Johan Hovold
On Tue, May 29, 2018 at 04:29:35PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Clean up the greybus camera driver by

Re: [PATCH v2] staging: mt7621-gpio: update #interrupt-cells for the gpio node

2018-05-31 Thread Sergio Paracuellos
On Thu, May 31, 2018 at 03:27:46PM +1000, NeilBrown wrote: > On Wed, May 30 2018, Sergio Paracuellos wrote: > > > Most gpio chips have two cells for interrupts and this should be also. > > Set this property in the device tree accordly fixing this up. In order > > to make this working properly the

Re: [PATCH v2 03/21] Staging: gdm724x: use match_string() helper

2018-05-31 Thread Yisheng Xie
Hi Greg, On 2018/5/31 19:44, Greg Kroah-Hartman wrote: > On Thu, May 31, 2018 at 07:11:08PM +0800, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used instead of open coded variant. >> >> Cc: Greg Kroah-Hartman >> Cc: Quytelda Kahja >>

Re: [PATCH v2 03/21] Staging: gdm724x: use match_string() helper

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 07:11:08PM +0800, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant. > > Cc: Greg Kroah-Hartman > Cc: Quytelda Kahja > Cc: de...@driverdev.osuosl.org > Signed-off-by: Yisheng Xie >

[PATCH v2 03/21] Staging: gdm724x: use match_string() helper

2018-05-31 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Greg Kroah-Hartman Cc: Quytelda Kahja Cc: de...@driverdev.osuosl.org Signed-off-by: Yisheng Xie --- v2: - const DRIVER_STRING instead - per Andy

Re: [greybus-dev] [PATCH 01/13] staging: greybus: camera: no need to check debugfs return values

2018-05-31 Thread Greg Kroah-Hartman
On Wed, May 30, 2018 at 10:23:42AM +0530, Viresh Kumar wrote: > On 29-05-18, 16:29, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on