[PATCH 3/7] staging: mt7621-dts: allow gnubee to reboot cleanly.

2018-12-08 Thread NeilBrown
Since commit bb276262e88d ("mtd: spi-nor: only apply reset hacks to broken hardware"), we need to mark the spi-nor as "broken" for reboot to work. Note that nothing is actually broken here. The hardware-watchdog in the SoC isn't wired in a way that works, but then the board doesn't claim to suppor

[PATCH 5/7] staging: mt7621-mmc: add missing header.

2018-12-08 Thread NeilBrown
is sometimes included by other include files, and sometimes not, depending on config, particularly CONFIG_HIGHMEM. So include it explicitly rather than relying on implicit inclusion. Signed-off-by: NeilBrown --- drivers/staging/mt7621-mmc/sd.c |1 + 1 file changed, 1 insertion(+) diff --g

[PATCH 1/7] staging: mt7621-eth: set correct dma mask.

2018-12-08 Thread NeilBrown
Since commit f8c55dc6e828 ("MIPS: use generic dma noncoherent ops for simple noncoherent platforms") changed MIPS dma handling, the eth driver fails because the dma mask is set on the wrong 'struct device'. Move the setting to the correct struct device. Signed-off-by: NeilBrown --- drivers/stag

[PATCH 6/7] staging: mt7621-mmc: fix compile warnging: cmd_buf

2018-12-08 Thread NeilBrown
cmd_buf is only used when MT6575_SD_DEBUG is defined. So only declare it in that case. Signed-off-by: NeilBrown --- drivers/staging/mt7621-mmc/dbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c index 82

[PATCH 2/7] staging: mt7621-mmc: set correct dma mask.

2018-12-08 Thread NeilBrown
Since commit f8c55dc6e828 ("MIPS: use generic dma noncoherent ops for simple noncoherent platforms") changed MIPS dma handling, the mmc driver fails because it doesn't have a dma mask is set. So set the correct dma mask. Signed-off-by: NeilBrown --- drivers/staging/mt7621-mmc/sd.c |2 +- 1

[PATCH 4/7] staging: mt7621-eth: fix compile warning.

2018-12-08 Thread NeilBrown
This code generates a waring as PHY_GBIT_FEATURES is "long" but ->supported in "int". It looks likely that "PHY_1000BT_FEATURES" is the correct define to use - it is intended to be used with the ->features field. Signed-off-by: NeilBrown --- drivers/staging/mt7621-eth/mdio.c |2 +- 1 file c

[PATCH 7/7] staging: mt7621-dts: avoid warnings in pinctrl definitions

2018-12-08 Thread NeilBrown
The device-tree checking code sees node names "i2c" and "spi" in the pinctrl definition and thinks these are defining i2c or spi devices, and complains that they look wrong. So add a '0' to the end of each name (much like "uart" and "rgmii" have numbers at the end) to avoid the warning. Signed-o

[PATCH 0/7] various fixes for mt7621-* in staging.

2018-12-08 Thread NeilBrown
These fixes, together with some that others have posted recently, allow my to once again compile mainline linux for my gnubee-pc1, and have it work. Thanks, NeilBrown --- NeilBrown (7): staging: mt7621-eth: set correct dma mask. staging: mt7621-mmc: set correct dma mask. stagi

Re: [PATCH v3 0/2] staging: mt7621-spi: drop broken SPI modes

2018-12-08 Thread NeilBrown
On Thu, Dec 06 2018, Chuanhong Guo wrote: > This SPI controller seems to be tested on SPI flash only and SPI mode > 1/2/3 and full-duplex mode is broken. (Details are in commit messages > for the two patches.) > This patchset drops those broken modes. > > Changes since v2: > Send the two commit a

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Greg KH
On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote: > Parts of this work came from contributions of Alexandru Ardelean and > Dragos Bogdan, I and Gabriel would like to thank for the insights > provided by their previous patches. Maybe it would be the case to add > them as co-authors of

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
Parts of this work came from contributions of Alexandru Ardelean and Dragos Bogdan, I and Gabriel would like to thank for the insights provided by their previous patches. Maybe it would be the case to add them as co-authors of this patch set. We also wanted to thank Jhonatan Cameron for giving us t

[PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933

2018-12-08 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 26 +++ 1 file changed, 26 insertio

[PATCH 1/3] staging: iio: ad5933: change regulator binging for vref

2018-12-08 Thread Marcelo Schmitt
Set a single voltage regulator for all voltage references. Remove voltage reference value from default platafrom data struct. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- drivers/staging/iio/impedance-analyzer/ad5933.c | 14 ++

[PATCH 2/3] staging: iio: ad5933: use clock framework for clock reference

2018-12-08 Thread Marcelo Schmitt
Add the option to specify the external clock (MCLK) using the clock framework. Also remove the old platform data structure. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../staging/iio/impedance-analyzer/ad5933.c | 43 ++-

[PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
This series of patches change voltage regulator error handling for the ad5933. It also add an option to specify external clock reference using a clock framework and remove the old platform data structure. Finally it adds binding documentation for devicetree. Marcelo Schmitt (3): staging: iio: ad

Re: [PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code

2018-12-08 Thread Shreeya Patel
On Sat, 2018-12-08 at 16:12 +, Jonathan Cameron wrote: > On Sat, 8 Dec 2018 20:46:37 +0530 > Shreeya Patel wrote: > > > There is a function adt7316_irq_setup() where irq_type is being > > set. It would be good to move devm_request_threaded_irq() function > > and assignment of chip->config1 i

Re: [PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code

2018-12-08 Thread Jonathan Cameron
On Sat, 8 Dec 2018 20:46:37 +0530 Shreeya Patel wrote: > There is a function adt7316_irq_setup() where irq_type is being > set. It would be good to move devm_request_threaded_irq() function > and assignment of chip->config1 in adt7316_irq_setup() to unclutter > the code in probe function. > > S

Re: [PATCH] iio: dac: ad5686: fix bit shift read register

2018-12-08 Thread Jonathan Cameron
On Thu, 6 Dec 2018 15:53:15 +0200 Mircea Caprioru wrote: > This patch solves the register readback issue with the bit shift. When the > dac resolution was lower than the register size (ex. 12 bits out of 16 > bits) the readback value was not shifted with the difference in bits and > the value was

Re: [PATCH] iio:dac:ad5686: Add AD5310R support

2018-12-08 Thread Jonathan Cameron
On Thu, 6 Dec 2018 15:38:30 +0200 Mircea Caprioru wrote: > From: Stefan Popa > > The AD5310R is a single channel DAC with 10-bit precision, which is > part of the same family as AD5311R, except that it uses the spi interface > instead of i2c. The device has a built-in 2.5V reference which is en

Re: [PATCH] Revert "Staging: iio: adt7316: Add an extra check for 'ret' equals to 0"

2018-12-08 Thread Shreeya Patel
On Sat, 2018-12-08 at 11:17 +, Jonathan Cameron wrote: > On Sat, 08 Dec 2018 00:07:21 +0530 > Shreeya Patel wrote: > > > On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote: > > > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote: > > > > On Thu, Dec 06, 2018 at 01:25:55AM +0

Re: [PATCH 2/2] staging: iio: adc: ad7192: Add clock output option

2018-12-08 Thread Jonathan Cameron
On Thu, 6 Dec 2018 11:10:52 +0200 Mircea Caprioru wrote: > When using the internal clock the device has an option in which the clock > output is available on MCLK2 pin. This patch adds a dt binding for enabling > this property. > > Signed-off-by: Mircea Caprioru I'd rather we looked at getting

Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference

2018-12-08 Thread Jonathan Cameron
On Thu, 6 Dec 2018 11:10:51 +0200 Mircea Caprioru wrote: > This patch adds a clock to the state structure of ad7192 for getting the > external clock frequency. This modifications is in accordance with clock > framework dt bindings documentation. > > Signed-off-by: Mircea Caprioru +cc Rob and t

[PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code

2018-12-08 Thread Shreeya Patel
There is a function adt7316_irq_setup() where irq_type is being set. It would be good to move devm_request_threaded_irq() function and assignment of chip->config1 in adt7316_irq_setup() to unclutter the code in probe function. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c

[PATCH v3 0/3] Remove platform data and introduce DT bindings

2018-12-08 Thread Shreeya Patel
This patchset introduces the use of device tree bindings for setting up the irq_type and removes the usage of platform data. Also, code related to interrupt is moved to the new function adt7316_setup_irq to unclutter the code in adt7316_probe(). A dev_err() message is added to give more details abo

[PATCH v3 1/3] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-12-08 Thread Shreeya Patel
ADT7316 driver no more uses platform data and hence use device tree data instead of platform data for assigning irq_type field. Switch case figures out the type of irq and if it's the default case then assign the default value to the irq_type i.e. irq_type = IRQF_TRIGGER_LOW All this is implemented

[PATCH v3 3/3] Staging: iio: adt7316: Add a dev_err() message

2018-12-08 Thread Shreeya Patel
Add a dev_err() message "failed to request irq" for describing what went wrong when an error contition is statisfied. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c

Re: [PATCH] Revert "Staging: iio: adt7316: Add an extra check for 'ret' equals to 0"

2018-12-08 Thread Jonathan Cameron
On Sat, 08 Dec 2018 00:07:21 +0530 Shreeya Patel wrote: > On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote: > > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote: > > > On Thu, Dec 06, 2018 at 01:25:55AM +0530, Shreeya Patel wrote: > > > > On Tue, 2018-12-04 at 18:49 -0700,

Re: [PATCH] staging: iio: ad5933: add binding doc for ad5933

2018-12-08 Thread Jonathan Cameron
On Sun, 02 Dec 2018 15:22:15 -0800 Joe Perches wrote: > On Mon, 2018-12-03 at 00:20 +0530, Himanshu Jha wrote: > > On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote: > > > Add a devicetree documentation for the ad5933 and ad5934 impedance > > > converter, network analyzer. > > >

[PATCH -next] media: rockchip/vpu: remove set but not used variables 'luma_qtable_p, chroma_qtable_p'

2018-12-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:101:10: warning: variable 'chroma_qtable_p' set but not used [-Wunused-but-set-variable] drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:100:10: warning: variable 'luma_qtable_p