Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Scally
Hi Dan -  thanks for all your comments. Sorry it took a while to get to yours. On 17/09/2020 10:34, Dan Carpenter wrote: > On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: >> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c >> b/drivers/media/pci/intel/ipu3/ipu3-cio2.c >>

[PATCH] staging/emxx_udc: fix indenting issue on a couple of statements

2020-09-18 Thread Colin King
From: Colin Ian King A couple of statements are indented too deeply, remove the extraneous tabs. Signed-off-by: Colin Ian King --- drivers/staging/emxx_udc/emxx_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH] staging: spmi: hisi-spmi-controller: Use devm_ version of ioremap().

2020-09-18 Thread Dan Carpenter
The ioremap() was never unmapped in the probe error handling or in the remove function. The fix is to use the devm_ioremap() function so it gets cleaned up automatically. Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver") Signed-off-by: Dan Carpenter ---

Re: [PATCH v5 2/9] media: staging: dt-bindings: rkisp1: drop i2c unit address

2020-09-18 Thread Rob Herring
On Wed, Jul 22, 2020 at 9:55 AM Helen Koike wrote: > > Add missing required items in Rockchip ISP1 dt-bindings example for > a complete i2c node. > Drop unit address to Fix error: > /example-0/parent/i2c@ff16: node has a unit name, but no reg or ranges > property > Remove unecessary fields

Re: [PATCH v5 4/9] media: staging: dt-bindings: rkisp1: drop parent unit address

2020-09-18 Thread Rob Herring
On Wed, Jul 22, 2020 at 9:56 AM Helen Koike wrote: > > Fix the following error found with make ARCH=arm64 dt_binding_check: > > Documentation/devicetree/bindings/media/rockchip-isp1.example.dts:24.27-101.11: > Warning (unit_address_vs_reg): /example-0/parent@0: node has a unit name, but > no reg

Re: [PATCH v5 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes

2020-09-18 Thread Rob Herring
On Wed, Jul 22, 2020 at 9:55 AM Helen Koike wrote: > > Add missing required nodes in json-schema yaml file for > Rockchip ISP1 dt-bindings. > > Signed-off-by: Helen Koike > Acked-by: Rob Herring > --- > > Changes in v2: > - New patch in the series > --- >

Re: [PATCH v2] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-18 Thread Ezequiel Garcia
Hi Nicolas, On Thu, 2020-09-17 at 20:43 -0400, Nicolas Dufresne wrote: > Le jeudi 17 septembre 2020 à 20:27 -0400, Nicolas Dufresne a écrit : > > As per spec, the CAPTURE resolution should be automatically set based on > > the OTUPUT resolution. This patch properly propagate width/height to the >

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Andy Shevchenko
On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote: > On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > > > On 17/09/2020 11:33, Sakari Ailus wrote: > > > > a module and not enlarge everyone's kernel, and

You have been selected as a winner for Master Card Lottery promo 2020

2020-09-18 Thread vicky Bindra
MasterCard®/ MegaLottery MasterCard®Office: 2000 Purchase Street Purchase, NY 10577 U.S.A. PRESIDENT & CEO: Ajay Banga MASTERCARD®INTERNATIONAL LOTTERY PROMO TICKET NUMBER: 0816 5701 470 REGISTRATION NO: 9027640 INSURANCE NO: MSTC4114TAX CLEARANCE NO: 28456 AMOUNT WON: $9,500, 000.00 Dear

[PATCH v17 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-09-18 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. Signed-off-by: Xin Ji Reported-by: kernel test robot Reported-by: Dan Carpenter --- drivers/gpu/drm/bridge/analogix/Kconfig |9 +

[PATCH v17 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter DT schema

2020-09-18 Thread Xin Ji
anx7625: MIPI to DP transmitter DT schema Signed-off-by: Xin Ji Reviewed-by: Rob Herring --- .../bindings/display/bridge/analogix,anx7625.yaml | 95 ++ 1 file changed, 95 insertions(+) create mode 100644

Re: [PATCH v16 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-09-18 Thread Xin Ji
On Fri, Sep 18, 2020 at 11:45:34AM +0300, Dan Carpenter wrote: > Hi Xin, > > url: > https://github.com/0day-ci/linux/commits/Xin-Ji/Add-initial-support-for-slimport-anx7625/20200917-163238 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >

[PATCH v17 0/2] Add initial support for slimport anx7625

2020-09-18 Thread Xin Ji
Hi all, The following series add support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the v17 version, any mistakes, please let me know, I will fix it in the next series. Change history: v17: Fix comments from

[PATCH 0/5] staging: vchiq: stop using compat_alloc_user_space

2020-09-18 Thread Arnd Bergmann
This driver is one of only a few remaining files using compat_alloc_user_space() and copy_in_user() to implement the compat_ioctl handlers. Change it to be more like the other drivers, calling the underlying implementation directly, which is generally simpler and less error-prone. This is only

[PATCH 5/5] staging: vchiq: convert compat await_completion

2020-09-18 Thread Arnd Bergmann
Split out the ioctl implementation for VCHIQ_IOC_QUEUE_BULK_TRANSMIT into a separate function so it can be shared with the compat implementation. This one is the trickiest conversion, as the compat implementation is already quite different from the native one. By using a common handler, the

[PATCH 2/5] staging: vchiq: convert compat create_service

2020-09-18 Thread Arnd Bergmann
Split out the ioctl implementation for VCHIQ_IOC_CREATE_SERVICE into a separate function so it can be shared with the compat implementation. Signed-off-by: Arnd Bergmann --- .../interface/vchiq_arm/vchiq_arm.c | 189 +- 1 file changed, 89 insertions(+), 100

[PATCH 1/5] staging: vchiq: rework compat handling

2020-09-18 Thread Arnd Bergmann
The compat handlers for VCHIQ_IOC_QUEUE_MESSAGE32 and VCHIQ_IOC_GET_CONFIG32 can simply call the underlying implementations that are already separate functions rather than using copy_in_user to simulate the native 64-bit interface for the full ioctl handler. vchiq_ioc_queue_message gets a small

[PATCH 3/5] staging: vchiq: convert compat dequeue_message

2020-09-18 Thread Arnd Bergmann
Split out the ioctl implementation for VCHIQ_IOC_DEQUEUE_MESSAGE into a separate function so it can be shared with the compat implementation. Signed-off-by: Arnd Bergmann --- .../interface/vchiq_arm/vchiq_arm.c | 180 +- 1 file changed, 92 insertions(+), 88

[PATCH 4/5] staging: vchiq: convert compat bulk transfer

2020-09-18 Thread Arnd Bergmann
Split out the ioctl implementation for VCHIQ_IOC_QUEUE_BULK_TRANSMIT into a separate function so it can be shared with the compat implementation. Here, the input data is converted separately in the compat handler, while the output data is passed as a __user pointer to thec

Re: [PATCH v16 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-09-18 Thread Dan Carpenter
Hi Xin, url: https://github.com/0day-ci/linux/commits/Xin-Ji/Add-initial-support-for-slimport-anx7625/20200917-163238 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5925fa68fe8244651b3f78a88c4af99190a88f0d config: mips-randconfig-m031-20200917 (attached as

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Carpenter
On Fri, Sep 18, 2020 at 09:40:43AM +0300, Sakari Ailus wrote: > Hi Dan, > > On Thu, Sep 17, 2020 at 01:49:41PM +0300, Dan Carpenter wrote: > > On Thu, Sep 17, 2020 at 01:33:43PM +0300, Sakari Ailus wrote: > > > > +static int connect_supported_devices(void) > > > > +{ > > > > + struct

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Scally
Ah, shoot - good spot, thanks On 18/09/2020 09:03, Dan Carpenter wrote: > I ran Smatch over the code and it spotted an off by one. > > On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: >> +#define MAX_CONNECTED_DEVICES 4 >> +#define SWNODE_SENSOR_HID

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Carpenter
I ran Smatch over the code and it spotted an off by one. On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: > +#define MAX_CONNECTED_DEVICES4 > +#define SWNODE_SENSOR_HID0 > +#define SWNODE_SENSOR_PORT 1 > +#define

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Sakari Ailus
Hi Andy, On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote: > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > > On 17/09/2020 11:33, Sakari Ailus wrote: > > > a module and not enlarge everyone's kernel, and the initialisation would > > > at > > > the same time take

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Sakari Ailus
Hi Dan, On Thu, Sep 17, 2020 at 01:49:41PM +0300, Dan Carpenter wrote: > On Thu, Sep 17, 2020 at 01:33:43PM +0300, Sakari Ailus wrote: > > > +static int connect_supported_devices(void) > > > +{ > > > + struct acpi_device *adev; > > > + struct device *dev; > > > + struct sensor_bios_data ssdb; > >