Re: [PATCH net-next] hyperv: Change the receive buffer size for legacy hosts

2014-03-10 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Sun, 9 Mar 2014 16:10:59 -0700 Due to a bug in the Hyper-V host verion 2008R2, we need to use a slightly smaller receive buffer size, otherwise the buffer will not be accepted by the legacy hosts. Signed-off-by: Haiyang Zhang

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread David Miller
From: KY Srinivasan k...@microsoft.com Date: Sat, 8 Mar 2014 10:27:54 + len would have gotten decremented prior to the check and in the case we are talking about, len would be zero and so j would not get incremented. You are correct, this is the part of the logic in this case which I

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 21:32:36 -0800 +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, + struct hv_page_buffer *pb) +{ + int j = 0; + + /* Deal with compund pages by ignoring unused part + * of the

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: KY Srinivasan k...@microsoft.com Date: Sat, 8 Mar 2014 04:12:01 + -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Saturday, March 8, 2014 3:18 AM To: KY Srinivasan Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; de

Re: [PATCH 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:05 -0800 @@ -140,21 +140,125 @@ static void netvsc_xmit_completion(void *context) dev_kfree_skb_any(skb); } +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, + struct

Re: [PATCH 2/6] Drivers: net: hyperv: Cleanup the send path

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:06 -0800 In preparation for enabling offloads, cleanup the send path. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Reviewed-by: Haiyang Zhang haiya...@microsoft.com --- drivers/net/hyperv/hyperv_net.h |7

Re: [PATCH 4/6] Drivers: net: hyperv: Enable receive side IP checksum offload

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:08 -0800 + /* + * We only look at the IP checksum here. + * Should we be dropping the packet if checksum + * failed? How do we deal with other checksums - TCP/UDP? +

Re: [PATCH 3/6] Drivers: net: hyperv: Enable offloads on the host

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:07 -0800 + /* + * can't put_rndis_request, since we may still receive a + * send-completion. + */ Please fix the formatting of this comment. + /* + * Turn on

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:09 -0800 +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4, + bool *is_tcp, bool *is_udp, u32 *trans_off) +{ Returning so many values like this is awkward, at best. Why not return a

Re: [PATCH 6/6] Drivers: net: hyperv: Enable large send offload

2014-03-06 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 03:13:10 -0800 + ppi = init_ppi_data(rndis_msg, NDIS_LSO_PPI_SIZE, + TCP_LARGESEND_PKTINFO); This is not indented properly, TCP_LARGESEND_PKTINFO); should start at the first column after the

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
From: KY Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 20:29:13 + -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, March 7, 2014 1:04 AM To: KY Srinivasan Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; de

Re: [PATCH net-next,v2] hyperv: Move state setting for link query

2014-03-05 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 4 Mar 2014 14:11:06 -0800 It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel-inbound_lock. This prevents pentential race between

Re: [PATCH net-next] hyperv: Add latest NetVSP versions to auto negotiation

2014-02-19 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 18 Feb 2014 12:28:54 -0800 + u32 ver_list[] = {NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2, + NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5}; Please put a space after { and before }. + int i, num_ver = 4; /*

Re: [PATCH net-next,v2] hyperv: Add latest NetVSP versions to auto negotiation

2014-02-19 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 19 Feb 2014 15:49:45 -0800 It auto negotiates the highest NetVSP version supported by both guest and host. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com Applied, thanks.

Re: [PATCH 0/3] Drivers: net: hyperv: Cleanup the hyper-V networking code

2014-02-17 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Sun, 16 Feb 2014 16:38:03 -0800 Get rid of some unnecessary code and some general cleanup. K. Y. Srinivasan (3): Drivers: net: hyperv: Get rid of the rndis_filter_packet structure Drivers: net: hyperv: Cleanup the receive path Drivers:

Re: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-13 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 12 Feb 2014 16:54:27 -0800 Without this patch, the cat /sys/class/net/ethN/operstate shows unknown, and ethtool ethN shows Link detected: yes, when VM boots up with or without vNIC connected. This patch fixed the problem.

Re: [PATCH 0/2] Drivers: net: hyperv: Cleanup the recive path

2014-02-01 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Fri, 31 Jan 2014 08:24:38 -0800 Some minor cleanup of the receive path. Get rid of unnecessary indirection as well as unnecessary re-establishment of state. It is not appropriate to submit cleanups at this time. Please wait until the net-next

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Mon, 27 Jan 2014 15:30:54 +0800 Call netif_carrier_on() after register_device(). Otherwise it won't work since the device was still in NETREG_UNINITIALIZED state. Fixes a68f9614614749727286f675d15f1e09d13cb54a (hyperv: Fix race between probe and

Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Mon, 27 Jan 2014 21:47:43 + So, could this patch be taken first? You always need to resend patches that I've originally rejected and you've made arguments for. ___ devel mailing list

Re: [PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM

2014-01-15 Thread David Miller
All 7 patches applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-14 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Thu, 9 Jan 2014 14:24:47 -0800 This will allow us to use bigger receive buffer, and prevent allocation failure due to fragmented memory. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com

Re: [PATCH net] hyperv: Fix race between probe and open calls

2013-12-21 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Fri, 20 Dec 2013 16:52:31 -0800 Moving the register_netdev to the end of probe to prevent possible open call happens before NetVSP is connected. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan

Re: [PATCH net-next] hyperv: Add support for Virtual Receive Side Scaling (vRSS)

2013-12-19 Thread David Miller
From: Tom Herbert therb...@google.com Date: Thu, 19 Dec 2013 13:43:06 -0800 + u32 v, r; + int off, rem; + + off = idx / 8; + rem = idx % 8; + + v = (((unsigned int)key[off]) 24) + + (((unsigned int)key[off + 1]) 16) + + (((unsigned

Re: [PATCH net] netvsc: don't flush peers notifying work during setting mtu

2013-12-17 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Fri, 13 Dec 2013 17:21:27 +0800 There's a possible deadlock if we flush the peers notifying work during setting mtu: ... Reported-by: Yaju Cao ya...@redhat.com Tested-by: Yaju Cao ya...@redhat.com Cc: K. Y. Srinivasan k...@microsoft.com Cc:

Re: [PATCH] net:drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-07 Thread David Miller
From: Duan Jiong duanj.f...@cn.fujitsu.com Date: Wed, 6 Nov 2013 15:58:13 +0800 This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong duanj.f...@cn.fujitsu.com Applied. ___

Re: [PATCH] smsc: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-07 Thread David Miller
From: Duan Jiong duanj.f...@cn.fujitsu.com Date: Wed, 6 Nov 2013 15:57:17 +0800 This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong duanj.f...@cn.fujitsu.com Applied. ___

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-09-03 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 03 Sep 2013 09:38:10 +0200 But it doesn't look like it ended up in net-next? Or am I missing something (again)? I forgot to push it out from my workstation before going away for the holiday weekend, this has now been fixed :-)

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

2013-08-31 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 30 Aug 2013 18:08:43 +0200 Copying the dev_addr from a parent device is an operation common to a number of drivers. The addr_assign_type should be updated accordingly, either by reusing the value from the source device or explicitly indicating that

<    1   2   3   4