Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

Dan Carpenter writes: > On Sat, Oct 06, 2018 at 12:18:38PM +0200, Stefan Wahren wrote: >> Hi Tuomas, >> >> > Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 >> > geschrieben: >> > >> > >> > Drop various pieces of dead code from here and there to get rid of >> > the remaining users of

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

Stefan Wahren writes: > Hi Tuomas, > >> Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 >> geschrieben: >> >> >> Drop various pieces of dead code from here and there to get rid of >> the remaining users of VCHI_CONNECTION_T. After that we get to drop >> entire header files worth of unused

Re: [PATCH 1/6] staging: vc04_services: no need to check debugfs return values

debugfs > calls. This ends up removing a number of lines of code that are not > needed. This series is: Reviewed-by: Eric Anholt Thanks for the cleanups! signature.asc Description: PGP signature ___ devel mailing list de...@linuxd

Re: [PATCH 04/13] staging: vc04_services: no need to check debugfs return values

debugfs > calls. This ends up removing a number of lines of code that are not > needed. > > Cc: Eric Anholt > Cc: Stefan Wahren > Cc: Kees Cook > Cc: Dan Carpenter > Cc: Arnd Bergmann > Cc: Keerthi Reddy > Cc: linux-rpi-ker...@lists.infradead.org > Cc: l

Re: [PATCH] staging: bcm2835-camera: Replace open-coded idr with a struct idr.

Dan Carpenter <dan.carpen...@oracle.com> writes: > On Thu, May 10, 2018 at 04:31:07PM -0700, Eric Anholt wrote: >> @@ -258,32 +181,40 @@ get_msg_context(struct vchiq_mmal_instance *instance) >> if (!msg_context) >> return ERR_PTR(-ENOMEM); >>

[PATCH] staging: bcm2835-camera: Fix module section mismatch warnings.

Noticed by Stephen Rothwell in -next. Signed-off-by: Eric Anholt <e...@anholt.net> Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.") Cc: Stephen Rothwell <s...@canb.auug.org.au> --- Note: only compile tested here. .../staging/vc04_s

[PATCH v2] staging: bcm2835-camera: Replace open-coded idr with a struct idr.

We just need some integer handles that can map back to our message struct when we're handling a reply, which struct idr is perfect for. v2: Fix error check to look at the right variable. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../vc04_services/bcm2835-camera/mmal-vchiq.c

Re: [PATCH] staging: bcm2835-camera: Replace open-coded idr with a struct idr.

Stefan Wahren <stefan.wah...@i2se.com> writes: > Hi Eric, > >> Eric Anholt <e...@anholt.net> hat am 11. Mai 2018 um 01:31 geschrieben: >> >> >> We just need some integer handles that can map back to our message >> struct when we'

[PATCH] staging: bcm2835-camera: Replace open-coded idr with a struct idr.

We just need some integer handles that can map back to our message struct when we're handling a reply, which struct idr is perfect for. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 135 -- 1 file changed, 31 insertions(+

Re: [PATCH 12/12] staging: bcm2835-camera: Fix identation of tables

Eric Anholt <e...@anholt.net> writes: > From: Dave Stevenson <dave.steven...@raspberrypi.org> > > As requested by Mauro Carvalho Chehab in review. > > Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> > Signed-off-by: Eric Anholt <e...@anholt

[PATCH 01/15] staging/vc04_services: Register a platform device for the camera driver.

We had the camera driver set up in a module_init function, but that meant that the camera driver would fail to load if it was initialized before VCHI. By attaching to this platform_device, it can get a defined load order. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../s

[PATCH 15/15] staging: bcm2835: Fix mmal_port_parameter_get() signed/unsigned warnings.

The arg is a u32 *, so switch over to that in our declarations. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-

[PATCH 03/15] staging: bcm2835-camera: Skip ISP pass to eliminate padding.

notion of that requirement. v2: Changes by anholt from the downstream driver: Flag two more planar formats as needing padding removal, and remove broken userspace workaround. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> ---

[PATCH 09/15] staging: bcm2835-camera: Move struct vchiq_mmal_rect

; Signed-off-by: Eric Anholt <e...@anholt.net> --- .../vc04_services/bcm2835-camera/mmal-parameters.h| 8 drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/b

[PATCH 12/12] staging: bcm2835-camera: Fix identation of tables

From: Dave Stevenson <dave.steven...@raspberrypi.org> As requested by Mauro Carvalho Chehab in review. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bcm2835-camera/bcm2835-camera.c | 289

[PATCH 00/15] staging: bcm2835-camera probing and cleanup

struct vchiq_mmal_rect staging: bcm2835-camera: Replace BUG_ON with return error staging: bcm2835-camera: Fix comment typos. staging: bcm2835-camera: Fix indentation of tables Eric Anholt (5): staging/vc04_services: Register a platform device for the camera driver. staging/bcm2835

[PATCH 04/15] staging: bcm2835-camera: Allocate context once per buffer

ed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bcm2835-camera/bcm2835-camera.c | 30 +-- .../bcm2835-camera/mmal-common.h | 4 ++ .../vc04_services/bcm2835-camera

[PATCH 06/15] staging: bcm2835-camera: Match MMAL buffer count to V4L2.

ed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bcm2835-camera/bcm2835-camera.c | 6 -- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 21 +-- .../vc04_services/bcm2835-camera/mmal-vchiq.h

[PATCH 05/15] staging: bcm2835-camera: Remove bulk_mutex as it is not required

Remove the bulk_mutex so that multiple receives can be scheduled at a time. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 48 +-- 1 file changed, 1 insertion(+), 47

[PATCH 10/15] staging: bcm2835-camera: Replace BUG_ON with return error

From: Dave Stevenson <dave.steven...@raspberrypi.org> The error conditions don't warrant taking the kernel down, so remove BUG_ON. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../staging/vc04_services/bcm2

[PATCH 12/15] staging: bcm2835-camera: Fix indentation of tables

From: Dave Stevenson <dave.steven...@raspberrypi.org> As requested by Mauro Carvalho Chehab in review. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bcm2835-camera/bcm2835-camera.c | 289

[PATCH 13/15] staging: bcm2835-camera: Fix warnings about string ops on v4l2 uapi.

The v4l2 uapi uses u8[] for strings, so cast those to char * to avoid compiler warnings about unsigned vs signed with sprintf() and friends. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../vc04_services/bcm2835-camera/bcm2835-camera.c| 12 ++-- 1 file changed, 6 insertions

[PATCH 08/15] staging: bcm2835-camera: Add multiple include protection

From: Dave Stevenson <dave.steven...@raspberrypi.org> mmal-parameters.h didn't have the normal ... protection to stop it being included multiple times. Add it. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net>

[PATCH 07/15] staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping

lists as the struct mmal_buffer context comes back from the VPU, so we can directly link back to the relevant V4L2 buffer. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bcm2835-camera/bcm2835-camera.c | 7 +-

[PATCH 11/15] staging: bcm2835-camera: Fix comment typos.

From: Dave Stevenson <dave.steven...@raspberrypi.org> Fix a typo flagged by checkpatch, and another in the same line. Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org> Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/staging/vc04_services/bcm2835-camera/m

[PATCH 14/15] staging: bcm2835: Remove dead code related to framerate.

Fixes a compiler warning about a set-but-not-used variable. I think this was just leftover dead code from before set_framerate_params(), since that also sets up some mmal_parameter_rational structs for fps. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../staging/vc04_services/bcm2835-

[PATCH 02/15] staging/bcm2835-camera: Set ourselves up as a platform driver.

This allows bcm2835-camera to automatically probe after VCHI has loaded, rather than only successfully probing if the arbitrary probe order chooses us after VCHI. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../staging/vc04_services/bcm2835-camera/TODO | 11 --- .../bcm2835-

[PATCH 1/2] staging/vc04_services: Register a platform device for the camera driver.

We had the camera driver set up in a module_init function, but that meant that the camera driver would fail to load if it was initialized before VCHI. This enforces that it loads after we've successfully set up. Signed-off-by: Eric Anholt <e...@anholt.net> --- I'm going to try to ge

[PATCH 2/2] staging/bcm2835-camera: Set ourselves up as a platform driver.

This allows bcm2835-camera to automatically probe after VCHI has loaded, rather than only successfully probing if the arbitrary probe order chooses us after VCHI. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../staging/vc04_services/bcm2835-camera/TODO | 11 --- .../bcm2835-

Re: [PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

d. > + > +3) Make driver more portable > + > +Building this driver with arm/multi_v7_defconfig or arm64/defconfig > +leads to data corruption during vchiq_test. This should be fixed. Sounds good, but could you document that it's "vchiq_test -f" for testing this? With that, the

Re: [PATCH] staging: vchiq_arm: Clear VLA warning

"Tobin C. Harding" writes: > The kernel would like to have all stack VLA usage removed[1]. The > array here is fixed (declared with a const variable) but it appears > like VLA to the compiler. We can use a pre-processor define to quiet > the compiler. > > [1]:

Re: [Bug] VCHIQ functional test broken

Rabin Vincent <ra...@rab.in> writes: > On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote: >> I'm confused by what you're saying here. The driver has already been >> converted to not use dmac_map_area (commit >> cf9caf1929882b66922aee698e99e6c8f357bee5),

Re: [Bug] VCHIQ functional test broken

Rabin Vincent writes: > On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote: >> > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit >> > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169 >> > Author: Rabin Vincent >> > Date: Tue

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

Michael Zoran <mzo...@crowfest.net> writes: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: >> Michael Zoran <mzo...@crowfest.net> writes: >> >> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> > > Michael Zoran <mzo...@crowf

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

Michael Zoran <mzo...@crowfest.net> writes: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> Michael Zoran <mzo...@crowfest.net> writes: >> >> > > > Since the API is completely documented, I see no reason we or >> > > > anybo

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

Michael Zoran writes: >> > Since the API is completely documented, I see no reason we or >> > anybody >> > couldn't essentially rewrite the driver while it's in staging.  I >> > just >> > think it would be best for everyone if the new version was a drop >> > in >> >

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Mauro Carvalho Chehab writes: > Em Wed, 15 Mar 2017 18:46:24 -0700 > Michael Zoran escreveu: > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: >> >> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. >> >

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

Greg KH writes: > On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote: >> You've got a reason. It's GPLv2 licenced code so I have no control >> over what happens to it. >> Everywhere I have worked, when a patch has issues it is better to "-1" >> to

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Mauro Carvalho Chehab <mche...@s-opensource.com> writes: > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt <e...@anholt.net> escreveu: > >> Here's my first pass at importing the camera driver. There's a bunch >> of TODO left to it, most of which is documente

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

ret; > + > + if (copy_from_user(, completion, sizeof(*completion))) > + return -EFAULT; > + > + completion32.reason = completiontemp.reason; > + completion32.header = ptr_to_compat(completiontemp.header); > + completion32.service_userdata = > + ptr_

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

Stefan Wahren writes: > [add Eric] > >> Michael Zoran hat am 18. Februar 2017 um 12:59 >> geschrieben: >> >> >> On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote: >> > The original github source allowed for the cache-line-size property >> >

Re: [PATCH] staging: vc04_services: remove unused functions

Dan Carpenter writes: > There is a bunch of vc04_services that we're still looking to merge in > the near future. Please hold off deleting these until we are further > along on that. Checking the downstream tree, these are actually dead. signature.asc Description:

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Joe Perches <j...@perches.com> writes: > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: >> Joe Perches <j...@perches.com> writes: >> >> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> > > Generated with checkpatch.pl --fix-

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Joe Perches <j...@perches.com> writes: > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> Generated with checkpatch.pl --fix-inplace and git add -p out of the >> results. > > Maybe another. > >> diff --git a/drivers/staging/media/platform/bcm2835/mmal

Re: [PATCH] staging: bcm2835-audio: Strengthen build dependencies

Michael Zoran writes: > This driver makes no sense outside of ARM or ARM64. > Add an explicit build dependency on: > (ARM || ARM64 || COMPILE_TEST) > > Also set the default build to n > > Signed-off-by: Michael Zoran > --- >

[PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

This is derived from the downstream tree's build system, but with just a single Kconfig option. For now the driver only builds on 32-bit arm -- the aarch64 build breaks due to the driver using arm-specific cache flushing functions. Signed-off-by: Eric Anholt <e...@anholt.net> --- d

[PATCH 5/6] staging: bcm2835-v4l2: Apply many whitespace fixes from checkpatch.

-by: Eric Anholt <e...@anholt.net> --- .../media/platform/bcm2835/bcm2835-camera.c| 90 drivers/staging/media/platform/bcm2835/controls.c | 236 ++--- .../staging/media/platform/bcm2835/mmal-vchiq.c| 13 +- 3 files changed, 167 insertions(+), 172 del

[PATCH 2/6] staging: bcm2835-v4l2: Update the driver to the current VCHI API.

49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user") removed the flags/msg_handle arguments, which were unused, and pushed the implementation of copying using memcpy vs copy_from_user to the caller. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/stagin

[PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Generated with checkpatch.pl --fix-inplace and git add -p out of the results. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++--- drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++-- 2 files chan

[PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

uot; patch will conflict with the outstanding "Add vchi_queue_kernel_message and vchi_queue_user_message" series, but the fix should be pretty obvious when that lands. I built this against 4.10-rc1, but a merge with staging-next was clean and still built fine. Eric Anholt (6): staging: Import th

[PATCH 4/6] staging: bcm2835-v4l2: Add a TODO file for improvements we need.

Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/staging/media/platform/bcm2835/TODO | 39 + 1 file changed, 39 insertions(+) create mode 100644 drivers/staging/media/platform/bcm2835/TODO diff --git a/drivers/staging/media/platform/bcm2835/TODO b/d

Re: [PATCH 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

is much nicer than the old interface, thanks. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

Greg KH writes: > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: >> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: >> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: >> > > Just for clarity, when you mean staging code? Are you

Re: [PATCH 0/9] staging: vc04_services: Clean up vchiq driver

Greg Kroah-Hartman writes: > On Sun, Jan 08, 2017 at 06:15:09PM +, Stefan Wahren wrote: >> This is a loose bunch of clean up patches for the bcm2835 vchiq driver. > > All now applied, thanks. Thanks! I've been off on vacation and wasn't reviewing anything. In

Re: [PATCH 0/6] staging: vchiq_arm: Fine-tuning for some function implementations

SF Markus Elfring <elfr...@users.sourceforge.net> writes: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Sat, 31 Dec 2016 22:42:34 +0100 > > Some update suggestions were taken into account > from static source code analysis. This series is:

Re: [PATCH] staging: vc04_services: Fix bracing on single statement blocks

Aaron Moore <aa...@atamisk.net> writes: > Fix coding style issue caught by checkpatch.pl relating to braces on > single statement blocks. This issue was corrected in 3 locations. > > Signed-off-by: Aaron Moore <aa...@atamisk.net> Reviewed-by: Eric Anholt <e...@

Re: [PATCH 1/2] staging: vc04_services: remove duplicate mutex_lock_interruptible

Arnd Bergmann <a...@arndb.de> writes: > The driver tries to redefine mutex_lock_interruptible as an open-coded > mutex_lock_killable, but that definition clashes with the normal > mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC > is set: These two are: Acked-

Re: [bug report] staging: add bcm2708 vchiq driver

Michael Zoran writes: > On Tue, 2016-11-15 at 22:04 -0500, Vince Weaver wrote: >> On Tue, 15 Nov 2016, Michael Zoran wrote: >> >> > I'm still interested to know more about the MMU statement.  I would >> > think at least some of the RPI models have one because swapping >> >

Re: [PATCH] staging: vc04_services: fix ifnullfree.cocci warnings

nerated by: scripts/coccinelle/free/ifnullfree.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.

Re: [PATCH] staging: vc04_services: fix array_size.cocci warnings

: scripts/coccinelle/misc/array_size.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> These 3 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ devel mailing list de...@linuxdrive

Re: [PATCH v2] staging: vc04_services: setup DMA and coherent mask

Michael Zoran <mzo...@crowfest.net> writes: > VCHI messages between the CPU and firmware use 32-bit > bus addresses. Explicitly set the DMA mask and coherent > on all platforms. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Descr

Re: [PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

re efficient and easier > to understand and maintain. > > Tests Run(Both Pass): > vchiq_test -p 1 > vchiq_test -f 10 Looks good, and it's a nice cleanup. Thanks! Reviewed-by: Eric Anholt <e...@anholt.net> I had one style note, which was that you're using an int and 0/1 for a b

Re: [PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning

r > then debug tools and it is expected that a human debugging > the kernel interpret it. > > This change adds a cast to long before the original cast > to int to silence the warning. > > Signed-off-by: Michael Zoran <mzo...@crowfest.net> Thanks for sorting this out. Revi

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

Michael Zoran writes: > Setting the DMA mask is optional on 32 bit but > is mandatory on 64 bit. Set the DMA mask and coherent > to force all DMA to be in the 32 bit address space. > > This is considered a "good practice" and most drivers > already do this. > >

Re: [PATCH] staging: vc04_services: call sg_init_table to init scatterlist

t; + * Initialize the scatterlist so that the magic cookie > + * is filled if debugging is enabled > + */ > + sg_init_table(scatterlist, num_pages); > + /* Now set the pages for each scatterlist */ I feel like the comments don't add much, but either way: Ack

Re: [PATCH 4/5] staging: vc04_services: fix CamelCase

didn't see camel case explicitly called out in CodingStyle after a brief search. Other than this concern, all 5 patches are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ devel mailing list de...@

Re: [PATCH v2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

iter 2275us/iter 2001us > vchiq_test -b 512 10000 4372us/iter 4616us/iter 4123us Reviewed-by: Eric Anholt <e...@anholt.net> Nice work! More portability and better performance at the same time. A possible future improvement would be to track the pagelist, num_pages, and pagel

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

Michael Zoran <mzo...@crowfest.net> writes: > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote: >> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: >> > mzo...@crowfest.net writes: >> > >> > >  */ >> > >   >> > &g

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

mzo...@crowfest.net writes: > From: Michael Zoran > > The original arm implementation uses dmac_map_area which is not > portable. Replace it with an architecture neutral version > which uses dma_map_sg. > > As you can see that for larger page sizes, the dma_map_sg >

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

Greg KH writes: > On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote: >> From: Michael Zoran >> >> The original arm implementation uses dmac_map_area which is not >> portable. Replace it with an architecture neutral version >>