s(-)
Thanks, the entire series looks good to me, for the series:
Reviewed-by: Hans de Goede
Regards,
Hans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; delete mode 100644
>> arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
>> delete mode 100644
>> arch/x86/platform/intel-mid/device_libs/platform_tca6416.c
>> delete mode 100644 arch/x86/platform/intel-mid/sfi.c
>> delete mode 100644 arch/x86/platfo
Hi,
On 10/29/20 2:52 PM, Brian O'Keefe wrote:
> Add 024c:0627 to the list of SDIO device-ids, based on hardware found in
> the wild. This hardware exists on at least some Acer SW1-011 tablets.
>
> Signed-off-by: Brian O'Keefe
Patch looks good to me:
Reviewed-by: Hans de Goede
Re
Hi Tom,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy.
On 10/17/20 6:09 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> This is a upcoming change to clean up a new warning treewide.
> I am wondering if the change could be one mega patch (see below) or
> normal
of thread_name.
Addresses-Coverity: ("copy of overlapping memory")
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Colin Ian King
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.
Hi,
On 13-11-2019 00:12, Linus Torvalds wrote:
On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
wrote:
Christoph, this is what you mean, right? If so, I'll send this to Linus
later this week, or he can grab it right from this patch :)
No.
I was unhappy about a staging driver being
The driver only binds by SDIO device-ids, all the ACPI device-id does
is causing the driver to load unnecessarily on devices where the DSDT
contains a bogus OBDA8723 device.
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 6 --
1 file changed, 6 deletions
Add 024c:0525 to the list of SDIO device-ids, based on a patch found
in the Android X86 kernels. According to that patch this device id is
used on the Alcatel Plus 10 device.
Reported-and-tested-by: youling257
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1
Good catch, thank you:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/vboxsf/super.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vboxsf/super.c b/drivers/staging/vboxsf/super.c
index 3913ffafa83b..0bf4d724aefd 100644
--- a/drivers/stag
vbox_utils.h
F: include/uapi/linux/vbox*.h
F: drivers/virt/vboxguest/
+VIRTUAL BOX SHARED FOLDER VFS DRIVER:
+M: Hans de Goede
+L: linux-fsde...@vger.kernel.org
+S: Maintained
+F: drivers/staging/vboxsf/*
+
VIRTUAL SERIO DEVICE DRIVER
M: Stephen Chandler Paul
S:
Hi Greg,
As discussed previously can you please take vboxsf upstream through
drivers/staging?
It has seen many revisions on the fsdevel list, but it seems that the
fsdevel people are to busy to pick it up.
Previous versions of this patch have been reviewed by Al Viro, David Howells
and
The phy_Config*WithParaFile() functions were the only user of this
function.
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/include/osdep_service_linux.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
b/drivers
rtl8723bs had 2 private file operation helpers:
rtw_is_file_readable()
rtw_retrive_from_file()
These were only used by the removed phy_Config*WithParaFile() functions,
so they can be removed now.
Signed-off-by: Hans de Goede
---
.../staging/rtl8723bs/include/osdep_service.h | 4
These are no longer used, so remove them and also remove various
struct definitions only used by these functions.
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/hal/hal_com.c |1 -
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 1076 -
.../rtl8723bs
e new code without the phy_Config*With*ParaFile() calls.
Signed-off-by: Hans de Goede
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 77 +++
.../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 41 +-
2 files changed, 13 insertions(+), 105 deletions(-)
diff --git a/drive
Now that the phy_Config*WithParaFile() functions have been removed nothing
is using these module-parameters and defines anymore.
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/include/drv_types.h | 4
.../staging/rtl8723bs/include/rtl8723b_hal.h | 15 --
drivers
amp; !pBuf"
is constantly false because it is a nested if in the else brach, i.e.,
"if (cond) { ... } else { if (cond) {...} }". This patch alters the
if condition to check "pBufLen && pBuf" pointers are not NULL.
Cc: Greg Kroah-Hartman
Cc: Hans de Goede
Cc: Bastie
mon
functionality.
Signed-off-by: Hariprasad Kelam
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 149 ++
1 file changed, 41 insertions(+), 108 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_
& 0x07) > 0x07)
padapter->driver_ampdu_spacing = 0xFF;
else
padapter->driver_ampdu_spacing = extra_arg;
Reported-by: Colin Ian King
Signed-off-by: Hans de Goede
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 inse
Hi,
On 5/21/19 3:49 PM, Colin Ian King wrote:
Hi,
static analysis with Coverity has detected an issues in the rtl8723bs
wifi driver:
File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function
rtw_dbg_port():
CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
Hi,
On 20-03-19 15:31, Ivan Safonov wrote:
Local variables pfhdr and prframe always have a same value,
so one of them is unnecessary.
Signed-off-by: Ivan Safonov
Patch look good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 13
Hi,
On 20-03-19 18:21, Aditya Pakki wrote:
hwxmits is allocated via kcalloc and not checked for failure before its
dereference. The patch fixes this problem by returning error upstream
in rtl8723bs, rtl8188eu.
Signed-off-by: Aditya Pakki
Patch look good to me:
Reviewed-by: Hans de Goede
Hi,
On 14-03-19 16:21, Sidong Yang wrote:
In function vbox_dumb_create() of vbox_main.c, It calls vbox_gem_create()
for creating drm_gem_object. and it calls vbox_gem_handle_create() for handle.
If handle creation fails only, drm_gem_object should be released by calling
Hi,
On 04-02-19 19:24, Dan Carpenter wrote:
"psecnetwork" is the address of >sec_bss. Since
->sec_bss isn't the first member of the struct that means that
"psecnetwork" can't be NULL.
We can just remove this dead code.
Signed-off-by: Dan Carpenter
Thanks, LGTM:
are equivalent, so the behavior
should not change.
Signed-off-by: Arnd Bergmann
The entire series looks good to me and I've also given it
a quick test run on a tablet with a rtl8723bs wifi chip:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 20
Hi,
Thank you for the patches.
On 10-12-18 10:52, Michael Straube wrote:
The function rtw_port_switch_chk() returns always false.
Remove the function and related dead code.
Signed-off-by: Michael Straube
Both patches look good to me:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 07-11-18 00:27, Josenivaldo Benito Jr wrote:
Correct following errors reported by checkpath.pl:
ERROR: space required before the open parenthesis '(' #265: FILE:
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c:265:
+ if(!precvframe) ')'
Also similar errors on line
ed-off-by: Shayenne da Luz Moura
Thank you.
Still looks good to me:
Acked-by: Hans de Goede
Regards,
Hans
---
Changes in v2:
- Make the commit message more clearer.
Changes in v3:
- Update to apply patch to the latest kernel tree
drivers/staging/vboxvideo/vbox_main.c | 8
Hi,
On 26-10-18 21:04, Shayenne da Luz Moura wrote:
This change was suggested by checkpath.pl.
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Shayenne da Luz Moura
So as already mentioned in response to the coverletter of
the first posting of this series.
The drm headers
ed-off-by: Shayenne da Luz Moura
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
Changes in v2:
- Make the commit message more clearer.
drivers/staging/vboxvideo/vbox_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s
Hi,
On 25-10-18 21:40, Shayenne da Luz Moura wrote:
This series cleans the following checkpatch.pl issues:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
CHECK: Avoid using bool structure members because of possible alignment issues
Shayenne da Luz Moura (2):
staging: vboxvideo: Change
Hi,
On 22-10-18 17:42, Emil Velikov wrote:
On Mon, 22 Oct 2018 at 15:58, Hans de Goede wrote:
Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
always available and if CONFIG_COMPAT is not set
Add myself as MODULE_AUTHOR.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vboxvideo/vbox_drv.c
b/drivers/staging/vboxvideo/vbox_drv.c
index b6e6530aa4be..80d7395e48dc 100644
--- a/drivers/staging
Stop adding -Iinclude/drm to the CFLAGS and stop using the obsolete
"include-all" drm/drmP.h header.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/Makefile | 2 --
drivers/staging/vboxvideo/vbox_drv.c | 1 -
drivers/staging/vboxvideo/vbox_drv.h | 2 +-
drivers/staging
This is a leftover from when the driver was out of tree and also build
against older kernels.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 4 +---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
drivers/staging/vboxvideo/vbox_main.c | 2 +-
3 files changed, 3
Use PCI_DEVICE() for our pci_id table and also simplify the terminating
entry tio just "{ }".
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_drv.c
b/drive
Use DRM_FB_HELPER_DEFAULT_OPS rather then open-coding it.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_fb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_fb.c
b/drivers/staging/vboxvideo/vbox_fb.c
index d3a5255c93b6
Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions.
Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is
always available and if CONFIG_COMPAT is not set then drm_compat_ioctl
is defined to NULL.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo
Hi All,
Note this series applies on top of my serious from a couple of days ago
which starts with
"[PATCH 1/6] staging: vboxvideo: Stop accessing crtc_state->active"
Regards,
Hans
___
devel mailing list
de...@linuxdriverproject.org
Hi,
Thank you for the review.
On 18-10-18 20:12, Sam Ravnborg wrote:
Hi Hans.
Just a bunch of random observations that I hope you find use of.
Sam
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index cb88528e7b10..6b4d6c957da8 100644
--- a/drivers/gpu/drm/Kconfig
Now that it has been converted to use atomic-modesetting and all other
known issues have addressed too, the vboxvideo driver can be moved out of
staging.
Signed-off-by: Hans de Goede
---
Note this commit only adds the driver to drivers/gpu/drm, it disables, but
does not remove the old version
Hi All,
Here is a patch wich adds a copy of the vboxvideo driver from staging
(as it will look like after the cleanup series I just posted).
The purpose of posting this as a copy rather then a patch just moving
the files is to give the DRM maintainers a chance to do a review before
it gets
Userspace mode-setting (and thus also VESA) is not supported together with
modesetting. KMS userspace apps not properly marking the framebuffer as
dirty are also not supported.
So stop trying to accommodate this and simply enable accel
once at driver init.
Signed-off-by: Hans de Goede
All the files contain a MIT license header, replace this with:
SPDX-License-Identifier: MIT
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 23 ++--
drivers/staging/vboxvideo/hgsmi_ch_setup.h | 23 ++--
drivers/staging/vboxvideo
Some comments where still using docbook style comments, move these
either over to kerneldoc, or just make them regular comments.
Also remove a bunch of obsolete comments.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 72 +---
drivers/staging/vboxvideo
uot;monitor") to resize to 640x480 (and become black).
This commit makes us not look at crtc_state->mode when crtc_state->enable
is not set, so that we keep the old mode and just make the window go black.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 12 +++--
Switch to the more complete vbox_err.h file from include/linux which got
added with the merging of the vboxguest driver.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 4 +-
drivers/staging/vboxvideo/modesetting.c | 4 +-
drivers/staging/vboxvideo/vbox_err.h
Atomic modesetting drivers should never check crtc_state->active directly,
instead check crtc_state->enable.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vboxvideo/vbox_mod
' was not declared. Should it be static?
Signed-off-by: Craig Kewley
Thanks.
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/staging/vboxvideo/vbox_mode.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging
d me about this
but I did not get around to fixing it yet.
Fix looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging/vboxvideo/vbox_mode.c
index 042e4f384df9..78a9c9b13ff6 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++
Hi,
On 05-10-18 18:01, Daniel Vetter wrote:
On Mon, Oct 01, 2018 at 11:20:04AM +0200, Hans de Goede wrote:
Hi,
On 01-10-18 09:25, Dan Carpenter wrote:
Why are you resending this? It's because you added some more patches
on the end? Just send those as a new series...
I accidentally
Hi,
On 02-10-18 00:01, Daniel Vetter wrote:
On Mon, Oct 1, 2018 at 11:14 PM Hans de Goede wrote:
Hi,
On 01-10-18 18:52, Daniel Vetter wrote:
On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote:
Hi,
On 01-10-18 09:53, Daniel Vetter wrote:
On Wed, Sep 26, 2018 at 09:42:02PM
Hi,
On 01-10-18 18:52, Daniel Vetter wrote:
On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote:
Hi,
On 01-10-18 09:53, Daniel Vetter wrote:
On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote:
Atomic modesetting does not use the traditional dpms call backs, instead
we
Hi,
On 01-10-18 09:53, Daniel Vetter wrote:
On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote:
Atomic modesetting does not use the traditional dpms call backs, instead
we should check crtc_state->active.
Signed-off-by: Hans de Goede
Are you sure this does what you want it to
Hi,
On 01-10-18 09:25, Dan Carpenter wrote:
Why are you resending this? It's because you added some more patches
on the end? Just send those as a new series...
I accidentally numbered the cover-letter of the original series
01/15 instea dof 00/15 this confused Greg, so he asked for a
Hi,
On 01-10-18 09:51, Daniel Vetter wrote:
On Wed, Sep 26, 2018 at 09:41:51PM +0200, Hans de Goede wrote:
Hi All,
This series converts the vboxvideo driver to the modesetting API, once this
is merged I will submit a patch to move the driver out of staging and into
drivers/gpu/drm
Hi,
On 28-09-18 14:38, Greg Kroah-Hartman wrote:
On Wed, Sep 26, 2018 at 09:41:52PM +0200, Hans de Goede wrote:
This cleanups 2 things:
1) The first time we loop over the crtc-s, to compare framebuffers, fb1 may
get set to NULL by the fb1 = CRTC_FB(crtci); statement and then we call
the bad pointer,
but still it is better to not do this.
2) Since we already figure out the first crtc with a fb in the first loop
and store that in fb1, there is no need to loop over the crtc-s again just
to find the first crtc with a fb again.
Signed-off-by: Hans de Goede
---
drivers/staging
Replace vbox_crtc_commit and vbox_crtc_disable with
vbox_crtc_atomic_[en|dis]able which are the preferred callbacks for
these for atomic drivers.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
All the encoder_helper_funcs are optional, and even setting the
drm_encoder_helper_funcs vtable itself is optional and may be left out
when not using any of the helper funcs, so lets drop all of this.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 34
to
an intermediate state which triggers WARN_ONs in the atomic code because
e.g. plane->fb is still being set.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/TODO| 1 -
drivers/staging/vboxvideo/vbox_drv.c | 40 +--
drivers/staging/vboxvideo/vbox_mod
In preparation for atomic conversion, let's use the transitional atomic
helpers drm_plane_helper_update/disable.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 5 -
drivers/staging/vboxvideo/vbox_mode.c | 386 +-
2 files changed, 186
the drm_atomic_helper_page_flip helper to implement
the page_flip callback.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging/vboxvideo/vbox_mode.c
Use drm_plane_helpers for the primary plane and replace our custom
mode_set callback with drm_helper_crtc_mode_set.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 116 --
1 file changed, 90 insertions(+), 26 deletions(-)
diff --git a/drivers
can start using drm_atomic_helper_page_flip().
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging/vboxvideo/vbox_mode.c
index babb02a1ebf2..adb6bcf989d1 100644
--- a/
Extend our planes atomic_check callbacks to be more thorough by calling
the drm_atomic_helper_check_plane_state helper.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 30 ++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers
Atomic modesetting does not use the traditional dpms call backs, instead
we should check crtc_state->active.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 1 -
drivers/staging/vboxvideo/vbox_mode.c | 28 ++-
2 files changed, 2 inserti
to use the data from the plane_state and crt_state instead.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 1 -
drivers/staging/vboxvideo/vbox_main.c | 16 +++-
drivers/staging/vboxvideo/vbox_mode.c | 15 +++
3 files changed, 18 insertions(+), 14 del
resizing the
window as a side effect of a mode_set on another crtc.
This commit adds caching of the mode info into out private vbox_crtc
struct so that we always have the info at hand when we need it.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 20
vbox_mode_valid always returns MODE_OK, which is also the default if no
mode_valid callback is defined.
vbox_best_single_encoder chains to drm_encoder_find, the drm-core will
call drm_encoder_find itself if there is no best_encoder call back.
Signed-off-by: Hans de Goede
---
drivers/staging
-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 10 +++-
drivers/staging/vboxvideo/vbox_drv.h | 28 +++
drivers/staging/vboxvideo/vbox_fb.c | 70 ++-
drivers/staging/vboxvideo/vbox_main.c | 12 -
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
5 files
Wire up state object handlers for the crtc-s and the planes, call
drm_mode_config_reset() after creating all the crtc-s and encoders and
remove the legacy drm_helper_disable_unused_functions() call.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_fb.c | 3 ---
drivers/staging
Hi All,
This series converts the vboxvideo driver to the modesetting API, once this
is merged I will submit a patch to move the driver out of staging and into
drivers/gpu/drm.
This series consists of 3 parts:
1) More cleanups / prep work for atomic conversion
2) The actual atomic conversion,
Hi,
On 26-09-18 16:44, Frieder Schrempf wrote:
Hi,
On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote:
[...]
>> > I'd like to know if any progress has been made on that problem
(I may
>> > have missed patches).
>> > Had you had the time to look at the issue?
>>
>> I have looked
the drm_atomic_helper_page_flip helper to implement
the page_flip callback.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging/vboxvideo/vbox_mode.c
vbox_mode_valid always returns MODE_OK, which is also the default if no
mode_valid callback is defined.
vbox_best_single_encoder chains to drm_encoder_find, the drm-core will
call drm_encoder_find itself if there is no best_encoder call back.
Signed-off-by: Hans de Goede
---
drivers/staging
-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 10 +++-
drivers/staging/vboxvideo/vbox_drv.h | 28 +++
drivers/staging/vboxvideo/vbox_fb.c | 70 ++-
drivers/staging/vboxvideo/vbox_main.c | 12 -
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
5 files
can start using drm_atomic_helper_page_flip().
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers/staging/vboxvideo/vbox_mode.c
index babb02a1ebf2..adb6bcf989d1 100644
--- a/
Use drm_plane_helpers for the primary plane and replace our custom
mode_set callback with drm_helper_crtc_mode_set.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 116 --
1 file changed, 90 insertions(+), 26 deletions(-)
diff --git a/drivers
Replace vbox_crtc_commit and vbox_crtc_disable with
vbox_crtc_atomic_[en|dis]able which are the preferred callbacks for
these for atomic drivers.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
Extend our planes atomic_check callbacks to be more thorough by calling
the drm_atomic_helper_check_plane_state helper.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 30 ++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers
All the encoder_helper_funcs are optional, and even setting the
drm_encoder_helper_funcs vtable itself is optional and may be left out
when not using any of the helper funcs, so lets drop all of this.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 34
In preparation for atomic conversion, let's use the transitional atomic
helpers drm_plane_helper_update/disable.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 5 -
drivers/staging/vboxvideo/vbox_mode.c | 386 +-
2 files changed, 186
Atomic modesetting does not use the traditional dpms call backs, instead
we should check crtc_state->active.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 1 -
drivers/staging/vboxvideo/vbox_mode.c | 28 ++-
2 files changed, 2 inserti
to
an intermediate state which triggers WARN_ONs in the atomic code because
e.g. plane->fb is still being set.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/TODO| 1 -
drivers/staging/vboxvideo/vbox_drv.c | 40 +--
drivers/staging/vboxvideo/vbox_mod
Wire up state object handlers for the crtc-s and the planes, call
drm_mode_config_reset() after creating all the crtc-s and encoders and
remove the legacy drm_helper_disable_unused_functions() call.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_fb.c | 3 ---
drivers/staging
to use the data from the plane_state and crt_state instead.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 1 -
drivers/staging/vboxvideo/vbox_main.c | 16 +++-
drivers/staging/vboxvideo/vbox_mode.c | 15 +++
3 files changed, 18 insertions(+), 14 del
resizing the
window as a side effect of a mode_set on another crtc.
This commit adds caching of the mode info into out private vbox_crtc
struct so that we always have the info at hand when we need it.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 20
Hi All,
This series converts the vboxvideo driver to the modesetting API, once this
is merged I will submit a patch to move the driver out of staging and into
drivers/gpu/drm.
This series consists of 3 parts:
1) More cleanups / prep work for atomic conversion
2) The actual atomic conversion,
the bad pointer,
but still it is better to not do this.
2) Since we already figure out the first crtc with a fb in the first loop
and store that in fb1, there is no need to loop over the crtc-s again just
to find the first crtc with a fb again.
Signed-off-by: Hans de Goede
---
drivers/staging
for this.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 2 +-
drivers/staging/vboxvideo/vbox_fb.c | 27 --
drivers/staging/vboxvideo/vbox_mode.c | 54 ---
drivers/staging/vboxvideo/vbox_ttm.c | 32 +---
4 files changed, 42
Add vbox_bo_k[un]map helper functions instead of having code directly
poking struct vbox_bo internals.
While touch neighboring code anyways also fix a return -PTR_ERR(info),
which should be return PTR_ERR(info).
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 2
This is the recommended way to create the drm_device structure,
according to DRM documentation.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 110 +++---
drivers/staging/vboxvideo/vbox_drv.h | 17 ++--
drivers/staging/vboxvideo/vbox_fb.c | 19
t crtc with a fb. This is in the single_framebuffer = true path,
so all crtc-s point to the same fb anyways.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/d
Move pin / unpin of fb out of vbox_crtc_set_base_and_mode() so that it can
be used to implement the atomic_update drm_plane_helper_func for the primary
plane.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 5 +++
drivers/staging/vboxvideo/vbox_mode.c | 52
-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.h | 1 -
drivers/staging/vboxvideo/vbox_fb.c | 14 +-
drivers/staging/vboxvideo/vbox_mode.c | 3 ---
3 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_drv.h
b/drivers/staging
Let's expose the primary plane initialization inside the vboxvideo driver
in preparation for universal planes and atomic.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 78 +--
1 file changed, 74 insertions(+), 4 deletions(-)
diff --git
Allow specifying where to pin the framebuffer bo, so that this helper can
be used from the cursor code too.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b
Registering the connector explicitly right after creation is not necessary
for modesetting drivers, because drm_dev_register already takes care of
this on the core side, by calling drm_modeset_register_all.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 1 -
1 file
vbox_pm_resume() is the only caller of vbox_drm_resume(), so squash the
2 functions into 1.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_drv.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/vboxvideo
1 - 100 of 303 matches
Mail list logo
