Re: [PATCH] staging: ion: remove from the tree

2020-10-16 Thread John Stultz
t; > > the current situation. Because of this problem, just drop the in-kernel > > > copy of the ion code now, as it's not used, and is only causing problems > > > for everyone involved. > > > > > > Cc: "Arve Hjønnevåg" > > >

Re: [PATCH] staging: ion: remove from the tree

2020-08-28 Thread John Stultz
On Fri, Aug 28, 2020 at 1:05 AM Greg Kroah-Hartman wrote: > > On Thu, Aug 27, 2020 at 11:54:12AM -0700, John Stultz wrote: > > On Thu, Aug 27, 2020 at 10:17 AM Greg Kroah-Hartman > > wrote: > > > On Thu, Aug 27, 2020 at 10:31:41PM +0530, Amit Pundir wrote: > > &

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread John Stultz
On Thu, Aug 27, 2020 at 10:17 AM Greg Kroah-Hartman wrote: > On Thu, Aug 27, 2020 at 10:31:41PM +0530, Amit Pundir wrote: > > I don't know what is the right thing to do here. I just want to > > highlight that AOSP's audio (codec2) HAL depends on the ION system > > heap and it will break AOSP for p

Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups

2020-08-21 Thread John Stultz
On Thu, Aug 20, 2020 at 1:23 AM Mauro Carvalho Chehab wrote: > > (added c/c Rob Herring) > > Em Wed, 19 Aug 2020 18:53:06 -0700 > John Stultz escreveu: > > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > > wrote: > > > @@ -376,7 +355,7 @@ stat

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote: > > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > > wrote: > > > So, IMO, the best is to keep it on staging for a while, until those

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > So, IMO, the best is to keep it on staging for a while, until those > > remaining bugs gets solved. > > > > I added this series, together wi

Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct > platform_device *pdev) > } > > static const struct of_device_id kirin_drm_dt_ids[] = { > - { .compatible = "hisilicon,hi3660-dpe", > + { .compatible = "hi

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > So, IMO, the best is to keep it on staging for a while, until those > remaining bugs gets solved. > > I added this series, together with the regulator driver and > a few other patches (including a hack to fix a Kernel 5.8 > regression

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
driver and > a few other patches (including a hack to fix a Kernel 5.8 > regression at WiFi ) at: > > > https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master > > > Chen Feng (1): > staging: hikey9xx: Add hisilicon DRM driver for hikey960/970 > >

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote: > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > > > This patch series port the out-of-tree driver for Hikey 970 (which > > > should also support Hike

Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-18 Thread John Stultz
On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote: > On 2020-08-18 16:29, Mauro Carvalho Chehab wrote: > > Em Tue, 18 Aug 2020 15:47:55 +0100 > > Basically, the DT binding has this, for IOMMU: > > > > > > smmu_lpae { > > compatible = "hisilicon,smmu-lpae"; > > }; > > > >

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-07-07 Thread John Stultz
On Fri, Jul 3, 2020 at 12:03 AM Greg Kroah-Hartman wrote: > On Tue, Apr 21, 2020 at 10:05:44AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > > > The dmabuf heaps have been in an official kernel now for all of three > >

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-20 Thread John Stultz
On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner wrote: > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > > But I do think we can mark it as deprecated and let folks know that > >

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread John Stultz
On Tue, Apr 14, 2020 at 9:11 AM Ørjan Eide wrote: > > On Tue, Apr 14, 2020 at 04:28:10PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, �rjan Eide wrote: > > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > > is actually mapped on the dev

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread John Stultz
On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > is actually mapped on the device. > > > > dma-bufs may be synced at any time. It can be reached f

Re: Limits for ION Memory Allocator

2019-07-24 Thread John Stultz
On Wed, Jul 24, 2019 at 1:18 PM John Stultz wrote: > > On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote: > > > > On 7/17/19 12:31 PM, Alexander Popov wrote: > > > Hello! > > > > > > The syzkaller [1] has a trouble with fuzzing the Linux

Re: Limits for ION Memory Allocator

2019-07-24 Thread John Stultz
perror("[-] open /dev/ion"); > > return 1; > > } > > > > while (1) { > > printf("iter %lu\n", i); > > ioctl(fd, ION_IOC_ALLOC, &data); > > i++; >

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-03 Thread John Stultz
quot; and that people rely on this interface now. > >> Well, "code outside of the kernel tree" relies on this, which is not ok, > >> but the "soon" people keep insisting on it... > >> > >> Odds are I should just delete all of ION, as there h

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread John Stultz
On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > > Hi John, > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > [snip] > > > Some thoughts, as this ABI break has the potential to be pretty painful. > > > > 1) Unfortunately

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread John Stultz
On Fri, Feb 15, 2019 at 12:52 PM Andrew F. Davis wrote: > On 2/15/19 1:58 PM, John Stultz wrote: > > So yea, I don't think we should tie our hands in reworking the > > interfaces, but it would be nice to avoid having subtle ABI changes > > that don't have clear wa

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread John Stultz
On Fri, Feb 15, 2019 at 11:22 AM Andrew F. Davis wrote: > > On 2/15/19 1:01 PM, John Stultz wrote: > > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > >> On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > >>> 2) For patches that cause ABI br

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-14 Thread John Stultz
On Mon, Jan 28, 2019 at 1:44 PM Andrew F. Davis wrote: > > Previously the heap to allocate from was selected by a mask of allowed > heap types. This may have been done as a primitive form of constraint > solving, the first heap type that matched any set bit of the heap mask > was allocated from, u

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-02 Thread John Stultz
On Thu, Nov 1, 2018 at 3:15 PM, Liam Mark wrote: > Based on the suggestions from Laura I created a first draft for a change > which will attempt to ensure that uncached mappings are only applied to > ION memory who's cache lines have been cleaned. > It does this by providing cached mappings (for u

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

2018-09-17 Thread John Stultz
On Mon, Sep 17, 2018 at 12:25 PM, Andy Lutomirski wrote: > On Fri, Sep 14, 2018 at 5:50 AM, Thomas Gleixner wrote: >> The code flow for the vclocks is convoluted as it requires the vclocks >> which can be invalidated separately from the vsyscall_gtod_data sequence to >> store the fact in a separa

Re: [patch V2 01/11] clocksource: Provide clocksource_arch_init()

2018-09-17 Thread John Stultz
et me try reply-all this time. :) Acked-by: John Stultz thanks -john ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [staging:staging-linus 3/3] drivers/staging//android/ion/ion_cma_heap.c:47:14: error: 'CONFIG_CMA_ALIGNMENT' undeclared; did you mean 'CONFIG_CMA_AREAS'?

2017-12-13 Thread John Stultz
On Tue, Dec 12, 2017 at 10:25 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-linus > head: d98e6dbf42f73101128885a1e0ae672cd92b2e1a > commit: d98e6dbf42f73101128885a1e0ae672cd92b2e1a [3/3] staging: ion: Fix > ion_cma_heap all

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

2017-08-22 Thread John Stultz
On Tue, Aug 22, 2017 at 8:01 PM, Jisheng Zhang wrote: > On Tue, 22 Aug 2017 19:57:04 -0700 John Stultz wrote: > >> On Tue, Aug 22, 2017 at 7:56 PM, John Stultz wrote: >> > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: >> >> On Tue, 22 Aug

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

2017-08-22 Thread John Stultz
On Tue, Aug 22, 2017 at 7:56 PM, John Stultz wrote: > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: >> On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: >> >>> On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: >>> > As noted in commit d0bd

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

2017-08-22 Thread John Stultz
On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: > On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > >> On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: >> > As noted in commit d0bdff0db809 ("staging: Fix build issues with new >> > binder API"), we can add back the choice for

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

2017-08-21 Thread John Stultz
On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote: > On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote: >> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote: >> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")' >> > w

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

2017-08-08 Thread John Stultz
On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote: > On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote: >> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote: >> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")' >> > w

Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

2017-08-08 Thread John Stultz
up_leader) > return -EINVAL; > > if ((vma->vm_end - vma->vm_start) > SZ_4M) Tested-by: John Stultz As Amit already confirmed, this resolves the wifi and bluetooth regression I was seeing with Android using 4.13-rc2. Though I've not seen it show up i

Re: [PATCH 02/37] binder: use group leader instead of open thread

2017-07-24 Thread John Stultz
On Mon, Jul 24, 2017 at 2:23 PM, Greg Kroah-Hartman wrote: > On Mon, Jul 24, 2017 at 02:00:45PM -0700, John Stultz wrote: >> On Thu, Jun 29, 2017 at 12:01 PM, Todd Kjos wrote: >> > The binder allocator assumes that the thread that >> > called binder_open will ne

Re: [PATCH 02/37] binder: use group leader instead of open thread

2017-07-24 Thread John Stultz
On Mon, Jul 24, 2017 at 2:00 PM, John Stultz wrote: > On Thu, Jun 29, 2017 at 12:01 PM, Todd Kjos wrote: >> The binder allocator assumes that the thread that >> called binder_open will never die for the lifetime of >> that proc. That thread is normally the group_leader, >

Re: [PATCH 02/37] binder: use group leader instead of open thread

2017-07-24 Thread John Stultz
On Thu, Jun 29, 2017 at 12:01 PM, Todd Kjos wrote: > The binder allocator assumes that the thread that > called binder_open will never die for the lifetime of > that proc. That thread is normally the group_leader, > however it may not be. Use the group_leader instead > of current. > > Signed-off-b

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread John Stultz
On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote: > On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote: >> On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: >>> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani >>> wrote: >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index

Re: [PATCH] android: binder: check result of binder_get_thread() in binder_poll()

2017-05-08 Thread John Stultz
On Mon, May 8, 2017 at 1:43 PM, Dmitry Torokhov wrote: > If binder_get_thread() fails to give us a thread data, we should avoid > dereferencing a NULL pointer and return POLLERR instead. > > Signed-off-by: Dmitry Torokhov Pulling Todd Kjos in on this too. -john > --- > drivers/android/binder.c

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-23 Thread John Stultz
On Wed, Feb 22, 2017 at 4:01 AM, Michal Hocko wrote: > From: Michal Hocko > > Lowmemory killer is sitting in the staging tree since 2008 without any > serious interest for fixing issues brought up by the MM folks. The main > objection is that the implementation is basically broken by design: >

Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time

2017-01-06 Thread John Stultz
On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: > With TimeSync version 4 protocol support we started updating system time > continuously through the whole lifetime of Hyper-V guests. Every 5 seconds > there is a time sample from the host which triggers do_settimeofday[64](). > While the t

Re: [PATCH v2 4/4] hv_util: improve time adjustment accuracy by disabling interrupts

2017-01-06 Thread John Stultz
On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: > If we happen to receive interrupts during hv_set_host_time() execution > our adjustments may get inaccurate. Make the whole function atomic. > Unfortunately, we can's call do_settimeofday64() with interrupts > disabled as some cross-CPU wor

Re: [PATCH v2 1/4] timekeeping: export do_adjtimex() to modules

2017-01-06 Thread John Stultz
On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: > While do_adjtimex() is available to userspace via adjtimex syscall it is > not available to modules which may want to implement in-kernel 'NTP > clients'. Hyper-V hv_utils is going to be the first one. > > Signed-off-by: Vitaly Kuznetsov >

Re: [PATCH v2 2/4] hv_util: switch to using timespec64

2017-01-06 Thread John Stultz
On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: > do_settimeofday() is deprecated, use do_settimeofday64() instead. > > Signed-off-by: Vitaly Kuznetsov Looks sane. Acked-by: John Stultz thanks -john ___ devel mailin

Re: [PATCH v2] android: binder: fix binder mmap failures

2015-02-27 Thread John Stultz
PAGE_SIZE, PAGE_KERNEL, page); > + flush_cache_vmap((unsigned long)page_addr, > + (unsigned long)page_addr + PAGE_SIZE); > + if (ret != 1) { > pr_err

Re: [PATCH] android: binder: fix binder mmap failures

2015-02-27 Thread John Stultz
On Fri, Feb 27, 2015 at 8:30 AM, Andrey Ryabinin wrote: > binder_update_page_range() initializes only addr and size > fields in 'struct vm_struct tmp_area;' and passes it to > map_vm_area(). > > Before 71394fe50146 ("mm: vmalloc: add flag preventing guard hole allocation") > this was because map_v

Re: [PATCH] lowmemorykiller: Avoid excessive/redundant calling of LMK

2015-01-29 Thread John Stultz
On Thu, Jan 15, 2015 at 9:03 AM, Michal Hocko wrote: > On Mon 12-01-15 21:49:14, Chintan Pandya wrote: >> The global shrinker will invoke lowmem_shrink in a loop. >> The loop will be run (total_scan_pages/batch_size) times. >> The default batch_size will be 128 which will make >> shrinker invoking

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread John Stultz
t;> To: Thomas Shao >> Cc: gre...@linuxfoundation.org; LKML; de...@linuxdriverproject.org; >> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan; >> John Stultz; Richard Cochran >> Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for >> do_adjtimex() &

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread John Stultz
On Thu, Oct 16, 2014 at 4:12 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: >> On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman >> wrote: >> > From: Greg Kroah-Hartman >> > >> > The Android binder code

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread John Stultz
On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > The Android binder code has been "stable" for many years now. No matter Well, ignoring the ABI break that landed in the last year. :) > what comes in the future, we are going to have to support this API,

Re: [PATCH v2 0/9] staging: ion: system heap and page pool fixes

2014-05-28 Thread John Stultz
saw no changes in the results on x86_64, i386(compat), and arm. So looks ok there. Would still be good to have Colin's ack, but here's my qualified tested-by line... (Basic Unit)Tested-by: John Stultz thanks -john ___ devel mailing

Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-27 Thread John Stultz
On Tue, May 27, 2014 at 11:52 AM, Greg Kroah-Hartman wrote: > On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: >> For aesthetics and readability, rename goto labels, remove >> useless code lines, and clarify function return type. >> >> Signed-off-by: Heesub Shin >> --- >> drivers/sta

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread John Stultz
On 04/16/2014 07:39 AM, Joe Perches wrote: > On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: >> This patch fix checkpatch.pl warnings and errors. > [] >> diff --git a/drivers/staging/android/uapi/binder.h >> b/drivers/staging/android/uapi/binder.h > [] >> @@ -169,7 +169,7 @@ struct binder_p

Re: [PATCH V2] staging: ion: replace ion_phys_addr_t with phys_addr_t

2014-02-17 Thread John Stultz
On 02/16/2014 04:00 PM, Tomas Winkler wrote: > Looks like phys_addr_t's are fully plumbed in the kernel. This needs a better commit description. Also you should include Colin and the rest of the Android kernel folks (cc'ed in this mail) so they can review and hopefully provide acks. thanks -john