[PATCH 04/11] staging: vchiq_arm: Clear VLA warning

]: https://lkml.org/lkml/2018/3/7/621 CC: Tobin C. Harding <m...@tobin.cc> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dri

[PATCH 07/11] staging: vc04_services: Use __func__ macro

It's better to use the __func__ macro instead of open-code the function name. This fixes the following checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'x', this function's name, in a string Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../int

[PATCH 03/11] staging: vchiq_core: remove BITSET_ZERO

Hiding memset behind a macro isn't the best, because it relies on that the parameter is not a pointer. Luckily all user has been removed, so we can remove BITSET_ZERO too. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core

Re: [bug report] staging: vchiq_core: Bail out in case of invalid tx_pos

Hi Dan, > Dan Carpenter <dan.carpen...@oracle.com> hat am 22. März 2018 um 13:28 > geschrieben: > > > Hello Stefan Wahren, > > The patch d1eab9dec610: "staging: vchiq_core: Bail out in case of > invalid tx_pos" from May 26, 2017, leads to the followin

[PATCH V2 1/2] staging: vc04_services: Remove import of bcm2835-camera from TODO

The bcm2835-camera driver has already been imported. So remove it from the TODO. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/staging/vc04_services/interface/vchi/TODO | 5 - 1 file changed, 5 deletions(-) Changes

[PATCH V2 2/2] staging: vc04_services: Add outstanding VCHI TODOs

The TODO list missed some issues before we can move the driver out of staging. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/staging/vc04_services/interface/vchi/TODO | 31 +++ 1 file changed, 3

[PATCH 1/2] staging: vc04_services: Remove import of bcm2835-camera from TODO

The bcm2835-camera driver has already been imported. So remove it from the TODO. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchi/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vch

[PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

The TODO list missed some issues before we can move the driver out of staging. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchi/TODO | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/staging/vc04_se

Re: [PATCH v2] staging: vchiq_arm: Clear VLA warning

Hi Tobin, > "Tobin C. Harding" hat am 12. März 2018 um 06:46 geschrieben: > > > On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote: > > The kernel would like to have all stack VLA usage removed[1]. The array > > here is fixed (declared with a const variable) but

Re: [PATCH] staging: vc04_services: merge vchiq_kern_lib.c into vchiq_arm.c

y access the members, > but it's clear that they need to agree on the layout. The easiest way > to achieve this appears to be to merge the two files into one. I tried > moving the structure definition into a shared header first, but ended > up running into too many interdependencies tha

Re: [PATCH] staging: vc04_services: remove unused files

ossibly used by a driver in the RPi Foundation tree, but i don't see any need to upstream it. Acked-by: Stefan Wahren <stefan.wah...@i2se.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: vc04_services: merge vchiq_kern_lib.c into vchiq_arm.c

[add Phil] > Arnd Bergmann hat am 2. Februar 2018 um 16:01 geschrieben: > > > There are two incompatible definitions of 'vchiq_instance_struct', so > passing them through vchiq_initialise(), vchiq_connect() or another > such interface is broken, as shown by building the driver

Re: [PATCH] staging: vc04_services: Fix checkpatch.pl warnings

Hi Sidong, > Sidong Yang hat am 14. Januar 2018 um 09:11 geschrieben: > > > Replace spaces to tabs for indents in beginning of statements. > > Signed-off-by: Sidong Yang i'm okay with the changes, but the subject is too general. We get fixes for

Re: [PATCH] staging: vc04_services: Prefer BUG_ON instead of if condition followed by BUG.

Hi Kishore, > kishor...@techveda.org hat am 23. Dezember 2017 um 16:06 geschrieben: > > > From: Kishore KP > > Use BUG_ON instead of if condition followed by BUG. > Pointed out by Coccinelle. > > Signed-off-by: Kishore KP > Signed-off-by:

Re: [PATCH] Staging: vc04_services: fix brace coding style issues in vchiq_shim.c

Am 13.12.2017 um 21:51 schrieb Tomas Marek: This patch fix brace on next line coding style errors reported by checkpatch. Signed-off-by: Tomas Marek <marek_to...@centrum.cz> Acked-by: Stefan Wahren <stefan.wah...@i2se.com> Thanks ___ d

Re: [PATCH 1/1] codestyle issue fixed drivers/staging/vc04_services

Hello Mikhail, Am 07.12.2017 um 08:47 schrieb Mikhail Shvetsov: > From: Mike please provide your full name and a changelog. Also the subject should start with something like "staging: vchiq_arm:". > > Signed-off-by: Mike > --- >

RFC: staging: vchiq_arm: prevent platform driver unload

Hi, in a recent discussion [1] with Phil Elwell pointed out that the VPU firmware of the Raspberry Pi isn't aware of an unload of the vchiq kernel module after a successful registration. So my question is there a proper way to prevent a platform driver from unloading? [1] -

Re: [PATCH] staging: vc04_services: Convert timers to use timer_setup()

pointer explicitly. > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Eric Anholt <e...@anholt.net> > Cc: Stefan Wahren <stefan.wah...@i2se.com> > Cc: Michael Zoran <mzo...@crowfest.net> > Cc: Keerthi Reddy <keerthigd4...@g

Re: [PATCH 08/20] staging: vc04_services: vchiq_core: mark expected switch fall-through

avo A. R. Silva <garsi...@embeddedor.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Stefan Wahren <stefan.wah...@i2se.com> ___

Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines

Am 03.10.2017 um 13:43 schrieb Arvind Yadav: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Stefan Wahren <stefan.wah...@i2se.com> > --- > drivers

Re: [PATCH v2 resend] staging: bcm2835-audio: Fix memory corruption

org> > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in > bcm2835_audio_open_connection()") Tested-by: Stefan Wahren <stefan.wah...@i2se.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption

Hi Phil, > Greg Kroah-Hartman <gre...@linuxfoundation.org> hat am 23. September 2017 um > 18:15 geschrieben: > > > On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote: > > Hi Greg, > > > > > Phil Elwell <p...@raspberrypi.org> ha

Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption

Hi Greg, > Phil Elwell hat am 11. August 2017 um 12:20 > geschrieben: > > > The previous commit (0adbfd46) fixed a memory leak but also freed a > block in the success case, causing a stale pointer to be used with > potentially fatal results. Only free the vchi_instance

[PATCH] staging: vchiq_2835_arm: Fix NULL ptr dereference in free_pagelist

This fixes a NULL pointer dereference on RPi 2 with multi_v7_defconfig. The function page_address() could return NULL with enabled CONFIG_HIGHMEM. So fix this by using kmap() instead. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: 71bad7f08641 ("staging: add bcm2708 v

Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON

Am 31.07.2017 um 09:14 schrieb janani-sankarababu: > This patch is to replace the use of BUG_ON macro with WARN_ON > inorder to prevent the crashing of the kernel. Unfortunately it isn't always that simple. checkpatch isn't smart. It's preferred to handle error cases instead of flooding the

[PATCH v2 06/16] staging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo

Assuming the intension of the function is to clean up, so fix the function name accordingly. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v2 12/16] staging: vchiq_core: Bail out if service is NULL

In the unlikely case that service is NULL we should bail out instead of calling BUG_ON(). The other BUG_ON calls will be fixed in separate patches. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 38 ++

[PATCH v2 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

Use the PAGE_MASK instead of open code it. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vch

[PATCH v2 10/16] staging: vchiq_core: Bailout if VCHIQ state is already initialized

In case VCHIQ state is already initialized we need to bailout in order to aovid a memory leak. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/s

[PATCH v2 05/16] staging: vchiq_arm: Avoid multiline dereference

Reduce the indentation within vchiq_dump_service_use_state in order to avoid a multiline derefernce. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v2 01/16] staging: vchiq_core: Use return value of mutex_lock_killable directly

Instead of saving the return value of mutex_lock_killable in a local variable we could use the value directly. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH v2 15/16] staging: vchiq_core: Bail out in case of invalid tx_pos

Properly handle the error case in case of an invalid tx_pos. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/int

[PATCH v2 16/16] staging: vchiq_core: Replace remaining BUG_ON with WARN_ON

This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH v2 03/16] staging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size

The variable slot_mem_size is assigned a value which is never used. This issue has been found by CppCheck. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH v2 11/16] staging: vchiq_core: Don't BUG if sending RESUME fails

VCHIQ suspend and resume isn't implemented, but even it was there is no need to call BUG(). Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_se

[PATCH v2 00/16] staging: vchiq_arm: several cleanups

This patch series addresses mostly minor issues. It's based on top of the latest vchiq bugfix [1]. [1] - https://lkml.org/lkml/2017/5/4/228 Changes in v2: * fix the signed-off-by in patches 8 and 9 Stefan Wahren (16): staging: vchiq_core: Use return value of mutex_lock_killable directly

[PATCH v2 14/16] staging: vchiq_core: Don't BUG if process is unexpected

Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vch

[PATCH v2 09/16] staging: vchiq_core: Simplify VCHIQ init

Since the ARM side of VCHIQ support only 1 state, we could simplify the init code. This makes it possible to avoid BUG_ON and a theoretical overflow of id. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +

[PATCH v2 07/16] staging: vchiq_2835_arm: Handle vmalloc_to_page error case

In case vmalloc_to_page returns NULL create_pagelist must abort imediatly. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vc04_services/int

[PATCH v2 13/16] staging: vchiq_core: Bail out if ref_count is unexpected

If the ref counter of service has an unexpected value then we better bail out. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/s

[PATCH v2 04/16] staging: vchiq_arm: Fix variable names in comment

This comment was apparently forgotten in the correction of CamelCase. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_se

[PATCH v2 02/16] staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

We can reduce the scope of the counting variable i. This has been found by CppCheck. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s

Re: [PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

> Greg Kroah-Hartman <gre...@linuxfoundation.org> hat am 25. Mai 2017 um 18:35 > geschrieben: > > > On Sat, May 20, 2017 at 11:30:33PM +0200, Stefan Wahren wrote: > > > > > Stefan Wahren <stefan.wah...@i2se.com> hat am 20. Mai 2017 um 14:22 &g

Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

> "Tobin C. Harding" hat am 25. Mai 2017 um 01:28 geschrieben: > > > On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: > > This driver is not in Greg KH's staging tree. The driver has moved to drivers/staging/vc04_services/bcm2835-audio > You may like to work

Re: [PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

> Stefan Wahren <stefan.wah...@i2se.com> hat am 20. Mai 2017 um 14:22 > geschrieben: > > > Since the ARM side of VCHIQ support only 1 state, we could simplify > the init code. This makes it possible to avoid BUG_ON and a theoretical > overflow of id. > >

Re: [PATCH 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

> Stefan Wahren <stefan.wah...@i2se.com> hat am 20. Mai 2017 um 14:22 > geschrieben: > > > Use the PAGE_MASK instead of open code it. > > Signed-off-by: Stefan Wahren <stefa.wah...@i2se.com> Sorry, for the typo in the mail address.

[PATCH 12/16] staging: vchiq_core: Bail out if service is NULL

In the unlikely case that service is NULL we should bail out instead of calling BUG_ON(). The other BUG_ON calls will be fixed in separate patches. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 38 ++

[PATCH 00/16] staging: vchiq_arm: several cleanups

This patch series addresses mostly minor issues. It based on top of the latest vchiq bugfix [1]. [1] - https://lkml.org/lkml/2017/5/4/228 Stefan Wahren (16): staging: vchiq_core: Use return value of mutex_lock_killable directly staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

[PATCH 13/16] staging: vchiq_core: Bail out if ref_count is unexpected

If the ref counter of service has an unexpected value then we better bail out. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/s

[PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

Since the ARM side of VCHIQ support only 1 state, we could simplify the init code. This makes it possible to avoid BUG_ON and a theoretical overflow of id. Signed-off-by: Stefan Wahren <ste...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file c

[PATCH 06/16] staging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo

Assuming the intension of the function is to clean up, so fix the function name accordingly. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH 11/16] staging: vchiq_core: Don't BUG if sending RESUME fails

VCHIQ suspend and resume isn't implemented, but even it was there is no need to call BUG(). Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_se

[PATCH 16/16] staging: vchiq_core: Replace remaining BUG_ON with WARN_ON

This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH 15/16] staging: vchiq_core: Bail out in case of invalid tx_pos

Properly handle the error case in case of an invalid tx_pos. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/int

[PATCH 14/16] staging: vchiq_core: Don't BUG if process is unexpected

Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vch

[PATCH 10/16] staging: vchiq_core: Bailout if VCHIQ state is already initialized

In case VCHIQ state is already initialized we need to bailout in order to aovid a memory leak. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/s

[PATCH 04/16] staging: vchiq_arm: Fix variable names in comment

This comment was apparently forgotten in the correction of CamelCase. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_se

[PATCH 05/16] staging: vchiq_arm: Avoid multiline dereference

Reduce the indentation within vchiq_dump_service_use_state in order to avoid a multiline dereference. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH 03/16] staging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size

The variable slot_mem_size is assigned a value which is never used. This issue has been found by CppCheck. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH 07/16] staging: vchiq_2835_arm: Handle vmalloc_to_page error case

In case vmalloc_to_page returns NULL create_pagelist must abort immediately. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vc04_se

[PATCH 02/16] staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

We can reduce the scope of the counting variable i. This has been found by CppCheck. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s

[PATCH 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

Use the PAGE_MASK instead of open code it. Signed-off-by: Stefan Wahren <stefa.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vch

[PATCH 01/16] staging: vchiq_core: Use return value of mutex_lock_killable directly

Instead of saving the return value of mutex_lock_killable in a local variable we could use the value directly. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [Bug] VCHIQ functional test broken

Am 15.05.2017 um 16:29 schrieb Phil Elwell: > On 13/05/2017 10:30, Russell King - ARM Linux wrote: >> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote: >>> In the meantime this issue has been fixed by Phil [1]. >> Right - definitely a driver bug. Mapping

Re: [Bug] VCHIQ functional test broken

> Stefan Wahren <stefan.wah...@i2se.com> hat am 24. April 2017 um 21:35 > geschrieben: > > > > > Russell King - ARM Linux <li...@armlinux.org.uk> hat am 24. April 2017 um > > 20:59 geschrieben: > > > > > > On Mon, Apr 24, 2017 at 07

Re: [PATCH] staging: vc04_services: Fix bulk cache maintenance

transfer start- and end-points prevents the > corruption. > > Fixes: cf9caf192988 ("staging: vc04_services: Replace dmac_map_area with > dmac_map_sg") > Signed-off-by: Phil Elwell <p...@raspberrypi.org> Reported-by: Stefan Wahren <stefan.wah...@i2se.com> Tested-by

Re: [Bug] VCHIQ functional test broken

> Russell King - ARM Linux <li...@armlinux.org.uk> hat am 24. April 2017 um > 20:59 geschrieben: > > > On Mon, Apr 24, 2017 at 07:42:27PM +0200, Stefan Wahren wrote: > > > What I can't see is how changing flush_dcache_page() has possibly broken > > > this

Re: [Bug] VCHIQ functional test broken

> Russell King - ARM Linux <li...@armlinux.org.uk> hat am 24. April 2017 um > 18:40 geschrieben: > > > On Mon, Apr 24, 2017 at 06:12:09PM +0200, Stefan Wahren wrote: > > Am 20.04.2017 um 21:58 schrieb Rabin Vincent: > > > On Thu, Apr 20, 2017 at 11:27:38AM

Re: [Bug] VCHIQ functional test broken

Am 20.04.2017 um 21:58 schrieb Rabin Vincent: > On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote: >> I'm confused by what you're saying here. The driver has already been >> converted to not use dmac_map_area (commit >> cf9caf1929882b66922aee698e99e6c8f357bee5), and uses dma_map_sg

Re: [Bug] VCHIQ functional test broken

Hi Rabin, > Rabin Vincent hat am 14. April 2017 um 09:41 geschrieben: > > > On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote: > > > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit > > > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169 > > >

Re: [Bug] VCHIQ functional test broken

> Stefan Wahren <stefan.wah...@i2se.com> hat am 11. April 2017 um 20:10 > geschrieben: > > > Hi, > > recently i found that vchiq_test -f doesn't work anymore with current > mainline (4.11-rc6) and linux-next (20170404) on my Raspberry Pi Zero. The

[Bug] VCHIQ functional test broken

Hi, recently i found that vchiq_test -f doesn't work anymore with current mainline (4.11-rc6) and linux-next (20170404) on my Raspberry Pi Zero. The issue is always reproducible, but the error behavior isn't deterministic. Sometimes vchiq_test hangs and sometimes i get an error message from

Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

early of the function with a null return. Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Stefan Wahren <stefan.wah...@i2se.com> _

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Hi Mauro, Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab: Em Sun, 19 Mar 2017 22:11:07 -0300 Mauro Carvalho Chehab escreveu: Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: A working DT that I tried this morning with the

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

> Michael Zoran hat am 19. März 2017 um 12:38 geschrieben: > > ... > > Sorry, I simply meant that I was hoping the comments would focus on > changes I made to the driver not the original version. I don't want > things to get mixed up between what I wrote and what Dave

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

Hi Michael, > Michael Zoran <mzo...@crowfest.net> hat am 19. März 2017 um 05:42 geschrieben: > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > Michael Zoran <mzo...@crowfest.net> hat am 17. März 2017 um 16:22 > > > geschrieben

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > This change adds the driver to the standard kernel build system. > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/Kconfig| 2 ++ >

Re: [PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > This change adds the following optional DT properties: > > number-gpios: Number of GPIOs the device should expose > gpio-base: GPIO base that is registered with the kernel Please don't reinvent existing

Re: [PATCH 2/6] staging: bcm2835-firmware-gpio: Add needed mailbox defines to driver

> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > The original change this driver is based on adds the needed mailbox > defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not > appropriate at this time, so add the defines directly into the >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > From: Dave Stevenson > > Pi3 and Compute Module 3 have a GPIO expander that the > VPU communicates with. > There is a mailbox service that now allows control of this >

[PATCH] staging: vchiq_arm: Fix MODULE_LICENSE

Regarding to the header the driver is licensed under BSD and GPL. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/int

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

Hi Michael, > Michael Zoran <mzo...@crowfest.net> hat am 17. März 2017 um 17:48 geschrieben: > > > On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > > Hi Michael, > > > > > > Am 17.03.2017 um 16:22 schrieb Michael Zoran: > > >

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

Hi Michael, Am 17.03.2017 um 16:22 schrieb Michael Zoran: The firmware now has a mailbox API for performing generalized gpio through the firmware. This driver builds upon a driver written by Dave Stevenson that was written specifically for the expander on the RPI 3, but I have generalized for

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Hi Mauro, > Mauro Carvalho Chehab hat am 15. März 2017 um > 15:01 geschrieben: > > > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt escreveu: > > > Here's my first pass at importing the camera driver. There's a bunch > > of TODO left to it, most

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

Hi Dave, Am 15.03.2017 um 16:32 schrieb Dave Stevenson: > Full description: > mmal_vchiq is reimplementing parts of the userside MMAL library in kernel > space. > The expected behaviour of port_parameter_get is that it takes the size > of storage for the parameter value, and returns the amount

Re: [PATCH] staging: vc04_services: Remove unused functions

> Jean-Baptiste Abbadie <j...@abbadie.fr> hat am 14. März 2017 um 20:14 > geschrieben: > > > These four functions are not used and report errors with sparse. > > Signed-off-by: Jean-Baptiste Abbadie <j...@abbadie.fr> Acked-by: Stef

Re: [PATCH 2/2] staging: bcm2835-audio: Disable extra virtual cards by default

Am 14.03.2017 um 07:45 schrieb Michael Zoran: > The extra virtual cards created for HDMI and Headphone output > may not be compatible with operating systems that expose > very simple audio controls. > > By default only enable the traditional mode that exposes a single > card for maximum

[PATCH] staging: vchiq_utils: Don't include headers twice

There is no need to include types.h and vmalloc.h twice. This issue has been found by make includecheck. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../vc04_services/interface/vchiq_arm/vchiq_util.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

Am 06.03.2017 um 16:57 schrieb Michael Zoran: > On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: >> On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: >>> On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: >

Re: [PATCH linux-next] staging: vchiq_arm: coding style

> Sergiy Redko <sergre...@gmail.com> hat am 4. März 2017 um 06:15 geschrieben: > > > On 03/03, Stefan Wahren wrote: > > Hi Sergiy, > > > > Am 03.03.2017 um 09:05 schrieb Sergiy Redko: > > > fix coding style: move brace to the line above > &

Re: [PATCH linux-next] staging: vchiq_arm: coding style

Hi Sergiy, Am 03.03.2017 um 09:05 schrieb Sergiy Redko: > fix coding style: move brace to the line above please make the subject of your patch more distinct. We get a lot of coding style fixes for vchiq. Btw it looks you missed to add Greg as staging maintainer. > > Signed-off-by: Sergiy Redko

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

> Michael Zoran hat am 2. März 2017 um 04:41 geschrieben: > > > This patch adds compatibility wrappers for the ioctls > exposed by vchiq/vc04_services. The compat ioctls are > completely implemented on top of the native ioctls. No > existing lines are modified. > >

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

> Michael Zoran <mzo...@crowfest.net> hat am 1. März 2017 um 17:39 geschrieben: > > > On Wed, 2017-03-01 at 16:51 +0300, Dan Carpenter wrote: > > On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote: > > > > > > > Michael Zoran <

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

> Michael Zoran hat am 28. Februar 2017 um 19:49 > geschrieben: > > > Change the audio's dependency on BCM2835_VCHIQ to a select. > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++- > 1 file

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

> Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben: > > ... > > For staging, Greg has been taking patches without platform maintainer > ack. I think this is great -- the staging code needs *lots* of work, > and it generally doesn't need any platform knowledge. > > As

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

> > What's the rule as to who exactly I should be including on patches? > get_maintainer.pl displays a very long list for stagging, so it isn't > clear to me who should be getting this. At least the active maintainers (bcm2835 + staging) and the relevant mailing lists. Usually i try to avoid

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

[add Eric] > Michael Zoran hat am 18. Februar 2017 um 12:59 > geschrieben: > > > On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote: > > The original github source allowed for the cache-line-size property > > to be missing. Since recent firmwares also require this

[PATCH 1/3] staging: vchiq_arm: Remove unnecessary includes

Including those headers is unnecessary, so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../interface/vchiq_arm/vchiq_2835_arm.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vch

[PATCH 3/3] staging: vchiq_arm: Don't define PAGE_SIZE

There is no need to define PAGE_SIZE in the vchiq driver so remove the define from vchiq_pagelist.h . Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../interface/vchiq_arm/vchiq_pagelist.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/s

[PATCH 2/3] staging: vchiq_arm: Include linux/mm.h

vchiq_2835_arm.c uses functions and macros like put_page() or PAGE_ALIGN(). So we better include the necessary header. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../interface/vchiq_arm/vchiq_2835_arm.c |1 + 1 file changed, 1 insertion(+) diff --git a/d

<    1   2   3   4   >