we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
we donot need the reboot notifier in module init section, as the
notifier is used after lcd is initialized. so lets register for the
reboot notifier only after we have successfully attached to the
parallel port. and similarly unregister at detach.
Signed-off-by: Sudip Mukherjee su
mention correct format specifier while printing
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
this patch will give checkpatch warnings about use of printk.
this patch was mainly to fix the build warnings. printk will be
converted to pr_* and dev_* in a later patch.
drivers/staging
On Sun, Mar 08, 2015 at 02:40:03PM +0200, Giedrius Statkevičius wrote:
On 2015.03.08 14:31, Sudip Mukherjee wrote:
mention correct format specifier while printing
index 711676c..2ab7b74 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -59,10 +59,10
obvious
checkpatch errors were taken care of.
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/sm750.c | 109 +++-
1 file changed, 52 insertions(+), 57 deletions(-)
diff --git
check if it is already defined before defining SM750LE_REVISION_ID
again and at the same time mention correct data type.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers
remove use of #pragma optimize which will usually be ignored by the
compiler.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/ddk750_swi2c.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
b/drivers/staging/sm750fb
On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevičius wrote:
On 2015.03.08 14:31, Sudip Mukherjee wrote:
-#define SM750LE_REVISION_ID (char)0xfe
+#ifndef SM750LE_REVISION_ID
+#define SM750LE_REVISION_ID ((unsigned char)0xfe)
+#endif
Do you need these parantheses? Also, you
On Fri, Mar 06, 2015 at 04:38:34PM -0800, Greg Kroah-Hartman wrote:
On Tue, Mar 03, 2015 at 04:21:06PM +0530, Sudip Mukherjee wrote:
---
this patch has lots of checkpatch warnings including some trailing
whitespaces.
And it has build warnings as well. Please send me patches to fix
On Sat, Mar 07, 2015 at 12:41:06PM +0100, Peter Senna Tschudin wrote:
sparse was complaining that the symbols 'lstcon_console_init'
and 'lstcon_console_fini' were not declared.
Declaring both as static.
you have not even build tested your patch.
WARNING: lstcon_console_init
these variables were assigned some values but they were never being
reused again.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
this patch will generate some checkpatch warning about line being above 80char,
but the code is so much indented that it is difficult to break the line
On Wed, Mar 04, 2015 at 07:53:10PM +0100, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
This patch removes the assignment of a function parameter that has no
effect.
then by the same logic you can also remove another rxb = NULL in
rtllib_rx_InfraAdhoc() function..
On Tue, Mar 03, 2015 at 04:19:17AM -0600, Drew Fustini wrote:
Move extern declartions from fbtft-core.c to fbtft header file. This resovles
the warning from checkpatch.pl that externs should be avoided in .c files.
but now it adds 6 additional warning in checkpatch --strict
extern prototypes
On Tue, Mar 03, 2015 at 02:49:47PM +0100, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
usually [PATCH 0/n] doesnot contain any patch, it can have a summary of your
patch series.
and since you are doing same type of change on rtl8188eu, i think you could
have sent a single
On Tue, Mar 03, 2015 at 11:47:18PM +, Cláudio Maia wrote:
Fixed two warnings occurring in lines that are over 80 characters and which
are not comments.
commit message should not be more than 72 characters.
Signed-off-by: Cláudio Maia c...@isep.ipp.pt
---
snip
static void
add myself and Teddy Wang as the Maintainer of the sm750
frame buffer driver.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9ee5466..1a51043 100644
--- a/MAINTAINERS
+++ b
Sudip Mukherjee (2):
staging: sm750fb: add sm750 to staging
MAINTAINERS: update for sm750fb driver
MAINTAINERS |8 +
drivers/staging/Kconfig |2 +
drivers/staging/Makefile |1 +
drivers/staging/sm750fb/Kconfig
On Mon, Mar 02, 2015 at 11:46:57AM +0300, Dan Carpenter wrote:
On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote:
On 02/27/2015 10:44 AM, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
This patch fixes the following errors:
ERROR: space prohibited before
On Wed, Feb 11, 2015 at 02:33:51PM +0800, Greg Kroah-Hartman wrote:
On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote:
Ok, that makes sense, I was thinking this was a new driver, instead of
a vendor driver crud.
Hi Greg,
The SM750 driver is almost ready for staging, it now
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
sparse was complaining that symbol 'vgamode' was not declared.
Declaring vgamode as static.
a similar patch has already been sent to Greg, which is not yet applied.
regards
sudip
Signed-off-by: Peter Senna Tschudin
On Sun, Feb 22, 2015 at 08:38:50PM +0100, Matteo Semenzato wrote:
From: Matteo Semenzato mattew8...@gmail.com
This patch fixes the following errors:
ERROR: space required after that ','
ERROR: trailing whitespace
Signed-off-by Matteo Semenzato mattew8...@gmail.com
checkpatch complains -
On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote:
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
you are doing three different
On Thu, Feb 12, 2015 at 01:43:00AM +0300, Dan Carpenter wrote:
On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
Maybe some help/warning text like:
--forceWithout --force, checkpatch will not scan files
using -f or --file
these functions are not being used anywhere.so we can remove them.
has been verified by git grep that they are not being referenced
anywhere also has been build tested.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
i am not sure if this is correct. req_handler_add() and req_handler_del
initialiaze lcd parameters only if lcd is enabled.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: fix indention of comment
drivers/staging/panel/panel.c | 41 ++---
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/drivers/staging
On Tue, Feb 10, 2015 at 02:34:15PM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote:
But as I've missed this in the past, nevermind, I'll take it as is. Can
you resend your outstanding patches and I'll queue them up after
3.20-rc1
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
@@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter
*adapt, u8 *powerlevel)
ptr++;
}
}
- rtl88eu_dm_txpower_track_adjust(hal_data-odmpriv, 1, direction,
-
we were getting lots of warnings about _tempresult set but not used.
_tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY
which was again using another macro ISSUE_IO_EXTENDED_VMCALL.
but the value assigned to it was never used.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
we were getting three warnings about timskmod and sparstopdriver
and channels. These warnings were about no such file or directory.
These directory names were included in the Makefile, but the
directories were not existing.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
make W=1
register the driver only if lcd or keypad has been enabled and if
both are disabled then just exit.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/panel
initialiaze lcd parameters only if lcd is enabled.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 41 ++---
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers
the variable vgamode is used only in this file and hence can be
safely made as static.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote:
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert lambert.quen...@gmail.com
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 6
Hi Greg,
we have this sm7xxfb in drivers/staging now which is supporting SM710, SM712,
SM721 and SM722. I am also working on another new hardware SM750, which will be
ready for staging in next 1 -2 weeks.
this SM750 is entirely different hardware and these two drivers will have
nothing in
On Tue, Feb 10, 2015 at 06:32:49PM +0530, Pushpendra Singh wrote:
Removed checkpatch.pl error
ERROR: code indent should use tabs where possible
Signed-off-by: Pushpendra Singh pushpendra.si...@smartplayin.com
---
drivers/staging/rtl8188eu/hal/rf.c | 3 +--
1 file changed, 1 insertion(+),
On Tue, Feb 10, 2015 at 02:34:15PM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote:
Nothing to do on your side, I am on the road this week and will move
those to my -next branch right now, thanks for reminding me.
welcome sir. If you ever need
On Tue, Feb 10, 2015 at 05:35:40AM +0800, Greg Kroah-Hartman wrote:
On Sun, Feb 08, 2015 at 04:31:07PM +0530, Sudip Mukherjee wrote:
On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote:
On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote:
we were getting lots
On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote:
On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote:
we were getting lots of warnings about _tempresult set but not used.
_tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY
which was again using
On Thu, Feb 05, 2015 at 06:39:13PM +0100, Rickard Strandqvist wrote:
2015-02-05 13:51 GMT+01:00 Dan Carpenter dan.carpen...@oracle.com:
On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
if (driver_info) {
stats-RxIs40MHzPacket = driver_info-BW;
if (stats
we were getting lots of warnings about _tempresult set but not used.
_tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY
which was again using another macro ISSUE_IO_EXTENDED_VMCALL.
but the vallue assigned to it was never used.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
we were getting three warnings about timskmod and sparstopdriver
and channels. These warnings were about no such file or directory.
These directory names were included in the Makefile, but the
directories were not existing.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging
On Thu, Feb 05, 2015 at 03:27:45PM +0300, Dan Carpenter wrote:
I don't know if this patch was merged before Greg cleaned out his inbox.
It's a good patch if you could just clean it up a bit.
On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote:
Fix a possible null pointer
of fb_get_options()
and
that will also fix the compilation warning of unused function.
thanks
sudip
Sudip Mukherjee (2):
staging: sm7xxfb: fix camelcase
staging: sm7xxfb: fix remaining camelcase
drivers/staging/sm7xxfb/sm7xx.h | 44 ++---
drivers/staging/sm7xxfb/sm7xxfb.c
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
regards
sudip
Signed-off-by: Max Perepelitsyn mperepelit...@gmail.com
---
On Tue, Feb 03, 2015 at 08:54:45PM +0530, Mohammad Jamal wrote:
This patch adds a static keyword to lprocfs_lmv_init_vars and
lprocfs_lmv_module_vars to suppress the sparse warnings about
static declaration
have you build tested your patch?
After your patch:
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c
Signed-off-by: Max Perepelitsyn mperepelit...@gmail.com
Tested-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
1 file
On Thu, Jan 29, 2015 at 07:46:10PM +0100, Rickard Strandqvist wrote:
Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote:
Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
checkpatch cleanup to add missing blank line after declaration
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index c550b71
This reverts commit dc93c85235efa5201e9a3c116bc3fbd1afc1a182
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: checkpatch cleanup has been added to the series.
after this series CamelCase is the only pending style related issue.
i have two doubts:
1) will it be easier if i have a git
checkpatch cleanup: space is not necessary after cast
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
checkpatch cleanup: alignment should match open parenthesis
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
checkpatch cleanup: blank lines are not necessary before closing brace
and after opening brace.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
these are actually two different checkpatch warning, but am sending
them together as they are of similar type.
drivers/staging/sm7xxfb
add myself and Teddy Wang as the Maintainer of the
SM7XX FRAME BUFFER DRIVER.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dbc17b3..4fd647e 100644
--- a/MAINTAINERS
+++ b
update the email addresses in the TODO file, also update the final
destination of this driver.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/TODO | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/TODO b/drivers
On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
This patch fixes the following checkpatch.pl error:
rxtx.c:588: WARNING: else is not generally useful
On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
any reason why this return was removed ?
Because it's not needed.
yes, it is not needed
On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
This patch fixes the following checkpatch.pl error:
rxtx.c:588: WARNING: else is not generally useful after a break or return
was the checkpatch error solved with this change? have you checked?
and the checkpatch is giving error at
On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote:
On 06/01/15 06:02, Sudip Mukherjee wrote:
On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
On 01/04, Piotr Kubus wrote:
This is a patch to the dmm32at.c
On Tue, Jan 06, 2015 at 02:33:27PM +0100, Konrad Zapalowicz wrote:
On 01/06, Sudip Mukherjee wrote:
yes, i read the SubmittingPatches again. summary is the subject line. But
then as Piotr Kubus has written that he could not find this rule in the
documentaion, I also tried to find
On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
On 01/04, Piotr Kubus wrote:
This is a patch to the dmm32at.c file that fixes up a code indent error
found by the checkpatch.pl tool.
Nice however improve
On Mon, Jan 05, 2015 at 11:56:40AM +0530, jitendra kumar khasdev wrote:
This is patch to pcl812.c that fix 80 character line limit which is found
by checkpatch.pl tool.
I have already sent this patch earlier but it was in 5 different patches,
this time I have make it into one patch.
this
On Sat, Jan 03, 2015 at 02:06:23PM +0530, jitendra kumar khasdev wrote:
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
what is Singed-off ??? why you are doing Signed-off
On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote:
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
I am assuming this one you wanted to make as v3.
but
This reverts commit dc93c85235efa5201e9a3c116bc3fbd1afc1a182
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Hi Greg K-H
With reference to our discussion at https://lkml.org/lkml/2014/11/22/54 ,
now I have the hardware and I will be working on the code along with
Teddy Wang.
drivers
On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote:
This patch fixes warnings/errors raised by checkpatch.pl relating to
whitespace
in r8192U_dm.c and additionally it removes inconsistent whitespace
throughout.
Additionally some 0x00... padding has been added for alignment to
On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote:
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 176
On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote:
On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote:
This patch fixes warnings/errors raised by checkpatch.pl relating to
redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
On Wed, Dec 31, 2014 at 09:40:13PM -0800, Joe Perches wrote:
On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote:
On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote:
This patch fixes warnings/errors raised by checkpatch.pl relating to
whitespace
in r8192U_dm.c
On Tue, Dec 30, 2014 at 07:04:35PM -0800, Serguey Parkhomovsky wrote:
On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
If you look at the source code just below these functions you will find:
EXPORT_SYMBOL(libcfs_arch_init);
EXPORT_SYMBOL(libcfs_arch_cleanup);
So
of current v2 indentation, I'll do it, please let me know.
well, if you check CodingStyle in Documentation, it clearly says:
Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation.
Sudip
On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee
sudipm.mukher
On Sat, Dec 27, 2014 at 07:45:07PM +0100, Rickard Strandqvist wrote:
Avoid allocate memory if we will exit the function.
Was found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
On Sun, Dec 28, 2014 at 09:30:44PM +0100, Jonas Lundqvist wrote:
Hi Jeremiah,
On 12/28/2014 04:44 PM, Jeremiah Mahler wrote:
Jonas,
On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote:
Fixed three errors in pcm.h found by checkpatch.pl.
What type of errors did you
On Mon, Dec 29, 2014 at 03:14:45AM +0530, jitendra kumar khasdev wrote:
This is a patch to the s626.c file that fixes up spcae and maximum
character limit warning found by the checkpatch.pl tool
you are doing two different kind of changes in this patch. it should be in two
different patches.
On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote:
Before:
1 ERROR: code indent should use tabs where possible
1 WARNING: please, no spaces at the start of a line
After:
(none)
Signed-off-by: David Decotigny ddeco...@gmail.com
---
On Fri, Dec 26, 2014 at 10:00:00AM +, Jonathan Cameron wrote:
On 22/12/14 13:48, Sudip Mukherjee wrote:
On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
Signed-off-by: Helene Gsaenger helene.gsaen...@studium.fau.de
Signed-off-by: Simone Weiss simone.we...@fau.de
On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
Signed-off-by: Helene Gsaenger helene.gsaen...@studium.fau.de
Signed-off-by: Simone Weiss simone.we...@fau.de
---
drivers/staging/iio/accel/adis16203.h | 41
++-
1 file changed, 31
On Mon, Dec 08, 2014 at 11:33:25PM +0530, Adithya K wrote:
From: Adithya Krishnamurthy linux.challe...@gmail.com
Fixed sparse warning fix.
you should mention what type of warning you have fixed.
sudip
Signed-off-by: Adithya Krishnamurthy linux.challen...@gmail.com
---
---
On Sun, Dec 07, 2014 at 11:02:44PM +0100, Rickard Strandqvist wrote:
Remove the function MACbCompareContext() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.
it is not applying to next-20141205. is it based on staging-testing ?
thanks
sudip
On Fri, Dec 05, 2014 at 10:28:19PM +0100, Mariusz Gorski wrote:
Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.
Signed-off-by: Mariusz Gorski marius.gor...@gmail.com
---
v2: Found and got rid of two more
On Fri, Dec 05, 2014 at 04:25:22PM +0530, Athira Lekshmi wrote:
Fixed the checkpatch warning:
Missing a blank line after declarations
this is not applying to next-20141204.
sudip
Signed-off-by: Athira Lekshmi andnlnb...@gmail.com
---
drivers/staging/octeon/ethernet-rx.c |1 +
1
On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote:
On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
From: Fred Chou fred.chou...@gmail.com
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c
On Thu, Dec 04, 2014 at 05:34:11PM +0800, Fred Chou wrote:
On 4/12/2014 4:30 PM, Sudip Mukherjee wrote:
On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote:
On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
From: Fred
On Wed, Dec 03, 2014 at 02:30:29PM +0800, Fred Chou wrote:
From: Fred Chou fred.chou...@gmail.com
v2: alignment to match open parenthesis
this should not come in commit log, this should go as a comment below the ---
and this patch is not applying to next-20141201, maybe in staging-testing
On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
From: Fred Chou fred.chou...@gmail.com
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
these header files were included two times
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/include/timskmod.h | 1 -
drivers/staging/unisys/uislib/uisutils.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
b/drivers
On Tue, Dec 02, 2014 at 01:46:54AM -0800, Jeremiah Mahler wrote:
Sudip,
On Tue, Dec 02, 2014 at 02:34:58PM +0530, Sudip Mukherjee wrote:
these header files were included two times
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/include/timskmod.h | 1
these header files were included multiple times
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
change in v2: missed seeing that linux/uuid.h is included 3 times
drivers/staging/unisys/include/timskmod.h | 1 -
drivers/staging/unisys/uislib/uisutils.c | 2 --
2 files changed, 3
On Tue, Dec 02, 2014 at 08:27:46AM -0600, Paul Hedman wrote:
From: Paul p...@mybb.com
This patch fixes various coding standards violations found by the
checkpatch.pl tool
Signed-off-by: Paul Hedman m...@paulhedman.com
---
1) you are doing multiple things in this patch. please do only
On Wed, Dec 03, 2014 at 10:38:27AM +0800, Fred Chou wrote:
From: Fred Chou fred.chou...@gmail.com
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
On Tue, Dec 02, 2014 at 07:30:40PM -0600, Paul Hedman wrote:
Fixes spacing issues around operators, e.g. i=0 to i = 0, as
found by the checkpatch.pl tool.
no Signed-off-by ???
please run your patch through checkpatch before sending.
thanks
sudip
---
On Tue, Dec 02, 2014 at 11:45:00PM +, Sean Cleator wrote:
A patch to the slicoss.c file to fix some of the long line issues found by
the
checkpath.pl tool
Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk
do not use whitespace before Signed-off-by
thanks
sudip
---
On Sat, Nov 22, 2014 at 09:50:20PM +0530, Sudip Mukherjee wrote:
On Sat, Nov 22, 2014 at 06:00:40AM -0800, Greg Kroah-Hartman wrote:
On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote:
2) most important - I do not have the hardware. So from the TODO list
dual head and 2D
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote:
The following chaeckpatch warning was fixed:
WARNING: line over 80 characters
Signed-off-by: Lekshmi andnlnb...@gmail.com
---
drivers/staging/wlan-ng/prism2fw.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
On Sat, Nov 22, 2014 at 01:20:13PM +0530, anjana s wrote:
Just now I resend the same patch by making necessary changes.
Kindly please go through it
you replied only to me. You should always use reply to all unless there is some
specific reason not to send the reply to all.
thanks
sudip
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
This patch fixes the checkpatch.pl error:
it still does not apply to next-20141121
ERROR: trailing whitespace
and i am not seeing any trailing whitespace at line 191 of this file.
if you base your patch on
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
This patch fixes the checkpatch.pl error:
this patch is not applying to next-20141121.
ERROR: trailing whitespace
but your patch is adding a blank line in the code ?
thanks
sudip
Signed-off-by: Anjana Sasindran
, then no
need to check it again.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
hi,
struct mlme_priv *pmlmepriv and bLinked was moved to the beginning of
the function, otherwise it was giving warning about mixed code while
compiling.
drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 +---
drivers
a variable is declared and initialized and then never updated in the
function.This default value is then used as the return from the
function.
So removed that unneeded return variable and returning that default
initial value directly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
801 - 900 of 962 matches
Mail list logo
