Re: [PATCH 04/10] staging: ks7010: fix checkpatch BRACES

2017-03-21 Thread Tobin C. Harding
On Tue, Mar 21, 2017 at 03:36:34PM +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK: Unbalanced braces around else > > statement. Statements in question are single statements so we do not > > need braces. Checkpatch also

Re: [PATCH 04/10] staging: ks7010: fix checkpatch BRACES

2017-03-21 Thread Dan Carpenter
On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote: > Checkpatch emits CHECK: Unbalanced braces around else > statement. Statements in question are single statements so we do not > need braces. Checkpatch also warns about multiple line dereference for > this code. > > Fix

[PATCH 04/10] staging: ks7010: fix checkpatch BRACES

2017-03-20 Thread Tobin C. Harding
Checkpatch emits CHECK: Unbalanced braces around else statement. Statements in question are single statements so we do not need braces. Checkpatch also warns about multiple line dereference for this code. Fix if/else/else if statement use of braces. Fix function argument layout at the same time