Re: [PATCH 20/21] erofs: kill use_vmap module parameter

2019-09-02 Thread Gao Xiang
Hi Christoph, On Mon, Sep 02, 2019 at 05:31:24AM -0700, Christoph Hellwig wrote: > > @@ -224,9 +220,6 @@ static void *erofs_vmap(struct page **pages, unsigned > > int count) > > { > > int i = 0; > > > > - if (use_vmap) > > - return vmap(pages, count, VM_MAP, PAGE_KERNEL); > > -

Re: [PATCH 20/21] erofs: kill use_vmap module parameter

2019-09-02 Thread Christoph Hellwig
> @@ -224,9 +220,6 @@ static void *erofs_vmap(struct page **pages, unsigned int > count) > { > int i = 0; > > - if (use_vmap) > - return vmap(pages, count, VM_MAP, PAGE_KERNEL); > - > while (1) { > void *addr = vm_map_ram(pages, count, -1, PAGE_KERNEL);

[PATCH 20/21] erofs: kill use_vmap module parameter

2019-08-31 Thread Gao Xiang
From: Gao Xiang As Christoph said [1], "vm_map_ram is supposed to generally behave better. So if it doesn't please report that that to the arch maintainer and linux-mm so that they can look into the issue. Having user make choices of deep down kernel internals is just a horrible interface. Ple