Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread David Miller
From: Scott Schafer Date: Thu, 12 Dec 2019 09:02:00 -0600 > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: >> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: >> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct >> > mbox_params *mbcp) >>

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread Dan Carpenter
On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote: > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, > > > struct mbox_params *mbc

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread Greg KH
On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote: > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, > > > struct mbox_params *mbc

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread Scott Schafer
On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct > > mbox_params *mbcp) > > mbcp->out_count = 6; > > > > status = ql_get_mb_sts(qd

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread Dan Carpenter
On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct > mbox_params *mbcp) > mbcp->out_count = 6; > > status = ql_get_mb_sts(qdev, mbcp); > - if (status) > + if (status) { > ne

[PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-11 Thread Scott Schafer
Fix CHECK: braces {} should be used on all arms of this statement in qlge_ethtool.c and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 18 -- drivers/staging/qlge/qlge_mpi.c | 9 ++--- 2 files changed, 18 insertions(+), 9 deletions(-)