Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread Sergio Paracuellos
On Thu, Jul 26, 2018 at 1:24 PM, Sergio Paracuellos wrote: > On Thu, Jul 26, 2018 at 08:02:17PM +1000, NeilBrown wrote: >> On Thu, Jul 26 2018, Sergio Paracuellos wrote: >> >> > >> > Ok, I think the problem is we are not setting the bridge->windows retrieved >> > with

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread Sergio Paracuellos
On Thu, Jul 26, 2018 at 08:02:17PM +1000, NeilBrown wrote: > On Thu, Jul 26 2018, Sergio Paracuellos wrote: > > > > > Ok, I think the problem is we are not setting the bridge->windows retrieved > > with devm_request_pci_bus_resources in "res". So we have to set those > > properly > > to the

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread NeilBrown
On Thu, Jul 26 2018, Sergio Paracuellos wrote: > > Ok, I think the problem is we are not setting the bridge->windows retrieved > with devm_request_pci_bus_resources in "res". So we have to set those properly > to the bridge to get all correctly assigned. So I think adding this should > make >

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread Sergio Paracuellos
On Thu, Jul 26, 2018 at 04:45:41PM +1000, NeilBrown wrote: > On Thu, Jul 26 2018, Sergio Paracuellos wrote: > > > On Thu, Jul 26, 2018 at 6:50 AM, NeilBrown wrote: > >> On Wed, Jul 25 2018, Sergio Paracuellos wrote: > >> > >>> On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: > On

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread Sergio Paracuellos
On Thu, Jul 26, 2018 at 04:45:41PM +1000, NeilBrown wrote: > On Thu, Jul 26 2018, Sergio Paracuellos wrote: > > > On Thu, Jul 26, 2018 at 6:50 AM, NeilBrown wrote: > >> On Wed, Jul 25 2018, Sergio Paracuellos wrote: > >> > >>> On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: > On

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread NeilBrown
On Thu, Jul 26 2018, Sergio Paracuellos wrote: > On Thu, Jul 26, 2018 at 6:50 AM, NeilBrown wrote: >> On Wed, Jul 25 2018, Sergio Paracuellos wrote: >> >>> On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: On Mon, Jul 16 2018, Sergio Paracuellos wrote: > This patch series

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-26 Thread Sergio Paracuellos
On Thu, Jul 26, 2018 at 6:50 AM, NeilBrown wrote: > On Wed, Jul 25 2018, Sergio Paracuellos wrote: > >> On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: >>> On Mon, Jul 16 2018, Sergio Paracuellos wrote: >>> >>> > This patch series include an attempt to avoid the use of custom >>> >

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-25 Thread NeilBrown
On Wed, Jul 25 2018, Sergio Paracuellos wrote: > On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: >> On Mon, Jul 16 2018, Sergio Paracuellos wrote: >> >> > This patch series include an attempt to avoid the use of custom >> > read and writes in driver code and use PCI subsystem common

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-25 Thread Sergio Paracuellos
On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: > On Mon, Jul 16 2018, Sergio Paracuellos wrote: > > > This patch series include an attempt to avoid the use of custom > > read and writes in driver code and use PCI subsystem common ones. > > > > In order to do this 'map_bus' callback is

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-25 Thread Sergio Paracuellos
On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote: > On Mon, Jul 16 2018, Sergio Paracuellos wrote: > > > This patch series include an attempt to avoid the use of custom > > read and writes in driver code and use PCI subsystem common ones. > > > > In order to do this 'map_bus' callback is

Re: [PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-24 Thread NeilBrown
On Mon, Jul 16 2018, Sergio Paracuellos wrote: > This patch series include an attempt to avoid the use of custom > read and writes in driver code and use PCI subsystem common ones. > > In order to do this 'map_bus' callback is implemented and also > data structures for driver are included. The

[PATCH v4 00/15] staging: mt7621-pci: avoid custom pci config read and writes

2018-07-16 Thread Sergio Paracuellos
This patch series include an attempt to avoid the use of custom read and writes in driver code and use PCI subsystem common ones. In order to do this 'map_bus' callback is implemented and also data structures for driver are included. The regs base address is being readed from device tree and the