Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 02:33:39PM +0900, Johnny Kim wrote: On 2015년 06월 11일 09:40, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler)

Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Dan Carpenter
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: This replace the argument of the function to the independent data type in system. Signed-off-by: Johnny Kim johnny@atmel.com This changelog says what you are doing but not why. What is the point of -u32Address? Now that it's

Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the real function pointer instead? Also, lots of these

Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Johnny Kim
On 2015년 06월 11일 09:40, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the real