[PATCH] driver-core: fix odd_ptr_err.cocci warnings

2016-11-10 Thread Julia Lawall
PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Dmitry Torokhov Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- 0-day warning related to the

Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings

2016-11-10 Thread Julia Lawall
On Thu, 10 Nov 2016, Dmitry Torokhov wrote: > [ resending as plain text ] > > On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov wrote: > > > > > > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall wrote: > >> > >> PTR_ERR should access the value just

Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure

2016-11-10 Thread Greg KH
On Mon, Nov 07, 2016 at 07:41:27AM -0800, Michael Zoran wrote: > On Mon, 2016-11-07 at 11:03 +0100, Greg KH wrote: > > On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote: > > > The current dma_map_sg based implementation for bulk messages > > > computes many offsets into a single

[PATCH] driver-core: fix platform_no_drv_owner.cocci warnings

2016-11-10 Thread Julia Lawall
Remove .owner field initialization as the core will do it. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Dmitry Torokhov Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- 0-day warning: tree:

Re: [PATCH] staging: lustre: lov: Fix signed wrap around when decrementing index 'i'

2016-11-10 Thread Dilger, Andreas
On Nov 10, 2016, at 07:19, Colin King wrote: > > From: Colin Ian King > > Change predecrement compare to post decrement compare to avoid an > unsigned integer wrap-around comparisomn when decrementing in the while > loop. > > Issue found

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Masahiro Yamada
2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman : > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: >> >> sdhci_alloc_host() returns an error pointer when it fails. >> but mmc_alloc_host() cannot. >> >> This series allow to propagate a proper error code

Re: [PATCH 06/35] staging: lustre: osc: Performance tune for LRU

2016-11-10 Thread kbuild test robot
Hi Jinshan, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20161110] [cannot apply to v4.9-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/James-Simmons

[PATCH v2] staging: vc04_services: rework ioctl code path

2016-11-10 Thread Michael Zoran
VCHIQ/vc04_services has a userland device interface that includes ioctls. The current ioctl implementation is a single monolithic function over 1,000+ lines that handles 17 different ioctls through a complex maze of switch and if statements. The change reimplements that code path by breaking up

Re: [PATCH 05/35] staging: lustre: llog: fix wrong offset in llog_process_thread()

2016-11-10 Thread kbuild test robot
Hi Mikhail, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20161110] [cannot apply to v4.9-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/James-Simmons

[PATCH] [STYLE]staging:braille:braille_console.c [2/2]

2016-11-10 Thread Walt Feasel
Made suggested modifications from checkpatch in reference to WARNING: Missing a blank line after declarations Signed-off-by: Walt Feasel --- drivers/accessibility/braille/braille_console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] [STYLE]staging:braille:braille_console.c [1/2]

2016-11-10 Thread Walt Feasel
Made suggested modifications from checkpatch in reference to ERROR: Use 4 digit octal (0777) not decimal permissions Signed-off-by: Walt Feasel --- drivers/accessibility/braille/braille_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: dgnc: re-arrange functions for removing forward declarations

2016-11-10 Thread Daeseok Youn
Re-arrange the functions for removing forward declarations in dgnc_driver.c Signed-off-by: Daeseok Youn --- I've checked the object size of dgnc_driver.c before and after. It has same size after re-arranging functions. drivers/staging/dgnc/dgnc_driver.c | 533

Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings

2016-11-10 Thread Dmitry Torokhov
[ resending as plain text ] On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov wrote: > > > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall wrote: >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Generated by:

Re: [PATCH] staging: mfa384x_usb: Corrected code indentation in hfa384x_usb.c to resolve checkpatch.pl warn

2016-11-10 Thread Greg Kroah-Hartman
On Tue, Nov 08, 2016 at 06:51:08AM +, Angus Gardner wrote: > Corrected indentation in drivers/staging/wlan-ng/hfa384x_usb.c to resolve > checkpatch.pl warninigs This is almost the same thing you said in the Subject:, care to make it different? And fix up your line to wrap properly at 72

Re: [PATCH] Staging: used dma_map_single in place of pci_map_single

2016-11-10 Thread Greg KH
On Tue, Nov 08, 2016 at 02:52:08AM +0530, Nadim Almas wrote: > pci_map_single is unneeded and can be replaced with dma_map_single > to avoid inconcitent api usage. > The Coccinelle semantic patch used to make this change is as follows: > @@ expression E1,E2,E3; @@ > - pci_map_single(E1, > +

[PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Masahiro Yamada
sdhci_alloc_host() returns an error pointer when it fails. but mmc_alloc_host() cannot. This series allow to propagate a proper error code when host-allocation fails. Masahiro Yamada (2): mmc: allow mmc_alloc_host() to return proper error code mmc: tmio: allow tmio_mmc_host_alloc() to

[PATCH] staging: lustre: lov: Fix signed wrap around when decrementing index 'i'

2016-11-10 Thread Colin King
From: Colin Ian King Change predecrement compare to post decrement compare to avoid an unsigned integer wrap-around comparisomn when decrementing in the while loop. Issue found with static analysis with CoverityScan, CID 1375917 Signed-off-by: Colin Ian King

[PATCH] Arch: arm: mm: Aligning the module end and Correction in

2016-11-10 Thread Shailendra Verma
From: "Shailendra Verma" The module end was not aligned as of module start and boundary check for module end is not proper.This out of bound value of module end can produce undesired results. Reported-by: Hillf Danton Signed-off-by:

Re: [PATCH 1/2] staging: lustre: llite: use u64 instead of loff_t in lov_object_fiemap()

2016-11-10 Thread Greg KH
On Tue, Nov 08, 2016 at 12:13:59PM +, Xu, Bobijam wrote: > Change loff_t to u64 in lov_object_fiemap() since loff_t is a signed > value type. > > Otherwise there could be an overflow in > drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap() > warn: signed overflow

Re: [PATCH v3] staging: lustre: mdc: manage number of modify RPCs in flight

2016-11-10 Thread Greg Kroah-Hartman
On Mon, Nov 07, 2016 at 05:23:23PM -0500, James Simmons wrote: > From: Gregoire Pichon > > This patch is the main client part of a new feature that supports > multiple modify metadata RPCs in parallel. Its goal is to improve > metadata operations performance of a single

[patch] staging/lustre/osc: indent an if statement

2016-11-10 Thread Dan Carpenter
We accidentally removed a tab here. Let's add it back, and some curly braces as well since this is a muti-line indent. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre/osc/osc_lock.c index

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 01:33:10PM +0100, Shiva Kerdel wrote: > Sorry for this misunderstanding, > > Since received a response from Stuart on my previous patch telling me I was > probably working on a out-of-date codebase, > I started to look where I did go wrong. > > After some research I found

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Greg Kroah-Hartman
On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: > > sdhci_alloc_host() returns an error pointer when it fails. > but mmc_alloc_host() cannot. > > This series allow to propagate a proper error code > when host-allocation fails. Why? What can we really do about the error except

[PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] mmc: allow mmc_alloc_host() to return proper error code

2016-11-10 Thread Masahiro Yamada
Currently, mmc_alloc_host() returns NULL on error, so its callers cannot return anything but -ENOMEM when it fails, assuming the most failure cases are due to memory shortage, but it is not true. Allow mmc_alloc_host() to return an error pointer, then propagate the proper error code to its

[PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 03:09:07PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- > 1 file

[PATCH 2/2] Staging: Media: Lirc - Improvement in code readability

2016-11-10 Thread Shailendra Verma
From: "Shailendra Verma" There is no need to call kfree() if memdup_user() fails, as no memory was allocated and the error in the error-valued pointer should be returned. Signed-off-by: Shailendra Verma ---

[PATCH v3 28/28] staging: iio: tsl2583: move out of staging

2016-11-10 Thread Brian Masney
Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline. Signed-off-by: Brian Masney --- .../ABI/testing/sysfs-bus-iio-light-tsl2583| 20 + drivers/iio/light/Kconfig | 7 + drivers/iio/light/Makefile |

[PATCH v3 27/28] staging: iio: tsl2583: add copyright and MODULE_AUTHOR

2016-11-10 Thread Brian Masney
Add Brian Masney's copyright to the header and to the MODULE_AUTHOR for all of the staging cleanups that has been done to this driver. The original MODULE_AUTHOR() did not have a space between his name and email address. This patch also adds the missing space. Signed-off-by: Brian Masney

Re: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE

2016-11-10 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Nov 08, 2016 at

Re: [PATCH 00/15] device-global identifiers and routes introduced

2016-11-10 Thread Greg Kroah-Hartman
On Wed, Oct 12, 2016 at 05:05:07AM -0600, Spencer E. Olson wrote: > This patchset introduces a new framework for providing and maintaining a > consistent namespace to define terminal/signal names for a set of comedi > devices. This effort was primarily focused on supporting NI hardware, but the >

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Shiva Kerdel
Sorry for this misunderstanding, Since received a response from Stuart on my previous patch telling me I was probably working on a out-of-date codebase, I started to look where I did go wrong. After some research I found out that I was always one step behind because I was developing on the

[PATCH] Staging: Media: Lirc - Improvement in code readability

2016-11-10 Thread Shailendra Verma
From: "Shailendra Verma" There is no need to call kfree() if memdup_user() fails, as no memory was allocated and the error in the error-valued pointer should be returned. Signed-off-by: Shailendra Verma ---

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong

2016-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2016 at 05:00:42PM +0100, Arnd Bergmann wrote: > On Wednesday, November 9, 2016 3:50:29 AM CET Dilger, Andreas wrote: > > On Nov 7, 2016, at 19:47, James Simmons wrote: > > > > > > The ldlm_pool field pl_recalc_time is set to the current > > > monotonic

[PATCH v3 01/28] staging: iio: tsl2583: split out functionality of taos_chip_on()

2016-11-10 Thread Brian Masney
taos_chip_on() reads an eight member array called taos_config that contains the desired state of the chip's registers. Only four of the registers actually need to be written to. The four that do not need to be written to are for the {low,high} byte of the lower interrupt threshold and the

[PATCH v3 10/28] staging: iio: tsl2583: unify function and variable prefix to tsl2583_

2016-11-10 Thread Brian Masney
Some functions and variables were prefixed with either taos, tsl258x, taos2583, or tsl2583. Change everything to use the tsl2583 prefix since that is the name of the .c file. The taos_settings member inside the taos_settings struct was renamed to als_settings. Signed-off-by: Brian Masney

[PATCH v3 04/28] staging: iio: tsl2583: remove unnecessary chip status check in taos_get_lux

2016-11-10 Thread Brian Masney
taos_get_lux checks to see if the chip is in a working state. This check is not necessary since it is only called from tsl2583_read_raw and in_illuminance_calibrate_store (via taos_als_calibrate). The chip state is already checked by these functions. Signed-off-by: Brian Masney

[PATCH v3 02/28] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

2016-11-10 Thread Brian Masney
When updating the in_illuminance_calibscale and in_illuminance_integration_time sysfs attributes, these values were not actually written to the chip. The chip would continue to use the old parameters. Extracted out tsl2583_set_als_gain() and tsl2583_set_als_time() functions that are now called

[PATCH v3 07/28] staging: iio: tsl2583: remove redundant write to the control register in taos_probe()

2016-11-10 Thread Brian Masney
taos_probe() calls i2c_smbus_write_byte() to select the control register, however there are no subsequent calls to i2c_smbus_read_byte(). The write call is unnecessary and is removed by this patch. Verified that the driver still functions correctly using a TSL2581 hooked up to a Raspberry Pi 2.

[PATCH v3 12/28] staging: iio: tsl2583: fix comparison between signed and unsigned integers

2016-11-10 Thread Brian Masney
Fixed warning found by make W=2: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v3 00/28] staging: iio: tsl2583: move out of staging

2016-11-10 Thread Brian Masney
This patch set continues my work to clean up the tsl2583 driver to move it out of staging. Some highlights include: - Eliminated some unnecessary i2c calls to the sensor. - Fixed issue with changes to calibscale and int_time not being set on the chip. - Moved from a global lux table to a per

[PATCH v3 08/28] staging: iio: tsl2583: remove the FSF's mailing address

2016-11-10 Thread Brian Masney
Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian Masney

[PATCH v3 16/28] staging: iio: tsl2583: updated code comment to match what the code does

2016-11-10 Thread Brian Masney
If channel 0 does not have any data, then the code sets the lux to zero. The corresponding comment says that the last value is returned. This updates the comment to correctly reflect what the code does. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c |

[PATCH v3 11/28] staging: iio: tsl2583: fix alignment of #define values

2016-11-10 Thread Brian Masney
Most of the values in the #defines have their values aligned on a single column, but some do not. This changes the remaining defines to use consistent alignment with the majority to improve code readability. Signed-off-by: Brian Masney ---

[PATCH v3 13/28] staging: iio: tsl2583: change newlines to improve readability

2016-11-10 Thread Brian Masney
Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH v3 14/28] staging: iio: tsl2583: combine sysfs documentation

2016-11-10 Thread Brian Masney
There are two separate files describing the tsl2583 sysfs attributes. Combine the two files into one. Updated the name of the sysfs attributes to match the current ABI. Signed-off-by: Brian Masney Suggested-by: Peter Meerwald-Stadler ---

[PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

2016-11-10 Thread Brian Masney
in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. Replace this with sizeof(unsigned int). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 17/28] staging: iio: tsl2583: moved code block inside else statement

2016-11-10 Thread Brian Masney
The check for ch1lux > ch0lux inside tsl2583_get_lux is only valid if the ratio is not equal to zero. Move the code block inside the else statement. This does away with the need to initialize the variables to zero. Signed-off-by: Brian Masney ---

[PATCH v3 15/28] staging: iio: tsl2583: fix multiline comment syntax

2016-11-10 Thread Brian Masney
The definition of the tsl2583_device_lux struct has a series of single line comments. There are two other cases where the multiline comments did not have an initial blank line. Change these comments to use the proper multiline syntax. Signed-off-by: Brian Masney ---

[PATCH v3 09/28] staging: iio: tsl2583: cleaned up logging

2016-11-10 Thread Brian Masney
There are several places in the code where the function name is hardcoded in the log message. Use the __func__ constant string to build the log message. This also clarifies some of the error messages to match the code and ensures that the correct priority is used since the message is already being

[PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

2016-11-10 Thread Brian Masney
in_illuminance_calibrate_store() did not check to see if the chip is suspended. This patch adds the proper check. The return value from taos_als_calibrate() was also not checked in this function, so the proper check was also added while changes are being made here. Signed-off-by: Brian Masney

[PATCH v3 05/28] staging: iio: tsl2583: remove unnecessary chip status checks in suspend/resume

2016-11-10 Thread Brian Masney
The device probing and the suspend/resume code checks a flag internal to the driver that determines whether or not the chip is in a working state. These checks are not needed. This patch removes the unnecessary checks. It will do no harm to the hardware if the chip is reinitialized if it is

[PATCH v3 06/28] staging: iio: tsl2583: change current chip state from a tristate to a bool

2016-11-10 Thread Brian Masney
The current chip state is represented as a tristate (working, suspended, and unknown). The unknown state was not used. This patch changes the chip state so that it is now represented as a single boolean value (suspended). Signed-off-by: Brian Masney ---

RE: [PATCH 1/3] PCI: hv: use the correct buffer size in new_pcichild_device()

2016-11-10 Thread Jake Oshins
> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:18 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang

RE: [PATCH 1/3] PCI: hv: use the correct buffer size in new_pcichild_device()

2016-11-10 Thread Dexuan Cui
> From: Jake Oshins > > From: Dexuan Cui > > Sent: Wednesday, November 9, 2016 11:18 PM > > We don't really need such a big on-stack buffer. > > vmbus_sendpacket() here only uses sizeof(struct pci_child_message). > > > > @@ -1271,9 +1271,9 @@ static struct hv_pci_dev > >

Re: [PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

2016-11-10 Thread Ian Abbott
On 12/10/16 12:05, Spencer E. Olson wrote: See README for a thorough discussion of this content. Adds two different collections of CSV files that: 1) summarize the various register values for creating routes for a particular family of NI hardware devices; 2) summarize all possible (direct)

Re: [PATCH 02/15] staging: comedi: add abstracted NI signal/terminal named constants

2016-11-10 Thread Ian Abbott
On 12/10/16 12:05, Spencer E. Olson wrote: This change adds abstracted constants for National Instruments terminal/signal names. Some background: There have been significant confusions over the past many years for users when trying to understand how to connect to/from signals and terminals

[PATCH] staging: rtl8192e: Fix checkpatch warnings

2016-11-10 Thread Yamanappagouda Patil
Fixed checkpatch.pl warning on Block comments. Signed-off-by: Yamanappagouda Patil --- drivers/staging/rtl8192e/dot11d.c | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-

RE: [PATCH 1/3] PCI: hv: use the correct buffer size in new_pcichild_device()

2016-11-10 Thread Jake Oshins
> -Original Message- > > > From: Jake Oshins > > > From: Dexuan Cui > > > Sent: Wednesday, November 9, 2016 11:18 PM > > > We don't really need such a big on-stack buffer. > > > vmbus_sendpacket() here only uses sizeof(struct pci_child_message). > > > > > > @@ -1271,9 +1271,9 @@ static

[PATCH] staging: rtl8192e: Fix checkpatch.pl warnings

2016-11-10 Thread Yamanappagouda Patil
Fixed "missing blank line after declaration" checkpatch.pl warnings. Signed-off-by: Yamanappagouda Patil --- drivers/staging/rtl8192e/rtllib_rx.c | 1 + drivers/staging/rtl8192e/rtllib_softmac.c | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH] staging: rtl8192e: Fix checkpatch warnings

2016-11-10 Thread Y M Patil
This patch fixes block comment coding style warnings. And added new line after variable declaration. Signed-off-by: Y M Patil --- drivers/staging/rtl8192e/dot11d.c | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 3 ++- drivers/staging/rtl8192e/rtl819x_HTProc.c

Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 09:32:30PM +0530, Y M Patil wrote: > This patch fixes block comment coding style warnings. > And added new line after variable declaration. > > Signed-off-by: Y M Patil Also, I need a "full" name please... thanks, greg k-h

Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 09:32:30PM +0530, Y M Patil wrote: > This patch fixes block comment coding style warnings. > And added new line after variable declaration. Please only do one-thing-per-patch. If you have to say "And", that's a huge hint that this should be broken up into multiple

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Greg KH
On Tue, Nov 08, 2016 at 04:42:13PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) What is

Re: [PATCH v2 1/3] vmbus: add support for dynamic device id's

2016-11-10 Thread Greg KH
On Mon, Oct 17, 2016 at 12:29:59PM -0700, Stephen Hemminger wrote: > From: Stephen Hemminger > > This patch adds sysfs interface to dynamically bind new UUID values > to existing VMBus device. This is useful for generic UIO driver to > act similar to uio_pci_generic. > >

Re: [PATCH 01/15] staging: comedi: tests: add unittest framework for comedi

2016-11-10 Thread Ian Abbott
On 12/10/16 12:05, Spencer E. Olson wrote: Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be

[PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

2016-11-10 Thread James Simmons
From: Gregoire Pichon This patch is the main client part of a new feature that supports multiple modify metadata RPCs in parallel. Its goal is to improve metadata operations performance of a single client, while maintening the consistency of MDT reply reconstruction and

[PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] staging: lustre: ldlm: pl_recalc time handling is wrong

2016-11-10 Thread Arnd Bergmann
James Simmons reports: > The ldlm_pool field pl_recalc_time is set to the current > monotonic clock value but the interval period is calculated > with the wall clock. This means the interval period will > always be far larger than the pl_recalc_period, which is > just a small interval time period.

Re: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 03:53:31PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's32' over 'int32_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > drivers/staging/fsl-mc/include/mc.h | 2 +- > 1 file

[PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - corrected an error in the log message, wrote 's32' instead of 's16'. Changes for v3: - added the missing

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 03:53:30PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - corrected an error in the log

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-10 Thread Shiva Kerdel
I corrected the log message because I wrote 's32' instead of 's16' in this patch (confused with the other one that I sent too). Thank you for your guidance, Shiva Kerdel On 11/10/16 15:20, Greg KH wrote: On Thu, Nov 10, 2016 at 03:09:07PM +0100, Shiva Kerdel wrote: Follow the kernel type

RE: [PATCH 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-11-10 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuart.yo...@nxp.com] > Sent: Friday, October 21, 2016 9:02 AM > To: gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong

2016-11-10 Thread Arnd Bergmann
On Thursday, November 10, 2016 1:21:08 PM CET Greg Kroah-Hartman wrote: > > > > the intention here is simply to have the console log keep the > > same numbers as "date +%s" for absolute values. The patch that > > James suggested converting everything to ktime_get_seconds() > > would result in the

[PATCH 16/35] staging: lustre: llite: support SELinux context labelling

2016-11-10 Thread James Simmons
From: Andrew Wellington SELinux contexts are applied by the kernel if mount options are not binary. As we don't use any binary mount options in Lustre, remove the binary mount option flag. Signed-off-by: Andrew Wellington

[PATCH 03/35] staging: lustre: ptlrpc: mbits is sent within ptlrpc_body

2016-11-10 Thread James Simmons
From: Liang Zhen ptlrpc is using rq_xid as matchbits of bulk data, which means it has to change rq_xid for bulk resend to avoid several bulk data landing into the same buffer from different resends. This patch uses one of reserved __u64 of ptlrpc_body to transfer mbits to

[PATCH 06/35] staging: lustre: osc: Performance tune for LRU

2016-11-10 Thread James Simmons
From: Jinshan Xiong Early launch page LRU work in osc_io_rw_iter_init(); Change the page LRU shrinking policy by OSC attributes; Delete the contented lock osc_object::oo_seatbelt Signed-off-by: Jinshan Xiong Intel-bug-id:

[PATCH 23/35] staging: lustre: ldlm: improve lock timeout messages

2016-11-10 Thread James Simmons
From: John L. Hammond In ldlm_expired_completion_wait() remove the useless LCONSOLE_WARN() message and upgrade the LDLM_DEBUG() statement to LDLM_ERROR(). Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7296

[PATCH 32/35] staging: lustre: mount: fix lmd_parse() to handle commas in expr_list

2016-11-10 Thread James Simmons
From: Jian Yu The lmd_parse() function parses mount options with comma as delimiter without considering commas in expr_list as follows is a valid LNET nid range syntax: :== '[' [ ',' ] ']' This patch fixes the above issue by using cfs_parse_nidlist() to parse nid range

[PATCH 13/35] staging: lustre: llite: lookup master inode by ilookup5_nowait

2016-11-10 Thread James Simmons
From: wang di Do not lookup master inode by ilookup5, instead it should use ilookup5_nowait, otherwise it will cause dead lock, 1. Client1 send chmod req to the MDT0, then on MDT0, it enqueues master and all of its slaves lock, (mdt_attr_set() ->mdt_lock_slaves()),

[PATCH 29/35] staging: lustre: misc: clean up DFID related error messages

2016-11-10 Thread James Simmons
From: Andreas Dilger Improve the error messages related to DFID output and parsing for usage in userspace. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1606 Reviewed-on: http://review.whamcloud.com/6156

[PATCH 25/35] staging: lustre: osc: Do not merge extents with partial pages

2016-11-10 Thread James Simmons
From: Jinshan Xiong After range lock is introduced to Lustre, it's possible for multiple threads to submit osc_extents with partial pages, and finally I/O engine may try to merge these extents, which will end up with assert in osc_build_rpc(). In this patch,

[PATCH 26/35] staging: lustre: mdc: remove console spew from mdc_ioc_fid2path

2016-11-10 Thread James Simmons
From: Andreas Dilger In some cases with a very long pathname, such as with sanity.sh test_154c, mdc_ioc_fid2path() would spew long debug messages to the log, because libcfs_debug_vmsg2() refuses to log messages over one page in size. Truncate the debug message to only

[PATCH 24/35] staging: lustre: osc: osc_extent should hold refcount to osc_object

2016-11-10 Thread James Simmons
From: Jinshan Xiong To avoid a race that osc_extent and osc_object destroy happens on the same time, which causes kernel crash. Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7164 Reviewed-on:

RE: [PATCH 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-11-10 Thread Stuart Yoder
> -Original Message- > From: Ruxandra Ioana Radulescu > Sent: Thursday, November 10, 2016 9:04 AM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; >

Re: [patch] staging/lustre/osc: indent an if statement

2016-11-10 Thread James Simmons
> We accidentally removed a tab here. Let's add it back, and some curly > braces as well since this is a muti-line indent. Reviewed-by: James Simmons > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH 04/15] staging: comedi: ni_routing: add ni routing tables

2016-11-10 Thread Spencer E Olson
On Thu, 2016-11-10 at 18:18 +, Ian Abbott wrote: > On 10/11/16 17:54, Greg Kroah-Hartman wrote: > > On Thu, Nov 10, 2016 at 05:17:22PM +, Ian Abbott wrote: > >> On 12/10/16 12:05, Spencer E. Olson wrote: > >>> Adds tables of all register values for routing various signals to various > >>>

[PATCH 1/4] staging: wlan-ng: use GENMASK macro in different defines of hfa384x.h

2016-11-10 Thread Sergio Paracuellos
This patch replace actual mask stuff using BIT macros with or operators to make use of GENMASK macro which simplifies code clearity and readibility. It applies for defines included in hfa384x.h header file. Signed-off-by: Sergio Paracuellos ---

[PATCH 2/4] staging: wlan-ng: use GENMASK macro in different defines of p80211hdr.h

2016-11-10 Thread Sergio Paracuellos
This patch replace actual mask stuff using BIT macros with or operators to make use of GENMASK macro which simplifies code clearity and readibility. It applies for defines included in p80211hdr.h header file. Signed-off-by: Sergio Paracuellos ---

[PATCH 3/4] staging: wlan-ng: use GENMASK macro in define of p80211netdev.h

2016-11-10 Thread Sergio Paracuellos
This patch replace actual mask stuff using BIT macros with or operators to make use of GENMASK macro which simplifies code clearity and readibility. It applies for defines included in p80211netdev.h header file. Signed-off-by: Sergio Paracuellos ---

Re: [PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

2016-11-10 Thread Ian Abbott
On 10/11/16 17:54, Greg Kroah-Hartman wrote: On Thu, Nov 10, 2016 at 05:08:36PM +, Ian Abbott wrote: On 12/10/16 12:05, Spencer E. Olson wrote: See README for a thorough discussion of this content. Adds two different collections of CSV files that: 1) summarize the various register values

[PATCH 4/4] staging: wlan-ng: use GENMASK macro in two bitwise operations in prism2sta.c

2016-11-10 Thread Sergio Paracuellos
This patch replace actual mask stuff using BIT macros with or operators to make use of GENMASK macro which simplifies code clearity and readibility. It applies for two bitwise operations included in prism2sta.c source file. Signed-off-by: Sergio Paracuellos ---

[PATCH 0/4] staging: wlan-ng: make use of GENMASK macro

2016-11-10 Thread Sergio Paracuellos
This patchset replaces mask stuff manipulation which is being used using BIT macro with or operators with the use of GENMASK macro. Sergio Paracuellos (4): staging: wlan-ng: use GENMASK macro in different defines of hfa384x.h staging: wlan-ng: use GENMASK macro in different defines of

Re: [PATCH 04/15] staging: comedi: ni_routing: add ni routing tables

2016-11-10 Thread Ian Abbott
On 10/11/16 17:54, Greg Kroah-Hartman wrote: On Thu, Nov 10, 2016 at 05:17:22PM +, Ian Abbott wrote: On 12/10/16 12:05, Spencer E. Olson wrote: Adds tables of all register values for routing various signals to various terminals on National Instruments hardware. This information is

[PATCH v3 23/28] staging: iio: tsl2583: clarified comment about clearing interrupts

2016-11-10 Thread Brian Masney
The comment that describes the code that clears the interrupt bit was vague and didn't provide much value. This patch adds more detail about why that bit needs to be cleared. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 5 +++-- 1 file changed, 3

[PATCH v3 19/28] staging: iio: tsl2583: remove unnecessary parentheses

2016-11-10 Thread Brian Masney
in_illuminance_lux_table_store() contains some unnecessary parentheses. This patch removes them since they provide no value. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   >