Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Ajay Singh
Please let me know, in case I have to rework and resubmit this patch series to make them into staging branch. Regards, Ajay ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Claudiu Beznea
On 27.03.2018 10:22, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. > As I suggested in patch 6, I prefer having the same format for wilc_wfi_cfg_tx_vendor_spec() and wilc_wfi_cfg_parse_rx_vendor_spec(). I

Re: [PATCH] staging: wilc1000: fix memdup.cocci warnings

2018-03-27 Thread Claudiu Beznea
On 26.03.2018 22:41, Julia Lawall wrote: > From: Fengguang Wu > > drivers/staging/wilc1000/host_interface.c:946:32-39: WARNING opportunity for > kmemdup > drivers/staging/wilc1000/host_interface.c:970:30-37: WARNING opportunity for > kmemdup > > Use kmemdup rather

Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

2018-03-27 Thread Claudiu Beznea
On 26.03.2018 20:16, Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with -ENOMEM. > > Signed-off-by: Colin Ian King

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-27 Thread Greg KH
On Tue, Mar 27, 2018 at 08:20:59AM +0300, Dan Carpenter wrote: > On Tue, Mar 27, 2018 at 02:00:45PM +0900, Ji-Hun Kim wrote: > > > > Are there any opinions? I'd like to know how this patch is going. > > > > > Looks good. Thanks! > > Greg just hasn't gotten to it yet. Greg does not take

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Ajay Singh
Hi Claudiu, On Tue, 27 Mar 2018 11:55:52 +0300 Claudiu Beznea wrote: > On 27.03.2018 10:22, Ajay Singh wrote: > > > > Please let me know, in case I have to rework and resubmit this patch > > series to make them into staging branch. > > > > As I suggested in

Re: [PATCH 07/18] media: staging: atomisp: fix endianess issues

2018-03-27 Thread Andy Shevchenko
On Mon, 2018-03-26 at 17:10 -0400, Mauro Carvalho Chehab wrote: > There are lots of be-related warnings there, as it doesn't properly > mark what data uses bigendian. > @@ -107,7 +107,7 @@ mt9m114_write_reg(struct i2c_client *client, u16 > data_length, u16 reg, u32 val) > int num_msg; >

Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-27 Thread Andrew Lunn
On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > Previous implementation overwrites PCP value, assuming the default value is > 0, instead of 7. > > Avoid this by modifying helper function ethsw_port_set_tci() to > ethsw_port_set_pvid() and make it update only the vlan_id of

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Robin Murphy
Hi Roy, On 26/03/18 20:05, Roy Pledge wrote: The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure.

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Roy Pledge
On 3/27/2018 7:05 AM, Robin Murphy wrote: > Hi Roy, > > On 26/03/18 20:05, Roy Pledge wrote: >> The error path in the dpaa2_dpio_probe() function was not properly >> unmapping the QBMan device memory on the error path. This was also >> missing from the dpaa2_dpio_release() function. >> >> Also

[Resend Patch 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

2018-03-27 Thread Long Li
From: Long Li This is a best effort for estimating on how busy the ring buffer is for that channel, based on available buffer to write in percentage. It is still possible that at the time of actual ring buffer write, the space may not be available due to other processes may

[Resend Patch 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

2018-03-27 Thread Long Li
From: Long Li In Vmbus, we have defined a function to calculate available ring buffer percentage to write. Use that function and remove netvsc's private version. Signed-off-by: Long Li --- drivers/net/hyperv/hyperv_net.h | 1 -

[Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

2018-03-27 Thread Long Li
From: Long Li Netvsc has a function to calculate how much ring buffer in percentage is available to write. This function is also useful for storvsc and other vmbus devices. Define a similar function in vmbus to be used by other vmbus devices. Signed-off-by: Long Li

[PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-27 Thread Razvan Stefanescu
Previous implementation overwrites PCP value, assuming the default value is 0, instead of 7. Avoid this by modifying helper function ethsw_port_set_tci() to ethsw_port_set_pvid() and make it update only the vlan_id of the tci_cfg struct. Signed-off-by: Razvan Stefanescu

RE: [PATCH net-next, 2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-27 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, March 27, 2018 11:23 AM > To: Haiyang Zhang > Cc: Haiyang Zhang ; da...@davemloft.net; > net...@vger.kernel.org; o...@aepfle.de; Stephen

Re: [PATCH net-next, 2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-27 Thread Stephen Hemminger
On Thu, 22 Mar 2018 12:01:14 -0700 Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch adds range checking for rx packet offset and length. > It may only happen if there is a host side bug. > > Signed-off-by: Haiyang Zhang

[PATCH] drivers: staging: rtl8192e: fixed a space coding style issue

2018-03-27 Thread Rene Hickersberger
There was a weird space before the struct which is now removed. Signed-off-by: Rene Hickersberger --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c

[PATCH v4 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-27 Thread Roy Pledge
Move the NXP DPIO (Datapath I/O Driver) out of the drivers/staging directory and into the drivers/soc/fsl directory. The DPIO driver enables access to Queue and Buffer Manager (QBMAN) hardware on NXP DPAA2 devices. This is a prerequisite to moving the DPAA2 Ethernet driver out of staging.

[PATCH v4 0/4] drives/soc/fsl: Move DPIO driver out of staging

2018-03-27 Thread Roy Pledge
This patchset moves the NXP DPIO (Datapath I/O Driver) out of the drivers/staging directory and into the drivers/soc/fsl directory. The DPIO driver enables access to Queue and Buffer Manager (QBMAN) hardware on NXP DPAA2 devices. This is a prerequisite to moving the DPAA2 Ethernet driver out of

[PATCH v4 1/4] drivers/staging/fsl-mc: Use devm_memremap/devm_ioremap for DPIO

2018-03-27 Thread Roy Pledge
Change the mapping of the QBMan cache enabled area from using ioremap_wc() to devm_memremap(). This allows the __iomem attribute to be removed from the pointer (which makes sense as accesses treat this as cacheable memory not IO memory). These changes allow sparse checks to pass. Also use

[PATCH v4 2/4] drivers/staging/fsl-mc: Fix DPIO error path issue

2018-03-27 Thread Roy Pledge
Remove unneeded call to dev_set_drvdata(dev, NULL) since the device will be deallocated in any case. Signed-off-by: Roy Pledge --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH v4 4/4] drivers/staging: Remove fsl-mc driver from staging

2018-03-27 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 -

[PATCH] Staging: Comedi: Use Preferred kernel type

2018-03-27 Thread Paul McQuade
Change to kenel type u8 or u16 instead of uint8_t or uint16_t Signed-off-by: Paul McQuade --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/s626.c

HI

2018-03-27 Thread Lucy Boston
-- Greeting, once again is me Lucy Boston this is twice am contacting you please is very urgent respond to me for more details through my. Email: dr.lucybos...@gmail.com ___ devel mailing list de...@linuxdriverproject.org

HI

2018-03-27 Thread Lucy Boston
-- Greeting, once again is me Lucy Boston this is twice am contacting you please is very urgent respond to me for more details through my. Email: dr.lucybos...@gmail.com ___ devel mailing list de...@linuxdriverproject.org

[PATCH 3/4] hv: add SPDX license to trace

2018-03-27 Thread kys
From: Stephen Hemminger Missing license on Hyper-V VMBUS tracing files. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_trace.c | 2 ++ drivers/hv/hv_trace.h | 2 ++ 2 files changed, 4

[PATCH 1/4] Drivers: hv: vmbus: respect what we get from hv_get_synint_state()

2018-03-27 Thread kys
From: Dexuan Cui I didn't really hit a bug, but just happened to notice the redundant line. Signed-off-by: Dexuan Cui Cc: Stephen Hemminger Cc: K. Y. Srinivasan Signed-off-by: K. Y. Srinivasan

[PATCH 0/4] Drivers: hv: vmbus: Miscellaneous fixes

2018-03-27 Thread kys
From: "K. Y. Srinivasan" Some miscellaneous fixes and adjustments. Dexuan Cui (2): Drivers: hv: vmbus: respect what we get from hv_get_synint_state() Drivers: hv: vmbus: do not mark HV_PCIE as perf_device Stephen Hemminger (2): hv: add SPDX license to trace hv: add

[PATCH 4/4] hv: add SPDX license id to Kconfig

2018-03-27 Thread kys
From: Stephen Hemminger Missing license on Kconfig file. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- drivers/hv/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hv/Kconfig

[PATCH 2/4] Drivers: hv: vmbus: do not mark HV_PCIE as perf_device

2018-03-27 Thread kys
From: Dexuan Cui The pci-hyperv driver's channel callback hv_pci_onchannelcallback() is not really a hot path, so we don't need to mark it as a perf_device, meaning with this patch all HV_PCIE channels' target_cpu will be CPU0. Signed-off-by: Dexuan Cui