Re: [PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h

2014-01-03 Thread Dan Carpenter
Fine, fine. I don't have strong feelings about this... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[patch] staging: vt6656: remove an unneeded NULL check

2014-01-03 Thread Dan Carpenter
We dereference "param->u.wpa_key.key" on the next line so the check here is inconsistent. This is only called from iwctl_siwencodeext() and "param->u.wpa_key.key" is a valid pointer. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/vt6656/wpactl.c b/drivers/staging/vt6656/wpactl.c inde

[patch] staging: vt6655: check too restrictive (off by one)

2014-01-03 Thread Dan Carpenter
key_len == MAX_KEY_LEN is valid but we return an error. Introduced-by: 6b7200fe0a59 ('Staging: vt6655: memory corruption in check in wpa_set_wpadev()') Signed-off-by: Dan Carpenter diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c index ee83704e4401..d43efb85f4d3 10

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Eric Nelson
Hi Philipp, On 01/03/2014 10:26 AM, Philipp Zabel wrote: Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM Linux: On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now the HPD signal does

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 06:26:44PM +0100, Philipp Zabel wrote: > Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM > Linux: > > On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: > > > Hi Russell, > > > > > > I've tested this series on a BD-SL (SabreLite) with HDMI. Ri

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Philipp Zabel
Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM Linux: > On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: > > Hi Russell, > > > > I've tested this series on a BD-SL (SabreLite) with HDMI. Right now > > the HPD signal doesn't seem to work, but after overwriting the

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: > Hi Russell, > > I've tested this series on a BD-SL (SabreLite) with HDMI. Right now > the HPD signal doesn't seem to work, but after overwriting the > connection check, I got a stable and correct picture on the monitor: Hmm. Does t

Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-01-03 Thread Philipp Zabel
Am Freitag, den 20.12.2013, 11:12 -0800 schrieb Greg Kroah-Hartman: > On Fri, Dec 20, 2013 at 06:52:41PM +0100, Philipp Zabel wrote: > > Hi, > > > > this is mostly about the first patch, which moves the IPUv3 core code > > (drivers/staging/imx-drm/ipu-v3) to drivers/gpu. host1x, which > > serves a

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Philipp Zabel
Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now the HPD signal doesn't seem to work, but after overwriting the connection check, I got a stable and correct picture on the monitor: arch/arm/boot/dts/imx6q-sabrelite.dts | 22 ++ 1 file changed, 2

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:26:14PM +0100, David Herrmann wrote: > Hi > > On Fri, Jan 3, 2014 at 5:13 PM, Russell King - ARM Linux > wrote: > > I'm not so sure - since the only place this mask gets used is with > > the "possible_crtcs" field. It's got nothing to do with the > > "possible_clones"

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread David Herrmann
Hi On Fri, Jan 3, 2014 at 5:13 PM, Russell King - ARM Linux wrote: > On Fri, Jan 03, 2014 at 05:05:46PM +0100, David Herrmann wrote: >> Hi >> >> On Thu, Jan 2, 2014 at 10:27 PM, Russell King >> wrote: >> > The encoder possible_crtcs mask identifies which CRTCs can be bound to >> > a particular e

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread David Herrmann
Hi On Thu, Jan 2, 2014 at 10:27 PM, Russell King wrote: > The encoder possible_crtcs mask identifies which CRTCs can be bound to > a particular encoder. Each bit from bit 0 defines an index in the list > of CRTCs held in the DRM mode_config crtc_list. Rather than having > drivers trying to trac

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:05:46PM +0100, David Herrmann wrote: > Hi > > On Thu, Jan 2, 2014 at 10:27 PM, Russell King > wrote: > > The encoder possible_crtcs mask identifies which CRTCs can be bound to > > a particular encoder. Each bit from bit 0 defines an index in the list > > of CRTCs held

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 02:24:26PM +0100, Rafael J. Wysocki wrote: > On Friday, January 03, 2014 12:18:13 PM Russell King - ARM Linux wrote: > > I'm not sure what I'm looking for. I've tried looking at the results of > > searching your linux-next branch for "container" but I don't see > > anything

Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

2014-01-03 Thread Joe Perches
On Fri, 2014-01-03 at 00:22 +0100, Tim Jester-Pfadt wrote: > Fixed indentation coding style issues on rtw_io.c [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c > b/drivers/staging/rtl8188eu/core/rtw_io.c [] > @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 12:18:13 PM Russell King - ARM Linux wrote: > On Fri, Jan 03, 2014 at 12:58:16PM +0100, Rafael J. Wysocki wrote: > > On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: > > > On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: > > > >

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 12:58:16PM +0100, Rafael J. Wysocki wrote: > On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: > > On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: > > > On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: > > > > Subsystems

I want to transfer an abandoned

2014-01-03 Thread mr.sinzoganchabi
Hi friend I am a banker in IDB BANK. I want to transfer an abandoned USD5. 5Million to your Bank account. 40/percent will be your share. No risk involved but keep it as secret.Contact me for more details.Please I will like you to reply. thank you,mr.sinzogan chabi. __

Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

2014-01-03 Thread Tim Jester-Pfadt
Thank you for your feedback. I'm still figuring stuff out. Submitting patches to the kernel has been my new year's resolution. Regards, Tim 2014/1/3 Dan Carpenter : > On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote: >> Fixed indentation coding style issues on rtw_io.c >> >> Sign

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: > On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: > > On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: > > > Subsystems such as ALSA, DRM and others require a single card-level > > > device stru

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: > On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: > > Subsystems such as ALSA, DRM and others require a single card-level > > device structure to represent a subsystem. However, firmware tends to > > describe the ind