On 05/02/14 23:21, Michael Kenney wrote:
On Wed, Feb 5, 2014 at 1:38 PM, Michael Kenney mfken...@gmail.com wrote:
On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch mar...@welchs.me.uk wrote:
On 5 February 2014 17:41, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Feb 04, 2014 at
Fix the following checkpatch warnings:
ERROR: return is not a function, parentheses are not required
#462: FILE: drivers/staging/imx-drm/imx-hdmi.c:462:
+ return (hdmi-hdmi_data.enc_in_format !=
ERROR: return is not a function, parentheses are not required
#468: FILE:
From: Roger Tseng rogera...@realtek.com
This patchset adds modules to support Realtek USB vendor specific class flash
card reader: one base module in MFD subsystem and two host modules in both mmc
and memstick subsystems. The architecture is similar to rtsx_pci.
This work is done primarily to
From: Roger Tseng rogera...@realtek.com
Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefile | 1 +
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
Fixed all the trailing whitespace errors found by checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 250
1 file changed, 125 insertions(+), 125 deletions(-)
diff --git
Removed all the C99 comments found by checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c
Fixed all the errors related to spacing found by checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c
Fixed all the errors related to space prohibition found by
checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
The following series of patches are used to Fix all the
errors found by checkpatch.pl script in the pci.c.
Few warnings are still present in the patches submitted.
That can be taken care in the next set of patches.
Gokulnath A (8):
staging:rtl8821ae:pci.c trailing whitespace cleanup
Fixed the error found by checkpatch.pl related to spacing requirement
in the condition.
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/pci.c
fixed all the spacing related issues found by checkpatch.pl script.
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 54 -
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git
fixed all the code indentation errors found by checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c
This patch fixes the following checkpatch.pl issues in
rtl8821ae/pci.c file
ERROR: (foo*) should be (foo *)
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On Fri, Feb 07, 2014 at 12:45:24AM +0530, Gokulnath A wrote:
fixed all the spacing related issues found by checkpatch.pl script.
A lot of this stuff should just be removed.
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
The signed off by should match the email you are
On Thu, Feb 06, 2014 at 11:01:11PM +0300, Dan Carpenter wrote:
On Fri, Feb 07, 2014 at 12:45:24AM +0530, Gokulnath A wrote:
fixed all the spacing related issues found by checkpatch.pl script.
A lot of this stuff should just be removed.
This whole driver is going to be deleted for 3.15
On Fri, Feb 07, 2014 at 12:45:26AM +0530, Gokulnath A wrote:
Fixed all the errors related to space prohibition found by
checkpatch.pl script
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 26 +-
1 file
On Fri, Feb 07, 2014 at 12:45:28AM +0530, Gokulnath A wrote:
Fixed the error found by checkpatch.pl related to spacing requirement
in the condition.
Signed-off-by: Gokulnath A gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/rtl8821ae/pci.c | 3 ++-
1 file changed, 2
We should cap the SSID length at NDIS_802_11_LENGTH_SSID (32) characters
to avoid memory corruption. If the SSID is too long then I have opted
to ignore it instead of truncating it.
We don't need to clear bssid-Ssid.Ssid[0] because this struct is
allocated with rtw_zmalloc()
Signed-off-by: Dan
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mf6x4.c | 23 ++-
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das08.c | 26 ++
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/me_daq.c | 35 ++---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 32 +++
Use comedi_timeout() to wait for the analog input end-of-conversion.
This prevents a deadlock condition that could occur by providing a
timeout in case the end-of-conversion does not happen.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
It's not necessary to clear the returned data pointer when an (*insn_read)
times out. For aesthetics, remove all of these in the drivers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use comedi_timeout() to wait for the analog input and output end-of-
conversions.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 42
Use comedi_timeout() to wait for the analog input end-of-conversion.
The interrupt routine also uses the timeout check to make sure data
is actually available. Using NULL here for the 'insn' is safe since
nothing uses it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/multiq3.c | 38
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl711.c | 21 ++---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmad.c | 21 ++---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 34 ++--
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 26 ++
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 42
Use comedi_timeout() to wait for the analog output end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci6208.c | 22 ++
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16m1.c | 27 +++
1
Introduce a comedi core helper function to handle the boilerplate
needed by the drivers to wait for a condition to occur. Typically
this condition is the analog input/output end-of-conversion used
with the comedi (*insn_read) and (*insn_write) operations.
To use this function, the drivers just
Use comedi_timeout() to wait for the analog input end-of-conversion.
The interrupt routine also uses the timeout check to make sure data
is actually available. Using NULL here for the 'insn' is safe since
nothing uses it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2814.c | 44 +++--
Use comedi_timeout() to wait for the analog input and output end-of-
conversion.
Use break to exit the loop when a timeout occurs during the analog
input read so that common code can be used to disable the device.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas.c | 27 +++
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Also, remove some unnecessary comments.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_daq_700.c | 53 ++---
Use comedi_timeout() to wait for the analog input settle and end-of-
conversion. These tests use different registers but the same bit so
the register is passed as the 'context'. The same test is used in
dmm32at_ai_cmd() but the 'insn' is not available. This is ok since
the test function, and
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mpc624.c | 28
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Since this is the sample skeleton driver, add comments about how the
callback function works with comedi_timeout().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use comedi_timeout() to wait for the analog input and output end-of-
conversions.
This prevents a deadlock condition that could occur by providing a
timeout in case the end-of-conversion does not happen.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use comedi_timeout() to wait for the analog input end-of-conversion.
Change the errno returned for an overrun from -EIO to -EOVERFLOW.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
All the comedi drivers that now use comedi_timeout() return a standard
errno when a timeout occurs. Remove all the private debug messages and
have the core output the dev_dbg() message.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 38 +---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Remove the unnecessary comments.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcimdas.c
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das800.c | 18 ++
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Use break to exit the loop so that the common path can be used to unlock
the spinlock.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2811.c | 23 ---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
This also fixes a possible bug where invalid data is returned if the
conversion did not complete.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Many of the comedi drivers implement a timeout loop of some sort in the
analog input (*insn_read) or analog output (*insn_write) functions. Some
of these are just crazy loop this many times for some status to change.
There are a couple that could actually deadlock the system if the status
does not
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++---
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
This wrapper is not used.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
This wrapper is not used.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 8
drivers/staging/rtl8188eu/include/odm_interface.h | 4
2 files changed, 12 deletions(-)
diff --git
This routine is the equivalent of rtw_write16.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +++-
drivers/staging/rtl8188eu/hal/odm_interface.c| 6 --
drivers/staging/rtl8188eu/include/odm_interface.h| 2 --
3
On 02/03/2014 04:38 PM, Dan Carpenter wrote:
MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer
in sync. It leads to a bogus pointer dereference.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Larry Finger larry.fin...@lwfinger.net
Larry
diff --git
This routine is the equivalent of rtw_write32.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 2 +-
drivers/staging/rtl8188eu/hal/odm_interface.c | 7 ---
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files
This wrapper for vzalloc() is not used.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 1 -
2 files changed, 7 deletions(-)
diff --git
The driver contains a large number of wrapper routines. None of them are
needed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
Larry Finger (12):
staging: r8188eu: Remove ODM_Read1Byte
staging: r8188eu: Remove ODM_Read2Byte
staging: r8188eu: Remove ODM_Read4Byte
staging: r8188eu:
This is essentially a synonym for rtw_read8.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 6 +++---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files
This routine is a wrapper for _rtw_memcmp(), which is a wrapper for memcmp.
In a later change, _rtw_memcmp will be removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5
This routine is never used.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 8 deletions(-)
diff --git
66 matches
Mail list logo
