Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Fix for possible null pointer dereference

On Tue, May 20, 2014 at 04:57:56PM -0700, j...@joshtriplett.org wrote: On Tue, May 20, 2014 at 06:26:51PM -0500, Larry Finger wrote: On 05/20/2014 04:31 PM, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static

[PATCH 09/74] staging: rtl8723au: Remove unused enum odm_security

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/odm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index

[PATCH 03/74] staging: rtl8723au: Get rid of write only NetworkTypeInUse and matching enum

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 18 - drivers/staging/rtl8723au/core/rtw_mlme.c | 27 - drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 06/74] staging: rtl8723au: Add -Wtype-limits to CFLAGS

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/Makefile b/drivers/staging/rtl8723au/Makefile index

[PATCH 15/74] staging: rtl8723au: Get rid of unused struct ndis_802_11_configuration_fh

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 - drivers/staging/rtl8723au/include/wlan_bssdef.h | 9 - 2 files changed, 14 deletions(-) diff --git

[PATCH 08/74] staging: rtl8723au: We don't support SMS4 or WEP+WPA mixed encryption

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_recv.c| 4 drivers/staging/rtl8723au/include/odm.h | 2 -- drivers/staging/rtl8723au/include/rtw_security.h | 2 -- 3 files changed, 8

[PATCH 27/74] staging: rtl8723au: Get rid of last HT OP mode duplicate defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 9 - drivers/staging/rtl8723au/include/wifi.h | 5 - 2 files changed, 4 insertions(+), 10 deletions(-) diff --git

[PATCH 36/74] staging: rtl8723au: wifi.h: Remove unused SetFragNum() macro

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index

[PATCH 24/74] staging: rtl8723au: Use kernel provided IEEE80211_HT_PARAM_* defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 2 +- drivers/staging/rtl8723au/include/wifi.h | 8 2 files changed, 1 insertion(+), 9 deletions(-) diff --git

[PATCH 30/74] staging: rtl8723au: rtw_cfg80211_inform_bss(): Use get_unaligned_le16()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 14/74] staging: rtl8723au: Make rtw_cfg80211_add_wep() take a struct rtw_wep_key

From: Jes Sorensen jes.soren...@redhat.com This allows the removal of the ugly struct ndis_8802_11_wep and simplify rtw_cfg80211_add_wep(). In addition remove unused element ndiswep from struct security_priv. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 21/74] staging: rtl8723au: wifi.h: Remove unused SetRetry() + SetAMsdu() macros

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index

[PATCH 23/74] staging: rtl8723au: Use kernel provided IEEE80211_HT_OP_MODE_* defines

From: Jes Sorensen jes.soren...@redhat.com In addition remove unused HT_INFO_STBC_PARAM_* defines Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 22 +++--- drivers/staging/rtl8723au/include/wifi.h | 16 2 files

[PATCH 28/74] staging: rtl8723au: cfg80211_rtw_mgmt_tx(): type is always -1

From: Jes Sorensen jes.soren...@redhat.com Rip out P2P defines since they are effectively never used. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 14 -- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 19

[PATCH 02/74] staging: rtl8723au: Use nl80211_iftype instead of driver's own custom types

From: Jes Sorensen jes.soren...@redhat.com In addition move rtw_set_802_11_infrastructure_mode23a() to ioctl_cfg80211.c and declare it static. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 5 +-

[PATCH 11/74] staging: rtl8723au: Introduce struct rtw_wep_key to store our wep keys

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 39 --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 +-- drivers/staging/rtl8723au/core/rtw_security.c | 11

[PATCH 07/74] staging: rtl8723au: Store algorithm type in a u32

From: Jes Sorensen jes.soren...@redhat.com This will allow us to switch to using WLAN_CIPHER_SUITE_* later Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_cmd.h | 4 ++-- drivers/staging/rtl8723au/include/rtw_security.h | 6 +++---

[PATCH 31/74] staging: rtl8723au: ioctl_cfg80211.c: Properly initialize seq_ctrl

From: Jes Sorensen jes.soren...@redhat.com Using SetSeqNum() on an uninitialized stack frame leaves us open to leaving random fragment bits set in seq_ctrl in the frame header. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 18

[PATCH 04/74] staging: rtl8723au: HalEEValueCheck(): content of a u8 is always = 0

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c

[PATCH 19/74] staging: rtl8723au: wlan_bssdef.h: Remove some more unused #defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wlan_bssdef.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wlan_bssdef.h

[PATCH 17/74] staging: rtli8723au: Get rid of struct ndis_802_11_fixed_ies

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 10 + drivers/staging/rtl8723au/core/rtw_mlme.c | 22 ++- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 20

[PATCH 45/74] staging: rtl8723au: rtw_xmit.c: Use IEEE80211_[FS]TYPE_ defines

From: Jes Sorensen jes.soren...@redhat.com In addition pkt_attrib-type a u16 and get rid of pattrib-stype Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c| 8 drivers/staging/rtl8723au/include/rtw_xmit.h | 3 +-- 2 files changed, 5

[PATCH 13/74] staging: rtl8723au: rtw_cfg80211_add_wep(): Get rid of unused keyindex flags

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 29/74] staging: rtl8723au: ioctl_cfg80211.c: Rip out 3.14 kernel support

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 37/74] staging: rtl8723au: Get rid of ugly SetDuration() macro usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 5 +++-- drivers/staging/rtl8723au/include/wifi.h | 4 2 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH 25/74] staging: rtl8723au: Remove unused enum WIFI_REG_DOMAIN

From: Jes Sorensen jes.soren...@redhat.com Must be the 17th duplicate of this list in the kernel Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 15 --- 1 file changed, 15 deletions(-) diff --git

[PATCH 39/74] staging: rtl8723au: rtl8723a_update_ramask(): Get rid of annoying debug message

From: Jes Sorensen jes.soren...@redhat.com There really is no need to print this message for anyone not trying to debug the driver: rtl8723a_update_ramask = mac_id:0, networkType:0x0b, mask:0x000f Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 12/74] staging: rtl8723au: Move rtw_set_802_11_add_wep23a() to ioctl_cfg80211.c

From: Jes Sorensen jes.soren...@redhat.com This is only called from ioctl_cfg80211.c so we can move it here and declare it static. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 76 --

[PATCH 42/74] staging: rtl8723au: _issue_qos_nulldata23a(): Use struct ieee80211_qos_hdr

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 00/74] staging-next: rtl8723au: rtl8723au-devel sync

From: Jes Sorensen jes.soren...@redhat.com Greg, Please find attached a resync of the current rtl8723au-devel tree for staging-next. Note this set includes fixes from Karim Raslan and Joe Perches, and should also make the reported randconfig build problems go away. I had to fix up Karim's patch

[PATCH 35/74] staging: rtl8723au: Get rid of SetSeqNum()

From: Jes Sorensen jes.soren...@redhat.com In every last use case, the header was just cleared with memset() so there is no need to use the complex SetSeqNum() macro when cpu_to_le16(IEEE80211_SN_TO_SEQ()) output will do just fine. In addition, get rid of __le16 *fctrl usage when there is no

[PATCH 20/74] staging: rtl8723au: Get rid of ClearMFrag/SetMFrag

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c | 9 + drivers/staging/rtl8723au/include/wifi.h | 6 -- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH 18/74] staging: rtl8723au: Get rid of struct ndis_802_11_var_ies

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 23 ++-- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 55 + drivers/staging/rtl8723au/core/rtw_wlan_util.c | 143

[PATCH 22/74] staging: rtl8723au: Use kernel provided WLAN_CAPABILITY_* definitions

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 6 +++--- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 7 +++ drivers/staging/rtl8723au/include/wifi.h | 12 3 files

[PATCH 10/74] staging: rtl8723au: Use WLAN_CIPHER_SUITE_* to mark crypto type

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 29 +++-- drivers/staging/rtl8723au/core/rtw_cmd.c | 9 +- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 6 +-

[PATCH 40/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

[PATCH 46/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

[PATCH 05/74] staging: rtl8723au: Fix up some random bit-flag handling

From: Jes Sorensen jes.soren...@redhat.com Randomly mixing true/false/_FAIL/0/1 is a recipe for disaster Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 ++---

[PATCH 38/74] staging: rtl8723au: Get rid of SetPrivacy()/SetPwrMgt()/SetMData() macros

From: Jes Sorensen jes.soren...@redhat.com Set these bits directly in the code instead of fiddling with wrapper macros. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 7 --- drivers/staging/rtl8723au/core/rtw_xmit.c | 6 --

[PATCH 16/74] staging: rtl8723au: Get rid of struct ndis_802_11_config

From: Jes Sorensen jes.soren...@redhat.com This exposed a nice endian bug in collect_bss_info23a() where two bytes in little-endian order were copied into a u32 and afterwards le32_to_cpu() was applied to it Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 01/74] staging: rtl8723au: Fix compiling with CONFIG_8723AU_BT_COEXIST=n

From: Jes Sorensen jes.soren...@redhat.com Reported-by: Jim Davis jim.ep...@gmail.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/Makefile | 3 ++- drivers/staging/rtl8723au/core/rtw_cmd.c | 1 +

[PATCH 55/74] staging: rtl8723au: wifi.h: Get rid of last ugly frame_control manipulation macros

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index

[PATCH 73/74] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

From: Karim Raslan karim.allah.ah...@gmail.com This should fix a few sparse warnings like the following: CHECK drivers/staging/rtl8723au/core/rtw_ap.c drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types)

[PATCH 48/74] staging: rtl8723au: rtw_mlme_ext.c: Get rid of most WIFI_* frame type usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 49 --- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 69/74] staging: rtl8723au: Remove obsolete rtw_action_frame_parse23a()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 31 -- drivers/staging/rtl8723au/include/ieee80211.h | 1 - 2 files changed, 32 deletions(-) diff --git

[PATCH 50/74] staging: rtl8723au: Fix issue_assocrsp() to use IEEE80211_STYPE_* defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 28 +-- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 62/74] staging: rtl8723au: Get rid of some unused tdls definitions

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_cmd.h | 1 - drivers/staging/rtl8723au/include/rtw_mlme.h | 27 --- 2 files changed, 28 deletions(-) diff --git

[PATCH 34/74] staging: rtl8723au: Declare rtw_make_wlanhdr() static

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c| 9 - drivers/staging/rtl8723au/include/rtw_xmit.h | 2 -- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH 58/74] staging: rtl8723au: Don't compile rtw_ap.c when CONFIG_8723AU_AP_MODE=n

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/Makefile | 2 +- drivers/staging/rtl8723au/core/rtw_ap.c | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/Makefile

[PATCH 74/74] staging: realtek: Convert /n to \n

From: Joe Perches j...@perches.com Use proper line terminations. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-

[PATCH 71/74] staging: rtl8723au: rtw_mlme_ext.c: Improve bad formatting in event handlers

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 133 +- 1 file changed, 67 insertions(+), 66 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 70/74] staging: rtl8723au: Declare rtw_site_survey() static

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 8 drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 47/74] staging: rtl8723au: ioctl_cfg80211.c: Use ieee80211.h provided fctl bits

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 56/74] staging: rtl8723au: rtw_mlme_ext.c: Declare a number of functions static

From: Jes Sorensen jes.soren...@redhat.com These are all just used locally, no point cluttering the kernel namespace with them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 121 +--

[PATCH 66/74] staging: rtl8723au: rtw_get_bcn_info23a(): Don't zero variables unncessarily

From: Jes Sorensen jes.soren...@redhat.com In addition remove excessive brackets. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH 61/74] staging: rtl8723au: Move dummy_event_callback() to rtw_mlme_ext.c

From: Jes Sorensen jes.soren...@redhat.com In addition get rid of a couple of empty *_event_callback() handlers and use dummy_event_callback() instead. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c| 14 --

[PATCH 53/74] staging: rtl8723au: rtw_xmit.c: Get rid of SetToDs()/SetFrDs() usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c

[PATCH 67/74] staging: rtl8723au: rtw_cfg80211_monitor_if_xmit_entry() use struct ieee80211_mgmt

From: Jes Sorensen jes.soren...@redhat.com Use struct ieee80211_mgmt to parse action frame. In addition remove unused functions rtw_cfg80211_rx_p2p_action_public() and rtw_cfg80211_rx_action_p2p() Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 54/74] staging: rtl8723au: rtl8723a_cmd.c: Get rid of SetToDs()/SetFrDs() usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

[PATCH 51/74] staging: rtl8723au: Get rid of duplicate ieee80211 frame_control defines

From: Jes Sorensen jes.soren...@redhat.com This is all defined nicely in ieee80211.h, this was all duplication serving no other purpose than to obfuscate the code. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 49

[PATCH 65/74] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_find_ie()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH 49/74] staging: rtl8723au: Declare issue_asocrsp() static

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 19 +++ drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 -- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 26/74] staging: rtl8723au: wifi.h: Remove a pile of unused WDS_ defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 67 1 file changed, 67 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h

[PATCH 44/74] staging: rtl8723au: Remove unused SetFrameType() macro

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index

[PATCH 57/74] staging: rtl8723au: rtw_mlme_ext.c: Fix compile warnings

From: Jes Sorensen jes.soren...@redhat.com Fixup #ifdefs to not build issue_assocrsp() and OnAuth23a() when CONFIG_8723AU_AP_MODE is not set. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 16 +--- 1 file changed, 9

[PATCH 60/74] staging: rtl8723au: Get rid of unused get_bsstype23a()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 9 - drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 1 - 2 files changed, 10 deletions(-) diff --git

[PATCH 43/74] staging: rtl8723au: Get rid of obsolete SetPriority()/SetEOSP()/SetAckpolicy()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/wifi.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index

[PATCH 64/74] staging: rtl8723au: rtw_ieee80211.c: Remove a number of unused functions

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 47 -- drivers/staging/rtl8723au/include/ieee80211.h | 2 -- 2 files changed, 49 deletions(-) diff --git

[PATCH 41/74] staging: rl8723au: rtw_make_wlanhdr(): Use ieee80211_qos_hdr

From: Jes Sorensen jes.soren...@redhat.com Use the kernel provided struct and defines to fill in qos_ctrl Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

[PATCH 32/74] staging: rtl8723au: rtl8723a_cmd.c: Properly initialize seq_ctrl

From: Jes Sorensen jes.soren...@redhat.com Control frames will not be fragmented, so we should fully initialize the seq_ctrl field to zero. This avoids leftover stack bits remaining set in the generated frame's seq_ctrl field. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 72/74] staging: rtl8723au: rtw_mlme_ext.c: Fixup some more unreadable formatting

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 208 +- 1 file changed, 103 insertions(+), 105 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

Re: [PATCH 04/74] staging: rtl8723au: HalEEValueCheck(): content of a u8 is always = 0

On Wed, May 21, 2014 at 09:37:28AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 05/74] staging: rtl8723au: Fix up some random bit-flag handling

On Wed, May 21, 2014 at 09:37:29AM +0200, jes.soren...@redhat.com wrote: diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index b912d09..8c6b094 100644 --- a/drivers/staging/rtl8723au/core/rtw_mlme.c +++

Re: [PATCH 11/74] staging: rtl8723au: Introduce struct rtw_wep_key to store our wep keys

On Wed, May 21, 2014 at 09:37:35AM +0200, jes.soren...@redhat.com wrote: diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl8723au/core/rtw_ioctl_set.c index 347ea99..19e2e68 100644 --- a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c +++

[PATCH 52/74] staging: rtl8723au: rtw_mlme_ext.c: Get rid of SetToDs()/SetFrDs() usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 33/74] staging: rtl8723au: rtw_make_wlanhdr23a(): Use IEEE80211_SN_TO_SEQ() to set seq_ctrl

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c

[PATCH 59/74] staging: rtl8723au: Declare SetBWMode23a() static

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 5 +++-- drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 68/74] staging: rtl8723au: rtw_cfg80211_rx_action(): Use ieee80211_mgmt to parse action frame

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 26 ++- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 63/74] staging: rtl8723au: rtw_cmd.h: Remove some more unused #defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_cmd.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_cmd.h b/drivers/staging/rtl8723au/include/rtw_cmd.h index

Re: [PATCH 05/74] staging: rtl8723au: Fix up some random bit-flag handling

Dan Carpenter dan.carpen...@oracle.com writes: On Wed, May 21, 2014 at 09:37:29AM +0200, jes.soren...@redhat.com wrote: diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index b912d09..8c6b094 100644 ---

Re: [PATCH 05/74] staging: rtl8723au: Fix up some random bit-flag handling

On Wed, May 21, 2014 at 10:49:55AM +0200, Jes Sorensen wrote: Dan Carpenter dan.carpen...@oracle.com writes: On Wed, May 21, 2014 at 09:37:29AM +0200, jes.soren...@redhat.com wrote: diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index

Re: [PATCH 40/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl

On Wed, May 21, 2014 at 09:38:04AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH 40/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl

Dan Carpenter dan.carpen...@oracle.com writes: On Wed, May 21, 2014 at 09:38:04AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 9 + 1 file

Re: [PATCH 46/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits

On Wed, May 21, 2014 at 09:38:10AM +0200, jes.soren...@redhat.com wrote: drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

Re: [PATCH 40/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl

On Wed, May 21, 2014 at 01:59:04PM +0200, Jes Sorensen wrote: Dan Carpenter dan.carpen...@oracle.com writes: On Wed, May 21, 2014 at 09:38:04AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

Re: [PATCH 46/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits

Dan Carpenter dan.carpen...@oracle.com writes: On Wed, May 21, 2014 at 09:38:10AM +0200, jes.soren...@redhat.com wrote: drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git

[PATCH v2 46/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits

From: Jes Sorensen jes.soren...@redhat.com v2: Fix endian bug reported by Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-)

Re: [PATCH 61/74] staging: rtl8723au: Move dummy_event_callback() to rtw_mlme_ext.c

This comment is not related to your patch. On Wed, May 21, 2014 at 09:38:25AM +0200, jes.soren...@redhat.com wrote: static struct fwevent wlanevents[] = { - {0, rtw_dummy_event_callback23a}, /*0*/ + {0, dummy_event_callback}, /*0*/ {0, NULL}, {0, NULL},

Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

On 16 May 2014 16:39, Ian Abbott abbo...@mev.co.uk wrote: These changes to the Microsoft Hyper-V storage driver in Ubuntu Saucy's 3.13 kernel look useful for the mainline kernel, especially as they enable 'TRIM' support. Andy Whitcroft (2): scsi: hyper-v storvsc switch up to SPC-3 scsi:

Re: [PATCH 61/74] staging: rtl8723au: Move dummy_event_callback() to rtw_mlme_ext.c

Dan Carpenter dan.carpen...@oracle.com writes: This comment is not related to your patch. On Wed, May 21, 2014 at 09:38:25AM +0200, jes.soren...@redhat.com wrote: static struct fwevent wlanevents[] = { -{0, rtw_dummy_event_callback23a}, /*0*/ +{0, dummy_event_callback},

Re: [PATCH v2 3/3] Staging: bcm: Outsourced IsFlash2x() handling

On 20-05-2014 22:52:41, Dan Carpenter wrote: On Tue, May 20, 2014 at 05:12:46PM +0200, Matthias Beyer wrote: This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. This patch introduces a bug. Please fix and resend. Also move the

[PATCH] staging: dgap: fix smatch warn: missing break in case

This patch fixes an smatch warning about a missing break in a case statement. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.c | 6 ++ 1 file changed, 2

[PATCH] staging: dgap: fix smatch warn: unsigned var is never less than zero

This patch fixes a smatch warning about an unsigned integer being tested for less than zero. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.h | 2 +- 1 file changed, 1

[PATCH] lustre: Use time_before()

To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/lustre/lustre/include/linux/obd.h |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] staging: ozwpan: Add missing blanklines after declarations

Signed-off-by: James A Shackleford sh...@linux.com --- (For Eudyptula Challenge) --- drivers/staging/ozwpan/ozhcd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b3d401a..91bb29e 100644 ---

[PATCH net-next] Add hash value into RNDIS Per-packet info

It passes the hash value as the RNDIS Per-packet info to the Hyper-V host, so that the send completion notices can be spread across multiple channels. MS-TFS: 140273 Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/net/hyperv/hyperv_net.h |4

[PATCH] staging: dgap: Remove dead sniff buffer code

The sniff buffer was a /proc filesystem file. This module no longer uses /proc. This patch removes the deaed code associated with the sniff buffer. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net ---

[PATCH] staging: dgap: Remove erroneous comment

This patch removes a false comment Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/dgap/dgap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index b3ad3ac..6816cf7

[PATCH] staging: dgap: Remove unnecessary test on count

This patch removes an unnecessary test. We've already tested it by the time we get here with no possiblity of it being changed. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Tested-by: Mark Hounschell ma...@compro.net ---

Re: [PATCH v2 3/3] Staging: bcm: Outsourced IsFlash2x() handling

No problem, let me explain the bug better. On Wed, May 21, 2014 at 06:14:53PM +0200, Matthias Beyer wrote: + ULONG ulDSDMagicNumInUsrBuff = 0; + + Status = BcmFlash2xCorruptSig(Adapter, Adapter-eActiveDSD); + if (Status != STATUS_SUCCESS) { + if (((stNVMReadWrite-uiOffset +

  1   2   >