This patch adjusts boolean assignments from 0/1 to false/true.
And accordingly, it also adjusts the if conditions.
Signed-off-by: Heba Aamer heba93aa...@gmail.com
---
drivers/staging/media/lirc/lirc_serial.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Reformat comments to usual style and add kerneldoc to exported
functions.
1) staging: comedi: 8255.c: reformat copyright comment
2) staging: comedi: 8255.c: reformat comedi driver comment
3) staging: comedi: 8255.c: document subdev_8255_init() and _mm_init()
4) staging: comedi: 8255.c: reformat
Use the usual block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.c
Use the usual block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 61 +--
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.c
Add kerneldoc comments for the subdev_8255_init() and
subdev_8255_mm_init() functions and remove the other comment about how
to use this module in a comedi driver.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 79 ---
1
Use the usual block comment formatting style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.c
b/drivers/staging/comedi/drivers/8255.c
index
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible
It is fixed by reformatting the comment block to usual comment style.
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 195
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- line over 80 characters
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git
Vitaly Kuznetsov vkuzn...@redhat.com writes:
It is possible (since 93e5bd06a953: Drivers: hv: Make the vmbus driver
unloadable) to unload hv_vmbus driver if no other devices are connected.
1aec169673d7: x86: Hyperv: Cleanup the irq mess fixed doulble interrupt
gate setup. However, if we try
Add a comedi driver comment in a form suitable for importing into
Comedilib documentation. The information about the change-of-state
subdevice has been pulled from other comments in the driver.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi_apci_1032.c | 78
On Sun, Jan 25, 2015 at 07:57:55PM +0800, Greg KH wrote:
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO
Ian,
At 2015/1/26 19:31, Ian Abbott wrote:
Okay, but this comment block really needs reformatting to use the usual
block comment style, and with spaces to line up the columns instead of
tabs so it still looks okay when the * is removed from the start of
each line of the block comment.
This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev,
... then dev_info(dev, ... then pr_info(... to
printk(KERN_INFO ...
Signed-off-by: Heba Aamer heba93aa...@gmail.com
---
v2: changed netdev_info to pr_info
Use the usual block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
On Sun, 25 Jan 2015, KY Srinivasan wrote:
Subject: [PATCH 3/3 v2] hyperv: hid-hyperv.c: match
wait_for_completion_timeout return type
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Thank you.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Applied. Nicholas, please make sure
In mdc_kuc_write(), OBD_ALLOC(lh, len) may leave 'lh' to NULL as kmalloc
may fail to allocate memory. This fix adds a check to avoid, dereferencing
a NULL pointer.
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 ++
1 file changed, 2
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Monday, January 26, 2015 2:39 AM
To: Greg Kroah-Hartman
Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux-
ker...@vger.kernel.org; Dexuan Cui
Subject: Re: [PATCH v3] Drivers: hv:
On Mon, 26 Jan 2015, Kumar Amit Mehta wrote:
In rtw_check_bcn_info(), check the return value of kzalloc() before
dereferencing it, to avoid NULL pointer dereference.
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 ++
1 file
In rtw_check_bcn_info(), check the return value of kzalloc() before
dereferencing it, to avoid NULL pointer dereference.
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Mon, 26 Jan 2015, Julia Lawall wrote:
On Mon, 26 Jan 2015, Kumar Amit Mehta wrote:
In rtw_check_bcn_info(), check the return value of kzalloc() before
dereferencing it, to avoid NULL pointer dereference.
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
---
On 26/01/15 13:17, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- line over 80 characters
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 15 ++-
1 file changed, 10 insertions(+), 5
OBD_ALLOC_PTR(uuid) invokes kmalloc, which may return NULL. This fix
adds a check before dereferencing such pointer.
Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 5 +
1 file changed, 5 insertions(+)
diff --git
On Monday, January 26, 2015 7:29 AM, Ian Abbott wrote:
Add a comedi driver comment in a form suitable for importing into
Comedilib documentation. The information about the change-of-state
subdevice has been pulled from other comments in the driver.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
On Monday, January 26, 2015 5:06 AM, Ian Abbott wrote:
1) staging: comedi: 8253.h: reformat copyright comment
2) staging: comedi: 8253.h: reformat other block comments
3) staging: comedi: 8253.h: use usual style for single-line comments
drivers/staging/comedi/drivers/8253.h | 92
On Monday, January 26, 2015 6:25 AM, Ian Abbott wrote:
Reformat comments to usual style and add kerneldoc to exported
functions.
1) staging: comedi: 8255.c: reformat copyright comment
2) staging: comedi: 8255.c: reformat comedi driver comment
3) staging: comedi: 8255.c: document
On Monday, January 26, 2015 3:29 AM, Ian Abbott wrote:
On 23/01/15 23:12, H Hartley Sweeten wrote:
The analog input (*do_cmdtest) in this driver currently validates that the
scan_begin_src is TRIG_FOLLOW or, if the board can_burst, TRIG_TIMER or
TRIG_EXT.
The rest of the driver is coded to
On 25/01/15 18:47, Marek Vasut wrote:
On Sunday, January 25, 2015 at 05:28:18 PM, Kristina Martšenko wrote:
These patches fix some issues with using the touchscreen and reading
other ADC channels at the same time.
[...]
Hi!
Thanks!
Entire series
Reviewed-by: Marek Vasut
This set of changes finds the _CRS object in the ACPI namespace
that contains memory address space descriptors, intended to convey
to VMBus which ranges of memory-mapped I/O space are available for
child devices, and then builds a resource list that contains all
those ranges. Without this change,
commit 92afc2b229038d7b962ae69de5b07bc6c1cf51bf inroduced a logic error
in the DMA size calculation.
If the 'nsamples' is greater than the 'unread_samples' then DMA needs to
be restarted. The current code checks it agains the 'max_samples'.
Signed-off-by: H Hartley Sweeten
On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote:
This patch change the error return value from -1 to -ENOMEM,
so that userspace can get the correct errno, otherwise,
-1 will be -EPERM, userspace will print permission deny for allocation
failure.
Signed-off-by: Yalin Wang
This patch change the error return value from -1 to -ENOMEM,
so that userspace can get the correct errno, otherwise,
-1 will be -EPERM, userspace will print permission deny for allocation
failure.
Signed-off-by: Yalin Wang yalin.w...@sonymobile.com
---
drivers/staging/android/ion/ion_cma_heap.c
On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with
drivers/staging/built-in.o: In function `reset':
(.text+0x2ae89d): multiple
Dear Super 5 Winner,
The Super 5 is a Lottery game of chance under the supervision of MALTCO
LOTTERIES Limited and
the Super 5 numbers are randomly drawn from a field of numbers from 1 to 45 and
each Super 5 Numbers
are attached electronically to recipients email addresses and later entered in
Greg KH gre...@linuxfoundation.org writes:
On Fri, Jan 09, 2015 at 10:18:51PM -0800, K. Y. Srinivasan wrote:
From: Vitaly Kuznetsov vkuzn...@redhat.com
fcopyd in missing in the Makefile, add it there.
Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com
Signed-off-by: K. Y. Srinivasan
This patch fixes the following checkpatch.pl error:
space prohibited before that close parenthesis ')'
Signed-off-by: Mariam Mohamed Fawzy maryammohame...@gmail.com
---
drivers/staging/fbtft/fb_bd663474.c | 98 ++---
1 file changed, 49 insertions(+), 49
This patch fixes the following in checkpatch.pl error:
space required after that ','
Signed-off-by: Mariam Mohamed Fawzy maryammohame...@gmail.com
---
drivers/staging/fbtft/fb_bd663474.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_bd663474.c
This patchset fixes three coding style errors in the file
fb_bd663474.c located in the driver fbtft
Mariam Mohamed Fawzy (3):
fix space prohibited before that close parenthesis ')'
fix space prohibited after that open parenthesis '('
fix space required after that ','
This patch fixes the following checkpatch.pl error:
space prohibited after that open parenthesis '('
Signed-off-by: Mariam Mohamed Fawzy maryammohame...@gmail.com
---
drivers/staging/fbtft/fb_bd663474.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On 23/01/15 23:12, H Hartley Sweeten wrote:
The analog input (*do_cmdtest) in this driver currently validates that the
scan_begin_src is TRIG_FOLLOW or, if the board can_burst, TRIG_TIMER or
TRIG_EXT.
The rest of the driver is coded to assume that the scan_begin_src is always
TRIG_FOLLOW.
I
Call __set_current_state() instead of assigning the new state directly.
These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
keeping track of who changed the state.
Signed-off-by: Davidlohr Bueso dbu...@suse.de
---
drivers/staging/comedi/drivers/me_daq.c | 2 +-
This patch fixes the following checkpatch.pl error:
fix that open brace { should be on the previous line
Signed-off-by: Mariam Mohamed Fawzy maryammohame...@gmail.com
---
v2: Adjusted my legal name.
drivers/staging/vt6655/card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Greg Kroah-Hartman gre...@linuxfoundation.org writes:
On Mon, Jan 12, 2015 at 05:50:11PM +0100, Vitaly Kuznetsov wrote:
When an SMP Hyper-V guest is running on top of 2012R2 Server and secondary
cpus are sent offline (with echo 0 /sys/devices/system/cpu/cpu$cpu/online)
the system freeze is
On 23/01/15 19:11, jitendra kumar khasdev wrote:
This is patch to file jr3_pci.h that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
1 file changed, 3
On 23/01/15 19:11, jitendra kumar khasdev wrote:
This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature
of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
so that 80 character line
On 25/01/15 09:30, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- line over 80 characters
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 14 ++
1 file changed, 10 insertions(+), 4
On 23/01/15 23:12, H Hartley Sweeten wrote:
The (*do_cmdtest) validates the cmd-convert_src as (TRIG_TIMER | TRIG_EXT |
TRIG_NOW). Only the TRIG_TIMER source validates the cmd-convert_arg using
the i8253_cascade_ns_to_timer() helper. The (*do_cmd) operation should only
program the pacer when the
On 25/01/15 09:28, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 26 +-
1 file
On 25/01/15 09:48, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- please, no space before tabs
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use the usual block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8253.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8253.h
b/drivers/staging/comedi/drivers/8253.h
index
1) staging: comedi: 8253.h: reformat copyright comment
2) staging: comedi: 8253.h: reformat other block comments
3) staging: comedi: 8253.h: use usual style for single-line comments
drivers/staging/comedi/drivers/8253.h | 92 ++-
1 file changed, 48 insertions(+),
Use the usual block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8253.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8253.h
Use one space after the opening and one space before the closing of the
comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8253.h | 48 +--
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git
Hi,
On 25/01/15 16:47, Nicholas Mc Guire wrote:
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
---
v2: fixed subject line
The return type of wait_for_completion_timeout is unsigned long not
int. This patch fixes up the declarations only.
Patch was compile tested only for
On Mon, Jan 26, 2015 at 11:38:54AM +0100, Vitaly Kuznetsov wrote:
Greg Kroah-Hartman gre...@linuxfoundation.org writes:
On Mon, Jan 12, 2015 at 05:50:11PM +0100, Vitaly Kuznetsov wrote:
When an SMP Hyper-V guest is running on top of 2012R2 Server and secondary
cpus are sent offline (with
Refactor das16_interrupt() to use the comedi_async 'scans_done' member to
detect the End-of-Acquisition for the async command. Use the helper function
comedi_nsamples_left() to determine if DMA needs to be restarted.
This allows the removal of the private data 'adc_byte_count' and fixes a
-Original Message-
From: Nicholas Mc Guire [mailto:der.h...@hofr.at]
Sent: Sunday, January 25, 2015 1:09 PM
To: KY Srinivasan
Cc: Haiyang Zhang; de...@linuxdriverproject.org; net...@vger.kernel.org;
linux-ker...@vger.kernel.org; Nicholas Mc Guire
Subject: [PATCH v2] net: hyperv:
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with
drivers/staging/built-in.o: In function `reset':
(.text+0x2ae89d): multiple definition of `reset'
Introduce a helper function to program the mux and gain for analog input
single channel (*insn_read) and multi-channel (*do_cmd) operations.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Clarify the (*attach) a bit by introducing a helper function to handle the
setup of the analog input 'range_table'.
Some of the boards supported by this driver do not have programmable ranges.
The analog input subdevice can use optional range information provided by
the user during the attach of
Currently this driver alwasy programs the DMA transfer to be the allocated
size of the DMA buffer. When the async command 'stop_src' is TRIG_COUNT its
possible (likely) for the last transfer to be less than the buffer size.
Introduce a helper function, das16_ai_setup_dma(), to calculate the
The das16_ai_disable() function disables interrupts and the pacer clock. This
function is called by the subdevice (*cancel) operation.
The comedi core will not call a subdevice (*insn_read) operation while an
async command is running due to the s-busy check in parse_insn(). Since all
async
Clarify the (*attach) a bit by introducing a helper function to handle the
setup of the analog output 'range_table'.
Some of the boards supported by this driver do not have programmable ranges.
The analog output subdevice can use optional range information provided by
the user during the attach
This function is only called by das16_cancel(). Absorb it to clarify code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16.c | 17 +
1 file
This member of the private data is a true/false flag. For aesthetics,
change the type to an unsigned int bit-field to save a bit of space.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
-Original Message-
From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
Sent: Monday, January 26, 2015 2:54 PM
To: Vitaly Kuznetsov
Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux-
ker...@vger.kernel.org; Dexuan Cui
Subject: Re: [PATCH v3] Drivers:
65 matches
Mail list logo
