Re: [PATCH 03/11] Drivers: hv: vmbus: Use the macro for comparing GUIDs

On Wed, Nov 11, 2015 at 3:59 AM, K. Y. Srinivasan wrote: > Use the uuid_le_cmp() macro for comparing GUIDs. It's not a macro as I see. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/channel_mgmt.c |3 +-- > drivers/hv/vmbus_drv.c|4

[PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

Remove the wrapper function cl_lock_lockdep_init() and replace its only call with the function it wrapped. Signed-off-by: Shivani Bhardwaj --- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [PATCH 5/8] staging/rdma/hfi1: return early if setlink state was specified

On Wed, Nov 11, 2015 at 12:43:06AM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > Set link state was not supported and so we can return early in the parameter > checks rather than falling through the switch clause. > > Signed-off-by: Dennis Dalessandro

Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

On Wed, Nov 11, 2015 at 01:10:40AM -0500, ira.weiny wrote: > The original author and I have been going through the code to see what we can > do. We have identified a couple of other pieces which can be split. > > One question. Is it ok to have functionality which is added which is unused > in

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

Hi Shivani, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.3 next-2015] url: https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/2015-182452 config: m68k-allyesconfig (attached

[PATCH] staging: lustre: cl_io: Remove cl_lock_descr_fid wrapper

Remove unnecessary wrapper function cl_lock_descr_fid() and replace all its calls with the function it wrapped. Signed-off-by: Shivani Bhardwaj --- drivers/staging/lustre/lustre/obdclass/cl_io.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

On Wed, Nov 11, 2015 at 02:33:32AM -0500, Jubin John wrote: > +static int read_efi_var(const char *name, unsigned long *size, > + void **return_data) > +{ > + int ret; > + > + /* set failure return values */ > + *size = 0; > + *return_data = NULL; > + > + /*

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > This goto done is followed by an if (ret) break in the outer switch clause. > It > is unnecessary. > > Signed-off-by: Dennis Dalessandro >

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote: > _rtl88e_fill_dummy fills the array elemets with zeros if necessary. > _rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code is aligned but it doesn't fill up to the end of FW_8188E_SIZE. Why do we even allocate

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

On 11/11/2015 04:43 PM, Dan Carpenter wrote: On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote: _rtl88e_fill_dummy fills the array elemets with zeros if necessary. _rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code is aligned but it doesn't fill up to the end

Re: [PATCH 19/20] staging/wilc1000: use more regular probing

On Wednesday 11 November 2015 09:54:57 Andy Shevchenko wrote: > > diff --git a/drivers/staging/wilc1000/linux_wlan_common.h > > b/drivers/staging/wilc1000/linux_wlan_common.h > > index f2ea8280b8f8..72b524a98cba 100644 > > --- a/drivers/staging/wilc1000/linux_wlan_common.h > > +++

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > This goto done is followed by an if (ret) break in the outer switch clause. > It > is unnecessary. > > Signed-off-by: Dennis Dalessandro >

[PATCH] staging: lustre: Remove cl_2queue_add wrapper

Remove the wrapper function cl_2queue_add() and replace all its calls in different files with the function it wrapped. Also, comments are added wherever necessary to make the working of function clear. Prototype of the function is also removed from the header file as it is no longer needed.

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: From: Dennis Dalessandro +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, +

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <l...@intel.com> wrote: > Hi Shivani, > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.3 next-2015] > > url: > https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/st

[PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

Let's not mix headers used by the core with those headers that are needed by some specific platform drivers. This patch was made via this script: mkdir include/media/platform for i in include/media/*.h; do n=`basename $i`; (for j in $(git grep -l $n); do dirname $j;

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

; > [auto build test ERROR on staging/staging-testing] >> > [also build test ERROR on v4.3 next-2015] >> > >> > url: >> > https://github.com/0day-ci/linux/commits/Shivani-Bhardwaj/staging-lustre-cl_lock-Remove-cl_lock_lockdep_init-wrapper/2015-182452 &g

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

On Wed, Nov 11, 2015 at 03:03:12PM +, Luick, Dean wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Wednesday, November 11, 2015 8:39 AM > > To: Luick, Dean > > Cc: John, Jubin ;

RE: [PATCH 03/11] Drivers: hv: vmbus: Use the macro for comparing GUIDs

> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Wednesday, November 11, 2015 12:35 AM > To: KY Srinivasan > Cc: Greg Kroah-Hartman ; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote: > On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot <l...@intel.com> wrote: > > Hi Shivani, > > > > [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v4.3 next-201

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

On Wed, Nov 11, 2015 at 02:03:02PM +, Luick, Dean wrote: > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > > Sent: Wednesday, November 11, 2015 2:45 AM > > To: John, Jubin

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

On Wed, Nov 11, 2015 at 12:01:08PM +0300, Dan Carpenter wrote: > On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > This goto done is followed by an if (ret) break in the outer switch clause. > > It > > is unnecessary. > > > >

[PATCH] comedi: ni_65xx: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_65xx.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff

Re: [PATCH v2] staging: comedi: use kmalloc_array instead of kmalloc

On 10/11/2015 14:41, Geliang Tang wrote: Use kmalloc_array instead of kmalloc to allocate memory for an array. Signed-off-by: Geliang Tang --- Changes in v2: - preserve the existing whitespace style. --- drivers/staging/comedi/drivers/amplc_pci224.c | 11 +++

[PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/cb_pcidda.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

RE: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday, November 11, 2015 8:39 AM > To: Luick, Dean > Cc: John, Jubin ; de...@driverdev.osuosl.org; > gre...@linuxfoundation.org; dledf...@redhat.com; linux-

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: > >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: > >>From: Dennis Dalessandro > >> > >>+int

Re: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Nov 11, 2015 at 07:15:28PM +0530, Ranjith T wrote: > Is this patch is fine?.. You sent it a few days ago, please wait at least 2 weeks before worrying if a patch is accepted or not, we all

[PATCH] comedi: pcmmio.c: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/pcmmio.c | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/comedi_parport.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On 11/11/2015 13:44, Ranjith T wrote: Is this patch is fine?. Thanks, Ranjith T. Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't really "T". On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T wrote: BIT macro is used for defining BIT location

Re: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

Is this patch is fine?.. Thanks, Ranjith T. On Mon, Nov 9, 2015 at 11:14 PM, Ranjith T wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith T > --- >

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

On Wed, Nov 11, 2015 at 12:03:36PM +0300, Dan Carpenter wrote: On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: From: Ira Weiny This goto done is followed by an if (ret) break in the outer switch clause. It is unnecessary. Signed-off-by: Dennis

Re: [PATCH 18/20] staging/wilc1000: split out bus specific modules

Hi Arnd, [auto build test ERROR on staging/staging-testing] [cannot apply to v4.3 next-2015] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/staging-wilc1000-cleanups-once-again/2015-074846 config: i386-allmodconfig (attached as .config) reproduce: # save

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On 11/11/15 14:18, Ranjith T wrote: Actually my name is Ranjith and father name is Thangavel. So I used to mention my name as Ranjith T. How do you write your name on legal documents? That is what you should use on the patch's "Signed-off-by:" line, and on the email's "From:" line. Thanks.

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

Is this patch is fine?. Thanks, Ranjith T. On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith T > --- >

RE: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Wednesday, November 11, 2015 2:45 AM > To: John, Jubin > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux-

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

Actually my name is Ranjith and father name is Thangavel. So I used to mention my name as Ranjith T. Thanks, Ranjith T On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott wrote: > On 11/11/2015 13:44, Ranjith T wrote: >> >> Is this patch is fine?. >> >> Thanks, >> Ranjith T. > > >

[PATCH V2 01/12] Drivers: hv: vss: run only on supported host versions

From: Olaf Hering The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and

[PATCH V2 10/12] Drivers: hv: vmbus: channge vmbus_connection.channel_lock to mutex

From: Dexuan Cui spinlock is unnecessary here. mutex is enough. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 12 ++-- drivers/hv/connection.c |7 +++

[PATCH V2 08/12] Drivers: hv: vmbus: fix rescind-offer handling for device without a driver

From: Dexuan Cui In the path vmbus_onoffer_rescind() -> vmbus_device_unregister() -> device_unregister() -> ... -> __device_release_driver(), we can see for a device without a driver loaded: dev->driver is NULL, so dev->bus->remove(dev), namely vmbus_remove(), isn't

[PATCH V2 05/12] Drivers: hv: vmbus: Get rid of the unused irq variable

The irq we extract from ACPI is not used - we deliver hypervisor interrupts on a special vector. Make the necessary adjustments. Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 16 +++- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git

[PATCH V2 03/12] Drivers: hv: vmbus: Use uuid_le_cmp() for comparing GUIDs

Use uuid_le_cmp() for comparing GUIDs. Signed-off-by: K. Y. Srinivasan --- V2: Fixed the typo in both the commit log and Subject line. drivers/hv/channel_mgmt.c |3 +-- drivers/hv/vmbus_drv.c|4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff

[PATCH V2 06/12] Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal()

From: Dexuan Cui process_chn_event(), running in the tasklet, can race with vmbus_close_internal() in the case of SMP guest, e.g., when the former is accessing channel->inbound.ring_buffer, the latter could be freeing the ring_buffer pages. To resolve the race, we can

[PATCH V2 02/12] Drivers: hv: vmbus: Use uuid_le type consistently

Consistently use uuid_le type in the Hyper-V driver code. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |2 +- drivers/hv/vmbus_drv.c | 10 ++-- include/linux/hyperv.h | 92 +-

[PATCH V2 00/12] Drivers: hv: vmbus: Miscellaneous fixes and cleanup

Miscellaneous fixes and cleanup. Changes from V1: Fixed the typo in patch number 3. Included the patch tools/hv: Use include/uapi with __EXPORTED_HEADERS__ Dexuan Cui (5): Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal() Drivers: hv: vmbus: do sanity check of

[PATCH V2 04/12] Drivers: hv: vmbus: Get rid of the unused macro

The macro VMBUS_DEVICE() is unused; get rid of it. Signed-off-by: K. Y. Srinivasan --- include/linux/hyperv.h | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index ee243a7..437c9c8 100644

[PATCH V2 11/12] drivers:hv: Allow for MMIO claims that span ACPI _CRS records

From: Jake Oshins This patch makes 16GB GPUs work in Hyper-V VMs, since, for compatibility reasons, the Hyper-V BIOS lists MMIO ranges in 2GB chunks in its root bus's _CRS object. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

On Wed, Nov 11, 2015 at 3:39 PM, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: >> On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: >>> From: Dennis Dalessandro >>> +int

[PATCH V2 09/12] Drivers: hv: vmbus: release relid on error in vmbus_process_offer()

From: Dexuan Cui We want to simplify vmbus_onoffer_rescind() by not invoking hv_process_channel_removal(NULL, ...). Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 21

[PATCH V2 07/12] Drivers: hv: vmbus: do sanity check of channel state in vmbus_close_internal()

From: Dexuan Cui This fixes an incorrect assumption of channel state in the function. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 12 1 files changed, 12 insertions(+), 0

[PATCH 12/12] tools/hv: Use include/uapi with __EXPORTED_HEADERS__

From: Kamal Mostafa Use the local uapi headers to keep in sync with "recently" added #define's (e.g. VSS_OP_REGISTER1). Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb Signed-off-by: Kamal Mostafa Signed-off-by: K. Y. Srinivasan

Re: [PATCH 5/9] staging/rdma/hfi1: Add function stubs for TID caching

On Sat, Oct 31, 2015 at 12:41 AM, wrote: > From: Mitko Haralanov > > Add mmu notify helper functions and TID caching function stubs in preparation > for the TID caching implementation. > > TID caching makes use of the MMU notifier to allow the

Re: [PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

On 11/02/2015 10:42 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Monday, November 2, 2015 3:34 AM Cc: rka...@virtuozzo.com; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; Andrey Smetanin ; KY

[PATCH] staging: wilc1000: fix bug in sdio/spi

sdio_init and wilc_spi_init always return error, so it fails everytime. Fix this by removing else statement. This fixes c1af9db78950a778ec18343c5c5a6d4cfbf58a61, bacd388547f55eb415ce266c8723cc6f1281a25d Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_sdio.c | 2 --

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote: > rename include/media/{ => platform}/exynos-fimc.h (100%) > rename include/media/{ => platform}/mmp-camera.h (100%) > rename include/media/{ => platform}/omap1_camera.h (100%) > rename include/media/{ => platform}/omap4iss.h

[PATCH] Staging: R8723au: rtw_ieee80211: Fixing code style space issues

Fixing code style space issues at rtw_mcs_rate23a() Signed-off-by: Marcos Oviedo --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 80 ++-- 1 file changed, 48 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

Re: [PATCH] Staging: R8723au: rtw_ieee80211: Fixing code style space issues

On Wed, Nov 11, 2015 at 9:48 AM, Marcos Oviedo wrote: > Fixing code style space issues at rtw_mcs_rate23a() > > Signed-off-by: Marcos Oviedo > --- > drivers/staging/rtl8723au/core/rtw_ieee80211.c | 80 > ++-- > 1 file changed, 48

[PATCH] tools/hv: Use include/uapi with __EXPORTED_HEADERS__

Use the local uapi headers to keep in sync with "recently" added #define's (e.g. VSS_OP_REGISTER1). Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb Signed-off-by: Kamal Mostafa --- tools/hv/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/hv/Makefile

Re: [PATCH] Staging: panel: Fixed a spacing after cast coding style issue

On Tue, Nov 10, 2015 at 07:35:30PM +0100, Daniel H. Hemmingsen wrote: > Fixed a spacing after cast coding style issue. > > Signed-off-by: Daniel H. Hemmingsen Acked-by: Willy Tarreau Thanks, Willy ___ devel

Re: [PATCH 01/20] staging/wilc1000: add struct net_device declaration

On Wed, 2015-11-11 at 00:42 +0100, Arnd Bergmann wrote: > A recent cleanup added a reference to struct net_device, but > that structure is not always visible in the context of the > declaration, so we may get a compile-time error: > > In file included from wilc1000/host_interface.c:5:0: >

Re: [PATCH 10/13] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

On Wed, Nov 11, 2015 at 02:33:30AM -0500, Jubin John wrote: > @@ -8288,6 +8367,21 @@ static int init_cntrs(struct hfi1_devdata *dd) > dd->ndevcntrs++; > index++; > } > + } else if (dev_cntrs[i].flags &