[PATCH 3/9] Drivers: hv: utils: introduce HVUTIL_TRANSPORT_DESTROY mode

From: Vitaly Kuznetsov When Hyper-V host asks us to remove some util driver by closing the appropriate channel there is no easy way to force the current file descriptor holder to hang up but we can start to respond -EBADF to all operations asking it to exit gracefully. As

[PATCH 4/9] Drivers: hv: utils: fix crash when device is removed from host side

From: Vitaly Kuznetsov The crash is observed when a service is being disabled host side while userspace daemon is connected to the device: [ 90.244859] general protection fault: [#1] SMP ... [ 90.800082] Call Trace: [ 90.800082] [] __fput+0xc8/0x1f0 [

[PATCH] staging: gdm724x: constify tty_port_operations structs

Constifies tty_port_operations structure in the tty code of the gdm724x driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz ---

Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls

On Mon, Dec 14, 2015 at 10:08:03AM +0100, SF Markus Elfring wrote: > > Markus, please stop sending these things to rename out labels unless > > there is a bug. CodingStyle allows out labels. > > How does this feedback fit to information like the following? > > "… > Chapter 7: … > … > Choose

Re: [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection

On Mon, Dec 14, 2015 at 01:04:14PM +0100, SF Markus Elfring wrote: > >> A few checks would be performed by the mgc_process_recover_log() function > >> even if it is known already that the passed variable "pages" contained > >> a null pointer. > >> > >> * Let us return directly if a call of the

Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection

>> Can you accept the proposed changes around the affected memory allocations? > > Just leave it as-is if there is no reason. I suggest to make the implementation of the function "mgc_process_recover_log" a bit more efficient. >> Do you prefer to stash any changes together for a bigger update

Re: staging: lustre: Rename a jump label for ptlrpc_req_finished() calls

>>> Markus, please stop sending these things to rename out labels unless >>> there is a bug. CodingStyle allows out labels. >> >> How does this feedback fit to information like the following? >> >> "… >> Chapter 7: … >> … >> Choose label names which say what the goto does or why the goto exists.

Re: [PATCH] comedi/comedi.h: cleanup coding style

Hi George, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.4-rc5 next-20151214] url: https://github.com/0day-ci/linux/commits/George-Kobiashvili/comedi-comedi-h-cleanup-coding-style/20151214-175007 config: i386-randconfig-s0-201550 (attached as .config

Re: [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection

>> A few checks would be performed by the mgc_process_recover_log() function >> even if it is known already that the passed variable "pages" contained >> a null pointer. >> >> * Let us return directly if a call of the kcalloc() function failed. >> >> * Move assignments for the variables "eof" and

Re: [PATCH] staging: nvec: fix block comments

Hi Simon, Am Mittwoch, 9. Dezember 2015, 08:14:06 schrieb Simon Guinot: > This patch fixes a couple of checkpatch warnings about block comments. > > Signed-off-by: Simon Guinot > --- > drivers/staging/nvec/nvec.c | 6 -- > drivers/staging/nvec/nvec_power.c

[PATCH] comedi/comedi.h: cleanup coding style

Signed-off-by: George Kobiashvili --- drivers/staging/comedi/comedi.h | 202 ++-- 1 file changed, 112 insertions(+), 90 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 66edda1..8ab57ce 100644

RE: [PATCH RESEND 09/27] drivers:hv: Export the API to invoke a hypercall on Hyper-V

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, December 14, 2015 7:08 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; >

Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Mon, Dec 14, 2015 at 07:03:31PM -0500, Sanidhya Solanki wrote: > Patch updates the TODO file. > > Signed-off-by: Sanidhya Solanki > --- > drivers/staging/dgnc/TODO | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/dgnc/TODO

leads for your business

Hey, Do you need new business? Do you need new sales? Do you need new customers? Do you need new customer leads? We can help you to generate new buyer leads and increase your sales by our mailing service. It will grow your business sales 1-2 times than what it is now. Please reply for pricing

[PATCH 3/3] staging/rdma/hfi1: fix build warning

config CONFIG_INFINIBAND=m, CONFIG_STAGING=y, CONFIG_STAGING_RDMA=m Patch is against linux-next (localversion-next is -next-20151214) drivers/staging/rdma/hfi1/chip.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index 5

[PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc

Patch is against linux-next (localversion-next is -next-20151214) drivers/staging/rdma/hfi1/chip.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index dc69159..31eec8a 100644 --- a/drivers/staging/rdma/hfi1/

[PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc

t linux-next (localversion-next is -next-20151214) drivers/staging/rdma/hfi1/chip.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index 31eec8a..52d2bd7 100644 --- a/drivers/staging/rdma/hfi1/chip.c +++ b/drivers/stagi

RE: [PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc

goto bail; > + I checked out a linux-next remote at the next-20151214 tag. The allocation method is clearly kmalloc_array() not kcalloc(). Where are you seeing the kcalloc()? While it is tempting to allocate and zero, there is a chip r

RE: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc

> --- a/drivers/staging/rdma/hfi1/chip.c > +++ b/drivers/staging/rdma/hfi1/chip.c > @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd, > u32 first_ctxt) > goto bail; > if (num_vls * qpns_per_vl > dd->chip_rcv_contexts) > goto bail; > -

Re: [PATCH 2/3] staging: dgnc: Patch includes CamelCase & Macro fixes

Patch contains the CamelCase fixes & Macro fixes that led to checkpatch.pl errors. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_driver.c | 56 - drivers/staging/dgnc/dgnc_driver.h | 25 ++-- drivers/staging/dgnc/dgnc_mgmt.c | 28 ++---

Re: [PATCH 3/3] staging: dgnc: Patch updates the TODO file

Patch updates the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.

The original code defined macros in the source code, making it harder to read. Moved them to the header file, as per the TODO file. Updated the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/skein/TODO | 1 - drivers/staging/skein/skein_block.c |

Re: [PATCH FIXED 3/3] staging: dgnc: Patch updates the TODO file

Patch updates the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Mon, Dec 14, 2015 at 08:22:47PM -0500, Sanidhya Solanki wrote: > Patch contains the spacing fixes that checkpatch prompted for, > as asked by the TODO. > > Signed-off-by: Sanidhya Solanki What is the FIXED doing in the subject? And the subject is horrid, please make it

Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes the checkpatch fixes

Patch contains the spacing fixes that checkpatch prompted for, as asked by the TODO. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_cls.c| 4 +- drivers/staging/dgnc/dgnc_driver.h | 8 -- drivers/staging/dgnc/dgnc_neo.c| 235

Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Patch contains the spacing fixes that led to checkpatch.pl warnings. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_cls.c| 4 +- drivers/staging/dgnc/dgnc_driver.h | 8 -- drivers/staging/dgnc/dgnc_neo.c| 235 -

Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Why is the "Re:" in the Subject? Why is "Patch" in the subject"? The Subject doesn't even make sense. On Mon, Dec 14, 2015 at 08:58:30PM -0500, Sanidhya Solanki wrote: > Patch contains the spacing fixes that led to checkpatch.pl warnings. > > Signed-off-by: Sanidhya Solanki

Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Patch contains the CamelCase fixes & Macro fixes that checkpatch prompted for, as asked by the TODO. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_driver.c | 56 - drivers/staging/dgnc/dgnc_driver.h | 25 ++-- drivers/staging/dgnc/dgnc_mgmt.c |

Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Patch updates the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes spacing fixes

Patch contains the spacing fixes that led to checkpatch.pl warnings. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_cls.c| 4 +- drivers/staging/dgnc/dgnc_driver.h | 8 -- drivers/staging/dgnc/dgnc_neo.c| 235 -

Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki wrote: > > Patch contains the spacing fixes that led to checkpatch.pl warnings. > > Signed-off-by: Sanidhya Solanki > --- > drivers/staging/dgnc/dgnc_cls.c| 4 +- >

Re: [PATCH] staging/rdma/hfi1: Fix a possible null pointer dereference

t findings like this definitely are a case for coccinelle scanners. /// check for missing NULL check before use // // missing check in: // ./drivers/staging/rdma/hfi1/chip.c:10131 unchecked allocation // in -next-20151214 // reported-by Mike Marciniszyn <mike.mar

[PATCH v2 RESEND 2/4] Drivers: hv: utils: rename outmsg_lock

As a preparation to reusing outmsg_lock to protect test-and-set openrations on 'mode' rename it the more general 'lock'. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv_utils_transport.c | 14 +++--- drivers/hv/hv_utils_transport.h | 2 +- 2 files changed, 8

[PATCH v2 RESEND 0/4] Drivers: hv: utils: prevent crash when a utility driver is disabled host side

Changes since v2: - No changes, this is just a resend. Changes since v1: - Don't re-introduce memory leak in hvt_op_write(), preserve the error code from on_msg() [Dan Carpenter] Original description: I'm observing a crash when a utility driver is disabled host side (e.g. 'Guest services' is

[PATCH v2 RESEND 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

inmsg should be freed in case of on_msg() failure to avoid memory leak. Preserve the error code from on_msg(). Signed-off-by: Vitaly Kuznetsov --- Changes since v1: - Preserve the error code from on_msg(). [Dan Carpenter] --- drivers/hv/hv_utils_transport.c | 7 --- 1

[PATCH] drivers:staging:wlan-ng Fix space preferred around that messages

This fixes all "space preferred around that ..." messages from checkpatch.pl Signed-off-by: Bogicevic Sasa --- drivers/staging/wlan-ng/hfa384x_usb.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH v2 RESEND 3/4] Drivers: hv: utils: introduce HVUTIL_TRANSPORT_DESTROY mode

When Hyper-V host asks us to remove some util driver by closing the appropriate channel there is no easy way to force the current file descriptor holder to hang up but we can start to respond -EBADF to all operations asking it to exit gracefully. As we're setting hvt->mode from two separate

Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection

On Mon, Dec 14, 2015 at 01:45:11PM +0100, SF Markus Elfring wrote: > >> Do you prefer to stash any changes together for a bigger update step? > > > > Yes. Patches 5 and 6 would be easier to review if they were folded into > > one patch. > > I do not like patch squashing for my update

Re: [PATCH 172/182] staging: vme: use gpiochip data pointer

On Fri, Dec 11, 2015 at 7:58 AM, Martyn Welch wrote: > On 09/12/15 13:50, Linus Walleij wrote: >> >> This makes the driver use the data pointer added to the gpio_chip >> to store a pointer to the state container instead of relying on >> container_of(). >> >> Cc: Greg

[PATCH v2 RESEND 4/4] Drivers: hv: utils: fix crash when device is removed from host side

The crash is observed when a service is being disabled host side while userspace daemon is connected to the device: [ 90.244859] general protection fault: [#1] SMP ... [ 90.800082] Call Trace: [ 90.800082] [] __fput+0xc8/0x1f0 [ 90.800082] [] fput+0xe/0x10 ... [ 90.800082]

[PATCH] drivers:staging:wlan-ng Fix all no space necesarry after a cast

This fixes all messages "no space necesarry after a cast" in cfg80211.c file Signed-off-by: Bogicevic Sasa --- drivers/staging/wlan-ng/cfg80211.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[RFC PATCH 02/15] IB/hfi1: Add basic rdmavt capability flags for hfi1

Most functionality is still being done in the driver, set flags so that rdmavt will let hfi1 continue to handle mr, qp, and cq init. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/verbs.c |

[RFC PATCH 11/15] IB/hfi1: Remove hfi1 MR and hfi1 specific qp type

This patch does the actual removal of the queue pair from the hfi1 driver along with a number of dependent data structures. These were moved to rvt. It also removes the MR functions to use those in rdmavt. These two pieces can not reasonably be split apart becuase they depend on each other.

[RFC PATCH 10/15] IB/hfi1: Implement hfi1 support for AH notification

For OPA devices additional work is required to create an AH. This patch adds support to set the VL correctly. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/verbs.c | 24

[RFC PATCH 15/15] IB/hfi1: Use rdmavt pkey verbs function

No need to keep providing the query pkey function. This is now being done in rdmavt. Remove support from hfi1. The allocation and maintenance of the list still resides in the driver. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro

[RFC PATCH 06/15] IB/hfi1: Remove driver specific members from hfi1 qp type

In preparation for moving the queue pair data structure to rdmavt the members of the driver specific queue pairs which are not common need to be pushed off to a private driver structure. This structure will be available in the queue pair once moved to rdmavt as a void pointer. This patch while not

[RFC PATCH 12/15] IB/hfi1: Remove srq from hfi1

SRQ data structure has been moved to rdmavt. Make use of it. Reviewed-by: Harish Chegondi Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/qp.c|2 +- drivers/staging/rdma/hfi1/ruc.c |4 ++--

[RFC PATCH 09/15] IB/hfi1: Use address handle in rdmavt and remove from hfi1

Original patch from Kamal Heib , split apart from original and modified to accomodate recent changes in rdmavt. Remove AH from hfi1 and use rdmavt version. Signed-off-by: Kamal Heib Signed-off-by: Dennis Dalessandro

Re: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc

On Mon, Dec 14, 2015 at 03:28:46PM +, Marciniszyn, Mike wrote: > > --- a/drivers/staging/rdma/hfi1/chip.c > > +++ b/drivers/staging/rdma/hfi1/chip.c > > @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd, > > u32 first_ctxt) > > goto bail; > > if (num_vls *

[RFC PATCH 04/15] IB/hfi1: Use rdmavt protection domain

Remove protection domain from hfi1 and use rdmavt's version. Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/keys.c |4 +-

[RFC PATCH 03/15] IB/hfi1: Consolidate dma ops for hfi1

Remove the dma.c file from hfi1 in favor of using that which is present in rdmavt. Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/Makefile |

[RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

This patch series is being submitted as a Request For Comment only. It depends on code submitted to the rdma subsystem [1]. This work is the first submission aimed to satisfy the TODO item for removing duplicated code in hfi1. At the time of submission hfi1 and qib contained alot of duplicated

[RFC PATCH 05/15] IB/hfi1: Remove MR data structures from hfi1

Remove MR data structures from hfi1 and use the version in rdmavt Reviewed-by: Dean Luick Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/keys.c | 30

Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection

>> I do not like patch squashing for my update suggestions here. > > I am a maintainer in drivers/staging. Thanks for this information. > I am telling you what you need to do if you want us to apply your patch. I am still waiting for a bit more constructive feedback for this patch series. How

[RFC PATCH 07/15] IB/hfi1: Add device specific info prints

Implement get_card_name and get_pci_dev helper functions for rdmavt for hfi1. Reviewed-by: Mike Marciniszyn Reviewed-by: Ira Weiny Signed-off-by: Dennis Dalessandro --- drivers/staging/rdma/hfi1/driver.c | 16

[RFC PATCH 13/15] IB/hfi1: Remove ibport and use rdmavt version

Remove most of the ibport members from hfi1 and use the rdmavt version. Also register the port with rdmavt. Reviewed-by: Mike Marciniszyn Reviewed-by: Harish Chegondi Signed-off-by: Dennis Dalessandro

Re: [PATCH 1/2] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay

On Fri, Nov 13, 2015 at 04:48:10PM +0530, Nizam Haider wrote: > removed heckpatch warning heckpatch? And what warning is that? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [jubin.j...@intel.com: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build]

On Mon, Dec 14, 2015 at 02:36:39PM -0500, ira.weiny wrote: > Greg, > > It looks like you missed this patch for 4.4-rc5 > > Could we get it included for rc6? I'll try, but again, I'm way behind, give me a few more days... thanks, greg k-h ___ devel

Re: [PATCH v4 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

On Mon, Dec 14, 2015 at 02:54:09PM -0500, ira.weiny wrote: > Any further feedback on this series? I'm way behind on staging patches right now (1000+ patches behind...), hopefully will catch up on them this week. thanks, greg k-h ___ devel mailing list

Re: [PATCH 172/182] staging: vme: use gpiochip data pointer

On 14/12/15 14:14, Linus Walleij wrote: On Fri, Dec 11, 2015 at 7:58 AM, Martyn Welch wrote: On 09/12/15 13:50, Linus Walleij wrote: This makes the driver use the data pointer added to the gpio_chip to store a pointer to the state container instead of relying on

hfi1 patches and ordering

Greg, We have other patch series close to being submitted. Some depend on the inflight patches you are behind on, some on each other. What is the best way of handling this to insure no conflicts? Mike ___ devel mailing list

Re: [PATCH v4 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

Any further feedback on this series? Ira On Tue, Dec 01, 2015 at 02:47:55PM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > This was a single patch before. The change to dev_dbg required a precursor > patch to add the dd_dev_dbg which is consistent with the other

[PATCH] comedi/comedilib.h: cleanup coding style

Signed-off-by: George Kobiashvili --- drivers/staging/comedi/comedilib.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index 56baf85..ccbe17b 100644

Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls

> Markus, please stop sending these things to rename out labels unless > there is a bug. CodingStyle allows out labels. How does this feedback fit to information like the following? "… Chapter 7: … … Choose label names which say what the goto does or why the goto exists. … Avoid using GW-BASIC

[PATCH] Staging: fbtft: Removed commented out/dead code

Deleted various commented out lines that have been replaced by write_reg() Signed-off-by: Ben Gilbert --- drivers/staging/fbtft/fb_uc1701.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/staging/fbtft/fb_uc1701.c

Re: [PATCH] Coding style cleanup

On 14/12/15 18:17, Dan Carpenter wrote: Fix the subject line. On Mon, Dec 14, 2015 at 06:09:46PM +, Ben Gilbert wrote: Fixed commenting style warnings. This stuff is dead code. Just delete it. Thanks Dan. Please ignore this patch, I am sending a new one. regards, dan carpenter

[jubin.j...@intel.com: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build]

Greg, It looks like you missed this patch for 4.4-rc5 Could we get it included for rc6? Thanks, Ira - Forwarded message from Jubin John - From: Jubin John To: , CC:

Re: [PATCH] Coding style cleanup

Fix the subject line. On Mon, Dec 14, 2015 at 06:09:46PM +, Ben Gilbert wrote: > Fixed commenting style warnings. This stuff is dead code. Just delete it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc

On Mon, Dec 14, 2015 at 05:41:23PM +, Nicholas Mc Guire wrote: > I obviously made a real mess here. > I incorrectly concluded that rxcontext is 0 which it is not in some cases Yep. Plus you build tested it but assumed that the unused variable warning must have been there in the original...

[PATCH] Coding style cleanup

Fixed commenting style warnings. Signed-off-by: Ben Gilbert --- drivers/staging/fbtft/fb_uc1701.c | 53 ++- 1 file changed, 35 insertions(+), 18 deletions(-) diff --git a/drivers/staging/fbtft/fb_uc1701.c

Re: hfi1 patches and ordering

On Mon, Dec 14, 2015 at 09:52:31PM +, Marciniszyn, Mike wrote: > Greg, > > We have other patch series close to being submitted. > > Some depend on the inflight patches you are behind on, some on each other. > > What is the best way of handling this to insure no conflicts? I apply patches

RE: [PATCH RESEND 00/27] Drivers: hv: Miscellaneous fixes.

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, December 14, 2015 10:59 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; >

[PATCH RESEND 00/27] Drivers: hv: Miscellaneous fixes.

Miscellaneous fixes and improvements. Andrey Smetanin (2): drivers/hv: cleanup synic msrs if vmbus connect failed drivers/hv: correct tsc page sequence invalid value Dexuan Cui (6): Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal() Drivers: hv: vmbus: do

[PATCH RESEND 14/27] Drivers: hv: vmbus: Get rid of the unused macro

The macro VMBUS_DEVICE() is unused; get rid of it. Signed-off-by: K. Y. Srinivasan --- include/linux/hyperv.h | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index b9f3bb2..f773a68 100644

[PATCH RESEND 27/27] tools: hv: vss: fix the write()'s argument: error -> vss_msg

From: Dexuan Cui Fix the write()'s argument in the daemon code. Cc: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui Cc: sta...@vger.kernel.org Signed-off-by: K. Y. Srinivasan

[PATCH RESEND 12/27] Drivers: hv: vmbus: Use uuid_le type consistently

Consistently use uuid_le type in the Hyper-V driver code. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |2 +- drivers/hv/vmbus_drv.c | 10 ++-- include/linux/hyperv.h | 92 +-

[PATCH RESEND 13/27] Drivers: hv: vmbus: Use uuid_le_cmp() for comparing GUIDs

Use uuid_le_cmp() for comparing GUIDs. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |3 +-- drivers/hv/vmbus_drv.c|4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index

[PATCH RESEND 20/27] Drivers: hv: vmbus: channge vmbus_connection.channel_lock to mutex

From: Dexuan Cui spinlock is unnecessary here. mutex is enough. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 12 ++-- drivers/hv/connection.c |7 +++

[PATCH RESEND 18/27] Drivers: hv: vmbus: fix rescind-offer handling for device without a driver

From: Dexuan Cui In the path vmbus_onoffer_rescind() -> vmbus_device_unregister() -> device_unregister() -> ... -> __device_release_driver(), we can see for a device without a driver loaded: dev->driver is NULL, so dev->bus->remove(dev), namely vmbus_remove(), isn't

[PATCH RESEND 19/27] Drivers: hv: vmbus: release relid on error in vmbus_process_offer()

From: Dexuan Cui We want to simplify vmbus_onoffer_rescind() by not invoking hv_process_channel_removal(NULL, ...). Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 21

[PATCH RESEND 21/27] drivers:hv: Allow for MMIO claims that span ACPI _CRS records

From: Jake Oshins This patch makes 16GB GPUs work in Hyper-V VMs, since, for compatibility reasons, the Hyper-V BIOS lists MMIO ranges in 2GB chunks in its root bus's _CRS object. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan

[PATCH RESEND 04/27] tools: hv: remove repeated HV_FCOPY string

From: Olaf Hering HV_FCOPY is already used as identifier in syslog. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_fcopy_daemon.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH RESEND 10/27] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

From: Jake Oshins This defines the channel type for PCI front-ends in Hyper-V VMs. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |3 +++ include/linux/hyperv.h| 11 +++

[PATCH RESEND 16/27] Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal()

From: Dexuan Cui process_chn_event(), running in the tasklet, can race with vmbus_close_internal() in the case of SMP guest, e.g., when the former is accessing channel->inbound.ring_buffer, the latter could be freeing the ring_buffer pages. To resolve the race, we can

[PATCH RESEND 02/27] Drivers: hv: utils: run polling callback always in interrupt context

From: Olaf Hering All channel interrupts are bound to specific VCPUs in the guest at the point channel is created. While currently, we invoke the polling function on the correct CPU (the CPU to which the channel is bound to) in some cases we may run the polling function in a

[PATCH RESEND 07/27] drivers/hv: cleanup synic msrs if vmbus connect failed

From: Andrey Smetanin Before vmbus_connect() synic is setup per vcpu - this means hypervisor receives writes at synic msr's and probably allocate hypervisor resources per synic setup. If vmbus_connect() failed for some reason it's neccessary to cleanup synic setup by

[PATCH RESEND 05/27] Drivers: hv: util: catch allocation errors

From: Olaf Hering Catch allocation errors in hvutil_transport_send. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan ---

[PATCH RESEND 03/27] tools: hv: report ENOSPC errors in hv_fcopy_daemon

From: Olaf Hering Currently some "Unspecified error 0x80004005" is reported on the Windows side if something fails. Handle the ENOSPC case and return ERROR_DISK_FULL, which allows at least Copy-VMFile to report a meaning full error. Signed-off-by: Olaf Hering

[PATCH RESEND 11/27] Drivers: hv: vss: run only on supported host versions

From: Olaf Hering The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and

[PATCH RESEND 06/27] Drivers: hv: utils: use memdup_user in hvt_op_write

From: Olaf Hering Use memdup_user to handle OOM. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_utils_transport.c |9

[PATCH RESEND 24/27] drivers/hv: correct tsc page sequence invalid value

From: Andrey Smetanin Hypervisor Top Level Functional Specification v3/4 says that TSC page sequence value = -1(0x) is used to indicate that TSC page no longer reliable source of reference timer. Unfortunately, we found that Windows Hyper-V guest side

[PATCH RESEND 25/27] Drivers: hv: vmbus: Force all channel messages to be delivered on CPU 0

Force all channel messages to be delivered on CPU0. These messages are not performance critical and are used during the setup and teardown of the channel. Signed-off-by: K. Y. Srinivasan --- drivers/hv/connection.c | 11 +++ 1 files changed, 7 insertions(+), 4

[PATCH RESEND 17/27] Drivers: hv: vmbus: do sanity check of channel state in vmbus_close_internal()

From: Dexuan Cui This fixes an incorrect assumption of channel state in the function. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 12 1 files changed, 12 insertions(+), 0

[PATCH RESEND 01/27] Drivers: hv: util: Increase the timeout for util services

Util services such as KVP and FCOPY need assistance from daemon's running in user space. Increase the timeout so we don't prematurely terminate the transaction in the kernel. Host sets up a 60 second timeout for all util driver transactions. The host will retry the transaction if it times out. Set

[PATCH 1/8] rtlwifi: rtl8723be: Fix module parameter initialization

This driver has a number of errors in the module initialization. These include the following: Parameter msi_support is stored in two places - one is removed. Paramters sw_crypto and disable_watchdog were never stored in the final locations, nor were they initialized properly. Signed-off-by:

[PATCH 8/8] rtlwifi: rtl8192cu: Add missing parameter setup

This driver fails to copy the module parameter for software encryption to the locations used by the main code. Signed-off-by: Larry Finger Cc: Stable --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 ++ 1 file changed, 2

[PATCH 6/8] rtlwifi: rtl8192se: Fix module parameter initialization

Two of the module parameter descriptions show incorrect default values. In addition the value for software encryption is not transferred to the locations used by the driver. Signed-off-by: Larry Finger Cc: Stable ---

[PATCH 3/8] rtlwifi: rtl8821ae: Fix errors in parameter initialization

This driver failed to copy parameters sw_crypto and disable_watchdog into the locations actually used by the driver. In addition, msi_support was initialized three times and one of them used the wrong variable. The initialization of parameter int_clear was moved so that it is near that of the rest

[PATCH 7/8] rtlwifi: rtl8192ce: Fix handling of module parameters

The module parameter for software encryption was never transferred to the location used by the driver. Signed-off-by: Larry Finger Cc: Stable --- drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++ 1 file changed, 2 insertions(+) diff

[no subject]

You have been picked up for a scam victim compensation payment. For details contact Mr. John Wale through this email: cc...@foxmail.com ___ devel mailing list de...@linuxdriverproject.org

  1   2   >