Re: [PATCH 00/13] staging: unisys: Remove POSTCODE macros

2016-11-30 Thread Greg KH
On Thu, Dec 01, 2016 at 01:31:02AM -0500, David Kershner wrote: > The s-Par firmware uses POSTCODE macros to get basic health of the > system even when we are not connected to the serial port or have > the ability to obtain the syslog. If you don't have access to a serial port, or a syslog, how

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Greg Kroah-Hartman
On Wed, Nov 30, 2016 at 01:15:50PM -0600, Alex Elder wrote: > On 11/30/2016 12:32 PM, Dan Carpenter wrote: > > On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: > >> Honestly, for a kernel newbie it is difficult to manage. I received 2 > >> email that suggest > >> to use S_IRUGO. My

[PATCH] Staging:rtl8712: Fixed coding style issue

2016-11-30 Thread Harsh Jain
From: Harsh Jain Fixes following checkpatch.pl warning Block comments should align the * on each line Signed-off-by: Harsh Jain --- drivers/staging/rtl8712/rtl8712_hal.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 10:48:32PM -0700, Jason Litzinger wrote: > > This is fine, but the fact that the most subsystem feels like it has to > > have its own attribute type is the big problem with this file, that > > should not be needed at all, and hopefully will be fixed up someday soon > >

[PATCH 11/13] staging: unisys: visorbus: Remove POSTCODE_SEVERITY levels

2016-11-30 Thread David Kershner
From: Bryan Thompson Use the already defined DIAG_SEVERITY values directly instead of special postcode macro names. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 07/13] staging: unisys: visorbus: Remove POSTCODE_LINUX_4 macro

2016-11-30 Thread David Kershner
From: Bryan Thompson Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_4. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c |

[PATCH 04/13] staging: unisys: visorbus: Use CURRENT_FILE_PC in base postcode macro

2016-11-30 Thread David Kershner
From: Bryan Thompson Use CURRENT_FILE_PC directly in the POSTCODE_LINUX macro instead of relying on passthrough macros to provide it. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 09/13] staging: unisys: visorbus: Remove unused values from guestlinuxdebug

2016-11-30 Thread David Kershner
From: Bryan Thompson Remove guestlinuxdebug enum values that are no longer being used and renumber remaining values accordingly. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 12/13] staging: unisys: visorbus: Remove two passthrough postcode macros

2016-11-30 Thread David Kershner
From: Bryan Thompson Remove two passthrough macros that are only called from a single location and make the resultant vmcall directly. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 10/13] staging: unisys: visorbus: Fix spelling error (FAIULRE to FAILURE)

2016-11-30 Thread David Kershner
From: Bryan Thompson There were two instances of FAILURE being misspelled in the s-Par firmware postcode event enum that are fixed. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 06/13] staging: unisys: visorbus: Remove POSTCODE_LINUX_3 macro

2016-11-30 Thread David Kershner
From: Bryan Thompson Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_3. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c |

[PATCH 03/13] staging: unisys: visorbus: Replace two base postcode macros with one

2016-11-30 Thread David Kershner
From: Bryan Thompson Leverage the 3 existing s-Par postcode macros to do a bit more work and provide only 1 base postcode macro. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 05/13] staging: unisys: visorbus: Remove POSTCODE_LINUX_2 macro

2016-11-30 Thread David Kershner
From: Bryan Thompson Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_2. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c |

[PATCH 13/13] staging: unisys: Create visorbus_log_postcode function

2016-11-30 Thread David Kershner
From: Bryan Thompson Replace the POSTCODE_LINUX macro used throughout visorbus with a visorbus function. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner ---

[PATCH 08/13] staging: unisys: visorbus: Update visorchipset postcode values

2016-11-30 Thread David Kershner
From: Bryan Thompson The visorchipset.c functionality was moved into the visorbus driver previously. This patch updates the s-Par firmware postcode values to reflect this status. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner

[PATCH 02/13] staging: unisys: visorbus: vbuschannel.h remove unused pound defines

2016-11-30 Thread David Kershner
From: Erik Arfvidson This patch removes all the unused pound defines currently in vbuschannel.h. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/vbuschannel.h | 11

[PATCH 00/13] staging: unisys: Remove POSTCODE macros

2016-11-30 Thread David Kershner
The s-Par firmware uses POSTCODE macros to get basic health of the system even when we are not connected to the serial port or have the ability to obtain the syslog. This patch series removes the unsightly postcode macros and creates a simple postcode function to log basic functionality of the

[PATCH 01/13] staging: unisys: visorbus: vmcallinterface.h remove unused pound defines

2016-11-30 Thread David Kershner
From: Erik Arfvidson This patch removes all the unused pound defines currently in vmcallinterface.h. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner ---

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-30 Thread Jason Litzinger
> This is fine, but the fact that the most subsystem feels like it has to > have its own attribute type is the big problem with this file, that > should not be needed at all, and hopefully will be fixed up someday soon > (i.e. it's a requirement before it can get out of staging...) Ok, couple

[PATCH] V4l: omap4iss: Clean up file handle in open() and release().

2016-11-30 Thread Shailendra Verma
Both functions initialize the file handle with v4l2_fh_init() and thus need to call clean up with v4l2_fh_exit() as appropriate. Signed-off-by: Shailendra Verma --- drivers/staging/media/omap4iss/iss_video.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-30 Thread Lino Sanfilippo
On 29.11.2016 18:14, Florian Fainelli wrote: > On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: >> The problem is that the HW does not provide a tx completion index. Instead >> we have to >> iterate the status descriptors until we get an invalid idx which indicates >> that there >> are no

[PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-)

RE: [PATCH] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

2016-11-30 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, November 30, 2016 9:55 AM > To: x...@kernel.org; de...@linuxdriverproject.org > Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; > Haiyang Zhang ;

Re: [PATCH] staging: wilc1000: fixed the wrong error code

2016-11-30 Thread Dan Carpenter
On Thu, Dec 01, 2016 at 12:58:45AM +0530, Atul Raj wrote: > ENOENT is error code for > ENOMEM should be used for > > Signed-off-by: Atul Raj > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH] staging: wilc1000: fixed the wrong error code

2016-11-30 Thread Atul Raj
ENOENT is error code for ENOMEM should be used for Signed-off-by: Atul Raj --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Alex Elder
On 11/30/2016 12:32 PM, Dan Carpenter wrote: > On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: >> Honestly, for a kernel newbie it is difficult to manage. I received 2 >> email that suggest >> to use S_IRUGO. My original patch was with octal, based on checkpatch.pl >> advice. Go

[PATCH 1/2] vmbus: add support for dynamic device id's

2016-11-30 Thread Stephen Hemminger
This patch adds sysfs interface to dynamically bind new UUID values to existing VMBus device. This is useful for generic UIO driver to act similar to uio_pci_generic. Signed-off-by: Stephen Hemminger --- v3 - use DRIVER_ATTR_WO drivers/hv/vmbus_drv.c | 174

[PATCH v3 0/2] Hyper-V UIO support

2016-11-30 Thread Stephen Hemminger
Patches to add UIO support to hyper-V vmbus in manner similar to existing pci-uio-generic Stephen Hemminger (2): vmbus: add support for dynamic device id's uio-hv-generic: new userspace i/o driver for VMBus MAINTAINERS | 1 + drivers/hv/connection.c | 1 +

[PATCH 2/2] uio-hv-generic: new userspace i/o driver for VMBus

2016-11-30 Thread Stephen Hemminger
This is a new driver to enable userspace networking on VMBus. It is based largely on the similar driver that already exists for PCI, and earlier work done by Brocade to support DPDK. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 1 +

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Dan Carpenter
On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: > Honestly, for a kernel newbie it is difficult to manage. I received 2 > email that suggest > to use S_IRUGO. My original patch was with octal, based on checkpatch.pl > advice. You've going to have to get used to conflicting

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-30 Thread Dan Carpenter
On Wed, Nov 30, 2016 at 06:04:14PM +0330, Saber Rezvani wrote: > @@ -1035,7 +1035,7 @@ static int s626_dio_set_irq(struct comedi_device *dev, > unsigned int chan) > return 0; > } > > -static int s626_dio_reset_irq(struct comedi_device *dev, unsigned int group, > +static int

[PATCH] hv: don't reset hv_context.tsc_page on crash

2016-11-30 Thread Vitaly Kuznetsov
It may happen that secondary CPUs are still alive and resetting hv_context.tsc_page will cause a consequent crash in read_hv_clock_tsc() as we don't check for it being not NULL there. It is safe as we're not freeing this page anyways. Signed-off-by: Vitaly Kuznetsov ---

[PATCH] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

2016-11-30 Thread Vitaly Kuznetsov
There is a feature in Hyper-V (Debug-VM --InjectNonMaskableInterrupt) which injects NMI to the guest. Prior to WS2016 the NMI is injected to all CPUs of the guest and WS2016 injects it to CPU0 only. When unknown_nmi_panic is enabled and we'd like to do kdump we need to perform some minimal cleanup

Re: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

2016-11-30 Thread Martin K. Petersen
> "Cathy" == Cathy Avery writes: Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array Cathy> requires. Also the buffer needs to be cleared or the upper bytes Cathy> will contain junk. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

2016-11-30 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: KY> Done. Thank you! -- Martin K. Petersen Oracle Linux Engineering ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Andrea Ghittino
On Wed, Nov 30, 2016 at 12:21 AM, Dan Carpenter wrote: > On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote: >> On 11/26/2016 03:50 PM, Andrea Ghittino wrote: >> > Fixes greybus user/groups permission style warnings >> > found by checkpatch.pl tool >> > >> >

[PATCH 2/3] staging: comedi: s626: use preferred kernel type u16

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u16' over 'uint16_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 96 +-- 1 file changed, 48 insertions(+), 48

[PATCH 3/3] staging: comedi: s626: use preferred kernel type u32

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 58 +-- 1 file changed, 29 insertions(+), 29

[PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 32 1 file changed, 16 insertions(+), 16

[PATCH 3/3] staging: comedi: s626: use preferred kernel type u32

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 58 +-- 1 file changed, 29 insertions(+), 29

[PATCH 2/3] staging: comedi: s626: use preferred kernel type u16

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u16' over 'uint16_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 96 +-- 1 file changed, 48 insertions(+), 48

[PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-30 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 32 1 file changed, 16 insertions(+), 16

[PATCH] staging: dgnc: remove sysfs files

2016-11-30 Thread Greg Kroah-Hartman
The dgnc driver has no business creating "custom" sysfs files just for a single tty driver. Combined with the odd way they are created, it's just a mess, so remove them entirely as I am tired of tripping over them when doing driver core changes. Cc: Lidza Louina Cc: Mark

Re: [PATCH 1/2] vmbus: add support for dynamic device id's

2016-11-30 Thread Greg Kroah-Hartman
On Mon, Nov 28, 2016 at 08:51:32AM -0800, Stephen Hemminger wrote: > +static DRIVER_ATTR(new_id, 0600, NULL, store_new_id); DRIVER_ATTR_RO()? > + > +/* > + * store_remove_id - remove a PCI device ID from this driver > + * > + * Removes a dynamic pci device ID to this driver. > + */ > +static

Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote: > Fixed checkpatch warning "line over 80 characters" in > wlan-ng/hfa384x_usb.c file. > > Signed-off-by: Yan Laijun > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1