From: Vitaly Kuznetsov
DoS protection conditions were altered in WS2016 and now it's easy to get
-EAGAIN returned from vmbus_post_msg() (e.g. when we try changing MTU on a
netvsc device in a loop). All vmbus_post_msg() callers don't retry the
operation and we usually end up
From: K. Y. Srinivasan
After the channel is rescinded, the host does not read from the rescinded
channel.
Fail writes to a channel that has already been rescinded. If we permit writes
on a
rescinded channel, since the host will not respond we will have situations where
we
From: Vitaly Kuznetsov
Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a
crash in percpu_channel_enq() when not all CPUs were online during
initialization and it naturally belongs there.
Signed-off-by: Vitaly Kuznetsov
From: Vitaly Kuznetsov
It may happen that not all CPUs are online when we do hv_synic_alloc() and
in case more CPUs come online later we may try accessing these allocated
structures.
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
From: Vitaly Kuznetsov
It may happen that secondary CPUs are still alive and resetting
hv_context.tsc_page will cause a consequent crash in read_hv_clock_tsc()
as we don't check for it being not NULL there. It is safe as we're not
freeing this page anyways.
Signed-off-by:
From: K. Y. Srinivasan
Some miscellaneous fixes.
K. Y. Srinivasan (1):
Drivers: hv: vmbus: Prevent sending data on a rescinded channel
Vitaly Kuznetsov (4):
Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg()
hv: allocate synic pages for all present CPUs
It looks like if the passed in parameter is not present, but
parameter length is non zero, then sanity checks on the length
are skipped and lstcon_test_add() might then use incorrect
allocation that's prone to integer overflow size.
This patch ensures that parameter len is zero if parameter is
Highlighted by relatively new checkpatch test, warnings like:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 6 +-
.../staging/lustre/lustre/include/lprocfs_status.h | 3 +-
These patches fix some more of the low hanging fruits
in the style problems highlighted by checkpatch.
Now only false positive ERRORs are left.
This also converts all bare unsigneds into unsigned ints
and a couple of spelling fixes.
Please consider.
Oleg Drokin (5):
staging/lustre/o2iblnd: Add
Highlighted by checkpatch:
WARNING: 'attemps' may be misspelled - perhaps 'attempts'?
#20278: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3272:
+ * reconnection attemps.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
Highlighted by checkpatch:
+ if (!ps->ps_net) /* intialized? */
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
checkpatch highlighted missing space before assignment
for lock variable.
+ spinlock_t *lock= _data.kib_connd_lock;
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
checkpatch highlighted there are 8 spaces that could be converted to a tab:
ERROR: code indent should use tabs where possible
+^I^I^I^I^I */$
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +-
1 file changed, 1 insertion(+),
On Tue, Dec 6, 2016 at 7:39 PM, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia
> ---
> Changes in v2:
> - Added driver name in the subject for better readability.
I have been having a lot of unexplainable crashes in osc_lru_shrink
lately that I could not see a good explanation for and then I found
this patch that slip under the radar somehow that incorrectly
converted while loop for lru list iteration into
list_for_each_entry_safe totally ignoring that in
Mein lieber Freund,
Ich mцchte mich erstmals gerne vorstellen. Mein Name ist Herr Morato Ortega
die persцnliche Investment Berater und Vermцgensverwalterin meines verstorbenen
Mandanten, der ihre familienname tragt. Er war als privater Geschдftsmann im
internationalen Bereich tдtig. Im Jahr
On Tue, Dec 06, 2016 at 02:10:13PM -0500, Oleg Drokin wrote:
>
> On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
>
> > On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> >> I see, indeed, it all makes sense now.
> >> So basically if we unconditionally check for the size to be > 0,
On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote:
> Can you point me to a driver with a better way to conditionally dump
> a debugging string to the logs?
People should look at using ftrace and kprobes. They really are very
powerful and useful.
regards,
dan carpenter
On Tue, Dec 06, 2016 at 02:10:13PM -0500, Oleg Drokin wrote:
>
> On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
>
> > On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> >> I see, indeed, it all makes sense now.
> >> So basically if we unconditionally check for the size to be > 0,
On 06.12.2016 17:30, David Miller wrote:
> From: Lino Sanfilippo
> Date: Mon, 5 Dec 2016 23:07:15 +0100
>
>> this is the forth version of the slicoss gigabit ethernet driver (which is a
>> rework of the driver from Alacritech which can currently be found under
>>
On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
> On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
>> I see, indeed, it all makes sense now.
>> So basically if we unconditionally check for the size to be > 0, we should be
>> fine then, I imagine.
>> On the other hand there's
On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> I see, indeed, it all makes sense now.
> So basically if we unconditionally check for the size to be > 0, we should be
> fine then, I imagine.
> On the other hand there's probably no se for no param and nonzero param len,
> so it's
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, December 06, 2016 11:56 AM
> To: Stuart Yoder
> Cc: Ruxandra Ioana Radulescu ;
> de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org;
Remove blank lines between open brace and comment.
Remove blank lines after comment in line with the rest of the comments
of the file.
Signed-off-by: Fernando Apesteguia
---
drivers/staging/dgnc/dgnc_tty.c | 6 --
1 file changed, 6 deletions(-)
diff --git
On Tue, Dec 06, 2016 at 12:59:59PM +, Stuart Yoder wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Tuesday, December 06, 2016 4:20 AM
> > To: Ruxandra Ioana Radulescu
> > Cc: de...@driverdev.osuosl.org;
For two cases (beginning and end of the patch) I opted to create small
functions instead of breaking the the lines in a weird way.
The other changes are simple ones: either by breaking the line when
appropriate or by turning a comment into a multi-line one.
Signed-off-by: Fernando Apesteguia
From: Greg KH
Date: Tue, 6 Dec 2016 17:40:39 +0100
> On Tue, Dec 06, 2016 at 11:30:04AM -0500, David Miller wrote:
>> From: Lino Sanfilippo
>> Date: Mon, 5 Dec 2016 23:07:15 +0100
>>
>> > this is the forth version of the slicoss gigabit
On Tue, Dec 06, 2016 at 11:30:04AM -0500, David Miller wrote:
> From: Lino Sanfilippo
> Date: Mon, 5 Dec 2016 23:07:15 +0100
>
> > this is the forth version of the slicoss gigabit ethernet driver (which is a
> > rework of the driver from Alacritech which can currently be
From: Lino Sanfilippo
Date: Mon, 5 Dec 2016 23:07:15 +0100
> this is the forth version of the slicoss gigabit ethernet driver (which is a
> rework of the driver from Alacritech which can currently be found under
> drivers/staging/slicoss). The driver is supposed to
On Tue, 6 Dec 2016 00:37:08 +
Long Li wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Monday, December 5, 2016 8:53 AM
> > To: Long Li
> > Cc: KY Srinivasan ;
On Dec 6, 2016, at 6:02 AM, Dan Carpenter wrote:
> On Mon, Dec 05, 2016 at 06:43:37PM -0500, Oleg Drokin wrote:
>>
>> On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
>>
>>> Hi Lustre Devs,
>>>
>>> The patch d7e09d0397e8: "staging: add Lustre file system client
>>> support" from May 2, 2013,
From: Haiyang Zhang
Date: Fri, 2 Dec 2016 15:55:38 -0800
> From: Haiyang Zhang
>
> We found network manager is necessary on RHEL to make the synthetic
> NIC, VF NIC bonding operations handled automatically. So, enabling
> network
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, December 6, 2016 2:54 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
>
On Tue, Dec 06, 2016 at 07:39:36PM +0530, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia
Acked-by: Johan Hovold
> ---
> Changes in v2:
> - Added driver name in the subject
All kmalloc-based functions print enough information on failure
Signed-off-by: Srikant Ritolia
---
Changes in v2:
- Added driver name in the subject for better readability.
drivers/staging/greybus/audio_module.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
On 12/05/2016 11:58 PM, Oleg Drokin wrote:
I guess it's a false positive?
Yes, probably.
Thank you for the explanation though, I don't fully understand all this yet,
I am still learning.
Sorry for the noise.
Quentin
___
devel mailing list
On Tue, Dec 06, 2016 at 10:12:56AM +0100, Greg KH wrote:
> On Sun, Dec 04, 2016 at 08:41:04PM +0100, Fernando Apesteguia wrote:
> > For the first lines of the patch, I opted to create a small function
> > instead of breaking the the line in a weird way.
> >
> > This is v2 of the patch with the
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, December 06, 2016 4:20 AM
> To: Ruxandra Ioana Radulescu
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de;
> a...@arndb.de; Alexandru
>
On Mon, Dec 05, 2016 at 06:43:37PM -0500, Oleg Drokin wrote:
>
> On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
>
> > Hi Lustre Devs,
> >
> > The patch d7e09d0397e8: "staging: add Lustre file system client
> > support" from May 2, 2013, leads to the following static checker
> > warning:
> >
On Tue, Dec 06, 2016 at 04:25:07PM +0530, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia
Please include the driver or component you are modifying in your subject
prefix (e.g. use "staging:
All kmalloc-based functions print enough information on failure
Signed-off-by: Srikant Ritolia
---
drivers/staging/greybus/audio_module.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/audio_module.c
On Sat, Dec 03, 2016 at 12:33:59PM -0800, k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> Fixes to handle CPU online/offline. Also included is a new uio
> driver for Hyper-V.
>
> V2: Updated commit logs (Greg KH)
> Re-implemented the API to
On Sat, Dec 03, 2016 at 12:34:42PM -0800, k...@exchange.microsoft.com wrote:
> From: Haiyang Zhang
>
> On Hyper-V, every VF interface has a corresponding synthetic
> interface managed by netvsc that share the same MAC
> address. netvsc registers for netdev events to
On 12/05/2016 10:52 PM, Dan Carpenter wrote:
> On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote:
>>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg)
>>> +{
>>> + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT);
>>
>> In other places in this
On Tue, Dec 06, 2016 at 10:06:25AM +, Ruxandra Ioana Radulescu wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Tuesday, December 06, 2016 11:58 AM
> > To: Ruxandra Ioana Radulescu
> > Cc:
On Mon, Dec 05, 2016 at 07:10:45PM -0500, Brian Masney wrote:
> On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote:
> > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote:
> > > Fixed warning found by make W=2 to reduce the amount of build noise:
> > >
> > > warning:
On 12/06/16 07:39, Greg Kroah-Hartman wrote:
> On Mon, Dec 05, 2016 at 08:01:35PM +, Guillaume Tucker wrote:
>> On 12/05/16 18:08, Greg Kroah-Hartman wrote:
>>> On Mon, Dec 05, 2016 at 05:34:15PM +, Guillaume Tucker wrote:
Convert ashmem_range related macros to inline functions to fix
On Sat, Dec 03, 2016 at 12:34:34PM -0800, k...@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov
>
> Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a
> crash in percpu_channel_enq() when not all CPUs were online during
> initialization and it
On Sat, Dec 03, 2016 at 12:34:33PM -0800, k...@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov
>
> It may happen that not all CPUs are online when we do hv_synic_alloc() and
> in case more CPUs come online later we may try accessing these allocated
> structures.
>
>
On Sat, Dec 03, 2016 at 12:34:31PM -0800, k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> Enhance the rescind callback functionality by permitting the passing of an
> opaque
> pointer. This functionality will be used by vmbus device drivers to implement
>
On Sat, Dec 03, 2016 at 12:34:28PM -0800, k...@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov
>
> DoS protection conditions were altered in WS2016 and now it's easy to get
> -EAGAIN returned from vmbus_post_msg() (e.g. when we try changing MTU on a
> netvsc device in
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, December 06, 2016 11:58 AM
> To: Ruxandra Ioana Radulescu
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;
> ag...@suse.de; a...@arndb.de; Alexandru
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
In most cases, usleep_range is better than udelay, as the precise wakeup
from udelay is unnecessary.
But, udelay does something different than usleep, are you sure you
should be giving up the cpu at this point in time?
Are you
On Fri, Dec 02, 2016 at 07:53:07PM -0500, James Simmons wrote:
> Batch of various fixes and clean ups missing in the upstream client.
> Only one smaller batch of patches left to sync lustre 2.8.0 version.
> These patches are independent of each other so they can be landed
> in any order.
I've
On Fri, Dec 02, 2016 at 07:53:21PM -0500, James Simmons wrote:
> From: Alexander Boyko
>
> Currently llog_process_or_fork() is hard coded to
> always pass the function pointer llog_cat_process_cb().
> Change llog_cat_process_or_fork() to pass in any
> function
On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote:
> Add a list of TODO items for the Ethernet driver
>
> Signed-off-by: Ioana Radulescu
> ---
> drivers/staging/fsl-dpaa2/ethernet/TODO |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
On Sat, Dec 03, 2016 at 08:47:28AM +, Parav Pandit wrote:
> Corrected label name from err_destory_routes to err_destroy_routes.
>
> Signed-off-by: Parav Pandit
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 8
> 1 file changed, 4 insertions(+), 4
On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote:
> From: Ben Evans
>
> Remove all obdo related functions from lustre_idl.h
> Create lustre_odbo.h. Include where appropriate.
> Make the functions lustre_get_wire_obdo and
> lustre_set_wire_obdo to not be inlined
Add the command build/parse APIs for operating on DPNI objects through
the DPAA2 Management Complex.
Signed-off-by: Ioana Radulescu
---
drivers/staging/Kconfig |2 +
drivers/staging/Makefile |1 +
Introduce the DPAA2 Ethernet driver, which manages Datapath
Network Interface (DPNI) objects discovered on the MC bus.
In addition to DPNIs, the Ethernet driver uses several other
MC objects to build a network interface abstraction: buffer
pools (DPBPs), I/O Portals (DPIOs) and concentrators
Add trace events in significant places of the data path.
Useful for debuggging.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/Makefile|3 +
.../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h | 185
Signed-off-by: Ioana Radulescu
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 312c582..da4a6fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5057,6 +5057,12 @@ S: Maintained
F:
Add custom statistics to be reported via ethtool -S. These include
driver specific per-cpu statistics as well as queue and channel
counters.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 42 -
This patchset introduces the Ethernet driver for Freescale / NXP SoCs
with DPAA2 (DataPath Acceleration Architecture v2). The driver manages
network objects discovered on the fsl-mc bus. A description of the
driver can be found in the associated README file.
The patchset consists of:
* A set of
Add support for several ethtool operations: show hardware statistics,
get/set link settings, get hash configuration.
Signed-off-by: Ioana Radulescu
Signed-off-by: Bogdan Hamciuc
---
drivers/staging/fsl-dpaa2/ethernet/Makefile|2 +-
Add a list of TODO items for the Ethernet driver
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/TODO |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO
diff --git
Add a README file describing the driver architecture, components
and I/O interface.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/README | 186 +
1 files changed, 186 insertions(+), 0 deletions(-)
create mode
On Fri, Dec 02, 2016 at 02:40:46PM -0500, James Simmons wrote:
> From: Ben Evans
>
> It was found if you sort the headers alphabetically
> that it reduced patch conflicts. This patch sorts
> the headers alphabetically and also place linux
> header first, then uapi header and
On Sun, Dec 04, 2016 at 02:59:13PM +, Manoj Sawai wrote:
> Rearranged comments so that lines are less than 80 characters long
>
> Signed-off-by: Manoj Sawai
> ---
> drivers/staging/ks7010/eap_packet.h | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Where
On Sat, Dec 03, 2016 at 12:26:06AM +0530, Atul Raj wrote:
> in case of memory failure -ENOMEM should be returned.
>
> Signed-off-by: Atul Raj
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch
On Fri, Dec 02, 2016 at 12:04:39AM +0530, SRIKANT RITOLIA wrote:
> Fix checkpatch.pl warnings:-
> Block comments should align the * on each line
>
> Signed-off-by: Srikant Ritolia
> ---
> drivers/staging/sm750fb/ddk750.h | 20 ++--
>
On Sun, Dec 04, 2016 at 08:41:04PM +0100, Fernando Apesteguia wrote:
> For the first lines of the patch, I opted to create a small function
> instead of breaking the the line in a weird way.
>
> This is v2 of the patch with the name of the function changed from
> v1
This goes below the --- line.
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
> In most cases, usleep_range is better than udelay, as the precise wakeup
> from udelay is unnecessary.
But, udelay does something different than usleep, are you sure you
should be giving up the cpu at this point in time?
Are you
On Thu, Dec 01, 2016 at 10:39:53PM +0100, Andrea Ghittino wrote:
> Fixes greybus "line over 80 characters" style warnings
> found by checkpatch.pl tool
>
> Signed-off-by: Andrea Ghittino
> ---
> changelog:
> v2) Review patch based on Vaibhav Hiremath review
> v3) Fixed email
In most cases, usleep_range is better than udelay, as the precise wakeup
from udelay is unnecessary.
usleep_range gives a much better chance of coalescing processor wakeups.
Signed-off-by: Shiva Kerdel
---
Changes for v2:
- Squashed the two commits to one patch.
75 matches
Mail list logo