Re: [PATCH 2/2] staging: mt7621-dts: Match pcie format to mt7623.dtsi

2018-06-06 Thread Rosen Penev
On Mon, Jun 4, 2018 at 3:25 PM, NeilBrown wrote: > On Mon, Jun 04 2018, Rosen Penev wrote: > >> This currently fixes the remaining dtb warnings: >> >> Node /pcie@1e14/pcie0 has a reg or ranges property, but no unit name >> Node /pcie@1e14/pcie1 has a reg or ranges property, but no unit

RE: [PATCH v4] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-06-06 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Wednesday, June 6, 2018 12:31 > ... > + int sysctl_record_panic_msg = 1; This variable can be static. -- Dexuan ___ devel mailing list de...@linuxdriverproject.org

RE: [PATCH] PCI: hv: Fix a __local_bh_enable_ip warning in hv_compose_msi_msg()

2018-06-06 Thread Dexuan Cui
> From: Haiyang Zhang > Sent: Friday, May 25, 2018 12:52 > To: Dexuan Cui ; Lorenzo Pieralisi > ; Bjorn Helgaas ; > linux-...@vger.kernel.org; KY Srinivasan ; Stephen > Hemminger ; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Cc: linux-ker...@vger.kernel.org;

[PATCH] staging: rtl8723bs: drop test

2018-06-06 Thread Julia Lawall
The test selects between two identical values, so it doesn't look useful. It turns out that the tested expression can only be true anyway, so drop the test, the corresponding parameter, and the corresponding argument at the only call site. The semantic match that finds this problem is as follows:

Re: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?

2018-06-06 Thread Luis R. Rodriguez
On Thu, Jun 07, 2018 at 12:41:12AM +0200, Ard Biesheuvel wrote: > On 7 June 2018 at 00:29, Luis R. Rodriguez wrote: > > Given no one is providing a clear answer, and we cannot easily describe the > > buffer at run time we'll just move forward with > > READING_FIRMWARE_DMA_COHERENT. > > I

Re: [PATCH] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-06-06 Thread Stephen Hemminger
On Wed, 6 Jun 2018 15:27:00 -0700 Yidong Ren wrote: > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters exist in current code. Exposing these > counters will help

RE: [PATCH] HV: Fix definition of struct hv_vp_assist_page.

2018-06-06 Thread KY Srinivasan
+Allen > -Original Message- > From: Thomas Gleixner > Sent: Wednesday, June 6, 2018 3:18 AM > To: Tianyu Lan > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; mi...@redhat.com; h...@zytor.com; > x...@kernel.org; vkuzn...@redhat.com; Alexander Grest > ;

Re: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?

2018-06-06 Thread Ard Biesheuvel
On 7 June 2018 at 00:29, Luis R. Rodriguez wrote: > On Wed, Jun 06, 2018 at 10:41:07PM +0200, Ard Biesheuvel wrote: >> On 6 June 2018 at 22:32, Luis R. Rodriguez wrote: >> > On Fri, Jun 01, 2018 at 09:23:46PM +0200, Luis R. Rodriguez wrote: >> >> On Tue, May 08, 2018 at 03:38:05PM +, Luis R.

Re: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?

2018-06-06 Thread Luis R. Rodriguez
On Wed, Jun 06, 2018 at 10:41:07PM +0200, Ard Biesheuvel wrote: > On 6 June 2018 at 22:32, Luis R. Rodriguez wrote: > > On Fri, Jun 01, 2018 at 09:23:46PM +0200, Luis R. Rodriguez wrote: > >> On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > >> > On Fri, May 04, 2018 at

[PATCH] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-06-06 Thread Yidong Ren
From: Yidong Ren This patch implements following ethtool stats fields for netvsc: cpu_tx/rx_packets/bytes cpu_vf_tx/rx_packets/bytes Corresponding per-cpu counters exist in current code. Exposing these counters will help troubleshooting performance issues. Signed-off-by: Yidong Ren ---

[PATCH 5/5] staging: mt7621-dts: convert to gpio-keys

2018-06-06 Thread NeilBrown
Now that gpio-interrupts work correctly, we can use gpio-keys instead of gpio-keys-polled for the single push-button on the gbpc-1. Signed-off-by: NeilBrown --- drivers/staging/mt7621-dts/gbpc1.dts |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 4/5] staging: mt7621-dts: correct various clock frequencies.

2018-06-06 Thread NeilBrown
The MT7621 documentation says that the sys clock - also known as OCP clock for the Open Core Protocol - can be configured to 1/3 or 1/4 of the CPU clock. Testing on my hardware, using the fact that the SPI clock is based on the OCP clock and measuring transfer rates, shows a clock of a little over

[PATCH 2/5] staging: mt7621-spi: change mt7621_spi_wait_till_ready to take struct mt7621_spi

2018-06-06 Thread NeilBrown
All callers have a 'struct mt7621_spi' and that is all mt7621_spi_wait_till_ready() needs. So just pass it instead of the spi_device. Signed-off-by: NeilBrown --- drivers/staging/mt7621-spi/spi-mt7621.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH 3/5] staging: mt7621-spi: revised half-duplex message handling

2018-06-06 Thread NeilBrown
The mt7621 SPI engine has a 32 byte buffer and the driver currently only allows 32-byte read requests and 36 bytes writes (there is a 4byte op/addr buffer). This is an unnecessary limitation. As the SPI clock is controlled by the host it is quite acceptable to send a larger message in multiple

[PATCH 1/5] staging: mt7621-pci: use rt_sysc_?32() to access system-control register.

2018-06-06 Thread NeilBrown
This driver currently has internal knowledge ofthe address of system-control registers and accesses them by dereferencing a constant pointer. It is cleaner to use rt_sysc_r32(), rt_sysc_w32(), rt_sysc_m32() which is a more standard interface. So change the defined names to offsets instead of

[PATCH 0/5] staging: mt7621 improvements, particularly SPI

2018-06-06 Thread NeilBrown
The highlight here is a substantial rewrite of the mt7621 SPI driver so that it makes sensible use of the hardware. The hardware is quite capable of transceiving large messages, it just needs to handle them 32 bytes at a time. This is more efficient than requiring upper levels to only send 32byte

RE: [PATCH] hv_netvsc: Fix a network regression after ifdown/ifup

2018-06-06 Thread Dexuan Cui
> From: Stephen Hemminger > Sent: Wednesday, June 6, 2018 14:07 > ... > Ok, just skip the check and big comment. > wake all queues is harmless if they are already awake. Ok, I'll post a v2 without the check and the comment shortly. -- Dexuan ___ devel

[PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup

2018-06-06 Thread Dexuan Cui
Recently people reported the NIC stops working after "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not enabled, after the refactoring of the common detach logic: when the NIC has sub-channels, usually we enable all the TX queues after all sub-channels are set up: see

[PATCH] hv_netvsc: Fix a network regression after ifdown/ifup

2018-06-06 Thread Dexuan Cui
Recently people reported the NIC stops working after "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not enabled, after the refactoring of the common detach logic. The patch fixes the regression. Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic") Signed-off-by: Dexuan

Re: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?

2018-06-06 Thread Ard Biesheuvel
On 6 June 2018 at 22:32, Luis R. Rodriguez wrote: > On Fri, Jun 01, 2018 at 09:23:46PM +0200, Luis R. Rodriguez wrote: >> On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: >> > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: >> > > >> > > I think the Qualcomm

Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?

2018-06-06 Thread Luis R. Rodriguez
On Fri, Jun 01, 2018 at 09:23:46PM +0200, Luis R. Rodriguez wrote: > On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > > > > > > I think the Qualcomm folks owning this (Andy, David, Bjorn, already > > > cc'd

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Justin Skists
On Wed, Jun 06, 2018 at 03:26:28PM +0200, Samuel Thibault wrote: > Hello, > > Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > > The synths[] array is a collection of synths acting like a list. > > There is no need for synths to be an array, so refactor synths[] to use > > standard

[PATCH v4] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-06-06 Thread Sunil Muthuswamy
In the VM mode on Hyper-V, currently, when the kernel panics, an error code and few register values are populated in an MSR and the Hypervisor notified. This information is collected on the host. The amount of information currently collected is found to be limited and not very actionable. To

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Samuel Thibault
Hello, Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > The synths[] array is a collection of synths acting like a list. > There is no need for synths to be an array, so refactor synths[] to use > standard kernel list_head API, instead, and modify the usages to suit. > As a

Re: [PATCH] android: binder: Drop dependency on !M68K

2018-06-06 Thread Greg Kroah-Hartman
On Wed, Jun 06, 2018 at 02:40:56PM +0200, Geert Uytterhoeven wrote: > As of commit 7124330dabe5b3cb ("m68k/uaccess: Revive 64-bit > get_user()"), the 64-bit Android binder interface builds fine on m68k. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/android/Kconfig | 2 +- > 1 file

RE: [PATCH] hv_netvsc: add per-cpu ethtool stats for netvsc

2018-06-06 Thread Yidong Ren
Thank you, Greg. I'm sorry for didn't read the guidelines on kernel newbies. Please ignore this patch. Thanks, Yidong -Original Message- From: Greg KH Sent: Wednesday, June 6, 2018 1:34 AM To: Yidong Ren Cc: driverdev-devel@linuxdriverproject.org; Haiyang Zhang ; Stephen Hemminger

[PATCH] android: binder: Drop dependency on !M68K

2018-06-06 Thread Geert Uytterhoeven
As of commit 7124330dabe5b3cb ("m68k/uaccess: Revive 64-bit get_user()"), the 64-bit Android binder interface builds fine on m68k. Signed-off-by: Geert Uytterhoeven --- drivers/android/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/Kconfig

Re: staging: rtl8192e: Series of coding style changes

2018-06-06 Thread Justin Skists
> On 06 June 2018 at 12:39 John Whitmore wrote: > Again these are just some simple coding style changes to the file, so nothing > of importance. If it keeps grumpy maintainers happy, then it's of great importance! :-) Justin ___ devel mailing list

[PATCH v6 7/8] staging: rtl8192e: Optimise Comparison to NULL tests - Coding Style

2018-06-06 Thread John Whitmore
Change comparison to NULL to better adhere to coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH v6 6/8] staging: rtl8192e: Correct declaration of HTResetIOTSetting - Coding Style

2018-06-06 Thread John Whitmore
Declaration of function was spread over three lines. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

2018-06-06 Thread John Whitmore
Remove unneccessary parentheses - Coding Style change Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

staging: rtl8192e: Series of coding style changes

2018-06-06 Thread John Whitmore
Version 6 : Sorry to send this out again but version 5 contained a little less verbosity then required. Again these are just some simple coding style changes to the file, so nothing of importance. ___ devel mailing list de...@linuxdriverproject.org

[PATCH v6 5/8] staging: rtl8192e: Remove unrequired space at start of line - Coding Style

2018-06-06 Thread John Whitmore
Function HTIOTActIsDisableMCS14 contained spurious space at start of line. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH v6 3/8] staging: rtl8192e: Remove unnecessary return statements - Coding style

2018-06-06 Thread John Whitmore
Return statments from void functions are not required by the coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH v6 2/8] staging: rtl8192e: Addition of prefered spacing - Coding style

2018-06-06 Thread John Whitmore
Added spaces around various operators, as preferred by coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH v6 1/8] staging: rtl8192e: Add and remove blank lines - Coding style

2018-06-06 Thread John Whitmore
Simple addition & removal of blank lines as required Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +-- 1 file changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

Re: [PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

2018-06-06 Thread Greg KH
On Wed, Jun 06, 2018 at 11:25:14AM +0100, John Whitmore wrote: > On Sun, Jun 03, 2018 at 02:28:35PM +0200, Greg KH wrote: > > On Sun, Jun 03, 2018 at 01:04:13PM +0100, John Whitmore wrote: > > > Signed-off-by: John Whitmore > > > --- > > > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12

Re: [PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

2018-06-06 Thread John Whitmore
On Sun, Jun 03, 2018 at 02:28:35PM +0200, Greg KH wrote: > On Sun, Jun 03, 2018 at 01:04:13PM +0100, John Whitmore wrote: > > Signed-off-by: John Whitmore > > --- > > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > I

Re: [PATCH] HV: Fix definition of struct hv_vp_assist_page.

2018-06-06 Thread Thomas Gleixner
On Mon, 21 May 2018, Tianyu Lan wrote: KY > The struct hv_vp_assist_page was defined incorrectly. > The "vtl_control" should be u64[3], "nested_enlightenments_control" > should be a u64 and there is 7 reserved bytes following "enlighten_vmentry". > This patch is to fix it. > >

Re: [PATCH] hv_netvsc: add per-cpu ethtool stats for netvsc

2018-06-06 Thread Greg KH
On Tue, Jun 05, 2018 at 08:14:06PM +, Yidong Ren wrote: > This patch implements following ethtool stats fields for netvsc: > cpu_rx_packets > cpu_tx_packets > cpu_rx_bytes > cpu_tx_bytes > cpu_vf_rx_packets > cpu_vf_tx_packets > cpu_vf_rx_bytes > cpu_vf_tx_bytes > --- No signed-off-by line?

[PATCH][next] staging: vc04_services: make a couple of pointers static

2018-06-06 Thread Colin King
From: Colin Ian King The pointers vchiq_dbg_dir and vchiq_dbg_clients are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: warning: symbol 'vchiq_dbg_dir' was not declared. Should it be static? warning: symbol 'vchiq_dbg_clients' was not