[PATCH v3 09/13] staging: comedi: tio: implement global tio/ctr routing

2018-10-01 Thread Spencer E. Olson
Adds ability to use device-global names in command args, in particular cmd->start_arg (for NI_CtrArmStartTrigger), and cmd->scan_begin_arg or cmd->convert_arg (either is used to specify NI_CtrGate, with preference given to cmd->scan_begin_arg, if it is set). The actual arguments of cmd->start_arg

[PATCH v3 12/13] staging: comedi: ni_660x: clean up pfi routing

2018-10-01 Thread Spencer E. Olson
Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH v3 03/13] staging: comedi: add new device-global config interface

2018-10-01 Thread Spencer E. Olson
Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH v3 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

2018-10-01 Thread Spencer E. Olson
Implement device-global config interface for ni_mio devices. In particular, this patch implements: INSN_DEVICE_CONFIG_TEST_ROUTE, INSN_DEVICE_CONFIG_CONNECT_ROUTE, INSN_DEVICE_CONFIG_DISCONNECT_ROUTE, INSN_DEVICE_CONFIG_GET_ROUTES for the ni mio devices. This means that the new abstracted

[PATCH v3 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

2018-10-01 Thread Spencer E. Olson
Use new signal routing capability for all comedi command *_src == TRIG_EXT options. This new interface allows the user specify signals and terminals as TRIG_EXT sources using a very consistent naming convention. Furthermore, the interface allows backwards compatibility to prior behavior of

[PATCH v3 10/13] staging: comedi: ni_mio_common: create device-global access to tio

2018-10-01 Thread Spencer E. Olson
Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH v3 05/13] staging: comedi: add interface to ni routing table information

2018-10-01 Thread Spencer E. Olson
Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Patch revisions: - [PATCH v3 05/13]: Simplify and clean up prototypes of functions for use with besearch. - [PATCH v2 05/13]: Tweak

[PATCH v3 13/13] staging: comedi: ni_660x: add device-global routing

2018-10-01 Thread Spencer E. Olson
Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH v3 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

2018-10-01 Thread Spencer E. Olson
Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH v3 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

2018-10-01 Thread Spencer E. Olson
Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v3 00/13] device-global identifiers and routes introduced

2018-10-01 Thread Spencer E. Olson
This patch set is the second revision of a recent patch set of the same name. Changes and notes: - [PATCH v3 04/13]: Minor update in indentation for support tool. - [PATCH v3 05/13]: Simplify and clean up prototypes of functions for use with besearch. - [PATCH v2 02/13]: Update

[PATCH v3 02/13] staging: comedi: add abstracted NI signal/terminal named constants

2018-10-01 Thread Spencer E. Olson
This change adds abstracted constants for National Instruments terminal/signal names. Some background: There have been significant confusions over the past many years for users when trying to understand how to connect to/from signals and terminals on NI hardware using comedi. The major

[PATCH v3 01/13] staging: comedi: tests: add unittest framework for comedi

2018-10-01 Thread Spencer E. Olson
Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Mon, Oct 1, 2018 at 11:14 PM Hans de Goede wrote: > > Hi, > > On 01-10-18 18:52, Daniel Vetter wrote: > > On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 01-10-18 09:53, Daniel Vetter wrote: > >>> On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 18:52, Daniel Vetter wrote: On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: Hi, On 01-10-18 09:53, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: Atomic modesetting does not use the traditional dpms call backs, instead we

Family Investment Project

2018-10-01 Thread Morka Family
Good Day FAMILY INHERITANCE INVESTMENT FUND With due respect, trust and humility, I write to you this proposal, which I believe, it would be of a great interest to you. I found your email address from email directory during the time we are searching for a reliable and

[PATCH 2/2] staging: iio: cdc: ad7150: fix misaligned lines

2018-10-01 Thread Slawomir Stepien
These lines were misaligned, but the checkpatch.pl didn't indicate them as such. Signed-off-by: Slawomir Stepien --- drivers/staging/iio/cdc/ad7150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index

[PATCH 1/2] staging: iio: cdc: ad7150: use pointer to shorten the line length

2018-10-01 Thread Slawomir Stepien
By using the pointer to channel attribute, we can now make the lines short enough to eliminate the checkpatch.pl problem: CHECK: Alignment should match open parenthesis Signed-off-by: Slawomir Stepien --- drivers/staging/iio/cdc/ad7150.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 0/2] Fix style problems in ad7150 driver

2018-10-01 Thread Slawomir Stepien
This series will fix simple style problem inside the ad7150 driver. Slawomir Stepien (2): staging: iio: cdc: ad7150: use pointer to shorten the line length staging: iio: cdc: ad7150: fix misaligned lines drivers/staging/iio/cdc/ad7150.c | 9 + 1 file changed, 5 insertions(+), 4

Re: [PATCH v2 05/13] staging: comedi: add interface to ni routing table information

2018-10-01 Thread Spencer Olson
On Mon, Oct 1, 2018 at 5:17 AM Ian Abbott wrote: > > On 27/09/18 20:27, Spencer E. Olson wrote: > > Adds interface and associated unittests for accessing/looking-up/validating > > the new ni routing table information. > > > > Signed-off-by: Spencer E. Olson > > --- > > > > Changes since last

Re: [PATCH v2 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-10-01 Thread Spencer Olson
On Mon, Oct 1, 2018 at 5:17 AM Ian Abbott wrote: > > On 27/09/18 20:27, Spencer E. Olson wrote: > > See README for a thorough discussion of this content. > > > > Adds tables of all register values for routing various signals to various > > terminals on National Instruments hardware. This

Re: [PATCH v3] staging: dgnc: Fix Kconfig help header and text

2018-10-01 Thread Mark Hounschell
On 10/1/18 12:49 PM, Lidza Louina wrote: On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell > wrote: On 9/28/18 3:59 PM, Lidza Louina wrote: > I haven't done work on this driver in a long time. I looked up the > devices, and they seem to already have an

Re: [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-01 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 11:17:57AM +0200, Hans de Goede wrote: > Hi, > > On 01-10-18 09:51, Daniel Vetter wrote: > > On Wed, Sep 26, 2018 at 09:41:51PM +0200, Hans de Goede wrote: > > > Hi All, > > > > > > This series converts the vboxvideo driver to the modesetting API, once > > > this > > >

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 11:37:29AM +0200, Hans de Goede wrote: > Hi, > > On 01-10-18 09:53, Daniel Vetter wrote: > > On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: > > > Atomic modesetting does not use the traditional dpms call backs, instead > > > we should check

Re: [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-10-01 Thread Dave Hansen
> How should a policy in user space look like when new memory gets added > - on s390x? Not onlining paravirtualized memory is very wrong. Because we're going to balloon it away in a moment anyway? We have auto-onlining. Why isn't that being used on s390? > So the type of memory is very

Re: [PATCH V3 2/13] KVM/MMU: Add tlb flush with range helper function

2018-10-01 Thread Paolo Bonzini
On 27/09/2018 05:48, Tianyu Lan wrote: > + > + if (range && kvm_x86_ops->tlb_remote_flush_with_range) { > + /* > + * Read tlbs_dirty before flushing tlbs in order > + * to track dirty tlbs during flushing. > + */ > + long

Re: [PATCH V3 4/13] KVM/MMU: Flush tlb directly in the kvm_handle_hva_range()

2018-10-01 Thread Paolo Bonzini
On 27/09/2018 05:49, Tianyu Lan wrote: > This patch is to flush tlb directly in the kvm_handle_hva_range() > when range flush is available. > > Signed-off-by: Lan Tianyu > --- > arch/x86/kvm/mmu.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/kvm/mmu.c

[PATCH v5 3/3] staging: mt7621-mmc: Remove unused single statement macros

2018-10-01 Thread Nishad Kamdar
This patch removes unused single statement macros in sd.c Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/sd.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index

[PATCH v5 2/3] staging: mt7621-mmc: Remove single statement macro msdc_irq_restore()

2018-10-01 Thread Nishad Kamdar
This patch removes the macro msdc_irq_restore() and replaces its usage with call to the function called in the macro definition. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/sd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v5 1/3] staging: mt7621-mmc: Remove #if 0 blocks

2018-10-01 Thread Nishad Kamdar
This patch removes #if 0 code blocks and usages of functions defined in the #if 0 blocks. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.c | 21 +-- drivers/staging/mt7621-mmc/dbg.h | 14 -- drivers/staging/mt7621-mmc/sd.c | 269 --- 3 files

[PATCH v5 0/3] Remove #if 0 blocks and fix macros

2018-10-01 Thread Nishad Kamdar
This patchset removes #if 0 blocks and removes single statement macros. Changes in v5: - Split the patch in three different patches. - The first patch removes #if 0 blocks. - The second one removes msdc_irq_restore() macro. - The third one removes other unused macros. Changes in v4: -

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Jonathan Cameron
On Mon, 1 Oct 2018 16:35:33 +0300 Dan Carpenter wrote: > On Mon, Oct 01, 2018 at 02:54:55PM +0200, Lars-Peter Clausen wrote: > > On 10/01/2018 02:52 PM, Dan Carpenter wrote: > > > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > > >> The checkpatch.pl tool detected coding

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Dan Carpenter
On Mon, Oct 01, 2018 at 02:54:55PM +0200, Lars-Peter Clausen wrote: > On 10/01/2018 02:52 PM, Dan Carpenter wrote: > > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > >> The checkpatch.pl tool detected coding style problem: > >> > >> CHECK: spaces preferred around that '-'

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Lars-Peter Clausen
On 10/01/2018 02:52 PM, Dan Carpenter wrote: > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: >> The checkpatch.pl tool detected coding style problem: >> >> CHECK: spaces preferred around that '-' (ctx:VxV) >> >> in two files inside the adc directory. This patch will remove

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Slawomir Stepien
On paź 01, 2018 14:51, Peter Meerwald-Stadler wrote: > > > The checkpatch.pl tool detected coding style problem: > > > > CHECK: spaces preferred around that '-' (ctx:VxV) > > oh no, not again > please see e.g. https://lore.kernel.org/patchwork/patch/635994/ > for some discussion why this

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Peter Meerwald-Stadler
> The checkpatch.pl tool detected coding style problem: > > CHECK: spaces preferred around that '-' (ctx:VxV) oh no, not again please see e.g. https://lore.kernel.org/patchwork/patch/635994/ for some discussion why this patch doesn't make sense > in two files inside the adc directory.

Re: [PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Dan Carpenter
On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > The checkpatch.pl tool detected coding style problem: > > CHECK: spaces preferred around that '-' (ctx:VxV) > > in two files inside the adc directory. This patch will remove this > problem. > > Signed-off-by: Slawomir

[PATCH] staging: iio: adc: add missing spaces around minus sign

2018-10-01 Thread Slawomir Stepien
The checkpatch.pl tool detected coding style problem: CHECK: spaces preferred around that '-' (ctx:VxV) in two files inside the adc directory. This patch will remove this problem. Signed-off-by: Slawomir Stepien --- drivers/staging/iio/adc/ad7192.c | 2 +-

Re: [PATCH v3] staging: dgnc: Fix Kconfig help header and text

2018-10-01 Thread Mark Hounschell
On 9/28/18 3:59 PM, Lidza Louina wrote: I haven't done work on this driver in a long time. I looked up the devices, and they seem to already have an existing Linux driver: https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and

Re: [PATCH v2 00/13] device-global identifiers and routes introduced

2018-10-01 Thread Ian Abbott
On 27/09/18 20:27, Spencer E. Olson wrote: This patch set is the second revision of a recent patch set of the same name. Changes and notes: - [PATCH v2 02/13]: Update signal/terminal names found after adding additional devices to routing list in [PATCH v2 04/13]. - [PATCH v2 04/13]:

Re: [PATCH v2 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-10-01 Thread Ian Abbott
On 27/09/18 20:27, Spencer E. Olson wrote: See README for a thorough discussion of this content. Adds tables of all register values for routing various signals to various terminals on National Instruments hardware. This information is directly compared to and taken from register-level

Re: [PATCH v2 05/13] staging: comedi: add interface to ni routing table information

2018-10-01 Thread Ian Abbott
On 27/09/18 20:27, Spencer E. Olson wrote: Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Changes since last submission: - [PATCH v2 05/13]: Tweak Makefile to build routing info for newly

Re: [PATCH v3] Staging: media: replace deprecated probe method

2018-10-01 Thread Dan Carpenter
Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] Staging: media: replace deprecated probe method

2018-10-01 Thread Andrey Abramov
Replaced i2c_driver::probe with i2c_driver::probe_new, because documentation says that probe method is "soon to be deprecated". Signed-off-by: Andrey Abramov --- v3: fix commit message drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [PATCH] Staging: media: replaced deprecated probe method

2018-10-01 Thread Dan Carpenter
On Mon, Oct 01, 2018 at 12:42:29PM +0300, Andrey Abramov wrote: > Replaced i2c_driver::probe with i2c_driver::probe_new, > because documentation says that probe method is "soon to be deprecated". > And fixed problems of the previous attempt. I'm sorry to complain again... Please, don't

[PATCH] Staging: media: replaced deprecated probe method

2018-10-01 Thread Andrey Abramov
Replaced i2c_driver::probe with i2c_driver::probe_new, because documentation says that probe method is "soon to be deprecated". And fixed problems of the previous attempt. Signed-off-by: Andrey Abramov --- drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++--- 1 file changed, 2

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 09:53, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: Atomic modesetting does not use the traditional dpms call backs, instead we should check crtc_state->active. Signed-off-by: Hans de Goede Are you sure this does what you want it to

Re: [PATCH] gpiolib: Fix incorrect use of find_next_zero_bit()

2018-10-01 Thread Linus Walleij
On Sat, Sep 29, 2018 at 2:19 PM Janusz Krzysztofik wrote: > Commit b17566a6b08b ("gpiolib: Implement fast processing path in > get/set array"), already fixed to some extent with commit 5d581d7e8cdc > ("gpiolib: Fix missing updates of bitmap index"), introduced a new mode > of processing bitmaps

Re: [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-10-01 Thread David Hildenbrand
On 01/10/2018 10:40, Michal Hocko wrote: > On Fri 28-09-18 17:03:57, David Hildenbrand wrote: > [...] > > I haven't read the patch itself but I just wanted to note one thing > about this part > >> For paravirtualized devices it is relevant that memory is onlined as >> quickly as possible after

Re: [PATCH resend 00/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 09:25, Dan Carpenter wrote: Why are you resending this? It's because you added some more patches on the end? Just send those as a new series... I accidentally numbered the cover-letter of the original series 01/15 instea dof 00/15 this confused Greg, so he asked for a

Re: [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 09:51, Daniel Vetter wrote: On Wed, Sep 26, 2018 at 09:41:51PM +0200, Hans de Goede wrote: Hi All, This series converts the vboxvideo driver to the modesetting API, once this is merged I will submit a patch to move the driver out of staging and into drivers/gpu/drm. This

Re: [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-10-01 Thread David Hildenbrand
On 28/09/2018 19:02, Dave Hansen wrote: > It's really nice if these kinds of things are broken up. First, replace > the old want_memblock parameter, then add the parameter to the > __add_page() calls. Definitely, once we agree that is is not nuts, I will split it up for the next version :) >

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

2018-10-01 Thread Pkshih
On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > >> The following: > >>  bool efuse_re_pg_sec1flag; > >>  u8 efuse_re_pg_data[8]; > >> are not referenced anywhere in the rtlwifi code. > >>  > >> Signed-off-by:

Re: [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes

2018-10-01 Thread Ajay Singh
Hi Dan, On Mon, 1 Oct 2018 10:47:34 +0300 Dan Carpenter wrote: > On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote: > > This patch series contains changes to avoid the use of static > > variables. Cleanup changes to fix some checkpatch issues and return > > void for function if their

Re: [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-10-01 Thread Michal Hocko
On Fri 28-09-18 17:03:57, David Hildenbrand wrote: [...] I haven't read the patch itself but I just wanted to note one thing about this part > For paravirtualized devices it is relevant that memory is onlined as > quickly as possible after adding - and that it is added to the NORMAL > zone.

Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-10-01 Thread Daniel Vetter
On Wed, Sep 26, 2018 at 09:42:02PM +0200, Hans de Goede wrote: > Atomic modesetting does not use the traditional dpms call backs, instead > we should check crtc_state->active. > > Signed-off-by: Hans de Goede Are you sure this does what you want it to do? Atomic helpers fully shut down the

Re: [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-01 Thread Daniel Vetter
On Wed, Sep 26, 2018 at 09:41:51PM +0200, Hans de Goede wrote: > Hi All, > > This series converts the vboxvideo driver to the modesetting API, once this > is merged I will submit a patch to move the driver out of staging and into > drivers/gpu/drm. > > This series consists of 3 parts: > > 1)

Re: [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes

2018-10-01 Thread Dan Carpenter
On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote: > This patch series contains changes to avoid the use of static variables. > Cleanup changes to fix some checkpatch issues and return void for > function if their return value is not used. > Also deleted 'wilc_debugfs.c' file as it's not

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

2018-10-01 Thread Joe Perches
On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > The following: > bool efuse_re_pg_sec1flag; > u8 efuse_re_pg_data[8]; > are not referenced anywhere in the rtlwifi code. > > Signed-off-by: Rick Veens > --- > drivers/staging/rtlwifi/wifi.h | 4 Presumably the equivalent uses in

Re: [PATCH resend 00/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-01 Thread Dan Carpenter
Why are you resending this? It's because you added some more patches on the end? Just send those as a new series... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rtlwifi: coding style fixes

2018-10-01 Thread Dan Carpenter
On Sat, Sep 29, 2018 at 02:36:09AM -0700, Greg KH wrote: > > --- a/drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c > > +++ b/drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c > > @@ -292,7 +292,7 @@ static void halbtc_leave_lps(struct btc_coexist > > *btcoexist) > > > > if (ap_enable) { >

Re: [PATCH 4/4] Staging: rts5208: sd: Fixed multiple coding style issues Fixed multiple braces issues

2018-10-01 Thread Dan Carpenter
Don't just add a 4/4 after a 3/3. Send it as a new series instead. Also the patch discription and sign off are missing. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 1/2] Staging: rts5208: rtsx_card: Fixed multiple coding style issues

2018-10-01 Thread Dan Carpenter
On Sat, Sep 29, 2018 at 12:44:31AM -0400, Maxime Desroches wrote: > Fixed multiple coding style issues > Too vague. Also inaccurate. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 2/2] Staging: rts5208: rtsx_chip: Fixed multiple coding style issues

2018-10-01 Thread Dan Carpenter
You can't have two patches with the same subject. On Sat, Sep 29, 2018 at 12:43:54AM -0400, Maxime Desroches wrote: > Fixed multiple braces issues > Signed-off-by: Maxime Desroches Put a blank line between the patch description and the Signed-off-by regards, dan careptner

Re: [PATCH] Staging: media: replaced deprecated probe method

2018-10-01 Thread Dan Carpenter
On Sat, Sep 29, 2018 at 09:51:50PM +0300, Andrey Abramov wrote: > drivers/staging/media/bcm2048/radio-bcm2048.c replaced i2c_driver::probe with > i2c_driver::probe_new, because documentation says that i2c_driver::probe > "soon to be deprecated" > This needs to be line wrapped at 72 characters.

Re: [PATCH] gpiolib: Fix incorrect use of find_next_zero_bit()

2018-10-01 Thread Marek Szyprowski
Hi Janusz, On 2018-09-29 14:20, Janusz Krzysztofik wrote: > Commit b17566a6b08b ("gpiolib: Implement fast processing path in > get/set array"), already fixed to some extent with commit 5d581d7e8cdc > ("gpiolib: Fix missing updates of bitmap index"), introduced a new mode > of processing bitmaps