Hi Sergio,
On 25/6/19 10:47 pm, Sergio Paracuellos wrote:
On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos
wrote:
On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote:
On 23/6/19 3:58 pm, Sergio Paracuellos wrote:
On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote:
On Fri, Jun 21, 2019
From: Yue Hu
We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.
From: Yue Hu
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu
---
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c
Hi Steffen,
On Tue, Jun 25, 2019 at 12:51:04PM +0200, Steffen Maier wrote:
> Hi Ming,
>
> I don't mind doing this change for zfcp. However, I'm having doubts
> regarding the rationale in the commit description. If I understood your
> patch series correctly from its cover letter (would have been
pHalData is not being used in halbtcoutsrc_LeaveLowPower. So remove the
same.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
fix below issues reported by checkpatch
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Dear winner,
Your email address has won you One Million Euro, from Online Lotto, all the
E-mail addresses were selected from a data base of internet e-mail users,
from which your e-mail address came out as the winning coupon.
Winning expiring date 31st of July , 2019. Contact our fiduciary
Dear Friend
I am sorry to encroach into your privacy in this manner my name is Morgan
Johnson an American soldier serving in Afghanistan my reason for contacting you
is that i would want to confide in you that i have in my possession the sum of
$4,980,000.00USD (Four million Nine hundred and
On Tue, Jun 25, 2019 at 10:41:29AM +0200, Simon Sandström wrote:
> Fixes checkpatch "CHECK: Unnecessary parentheses around '...'".
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Mon, Jun 24, 2019 at 11:46:39AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a
> way,
> that the actual comment starts on the second line of the commented portion.
> E.g:
You sent 2 patches that did different things, yet have
On Mon, 2019-06-24 at 22:37 -0700, Joe Perches wrote:
> On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva
> >
> > With the wider display format, it can become hard to identify how
> > many
> > bytes into the line you are looking at.
> >
> > The patch adds new
On Mon, 2019-06-24 at 22:19 -0700, Joe Perches wrote:
> On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote:
> > The change actions Jani's suggestion:
> > https://lkml.org/lkml/2019/6/20/343
>
> I suggest not changing any of the existing uses of
> hex_dump_to_buffer and only use
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote:
> On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva
> >
> > In order to support additional features, rename hex_dump_to_buffer
> > to
> > hex_dump_to_buffer_ext, and replace the ascii bool parameter with
>
On Tue, Jun 25, 2019 at 10:28:55PM +0800, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-testing
> head: 65b66682344a15ba2069d4dd8d0cc39cc3aed7e9
> commit: 92ce7e83b4e5c86687d748ba53cb755acdce1256 [84/85]
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote:
> On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:
> > From: Alastair D'Silva
> >
> > Apologies for the large CC list, it's a heads up for those
> > responsible
> > for subsystems where a prototype change in generic code causes a
>
Hi Alastair,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Hi Alastair,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Remove unused function vchiq_send_remote_release.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 11 ---
.../vc04_services/interface/vchiq_arm/vchiq_core.h| 3 ---
2 files changed, 14 deletions(-)
diff --git
Remove unused function vchiq_arm_allow_resume.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_arm.c | 43 ---
.../interface/vchiq_arm/vchiq_arm.h | 3 --
2 files changed, 46 deletions(-)
diff --git
Remove unused function vchiq_use_service_no_resume.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 --
.../vc04_services/interface/vchiq_arm/vchiq_if.h | 2 --
2 files changed, 16 deletions(-)
diff --git
Remove function block_resume as it was only called by
vchiq_arm_force_suspend, which was removed in a previous patch.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_arm.c | 66 ---
1 file changed, 66 deletions(-)
diff
Remove unused function vchiq_resume_internal.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_core.c | 16
.../interface/vchiq_arm/vchiq_core.h | 3 ---
2 files changed, 19 deletions(-)
diff --git
Remove unused function vchiq_pause_internal.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_core.c | 23 ---
.../interface/vchiq_arm/vchiq_core.h | 3 ---
2 files changed, 26 deletions(-)
diff --git
Remove function output_timeout_error as it was only called by
vchiq_arm_force_suspend, which was deleted in a previous patch.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_arm.c | 36 ---
1 file changed, 36 deletions(-)
Remove unused function vchiq_arm_force_suspend.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../interface/vchiq_arm/vchiq_arm.c | 120 --
.../interface/vchiq_arm/vchiq_arm.h | 3 -
2 files changed, 123 deletions(-)
diff --git
Remove unused function vchiu_queue_is_full.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 5 -
.../staging/vc04_services/interface/vchiq_arm/vchiq_util.h | 1 -
2 files changed, 6 deletions(-)
diff --git
Hi Alastair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Hi Dan,
hi Dave,
Am 25.06.19 um 09:55 schrieb Dan Carpenter:
> On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote:
>> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in
>> ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate().
>> This breaks probing of
Improved readability by fixing some issues related to maximum line length.
Signed-off-by: Felix Winkler
Signed-off-by: Niklas Witzel
---
drivers/staging/media/ipu3/ipu3-css.c | 274 +++---
1 file changed, 121 insertions(+), 153 deletions(-)
diff --git
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
head: 65b66682344a15ba2069d4dd8d0cc39cc3aed7e9
commit: 92ce7e83b4e5c86687d748ba53cb755acdce1256 [84/85] driver_find_device:
Unify the match function with class_find_device()
config:
On 25/06/19, 1:51 AM, "Sasha Levin" wrote:
> On Tue, Jun 25, 2019 at 02:33:06AM +0530, Ajay Kaher wrote:
> > coredump: fix race condition between mmget_not_zero()/get_task_mm()
> > and core dumping
> >
> > [PATCH v4 1/3]:
> > Backporting of commit 04f5866e41fb70690e28397487d8bd8eea7d712a
On 25/06/2019 13:06, Christoph Hellwig wrote:
From the DMA point of view this looks good:
Reviewed-by: Christoph Hellwig
Thanks!
I still think that doing that SetPageReserved + remap_pfn_range
dance for the normal memory allocations is a bad idea. Just use
vm_insert_page on the page, in
On Tue, 2019-06-25 at 09:17 +0200, Hans Verkuil wrote:
> On 6/21/19 8:39 AM, Aliasgar Surti wrote:
> > From: Aliasgar Surti
> >
> > checkpatch reported "WARNING: line over 80 characters".
> > This patch fixes the warning for file soc_camera/soc_ov5642.c
>
> FYI: we're not accepting patches for
On 25/06/2019 12:47, Dan Carpenter wrote:
On Tue, Jun 25, 2019 at 12:26:59PM +0100, Ian Abbott wrote:
drivers/staging/comedi/comedi_buf.c | 150 ++-
drivers/staging/comedi/comedi_fops.c | 39 ---
2 files changed, 125 insertions(+), 64 deletions(-)
diff --git
On Tue, Jun 25, 2019 at 02:21:41PM +0100, Ian Abbott wrote:
> On 25/06/2019 12:47, Dan Carpenter wrote:
> > On Tue, Jun 25, 2019 at 12:26:59PM +0100, Ian Abbott wrote:
> > > + } else {
> > > + for (i = 0; i < bm->n_pages; i++) {
> > > + buf =
Hi Greg,
On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos
wrote:
>
> Hi Greg,
>
> On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote:
> >
> > Hi Sergio,
> >
> > On 23/6/19 3:58 pm, Sergio Paracuellos wrote:
> > > On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier
> > > wrote:
> > >> On Fri, Jun
On Tue, Jun 25, 2019 at 08:48:26AM -0300, Mauro Carvalho Chehab wrote:
> Keeping legacy problematic code forever is not a good idea.
>
> So, let's schedule a date for those legacy stuff to rest in piece.
>
> If someone wants to steps up and take them from the staging ostracism
> and do give them
Hi Ming,
I don't mind doing this change for zfcp. However, I'm having doubts regarding
the rationale in the commit description. If I understood your patch series
correctly from its cover letter (would have been nice to copy the SCSI MQ
detail part of its core statement in (one of) the patches
>From the DMA point of view this looks good:
Reviewed-by: Christoph Hellwig
I still think that doing that SetPageReserved + remap_pfn_range
dance for the normal memory allocations is a bad idea. Just use
vm_insert_page on the page, in which case it doesn't need to be
marked as Reserved.
On
On Tue, Jun 25, 2019 at 01:27:17PM +0200, Fabian Krueger wrote:
> Replaced 'unsigned' with it's equivalent 'unsigned int' to reduce
> confusion while reading the code.
>
> Signed-off-by: Fabian Krueger
> Signed-off-by: Michael Scheiderer
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 4 ++--
>
On Tue, Jun 25, 2019 at 01:27:15PM +0200, Fabian Krueger wrote:
> Added spaces on the left side of parenthesis and on both sides of binary
> operators.
> This refactoring makes the code more readable.
>
> Signed-off-by: Fabian Krueger
> Signed-off-by: Michael Scheiderer
> ---
>
On Tue, Jun 25, 2019 at 01:27:12PM +0200, Fabian Krueger wrote:
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
> b/drivers/staging/kpc2000/kpc2000_spi.c
> index c3e5c1848f53..7ed0fb6b4abb 100644
> --- a/drivers/staging/kpc2000/kpc2000_spi.c
> +++ b/drivers/staging/kpc2000/kpc2000_spi.c
> @@
On Tue, Jun 25, 2019 at 12:26:59PM +0100, Ian Abbott wrote:
> drivers/staging/comedi/comedi_buf.c | 150 ++-
> drivers/staging/comedi/comedi_fops.c | 39 ---
> 2 files changed, 125 insertions(+), 64 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_buf.c
Keeping legacy problematic code forever is not a good idea.
So, let's schedule a date for those legacy stuff to rest in piece.
If someone wants to steps up and take them from the staging ostracism
and do give them a rejuvenation shower in order to address the
isues pointed on their TODO lists,
Replaced 'unsigned' with it's equivalent 'unsigned int' to reduce
confusion while reading the code.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Added spaces on the left side of parenthesis and on both sides of binary
operators.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 15 ++-
1 file changed, 6 insertions(+), 9
Replaced __attribute__((packed)) with __packed. Both ways of attributing
are equivalent, but being shorter, __packed should be preferred.
This refactoring makes the core more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 6
After the declarations in a function, there should be a blank line, so
that the declaration part is visibly separated from the rest.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 4
Removed brackets on around one-lined if-cases.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git
The unconditioned jump will prohibit to ever reach the break-statement.
Deleting this needless statement, the code becomes more understandable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
drivers/staging/kpc2000/kpc2000_spi.c | 1 -
1 file changed, 1 deletion(-)
diff
To fix some checkpatch-warnings some lines of this module had to be
shortened so that they do not exceed 80 characters per line.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 77
A patch-series that will remove warnings, errors and check-messages,
noted and highlighted by the checkpatch.pl script concerning
kpc2000_spi.c.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
Fabian Krueger (8):
staging: kpc2000: add line breaks
staging: kpc2000:
Instead of using the function name hard coded as string, using __func__
and the '%s'-placeholder will always give the current name of the
function. When renaming a function, the debugging-messages won't have to
be rewritten.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
---
Comedi's acquisition buffer allocation code can allocate the buffer from
normal kernel memory or from DMA coherent memory depending on the
`dma_async_dir` value in the comedi subdevice. (A value of `DMA_NONE`
causes the buffer to be allocated from normal kernel memory. Other
values cause the
Use BIT(x) instead of (1<
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.h | 2 +-
drivers/staging/media/davinci_vpfe/dm365_isif.h | 4 ++--
drivers/staging/media/davinci_vpfe/dm365_isif_regs.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Fixes checkpatch "CHECK: Unnecessary parentheses around '...'".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
b/drivers/staging/kpc2000/kpc2000_spi.c
index
Fixes checkpatch errors: "else should follow close brace '}'" and
"braces {} are not necessary for single statement blocks".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000_spi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git
Hi,
Here are some fixes for minor space, parenthese and brace issues in
kpc2000 reported by checkpatch.pl.
- Simon
Simon Sandström (4):
staging: kpc2000: add missing spaces in kpc2000_i2c.c
staging: kpc2000: add missing spaces in kpc2000_spi.c
staging: kpc2000: remove unnecessary
Fixes checkpatch errors:
- spaces required around that '=' (ctx:VxV)
- space required before the open parenthesis '('
- spaces preferred around that '-' (ctx:VxV)
- space required before the open brace '{'
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000_spi.c | 14
Fixes checkpatch "CHECK: spaces preferred around that '+' (ctx:VxV)".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000_i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c
b/drivers/staging/kpc2000/kpc2000_i2c.c
On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote:
> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in
> ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate().
> This breaks probing of bcm2835-camera:
>
> bcm2835-v4l2: mmal_init: failed to set all
On Mon, Jun 24, 2019 at 11:13 PM Stefan Wahren wrote:
>
> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in
> ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate().
> This breaks probing of bcm2835-camera:
>
> bcm2835-v4l2: mmal_init: failed to set all camera
On 6/21/19 8:39 AM, Aliasgar Surti wrote:
> From: Aliasgar Surti
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file soc_camera/soc_ov5642.c
FYI: we're not accepting patches for staging/media/soc_camera: these
are obsolete and broken drivers.
On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> In order to support additional features, rename hex_dump_to_buffer to
> hex_dump_to_buffer_ext, and replace the ascii bool parameter with flags.
[]
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c
>
On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> With the wider display format, it can become hard to identify how many
> bytes into the line you are looking at.
>
> The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to
> print vertical
65 matches
Mail list logo
